From: "Ni, Ray" <ray.ni@intel.com>
To: "Chuang, SofiaX" <sofiax.chuang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib
Date: Wed, 28 Apr 2021 09:04:53 +0000 [thread overview]
Message-ID: <CO1PR11MB4930631C436AE2835551CD088C409@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <84de1b2ca444acef98975874f52e3ba2f355f923.1619474343.git.sofiax.chuang@intel.com>
> +#include <PiPei.h>
> +#include <Uefi.h>
1. can you please check whether <BaseTypes.h> is enough?
> +VOID
> +EFIAPI
> +ReportCpuHob (
> + VOID
> + );
2. can you please add comments for this API in header file and C file?
>
> + AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &RegEax, NULL, NULL, NULL);
3. can you use CPUID_VIR_PHY_ADDRESS_SIZE_EAX AddressSizeEax?
So the code becomes:
AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, NULL, NULL, NULL);
BuildCpuHob (AddressSizeEax.Bits.PhysicalAddressBits, 16);
next prev parent reply other threads:[~2021-04-28 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib sofiax.chuang
2021-04-28 9:04 ` Ni, Ray [this message]
2021-04-26 22:01 ` [edk2-devel][PATCH v3 2/7] CometlakeOpenBoard: Move ReportCpuHob library path sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 3/7] TigerlakeOpenBoard: " sofiax.chuang
2021-04-28 0:53 ` Heng Luo
2021-04-26 22:01 ` [edk2-devel][PATCH v3 4/7] SimicsOpenBoard: " sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 5/7] KabylakeOpenBoard: " sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 6/7] WhiskeylakeOpenBoard: Move " sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 7/7] MiniPlatformPkg: Move ReportCpuHob " sofiax.chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930631C436AE2835551CD088C409@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox