From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.9199.1619600697472609009 for ; Wed, 28 Apr 2021 02:04:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bRFW2aSU; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) IronPort-SDR: YplZCW79K9LlId4sMB/SsY02fv+dBm/j0yX7QWdiCXo0RQutNBSxKuzhx8pO/a/YtSyZF30wRw wNE56kgdfjCA== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="196249870" X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="196249870" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 02:04:56 -0700 IronPort-SDR: scOttDa85a3rP4x7KOOKYXOuU2v8AXvCy0s5/SSthZdulibyq/0WKLfv7kVYwnksC5csi07ttW j10d9IyA79EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="425532233" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 28 Apr 2021 02:04:55 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 28 Apr 2021 02:04:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 28 Apr 2021 02:04:54 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 28 Apr 2021 02:04:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VqPnrfXrYtbnz404hQkgeFqpbdabR73WfWX1XjqEm/pbYybCNDqeg26XClZnaGOlOlk82aW7Ms10yVoxBKGBP753oxLBonh10PAxtE/S/mp2r9JwOo7WzigaTW5ta60Ws9WEEbXXaFgegZ5ZyFUJTeasBw9dioZC6Bhk1T+gtooIATsw6z8TKfnp0DGVs5hTiOlfAIlaY7uNIi7aTnO+JiYV+0P9LGfH72vCojPhqzhTxep6rHXnQdC7Q7Jb3ZZOusvGqeYMCaCbeXEI3oYQCwHEVwGzjDFOamc9KoGw37fGPj7iW35bGRoKc/39hMQp1rJehIReZwiQqaekB/vzCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7OSb12qGQ7du/7nCa4Kdas/lXgDUqE69Unq17K2c5NU=; b=bLv8B1vEWka9tuntH3o2NJ9JWNcYRcRm8o+MFCcYe3KUQyb41g1tn+wm5YJxyDdW2HTC/Vd3MwXeoQ4l3fRoK5S1xwG1nZkH498fN+I5eXfOYldP58sdtKGjVVGaGXizvnlNKTIUD79KlRCOZ/tRXuUcNAPnsEr+H4cLfNo1zHWmSPstSxyCQpIzRtZipvwBL+hLLfyiJfUDDCyWnbghj5RBnGOqI2U5pm6JI//RQpc4ByI+J9MC03Yd++BEsKwM+CGpGwyyLhIixzIKQTzKIBbkoze+Dt75iwSzFBtloSgbTJZRzqVyu05EKIWiv29WeTW3JtoNvPzWed574tbKcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7OSb12qGQ7du/7nCa4Kdas/lXgDUqE69Unq17K2c5NU=; b=bRFW2aSUoO5e40LXwfAlIL6nVUmpmboXN1hu4dZvlZsZQKP1Z0bDqzHGvGDczWIZhS4yXp3pYHiY7mkoQ44LaNKeTP5XMJFDsiF6SX0jszv6gC80iaaxRbuePshutr22cVq3P4w/iSkJz5lx9+UZaf2d85GPAlWYMGga6mMede0= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB0077.namprd11.prod.outlook.com (2603:10b6:301:61::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Wed, 28 Apr 2021 09:04:53 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7%5]) with mapi id 15.20.4065.027; Wed, 28 Apr 2021 09:04:53 +0000 From: "Ni, Ray" To: "Chuang, SofiaX" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib Thread-Topic: [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib Thread-Index: AQHXO0cSkHRT9xX0wE696dq3ksMKkarJoyCA Date: Wed, 28 Apr 2021 09:04:53 +0000 Message-ID: References: <84de1b2ca444acef98975874f52e3ba2f355f923.1619474343.git.sofiax.chuang@intel.com> In-Reply-To: <84de1b2ca444acef98975874f52e3ba2f355f923.1619474343.git.sofiax.chuang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b459a4c4-e12f-4ae0-f173-08d90a24b013 x-ms-traffictypediagnostic: MWHPR11MB0077: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iz+lHqNzfjL5MlHP4EjXhEipj4sp28JD5S2TNchfXokh7yBTO/Q/ALdiMv04ttQJy84mn6XY2dBWaNM5oRqzxD4k6LnuNF4+6/cvDYsxC0/VChUSQjxUSySTML2Mslt4LWBmZ5UqxBCNOLTX7fBFRXolqxyn0FZ0CbsSCf3U0NwU232lyIjcUCz5Lek+NVTRaTKEq22pAIEZ7GZfmHAouo7IM5zO3nB6nSCrGLG2eFSU86Lez59eBdzJ+c5pumpZgAQ8kEWbrrtsBZDy6tYdlzbQRXwW8l3Phn4umOIPzzUehBauv3J/qAK0QK65O5DJBbqYWgR5Y1emKQq7JuB2OFp5UHboj/QMHkZq4RSLgLmMqfDcTFhGuP8gjpnUgOa0/UBHsNumM/yly2uSsTIAa+s34faBOJtOeDV1cYU7MdasnTcc1TOL0EISRslVKq/n7T0XMvS/tSJjMnuj4OCPmqsNPaMzYWXJar8eZ1X6NnGJfQaOWvGfNm8yDfcNQQfIncXPzt5kOx6zal+jFzDe+guRME8j+Ik6uAfa3BPSb6yAkEvLrgpoK3KEcmiNURnkeTOooBx/3SjNR+dbmvPn0IKmsxaKX3+nlo2jDSvbUWg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(366004)(39860400002)(376002)(396003)(86362001)(52536014)(55016002)(8676002)(4326008)(33656002)(26005)(7696005)(9686003)(2906002)(66446008)(107886003)(71200400001)(186003)(122000001)(8936002)(5660300002)(64756008)(66476007)(66556008)(66946007)(110136005)(76116006)(4744005)(38100700002)(316002)(478600001)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?QZxdMK9x8LyiOPb1tJaXu0c1Qo5ZsY18zLk90ozgWhKqE19x16ObpbTVIsii?= =?us-ascii?Q?UnObgl05jlWm7OJ1geCsl9zd8/NsKOBAq/mhz02AlUw7sO4wowue3CKzzyla?= =?us-ascii?Q?zypZDCWCm+Ncx17j+6rs127z0bQRaJbdvBE2cJE5nzGuIScR2xSIS8wZQe6v?= =?us-ascii?Q?Ye/PV9SMlpWefkm3YPOkT4uXwZSKEpGRbx3KszZqA26YvPvAFTTG23Fjdqzv?= =?us-ascii?Q?LDtI4cX+oE2s5L0B9QNdVh4skFVuiu3qcPkL2zAFWE1CpziK6OY8Q5jHGMwA?= =?us-ascii?Q?p3y3UKRpmBfOJ+8FqlFEO1AEcOoVXvDdDElWZB5au4EC6ve6Y2bFkQacaD3M?= =?us-ascii?Q?G1sFnrVtGM3aQIglvzqBVIXeUR86EmzshJy0wlGA4fzeRygVfIZwfv+WI88C?= =?us-ascii?Q?YHvJqUWif0SAxowu1jiexGT3qOgccBfvq2+M72N3XQyjWplJQkpFoz+09XPn?= =?us-ascii?Q?ORX+exGYgPi1kNBenuy/Ahp+BVK7BPP9zE0O+b36dwOiAneJcT2h1h2dF7VO?= =?us-ascii?Q?px5/Qmn8RjGCzrhhhvdWRjuf5/P7Uqu6fxaPqSmySZyuqLmpcckn/H0rnvtD?= =?us-ascii?Q?6AbuJy0LKngW4HI9qRJ/Fo9OXK/XyUm+zAiEFG96hA4OTxYKBxoJp8RJfwvX?= =?us-ascii?Q?actLF9s7rpM6ovnQkzTVCrABzQymxUxT0u/EacIF2SOuq/qVt0XDYvYJ8Rmt?= =?us-ascii?Q?cJ0VdgAYB7/MT2QxDi7w5zj699hoxQEMGvLstrHxb4zMYuf/LQHZis2NU3zB?= =?us-ascii?Q?g3WZ5CdnnFUzoKinNVgsAWxO5Z+vo/rDUJVSUhCVwhbes5yCWtHiCYaK8WTE?= =?us-ascii?Q?qTbEgYcVP6PSSGywl/KO7YuNzZCpKOvxZDc95VLDlhhZ5HEqDwdtAFF1EtjT?= =?us-ascii?Q?yJLmZ2CpQAxBKzjHhe67NmcxRPcIkAComOUOyvq+McCLu0enyk+1ubSG8+pw?= =?us-ascii?Q?4jhrRAouYHhdbS7MixNseNQ9tdQvYKWRbMFhIJnChKAC+Qo3Cywm6GWuag1T?= =?us-ascii?Q?M5EVZaZYPXlBuTi+gncxnBQHHkBZSWuPQrIEMKiZvrz2tYsqpjEibsO+wSh2?= =?us-ascii?Q?8FLTpqWNLFiCccef2GdIhHIZltpNgV9xQbQDxTFvVmThInBmRcFapCYJWt2W?= =?us-ascii?Q?D5X+T6bsOMW4jR6UTtiNxSXvA2bGGD3AyPBi8/sT32qkVv3JmNCCBMdZvEmL?= =?us-ascii?Q?rOPIP7okj9tI4KQ62IxTRRCBYXyYQIn/YYH3YVpvMubcZpYcxT83ZL5J/rDD?= =?us-ascii?Q?KhDoczsEbbJADdRKUBgWfpY72n+2KH+pZSBlFzqaG1p8SGjrXMdUtNSYyifX?= =?us-ascii?Q?Ybbp99hmUfcVK/Ylz4+iV/In?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b459a4c4-e12f-4ae0-f173-08d90a24b013 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 09:04:53.7986 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AfXdWffB6SsKtyevrAyYcK9IIHR2OIJ8jk7js5N0LMWAnDOSAEUOsABcSlLKMpRk10iLxkCylxFCuUaTQesiHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0077 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > +#include > +#include 1. can you please check whether is enough? > +VOID > +EFIAPI > +ReportCpuHob ( > + VOID > + ); 2. can you please add comments for this API in header file and C file? >=20 > + AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &RegEax, NULL, NULL, NULL); 3. can you use CPUID_VIR_PHY_ADDRESS_SIZE_EAX AddressSizeEax? So the code becomes: AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, NULL, NULL, N= ULL); BuildCpuHob (AddressSizeEax.Bits.PhysicalAddressBits, 16);