* [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
2021-04-28 9:04 ` Ni, Ray
2021-04-26 22:01 ` [edk2-devel][PATCH v3 2/7] CometlakeOpenBoard: Move ReportCpuHob library path sofiax.chuang
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel; +Cc: SofiaX Chuang, Ray Ni, Rangasai V Chaganty
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Add ReportCpuHobLib
Signed-off-by: SofiaX Chuang <sofiax.chuang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
---
.../Include/Library/ReportCpuHobLib.h | 24 +++++++++++++
.../Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 6 +++-
.../Library/ReportCpuHobLib/ReportCpuHobLib.c | 35 +++++++++++++++++++
.../ReportCpuHobLib/ReportCpuHobLib.inf | 26 ++++++++++++++
4 files changed, 90 insertions(+), 1 deletion(-)
create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
create mode 100644 Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
create mode 100644 Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
new file mode 100644
index 0000000000..46f502d616
--- /dev/null
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ReportCpuHobLib.h
@@ -0,0 +1,24 @@
+/** @file
+
+ Report CPU HOB library
+
+ This library report the CPU HOB with Physical Address bits.
+
+Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef _REPORT_CPU_HOB_LIB_H_
+#define _REPORT_CPU_HOB_LIB_H_
+
+#include <PiPei.h>
+#include <Uefi.h>
+
+VOID
+EFIAPI
+ReportCpuHob (
+ VOID
+ );
+
+#endif
diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
index 4a2cbca5c1..2461ab8e06 100644
--- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
+++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
@@ -3,7 +3,7 @@
#
# This package provides common open source Intel silicon modules.
#
-# Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -42,6 +42,10 @@
#
AslUpdateLib|Include/Library/AslUpdateLib.h
+ ## @libraryclass Provides services to report CPU hob
+ #
+ ReportCpuHobLib|Include/Library/ReportCpuHobLib.h
+
[Guids]
## GUID for Package token space
# {A9F8D54E-1107-4F0A-ADD0-4587E7A4A735}
diff --git a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
new file mode 100644
index 0000000000..97cacb7110
--- /dev/null
+++ b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c
@@ -0,0 +1,35 @@
+/** @file
+ Source code file for Report CPU HOB library.
+
+Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <PiPei.h>
+#include <Library/BaseLib.h>
+#include <Library/HobLib.h>
+#include <Register/Intel/Cpuid.h>
+
+VOID
+EFIAPI
+ReportCpuHob (
+ VOID
+ )
+{
+ UINT8 PhysicalAddressBits;
+ UINT32 RegEax;
+
+ AsmCpuid (CPUID_EXTENDED_FUNCTION, &RegEax, NULL, NULL, NULL);
+ if (RegEax >= CPUID_VIR_PHY_ADDRESS_SIZE) {
+ AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &RegEax, NULL, NULL, NULL);
+ PhysicalAddressBits = (UINT8) RegEax;
+ } else {
+ PhysicalAddressBits = 36;
+ }
+
+ ///
+ /// Create a CPU hand-off information
+ ///
+ BuildCpuHob (PhysicalAddressBits, 16);
+}
diff --git a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
new file mode 100644
index 0000000000..1d2d6b4151
--- /dev/null
+++ b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
@@ -0,0 +1,26 @@
+### @file
+# Component information file for the Report CPU HOB library.
+#
+# Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+###
+
+[Defines]
+ INF_VERSION = 0x00010005
+ BASE_NAME = ReportCpuHobLib
+ FILE_GUID = 0A1C9D6B-44BE-4FD7-A4A2-D0E68D436848
+ VERSION_STRING = 1.0
+ MODULE_TYPE = PEIM
+ LIBRARY_CLASS = ReportCpuHobLib
+
+[LibraryClasses]
+ BaseLib
+ HobLib
+
+[Packages]
+ MdePkg/MdePkg.dec
+
+[Sources]
+ ReportCpuHobLib.c
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib
2021-04-26 22:01 ` [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib sofiax.chuang
@ 2021-04-28 9:04 ` Ni, Ray
0 siblings, 0 replies; 10+ messages in thread
From: Ni, Ray @ 2021-04-28 9:04 UTC (permalink / raw)
To: Chuang, SofiaX, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V
> +#include <PiPei.h>
> +#include <Uefi.h>
1. can you please check whether <BaseTypes.h> is enough?
> +VOID
> +EFIAPI
> +ReportCpuHob (
> + VOID
> + );
2. can you please add comments for this API in header file and C file?
>
> + AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &RegEax, NULL, NULL, NULL);
3. can you use CPUID_VIR_PHY_ADDRESS_SIZE_EAX AddressSizeEax?
So the code becomes:
AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, NULL, NULL, NULL);
BuildCpuHob (AddressSizeEax.Bits.PhysicalAddressBits, 16);
^ permalink raw reply [flat|nested] 10+ messages in thread
* [edk2-devel][PATCH v3 2/7] CometlakeOpenBoard: Move ReportCpuHob library path
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 3/7] TigerlakeOpenBoard: " sofiax.chuang
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel
Cc: SofiaX Chuang, Chasel Chiu, Nate DeSimone, Rangasai V Chaganty,
Deepika Kethi Reddy, Kathappan Esakkithevar
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
---
.../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 6de834565a..44a1bd54d6 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the CometlakeURvp board.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -161,6 +161,7 @@
# Silicon Initialization Package
#######################################
SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Platform Package
@@ -173,7 +174,6 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [edk2-devel][PATCH v3 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 1/7] IntelSiliconPkg/ReportCpuHobLib: Add ReportCpuHobLib sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 2/7] CometlakeOpenBoard: Move ReportCpuHob library path sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
2021-04-28 0:53 ` Heng Luo
2021-04-26 22:01 ` [edk2-devel][PATCH v3 4/7] SimicsOpenBoard: " sofiax.chuang
` (3 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel; +Cc: SofiaX Chuang, Sai Chaganty, Nate DeSimone, Heng Luo
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
---
.../Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
index a4265a839c..1adf634034 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
@@ -89,7 +89,6 @@
PciSegmentLib|$(PLATFORM_SI_PACKAGE)/Library/BasePciSegmentMultiSegLibPci/BasePciSegmentMultiSegLibPci.inf
PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#
# Silicon Init Package
@@ -115,6 +114,7 @@
#
# Silicon Init Package
#
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
!include $(PLATFORM_SI_PACKAGE)/SiPkgPeiLib.dsc
#
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [edk2-devel][PATCH v3 3/7] TigerlakeOpenBoard: Move ReportCpuHob library path
2021-04-26 22:01 ` [edk2-devel][PATCH v3 3/7] TigerlakeOpenBoard: " sofiax.chuang
@ 2021-04-28 0:53 ` Heng Luo
0 siblings, 0 replies; 10+ messages in thread
From: Heng Luo @ 2021-04-28 0:53 UTC (permalink / raw)
To: Chuang, SofiaX, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Desimone, Nathaniel L
Reviewed-by: Heng Luo <heng.luo@intel.com>
> -----Original Message-----
> From: Chuang, SofiaX <sofiax.chuang@intel.com>
> Sent: Tuesday, April 27, 2021 6:01 AM
> To: devel@edk2.groups.io
> Cc: Chuang, SofiaX <sofiax.chuang@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Luo, Heng <heng.luo@intel.com>
> Subject: [edk2-devel][PATCH v3 3/7]
> TigerlakeOpenBoard: Move ReportCpuHob library path
>
> From: SofiaX Chuang <sofiax.chuang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
>
> Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> ---
> .../Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> index a4265a839c..1adf634034 100644
> --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc
> @@ -89,7 +89,6 @@
>
>
>
> PciSegmentLib|$(PLATFORM_SI_PACKAGE)/Library/BasePciSegmentMultiSegLib
> Pci/BasePciSegmentMultiSegLibPci.inf
>
> PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
>
> -
> ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHob
> Lib/ReportCpuHobLib.inf
>
>
>
> #
>
> # Silicon Init Package
>
> @@ -115,6 +114,7 @@
> #
>
> # Silicon Init Package
>
> #
>
> +
> ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.i
> nf
>
> !include $(PLATFORM_SI_PACKAGE)/SiPkgPeiLib.dsc
>
>
>
> #
>
> --
> 2.27.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [edk2-devel][PATCH v3 4/7] SimicsOpenBoard: Move ReportCpuHob library path
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
` (2 preceding siblings ...)
2021-04-26 22:01 ` [edk2-devel][PATCH v3 3/7] TigerlakeOpenBoard: " sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 5/7] KabylakeOpenBoard: " sofiax.chuang
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel; +Cc: SofiaX Chuang, Agyeman Prince, Chasel Chiu
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
---
.../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 77c408a326..93a7d1df55 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the X58Ich10 board.
#
-# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -42,7 +42,8 @@
DEFINE NETWORK_ISCSI_ENABLE = FALSE
DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include $(PROJECT)/OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -137,6 +138,11 @@
MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
+ #####################################
+ # Silicon Package
+ #####################################
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+
#####################################
# Platform Package
#####################################
@@ -145,7 +151,6 @@
!endif
TestPointLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointLib/PeiTestPointLib.inf
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
[LibraryClasses.common.DXE_DRIVER]
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [edk2-devel][PATCH v3 5/7] KabylakeOpenBoard: Move ReportCpuHob library path
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
` (3 preceding siblings ...)
2021-04-26 22:01 ` [edk2-devel][PATCH v3 4/7] SimicsOpenBoard: " sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 6/7] WhiskeylakeOpenBoard: Move " sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 7/7] MiniPlatformPkg: Move ReportCpuHob " sofiax.chuang
6 siblings, 0 replies; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel; +Cc: SofiaX Chuang, Chasel Chiu, Nate DeSimone, Jeremy Soller
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Jeremy Soller <jeremy@system76.com>
---
.../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 11 ++++++++---
.../KabylakeRvp3/OpenBoardPkg.dsc | 11 ++++++++---
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
index 862e6a6655..302cb679b5 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the GalagoPro3 board.
#
-# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -38,7 +38,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -160,7 +161,11 @@
DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+
+ #######################################
+ # Silicon Package
+ #######################################
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Platform Package
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
index 0b30da8f96..8523ab3f4f 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the KabylakeRvp3 board.
#
-# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -37,7 +37,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -201,6 +202,11 @@
SecBoardInitLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/SecBoardInitLibNull/SecBoardInitLibNull.inf
[LibraryClasses.common.PEIM]
+ #######################################
+ # Silicon Package
+ #######################################
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+
#######################################
# Platform Package
#######################################
@@ -212,7 +218,6 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [edk2-devel][PATCH v3 6/7] WhiskeylakeOpenBoard: Move library path
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
` (4 preceding siblings ...)
2021-04-26 22:01 ` [edk2-devel][PATCH v3 5/7] KabylakeOpenBoard: " sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
2021-04-26 22:01 ` [edk2-devel][PATCH v3 7/7] MiniPlatformPkg: Move ReportCpuHob " sofiax.chuang
6 siblings, 0 replies; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel; +Cc: SofiaX Chuang, Chasel Chiu, Nate DeSimone
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 7 ++++---
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 7 ++++---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index fb493973e2..ee2aedd978 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the UpXtreme board.
#
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -160,6 +161,7 @@
# Silicon Initialization Package
#######################################
SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Platform Package
@@ -172,7 +174,6 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
index 9a1f107faf..b69cc8deb0 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the WhiskeylakeURvp board.
#
-# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -160,6 +161,7 @@
# Silicon Initialization Package
#######################################
SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSiliconInitLib.inf
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Platform Package
@@ -172,7 +174,6 @@
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
!endif
SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
- ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
#######################################
# Board Package
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [edk2-devel][PATCH v3 7/7] MiniPlatformPkg: Move ReportCpuHob library path
2021-04-26 22:01 [edk2-devel][PATCH v3 0/7] Move ReportCpuHobLib from MinPlatformPkg to IntelSiliconPkg sofiax.chuang
` (5 preceding siblings ...)
2021-04-26 22:01 ` [edk2-devel][PATCH v3 6/7] WhiskeylakeOpenBoard: Move " sofiax.chuang
@ 2021-04-26 22:01 ` sofiax.chuang
6 siblings, 0 replies; 10+ messages in thread
From: sofiax.chuang @ 2021-04-26 22:01 UTC (permalink / raw)
To: devel; +Cc: SofiaX Chuang, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
From: SofiaX Chuang <sofiax.chuang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3298
Move ReportCpuHob library from MinPlatformPkg to IntelSiliconPkg.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 2 +-
.../PlatformInit/PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 707686055c..35cbd40abb 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -94,7 +94,7 @@
#
FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
- ReportCpuHobLib|MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
+ ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
SetCacheMtrrLib|MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
index e37bcba560..fb997838ef 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
@@ -1,7 +1,7 @@
### @file
# Component information file for the Platform Init Pre-Memory PEI module.
#
-# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -33,6 +33,7 @@
MinPlatformPkg/MinPlatformPkg.dec
MdeModulePkg/MdeModulePkg.dec
MdePkg/MdePkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
[Pcd]
gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## CONSUMES
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread