From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.2774.1628215680047250355 for ; Thu, 05 Aug 2021 19:08:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=MXYkWcb/; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="214320132" X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="214320132" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 19:07:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,299,1620716400"; d="scan'208";a="501850661" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 05 Aug 2021 19:07:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:07:58 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 19:07:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 19:07:57 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 19:07:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NodzNlmec/osqVF6zm9WGG7xjbBPYvcOMNkiEMiDtmJUn3F7cQaN6CWsFZdjsoHDUKBaX+T56sJbzKO62rTr7Q1eWzONzDl9+mCp/CjLBwTRfvt4hAA+mnqDE5xMpz60CX5DyOIygRFZ4mjoprhucAIcnzrwlFSxFa/fecq/q974rL4YnHbhE9ZpX7ZF3+txxbUYZhu4mHRwF4U/DcZDPiYqn0S3ddp/B4EU2p8ZLi3ImThV68P6InxuFJs+qI6fYzJMr+a95tb9V899VtH3eDU+ib5l1Cz1EPG1CMIHTUyiljr20kxIk5vc+JqItwcibjlI08Y8tVSiCdq+LX7ESQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0vV2eXC/6XH1eQJRW0UVoz7QgPyD8f7AM0G9wN8xvTM=; b=bm2QlrE8zWo/t7SRzkWYzhUgTVTaK2yUEC8qyGq6goxDjfhgm0CRxUBJvML5YOyxHNEHHwNZESBzVaTwOUub3l99FKhDd1tqXXzK5+pAm27WJkuGIYG3DRYXklQUOz9Pp5AK62bjWMX02nOwjoUaVE/V1judYy4J5ljRmJ5K3wEOfZsSV0eYqknKddFdrbliW1BuNE3gugUtIkInjsR/bCT58A6Ykj3fvQjSgfGUirbVOttonNuILgouA5TsjV3/8WpF8YxytHbCSUnfmfwk/QN8zEBksimTf+nIi+Pg9xQKfeWhqPn0ZYdzmP9EvE0j7l4x00cKkWAjy3uRBEwuTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0vV2eXC/6XH1eQJRW0UVoz7QgPyD8f7AM0G9wN8xvTM=; b=MXYkWcb/2lENVu3fdJiYWgilHInkMhNeUV4R4sHBFxB1wervWQXgDSnyKYVSP5M158J5YhGCIKYwRq4XTY5zfMJ4EpNEVDyn98rLIA5W4MzPn6oyWXHCjKLlBluWsIBeObtg8o+cvoFplyOms14B1EUHUR+KU4jyD8yHh3aLczk= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MW3PR11MB4745.namprd11.prod.outlook.com (2603:10b6:303:5e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.22; Fri, 6 Aug 2021 02:07:55 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865%5]) with mapi id 15.20.4394.018; Fri, 6 Aug 2021 02:07:55 +0000 From: "Ni, Ray" To: "Lin, JackX" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Huang, Jenny" , "Yao, Jiewen" , "Chaganty, Rangasai V" , "Kuo, Donald" , "Kumar, Chandana C" , Bret Barkelew Subject: Re: [edk2-platforms: PATCH V5] Platform/Intel: Correct CPU APIC IDs Thread-Topic: [edk2-platforms: PATCH V5] Platform/Intel: Correct CPU APIC IDs Thread-Index: AQHXic1N9T0UoaJa1ECr9kmqIsgGbKtltcuw Date: Fri, 6 Aug 2021 02:07:55 +0000 Message-ID: References: <20210805074102.1317-1-JackX.Lin@intel.com> In-Reply-To: <20210805074102.1317-1-JackX.Lin@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.100.41 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b54a8cde-6d81-473b-73da-08d9587f0189 x-ms-traffictypediagnostic: MW3PR11MB4745: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H4wqnXpp29qS4DbS+Fv0NobRMgvOBySZLlq1Fs1fc5wJ87tNJ8aIcNaNvjLdC60WKnipEpX4bXyFe5EdCC70Lgum0cOy5MWF1xd0QElP6HWOLt7j47Au/DPjkVmDDvFnqcD9iJdMybWqUdlDJso49w3YZFcc8cBligXMgq83lmn7IlJcPl2H09kvvt6g7JVcR17YX9WS9AKfzmfrKpt6du+qhirZvtvWcoUyor5kS23A+2fdVmU1KaFzl53v+DM+x1K3rZS/uC7BL63uTbRakpX5R4CDySeb5Vh7TZ/vFc8Oy8jtR1fFWz9Uo68J7C36UzMeQYiUlgPPXguLIP5tPREhotpYXBRzA+zCYzvyF3fkBaxif5Ztqiu87zGu1b+BmuNnon5Lh6iQims2W57s8Ud6Kmg38EIdq1E0zLsh5FhYcBtjlrDZpqID3tdGb19gIEAkIuNzWlQmTxg+p8D6QUQFIa2R1ZyaQ9/ulYLoxT/95mmQxjFxEhP8+FHeDuPU8YdSDkppFb3QDXA9eEKb3gKxCfkkMNL38DWQdHDQwCGA8/Sd1NDJTCmilPaWszx21F6ySUlSwmc0mHV5SDr7h93zGAY3dFQW2/KS87IbFIjEhCq3Yp50vQ8QtEegKskzp8xJnB1YBpw6lt9vOlStmaXd0YA0ph+CRbXCbb8qNI2yrQqjdJMOlWlU99V5dNETSh54cj8pvhOhcQBGMr6/eQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(4744005)(316002)(66446008)(71200400001)(55016002)(8676002)(52536014)(8936002)(110136005)(2906002)(64756008)(54906003)(478600001)(186003)(9686003)(66476007)(76116006)(66946007)(66556008)(6506007)(83380400001)(26005)(7696005)(4326008)(38100700002)(33656002)(86362001)(122000001)(5660300002)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MbGzt+rlWXKfUC+bbJ0H/8gaJKiTDBidd9wy49aia+zekUxuKk1TaHpI4vlJ?= =?us-ascii?Q?2hjjhFA5FfusZbisN0foEZiylA1U04xfzJ6zsHp5KktFEidORMp+dvPimWhQ?= =?us-ascii?Q?UwjzcJdZ+iGt8FOYioTJ8Pefgb+4G3EwprwPbCI9e5FcpVNk5PpLotRb2nAp?= =?us-ascii?Q?tnbOOHouKpgtka1HaVmcFCZd6X4h2DS+EvbjC+hox1CS4lE0sw5C1jod1Fzn?= =?us-ascii?Q?NtHxegcn6NqBH1bHD9+rbmL6iHfOwuW2QdPWJWqZ4HnHhXkPwLqaCc2pfPFg?= =?us-ascii?Q?XCUK6qbmNgmNQoJUxrfAqttIv1L+mXZYa7xcKvkOWGaWa2kIXIcaxIaxwZ0M?= =?us-ascii?Q?3Wkt2dD1h2SeFlHaqlAv91DGBFgmf6hlWNKSKEJFLJBvVN/iR0tS+l1Lrmey?= =?us-ascii?Q?CRhPLcZy0UgBvHSXAX8fMIaKkXczHQJB92RLWJSN5mj0Trldsxl2yi8Yicyb?= =?us-ascii?Q?NwYMyu1b8+j8LkUkJJb45VbJWC66LcXNsTNGuIEt3pQroe+quDES+7tXicIp?= =?us-ascii?Q?/bGYlcoDnW7utXmDhAuCfwKlhCpGO9orUMx1/Ugkjrs05ipTezo/8QKEIrav?= =?us-ascii?Q?hv/mZaaxRjYsoP1UU9gd7SpiiR7itQ7o7ZiJWRLiiUpq2+uE7uqsQm8Jfg/d?= =?us-ascii?Q?iJMMIYA1p9hiYbL/nTv3He2ZOzbPoUoepbipcMnrZ/VzWXcLUQ9NAcevrWyO?= =?us-ascii?Q?A46zfdIJ0YaYefhkV+SPKv6QXt44mB9DhccAFNEOG27RI75+00Q0kdLDO3r6?= =?us-ascii?Q?4XGhWUgMn3Cc2osQiyGu1DBW7XxsrcMr01zqD3KXzgl4wRrSVvvjNVFw56D7?= =?us-ascii?Q?6PVV4JM2fKTeFdSsSON9ykr9Rhl5Jw5UX77R+YBoTH1fMNhSa05sRjRYOr+2?= =?us-ascii?Q?ANvolHtcnEb//b0nkli8ZGBDIL2o6e2NubPylBiPmsVnCqCJn3H/xMzQMqor?= =?us-ascii?Q?0beDDfqGaJvW/5Nq613e9fUTp8948xVGnbaJ3EN1JxSOgk19b0D3l7ktG65N?= =?us-ascii?Q?c/KiTs33sjtO8nJuongL1uFPZphTAvnSYBQ3Agbh7DpYFFCqDqk3/BWXPfEk?= =?us-ascii?Q?MdBDzUEaHXKKH8LRGeQjtl0DVWrdwDfvEFFNBi+b9B41w+Co5MsU5oYlnzjf?= =?us-ascii?Q?L55MYTC2FEANnBuhpflio+eqzvOqB2rkbDOGs6XrbIgOk01DgvHP8OlMbO4S?= =?us-ascii?Q?9NG7w4ucXXO9bTSlFWMJHDoNoRrd/zN6Q0folfRqOJJYyoJy5AkMbyRvuXZZ?= =?us-ascii?Q?9TSHipxKLgFF+DTXwNZTn32z2JqO16PxpybUHs7Tjg8EZIDjJ9HqHHDYUwiU?= =?us-ascii?Q?K9lalQObEq03OJC0Qa9MnXuQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b54a8cde-6d81-473b-73da-08d9587f0189 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 02:07:55.9123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iCDFzfCjPrdCqGpU00eYU2bn+DOQVYjX3uecN42hwDr/EPSsrSbJ1bujPsAS/5fx7GBAx1qmfCHRVmuRzakE5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4745 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable 1. I see lots of coding style changes in the patch. Can you please separate= these changes that don't impact functionality in a standalone patch? > + CpuIdMapPtr->AcpiProcessorId =3D ((UINT32)ProcessorInfoBuffer.Lo= cation.Package * (UINT32)mNumberOfCpus * 2) + Index; 2. Per ACPI spec, this value should match to the _UID value of processor ob= ject in ACPI table. What mechanism is used to guarantee the match? The original logic uses PCD value FixedPcdGet32(PcdMaxCpuCoreCount) * Fixed= PcdGet32(PcdMaxCpuThreadCount) to guarantee the match. We need to finalize the correct mechanism for the _UID match requirement in= ACPI spec first. Then we can continue review the following reorder logic because the followi= ng logic depends on the initial order. Thanks, Ray