From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.5992.1607518713039680298 for ; Wed, 09 Dec 2020 04:58:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=q/6NPpYQ; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) IronPort-SDR: KCxw2tEF9ZeYIYrb8wWvRgjhUcpFflv1GK/zUDn2OvTzhwGJ63AMQYDn3mpzrNI/4PauQpQWZR UPhkL82g5VIw== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="161122351" X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="161122351" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2020 04:58:31 -0800 IronPort-SDR: tPzm3Zm+4JLle5KqnFUHGSaADoOvNRGUgY6AJvq5gbtcpIP421EWk/vioZNUhfrFjaaBG5aWK1 7cAuPLRvIAlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,405,1599548400"; d="scan'208";a="437779630" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 09 Dec 2020 04:58:31 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Dec 2020 04:58:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Dec 2020 04:58:31 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Dec 2020 04:58:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iK9j/rm7Mmp/C+J+HehhVr54jRjunxazLHYVWjMz/RC9PzVAcXxLXUb2YNea67sPVBRrPJ+TZiqsvxknP+xpGI+e1qZIdc41XS7c7j4oTBku/4s/FeDAgEfwfVIhqBuHOolsSpi3PYFSBKd25qM6y+Jj/EMTHWkFPxYDM/hDFrakr10e4ESA/5MyP8siLAoa/Yl4T83l7HNczer15+9lilNQ2gX7g9MdCQuaN1jmcZsR613gOojHI7NIaLxIa3WNRRUWUrgSFLvvS7rZicJPrsJbAX/IqQynDKVYVlYCKondf9XnhRDOU81mvhUKwvb1PEEbZepUPPsDAgGEDGurtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8n9VhMjItftf/L/cgOjt9M9NJJcfXsg2OwubRIp9BBo=; b=FFNcQ2wxXszCrm1O8/aypzua3SqU40QlsJkWJGzF6h+rFLGdzVqNlTmdt8DjLBlssfCIdcaoBw5O0jB5YmghnMayMRzyI0hJ+YDd4TA2FY5ZE0vglhUL0aH1f1aMuzXrXeTS3O/vnZL3C+9Bw295Y7Y2Mg6RITWBYYNScVfoO8sS0FpZewc+tC4RNSxOJrXg964TFx/em7B6yk58i0rV9v6Fz6d8zIyXCBqFm4I4Xs7wp7yGfybltdWZJTTrenuY0ib1GWpukYUyPLfV+EMktTucH6jCJs2MFD0FyyIFJ+lwECDW+6xWwFMiPkcVmgMLsUuuwzkH1pUizenvf7q/JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8n9VhMjItftf/L/cgOjt9M9NJJcfXsg2OwubRIp9BBo=; b=q/6NPpYQdntd0AVTVG+41T7MpvS1myYPMtZ+mr8QG3zUN/MZSbCJ5qpx8dMUeNInJbJNhEJ7tnrUM6vSHe/IVCdkWRrK0lWqTqgw7h7Q2LFmnFU5Kw55dbSJZbztxf1aiYfEZbaQJAasuMazTT2o6cBqgSvmzVrMyMSjm44Y+qM= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2222.namprd11.prod.outlook.com (2603:10b6:301:57::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Wed, 9 Dec 2020 12:58:27 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3654.012; Wed, 9 Dec 2020 12:58:27 +0000 From: "Ni, Ray" To: "Li, Aaron" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Fu, Siyuan" Subject: Re: [PATCH v2 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Thread-Topic: [PATCH v2 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return value in ShadowMicrocode. Thread-Index: AQHWzfjxBgOCz/9xOkCf28WmmtMk/anuufrw Date: Wed, 9 Dec 2020 12:58:27 +0000 Message-ID: References: <20201209065948.6852-1-aaron.li@intel.com> In-Reply-To: <20201209065948.6852-1-aaron.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d31968e6-1c7f-4b9a-41b0-08d89c421f4c x-ms-traffictypediagnostic: MWHPR1101MB2222: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UusN8sqIMYLD1rljXR9MhqguWSYoGis0fmZKh7pspRE908stBBkmzw0ITIWKS6lDrE5SG+LPGoF0946I1xgCIsDO7pik9gL6aH8+KJcve9GQtE+8RjXHaNJ6p7h0YlpQgCz7jLS/sPGdHnQ81Yz+3BqAWXauWtQTzFLZTX7ceKhbwLoNEUBHulpMmnw0RrZ56uHSmnx22JTTrcetIjyhUtQ/6Oqrbg9vlICiPagHkpFdRobOR1ivq0d9Q90kNVU/9gXoVseObtro0iZlnB9aYKGYATxBs6B2MIxuXCrSCGU8S4n6tSfBPWG6iBg7r8CiYl9ly5zJ80qI2W2PI66EPBhq32zVl9yViraQYLeDCAdgYzTkGXBL29YLTY44+xuQIhbQa8sgnLcuLymdvlSG+w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(136003)(110136005)(26005)(64756008)(66446008)(66556008)(107886003)(4326008)(83380400001)(508600001)(7696005)(71200400001)(76116006)(66476007)(53546011)(86362001)(966005)(8676002)(52536014)(54906003)(8936002)(6506007)(55016002)(5660300002)(9686003)(2906002)(66946007)(33656002)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?9VKz31T0V3bTIjlXt+KY8yh4Er6JO3bHgVLJ/zxN/jBpU9RZ8TxYUw/d2Iav?= =?us-ascii?Q?2YYzDmowWB0wc9KLAcBPuLtQcbHp/hRYRkaxrexJnAqCiQm+WXu7aaQm+jXL?= =?us-ascii?Q?6cnUl9BThVYShCjGacTYCqLv7DGa63Q/uGXeJ1e8+CKaoRv7PqlUuQEz0Ddr?= =?us-ascii?Q?oyPdQizSxDeCzBnYN1cyZx4md2veFlwsyP7gQ7lH2kCxIFsKvTsRYBb6E1vE?= =?us-ascii?Q?+WRmXBorrB0gcU5FWwa9w0RAvoFpDhHEwkEokZE4qxbRp9WEeNUFeEuf8Yyp?= =?us-ascii?Q?G+UwaU4XkICLxcAiVvD9b3w2DrAHR++wrpYnVkbRXUNSyaG2RmAtPXPUwoGk?= =?us-ascii?Q?uw45PG/SYACxiVKX/WUk59HiK6XHX62ADza8lwHFDH2YHuSbvH0Nga2Tv/Lw?= =?us-ascii?Q?AuexCbGgiv8qmBbFkjfwzefgx2lPAWtq3tP5o1rSiUQd+nVqlGJ844VgMuJ+?= =?us-ascii?Q?2EP9/LwDx+NGPzZVdPJKmNHmLOxcufvQgu1AkNyIW6fF6kmQ9al4wwKloS9B?= =?us-ascii?Q?0RkhKOE0DthyNzs5c1eaIRp27NmqWzDBCwndymM/lf0wp5iW4w0F6OT11ZTW?= =?us-ascii?Q?Bj5Z5htRRZdvmVRe1N5gXv1qtLIOCN6Uhca5Dh74CCd18QrPsTL75Jan+VH6?= =?us-ascii?Q?LJjcPelpD5H0IcvSyV6VXLoTGbLCI5MIqObnclNITul4cktF4kfFa2QpEfU0?= =?us-ascii?Q?gMbXexOMED022OQWTd3Oln1gE/Tkv3Mg7bTNmgCTHfzugABw//spR/hhxe8H?= =?us-ascii?Q?wc8wKuFrqXDHc718Am+eoOlssMmJcOF/cYzllvLDQLeFsD332d6Zo6S5717V?= =?us-ascii?Q?laISsYodH0zM0zzJgEqxQjnr5vPqo2nr2VDTug8AYo+fySaN5vyOrvHVAj1Y?= =?us-ascii?Q?fegLRsVvhYRt02SSfCvLWWBu8u2yD5NzHmp1T1VopTJq5yXKyh1shcpM4VEb?= =?us-ascii?Q?MGmo9nv3nYl2HjyFMKlOsLV8DAgRa/t3hH6/qoJFg8i7VBdwLI/bu2Danrjp?= =?us-ascii?Q?fUgF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d31968e6-1c7f-4b9a-41b0-08d89c421f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2020 12:58:27.8914 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k/DegtxmZyi17y6UGylxtfctnYbuWf0etKh4RlG18GTLkkWynlF39O41eIS1y7hthKN5bkAlfysMWhGStOauTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2222 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Li, Aaron > Sent: Wednesday, December 9, 2020 3:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V ; Fu, Siyuan > Subject: [PATCH v2 1/1] IntelSiliconPkg/ShadowMicrocodePei: Fix return va= lue in ShadowMicrocode. >=20 > ShadowMicrocode should return EFI_NOT_FOUND when no valid Microcode found > in FIT table. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3110 >=20 > Signed-off-by: Aaron Li > Cc: Ray Ni > Cc: Rangasai V Chaganty > Cc: Siyuan Fu > --- > Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei= .c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/Shadow= MicrocodePei.c > b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePe= i.c > index 5c7ee6910c8e..1494397a8e36 100644 > --- a/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicroco= dePei.c > +++ b/Silicon/Intel/IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicroco= dePei.c > @@ -377,6 +377,9 @@ IsValidFitTable ( > with microcode patches data in it. >=20 >=20 >=20 > @retval EFI_SUCCESS The microcode has been shadowed to me= mory. >=20 > + @retval EFI_INVALID_PARAMETER BufferSize or Buffer is NULL. >=20 > + @retval EFI_INVALID_PARAMETER CpuIdCount not equal to 0 and Microco= deCpuId is NULL. >=20 > + @retval EFI_NOT_FOUND No valid microcode found. >=20 > @retval EFI_OUT_OF_RESOURCES The operation fails due to lack of re= sources. >=20 >=20 >=20 > **/ >=20 > @@ -390,6 +393,7 @@ ShadowMicrocode ( > OUT VOID **Buffer >=20 > ) >=20 > { >=20 > + EFI_STATUS Status; >=20 > UINT64 FitPointer; >=20 > FIRMWARE_INTERFACE_TABLE_ENTRY *FitEntry; >=20 > UINT32 EntryNum; >=20 > @@ -460,10 +464,13 @@ ShadowMicrocode ( > )); >=20 >=20 >=20 > ShadowMicrocodePatchWorker (PatchInfoBuffer, PatchCount, TotalLoadSi= ze, BufferSize, Buffer); >=20 > + Status =3D EFI_SUCCESS; >=20 > + } else { >=20 > + Status =3D EFI_NOT_FOUND; >=20 > } >=20 >=20 >=20 > FreePool (PatchInfoBuffer); >=20 > - return EFI_SUCCESS; >=20 > + return Status; >=20 > } >=20 >=20 >=20 >=20 >=20 > -- > 2.29.2.windows.2