From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.5243.1616715177723656593 for ; Thu, 25 Mar 2021 16:32:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Pg9iFclx; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) IronPort-SDR: 2o0hMj7AtVr+w/UKHVB1GMltmxI1zR3MbVUo/wX08UaLAry2RqUEaS1PQ+fbf6I3iKs1OsgwRE 8xFxKmhlNY9w== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="255038324" X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208,217";a="255038324" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 16:32:57 -0700 IronPort-SDR: BJgOdqOGixQzF+x0+wTflkLONfnIoCjn+PNiqwalCBnxhDL+IdLa7ALOg1dsIMKwkSj5VJVXBp vOLPFVdJW3pg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208,217";a="453273724" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 25 Mar 2021 16:32:56 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 16:32:56 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 25 Mar 2021 16:32:56 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 25 Mar 2021 16:32:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzRRqUf5mxVpAJKc2vOrgliVMg1MlUhGng6bCKsvnX1Lt9l+GjvpJqzK41hKtpmrAgtiZWgfrOihLwTg8vUdvBgncgfp0vwYIpweoGCVDmLJTX7T3RH9mHUQt5bWibMzPXk5bbfBH5hoepC1vd1ShkM3rCYM7CSZ+OPkEW+JC/XYwvRv9UrNGOzPNHBcZtDpIHWtKRFVS0X1o6xHBR5qFeGwvw9T73pkkvW+tV0w+Q1QKWhhoB5P7eRplZSYwtfD+7GX+v7v7z+PKSV9YOrT9H06tbXxiSs58wfXk376OTxvL+tb+jEdjXliojxEhKBwSoBPpLmDA/C8ha5J21VutA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ehIfA7Pu3lHXNa5nDF6pBZZbRjrLnUsMLSkjbIoRmqQ=; b=klQHheYjE0pF7T/ehrVbQm9NK+BTYORxfJNMldYF8INIWGRjDEsu+pyEmjQwoWxllvG6Sg/wlK+oCWawzqBDYbf0GeLCzkP2QIeNnS31zayjWzxvZeRYoyVtp89VnVYhjIlGAsCGSusjeW8EZs8CciMbPNomn8iDyHHzrJTIGAr4aHfHO7GN33YUk+TpxarJN6f0vnJMkvlzAXKMQd1fGPWkIXxlbpfWhGyWaWdtMoMZYIdRYtPPLUNMfMVsRNJ0NnOak/h7oxxaeGJ2dJr27ieMSYkq6hmEf+1lhgQQXHlez85I8j657ZLhf1jS//8WBpwL1GR45k42C/oIX/Zmmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ehIfA7Pu3lHXNa5nDF6pBZZbRjrLnUsMLSkjbIoRmqQ=; b=Pg9iFclxtMx/LQgTSonI5rN4fvQvsaeMJHPJuXZyJg+qgxyaPw6H24WtU43VxMigmDSBAS/KGP8CZpHfG+2+AR3MZD9PqDLfrXQhoQVLpvpI3TMna0JWuQr+llFP0QHZQnSSNBhofPKw17ZXg5cZjHXkACOyijG/dWPP0/5bm2w= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5108.namprd11.prod.outlook.com (2603:10b6:303:92::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Thu, 25 Mar 2021 23:32:55 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%7]) with mapi id 15.20.3977.025; Thu, 25 Mar 2021 23:32:55 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "Bi, Dandan" CC: "Dong, Eric" , "Kumar, Rahul1" Subject: Re: [edk2-devel] [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Thread-Topic: [edk2-devel] [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Thread-Index: AQHXHvLhP5W8NX/QwECmIGNuYbGALaqQVWcAgAULCFk= Date: Thu, 25 Mar 2021 23:32:55 +0000 Message-ID: References: <20210322080941.6780-1-dandan.bi@intel.com> <20210322080941.6780-26-dandan.bi@intel.com>,<9e56401b-9265-1269-806b-4fec5457182f@redhat.com> In-Reply-To: <9e56401b-9265-1269-806b-4fec5457182f@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [124.77.195.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f47c5b15-017f-4bc4-93ab-08d8efe650da x-ms-traffictypediagnostic: CO1PR11MB5108: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 26s86LL28od8uhjO0zxse6x1DpLvG9+XW8tqhqU+gqJ1CdT4fBfanOROhVVQOoOzVVjH4XFfhOxHp/ROsHOcbRrVuvEIj56nQKorEFz238OvRKSqbRm8SbTUA0QoMzbNU1c2Cxl3bHYWjHUMUL90v6sAGuojkThBAgU6iLq0DjO9knhjRrpTq4hzuYApMM+swdSqnrnz97yP+cj2Zj8TnI9OGfomm6vz2PZWU6ibAR3qxUSxYbR1KxXDGydg8g2jW/3mwtReQq8klRBBIb0Q/Zd0ckgLoGoUq+CgzJCBYAge9NQSCgEUI5yHv2wT77+5BwT58Zs44XI8YGqn9zEMzTxNtaiHpbxergfdZlcEuJqOLNnMpIqVnbjGWq+eNGtJGUvbbxJ5qu4lD1+5Mt9vtyxWLhlVF4zJ4c6uWywD5zaroPS8K55vqz2kYVRL30/0bi5buHBALwzdP8hG4ehJOCoiuGDyn5yeiDTL17Ke+/cPjf2XRblnFlR0+1/SCTkTj1LIpWJlfngoWxwqoXxHV4TQs1V+F/JG4H8EUDu3VLQUUuyr8Ts/ZrRdE2XDwhChLXHVvfFv7QpkoSlvk5IpY/NvGyePCN43iRGYJQEmpuir7HuRM10R9pU3ZQg4HUGP6hGou9GDOZ9VHfJW7LnMaHyEwBXNSQr5PYXW/nuNaWKFA+Psl4ysEk/rB7spF/KTcejCl8zV8qNJFOeZ+FHKsuUXtgVZyPrZ2WTyoHgKiApy78fZXFHFUi9KG5PjzCRG x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(346002)(39860400002)(376002)(366004)(9686003)(6506007)(186003)(26005)(5660300002)(52536014)(53546011)(166002)(55016002)(6636002)(91956017)(66476007)(76116006)(66556008)(64756008)(66946007)(33656002)(38100700001)(2906002)(7696005)(478600001)(966005)(316002)(8936002)(107886003)(8676002)(54906003)(86362001)(66446008)(83380400001)(110136005)(71200400001)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?c37FuPNrvBViJdIVmWjTof6TtJj1bAZE5Gh76aHAJ1NmYrXcHbH1G2rczNmH?= =?us-ascii?Q?NOgcCZHR9G2SN5Aq7DwwEjg9MFRbeuV0Kff7+wJ39xQYd4ox8e4LqKPMQlDK?= =?us-ascii?Q?WGk2Yf5yLlodmkYBMNlHvXBlUhU2gyJBqbWGFA3rrEJea9Uv75g7Wv5yJSDK?= =?us-ascii?Q?5fA9Uzk/CpCUq1EahPwj+Qn6JRMug3fGceGSK6KAtjIJlTwVBQU3v9uEGHmg?= =?us-ascii?Q?xmYomIGnHB1mfTrhGG+Jbuoe3cwJsfDJR2pPXZ2inURAO3QnshNchqINAYYV?= =?us-ascii?Q?/1Xkz80MGQakE+cGwil6n4oFg1uDrqZIl7PVzDYuwkiGINHm1dEjLHQmcuUn?= =?us-ascii?Q?8wjNwmpQVY4p4aRpjdjvUTSJZ/JF1ACjIAOAGo7zrKjxbigcBPaK5cVP7Aiw?= =?us-ascii?Q?AIPVdxNZ85pvCB4sZrJUti4cYD8mnbZWuIOmoEWx6P6pfLrPt4/q3fJSdADY?= =?us-ascii?Q?MOctUDUrCf0y3B4yNNEL2ZLtyjH8ZVcvbImWcr4iacEISasMFmFpfQJnuWyU?= =?us-ascii?Q?VC6wEHyVoKwbtdrKfWW6+A3XlfLPc9buUltT+K6wB+i5zVB43V/pHxIEQNnO?= =?us-ascii?Q?21A/neacLNUX/J81HCJ9oXsgqCA/C+Ihl/gWh/dieQ9VfidapWYSqvLqoMMS?= =?us-ascii?Q?BK4fDivVjBXHXZLw1ZMWhdb9a5+PrfhtyQY4pjpN8X+XmG8CTZOB4Hag22Cj?= =?us-ascii?Q?WLID0T1mOxzkwUVJd0apd4zdY0djsde+jE99ffFiepFBk3QAwHyqWEVC2+iF?= =?us-ascii?Q?QKApzA51/ZCyw4deExk/gtpm7i1oc/zp2HSuURSW2IBIzC3TLI3EBdZ3xfZi?= =?us-ascii?Q?x9i8t/AQjmwUngkJ5E44y10Z1MUoy/bVdO38OeBd3UbggvmH5GtgdqOB6zZB?= =?us-ascii?Q?cztfm7Ehd8BchIwMjDEe+kMOzOyGMce/3KOnWu/CmHzP9Uc830PgbWixPAvN?= =?us-ascii?Q?yz0G+sFTZxXxGbwK+JWqDiUoqTekwbcxLKYp1VPEMrC7q4HonnwM+DXFEO9I?= =?us-ascii?Q?dva7nNLrF8h6SK+588NvQuXM8amqG85IDFKixHl8NeumxYbGe81P9eFbt/bz?= =?us-ascii?Q?GunQzAsD5zoyy/7knejNtybInY5OyOy6L7h0TFfIO0xMvMvDOdRFrQX/CRsx?= =?us-ascii?Q?4tSQ/GSV5/3Xf3qr1p4j2zZyXlFxwyGJyfvbSroL/ivua+kQ/fsnHACLQCxu?= =?us-ascii?Q?5b803X5UAwMAyCLYjXXhPiWLuGyxlok9QUcplzyjBsra8dECBrYKPtDKmNSB?= =?us-ascii?Q?OAmzOyImGdS5hjBjexvr93DYaBkibB2qVZ/g2Kjznyr57zRkKueCuuy1Yjhs?= =?us-ascii?Q?Iq3W6BPTNubW3IcMTlxP1+vkp67GrCfEUQbQya70G8pGBg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f47c5b15-017f-4bc4-93ab-08d8efe650da X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 23:32:55.0087 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DPdbKweqTqa47LdxBgZ2/yUgznb8/X03mLGb2oLpU8K9BMXmoZSilSpdQOhHq/7iHwHw7LS3m6lJuhRAU5tleQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5108 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CO1PR11MB49307498DCD33FA69D42DE928C629CO1PR11MB4930namp_" --_000_CO1PR11MB49307498DCD33FA69D42DE928C629CO1PR11MB4930namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: ray.ni@intel.com thanks, ray ________________________________ From: devel@edk2.groups.io on behalf of Laszlo Erse= k Sent: Tuesday, March 23, 2021 2:32:02 AM To: Bi, Dandan ; devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, R= ahul1 Subject: Re: [edk2-devel] [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc= .inc for RegisterFilterLib On 03/22/21 09:09, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Dandan Bi > --- > UefiCpuPkg/UefiCpuPkg.dsc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index 7db419471d..6c7cc6b273 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -1,9 +1,9 @@ > ## @file > # UefiCpuPkg Package > # > -# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved. > +# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > > @@ -20,10 +20,12 @@ [Defines] > # > # External libraries to build package > # > > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibN= ull.inf > I would suggest un-indenting the !include directive here as well. Reviewed-by: Laszlo Ersek Thanks Laszlo --_000_CO1PR11MB49307498DCD33FA69D42DE928C629CO1PR11MB4930namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Laszlo Ersek <lersek@redhat.c= om>
Sent: Tuesday, March 23, 2021 2:32:02 AM
To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io &l= t;devel@edk2.groups.io>
Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@inte= l.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [patch V2 25/29] UefiCpuPkg: Consume MdeL= ibs.dsc.inc for RegisterFilterLib
 
On 03/22/21 09:09, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib. >
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.dsc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index 7db419471d..6c7cc6b273 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> @@ -1,9 +1,9 @@
>  ## @file
>  #  UefiCpuPkg Package
>  #
> -#  Copyright (c) 2007 - 2019, Intel Corporation. All rights res= erved.<BR>
> +#  Copyright (c) 2007 - 2021, Intel Corporation. All rights res= erved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  ##
> 
> @@ -20,10 +20,12 @@ [Defines]
>  #
>  # External libraries to build package
>  #
> 
>  [LibraryClasses]
> +  !include MdePkg/MdeLibs.dsc.inc
> +
>    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>    BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemo= ryLib.inf
>    CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
>    DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugL= ibNull.inf
>    SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/= BaseSerialPortLibNull.inf
>

I would suggest un-indenting the !include directive here as well.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo






--_000_CO1PR11MB49307498DCD33FA69D42DE928C629CO1PR11MB4930namp_--