From: "Ni, Ray" <ray.ni@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard
Date: Wed, 17 Mar 2021 02:47:27 +0000 [thread overview]
Message-ID: <CO1PR11MB49307FD5F233D9F2B2842ED18C6A9@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3cecbb33-6838-a0d8-e81d-ed81d33ec4f1@redhat.com>
> (1) I think "mGdtTemplate" would be a better name than "gGdtTemplate". I
> think the "g" prefix is used when an object is identical for all
> firmware modules (such as named GUIDs, for example).
Agree! I will change in v2.
>
> (2) I think the last hunk does not belong in this patch -- more
> precisely, I *disagree* with the last hunk. Inserting a space in the
> middle of a typecast, after the parenthesized typename, is a bad
> practice in edk2; it is error prone and suggests that typecasts have low
> binding power (when in reality they have almost the strongest binding).
I double checked the edk2 coding standard and did find a rule for this.
That might be just my personal preference. Since I need your Ack or Rb, I will remove
this change in v2.
next prev parent reply other threads:[~2021-03-17 2:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 3:33 [PATCH 0/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB Ni, Ray
2021-03-16 3:33 ` [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard Ni, Ray
2021-03-16 13:58 ` Dong, Eric
2021-03-16 16:30 ` Laszlo Ersek
2021-03-17 2:47 ` Ni, Ray [this message]
2021-03-16 3:33 ` [PATCH 2/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB Ni, Ray
2021-03-16 13:59 ` Dong, Eric
2021-03-16 16:35 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB49307FD5F233D9F2B2842ED18C6A9@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox