From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.59318.1622561089004769969 for ; Tue, 01 Jun 2021 08:24:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EpBK06YA; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) IronPort-SDR: D7N4TrppHW7ICrYOu2LKO92XD8XvFVuR6kTBNpjJCMae5F7f5V0G1AKiG31UPNmYy3bu5beuIm PKM0j92HIzrA== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="267442417" X-IronPort-AV: E=Sophos;i="5.83,240,1616482800"; d="scan'208";a="267442417" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 08:24:48 -0700 IronPort-SDR: nKbzh7SxXoo1Z8keBlo4PsPY1xg3wbxAEDhcMdvYnQ49814iPCp4b4qXT5T7pF7sESMh1Zz0B7 xfydFUHchP4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,240,1616482800"; d="scan'208";a="467090307" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 01 Jun 2021 08:24:47 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 08:24:47 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 08:24:46 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 1 Jun 2021 08:24:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 1 Jun 2021 08:24:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gZY8R6BwpHG6vWgIWWGTfkYtN6aNDV+866GZUadrh3xpvbnWIi0exbnEDPKf1cq13U7iiajtbOyqlHakTYnieomqazTPX3CYmkeXy/KU34Bo6+JWh4pefU4Cpl2dHdFqktK8SmhTBl3ySrwOO4/j9lPOZOSGGNu9sODf/jB6l6lGrIrm/83T3f+UapsBHfb3qMZQ8I/eN4gXPoJZDeG5STx8qGUBvEsWlA83//ggVsv4+Z0pCRWax7pltsyO92sGD8a9uzxgIBqKULXJLUpHhim1i54mSbsAGu4hb2omPsXkvlHc4yjYZB8MgrF+900ZDhK2Jx3zVbyYGInADJd/Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3EF/YjklCqWsU+sQYdMXzQf+6zkCbDZtl8yUM436sE=; b=aonN4qzuqz5VfqPzZLa0BarEm4yV8QRA6izL/IYRTJisZnLQBmWukupRo0sER/85A5OkHINU5WbmeNez8NMAsYC6bo44doLGFcUs/IeN0Qt75mafebucB5oKrsB/nh5fQPb8iHQkKyCqNvFcEnUIuRDJeMMYXHT+IlEkqOaTvOHjXsaH7C4i7EY1voCZFUmM2zRsz7T9yRXrD6e4bZ+QiAPDVVzRznWc59bNnuzncOUrmWpAIhD9H+ry9284kJdbpuHFuX440WmPadm2tzRTfmPT22GJh01hh55t7a2lxB/uDVe6nxCtOLZWYjNhrNMgm2127N7tRupZ5LKvWJcnBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3EF/YjklCqWsU+sQYdMXzQf+6zkCbDZtl8yUM436sE=; b=EpBK06YA77VGzQCKkfR8QGhR9tMy5OIj+7bEGbHCsVBfOetLIbCpKM3ZyrgeS4CQq3NU+lXifp0GftDt6U3vmUzilYvp3a/m8ZB5oxYbpEIDf06ljDi0vo+nzXHbA1j897sNTESfw2PmOoegoIOe8bE92nvHbC3K4y1ic21y7gI= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2304.namprd11.prod.outlook.com (2603:10b6:301:4e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.21; Tue, 1 Jun 2021 15:24:45 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::59d6:8b94:55bf:36e7%5]) with mapi id 15.20.4173.030; Tue, 1 Jun 2021 15:24:45 +0000 From: "Ni, Ray" To: "Li, Daoxiang" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor location info Thread-Topic: [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor location info Thread-Index: AQHXVrdUr8ePCBV+n06umZzOFa30KKr/RwXg Date: Tue, 1 Jun 2021 15:24:45 +0000 Message-ID: References: <20210601072451.1329-1-daoxiang.li@intel.com> In-Reply-To: <20210601072451.1329-1-daoxiang.li@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.142.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b1380c9-cd1f-447d-1555-08d92511633d x-ms-traffictypediagnostic: MWHPR1101MB2304: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dox2ixamHhQZU2F89YUAcWx01ybQqP2FefwF5EtObEz5rV4oSBCWwXqA3pA6tG2S4sWECucFa1cY0786saG1Bu6E/DS9kpysVGcZvtNXup/cNaG2y7UdfmBCvVyg1WN/E4+efz55MZaQVd7fRGgvnP7TXH5Sx9RVctma+9IuFCJPvQw6TDkvQKsmcpX+pZfxAn9MxyKvbJsh6o9PPmF5DWkXdAuPXaRq1vcfkpk495ItcO6rht14Cf22Y1uYSqDS89Vmv+qIlZHWjPvutjToUtOTf5I1hOSFPzrDsPf2PHvPkNfMd7VS9X6W7agDFMJoxJ84z97r8gS0z1HNR2VCfaCXksHfbnmy9RclOOkMpVu98IMHFGnVM2KYd+VbwnI5Hy2QFFfJhuUFQMbHhiPAIitZgyZwJlVS+tNqD7JBeTKop3AHEJTznWAi3hJ4txBbNfWOLeGrzCB3+gloAIZXIseZizFni0MaAn7tMETE+iyg781k3HMbWaBFUwdsvgzaAhrb+kZvx6eAnRG77s83tWVd1X6Gr8VIEw6oOvXwNdYjGrI0+WS/Q2tR9DfZmmjNSw+H2rkfIWmfN8MXYLXCWbika4PcGT92y5v1buOSd2CYdSErwgMrPxmCzP+fTUIqPWIl2cubTma4EPl7IRGIm/c8uTvluCV/BFyS9sNLaqtLdxBMKoA8XdP18uw38vSVIY8U1ERUbROodBx2REmw4w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(39860400002)(366004)(346002)(396003)(316002)(110136005)(54906003)(9686003)(4326008)(83380400001)(478600001)(7696005)(8676002)(55016002)(71200400001)(966005)(6506007)(38100700002)(15650500001)(5660300002)(76116006)(66946007)(19627235002)(122000001)(33656002)(66476007)(86362001)(186003)(66556008)(2906002)(66446008)(26005)(107886003)(52536014)(8936002)(53546011)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?pYRW9cBKdd+ElKUHinFkrwLXsMipPPQFtwWiiGO6YMGygNxaeGP7XpTy3ZFC?= =?us-ascii?Q?Zuu5lov3V/Isua01GikS0OUTG7t/gztKe9BiBjwz33yPj6y4HhorgeK7CZtX?= =?us-ascii?Q?0mNdGk3vZe5fROhGC3q2q69USJYynO0NSptClbzl8yt7h8IcA/5VDWcWuaQh?= =?us-ascii?Q?yCm85jf1YEoovy98IzMaOGC2v6u3iZS3D6UgnSe3M2Xm3GRIO28uNqif6PXs?= =?us-ascii?Q?J9Fu41eQgAFCRvkUX2h+pK5s7vU1ov4irqMb6+OuNltB73Oh2QP53Nu2vfvD?= =?us-ascii?Q?oDPrU9khJx9xCqNAmJFTq96iEtSXg7VT6Z19FDISSezU4H9YA/mRI19Jfqrb?= =?us-ascii?Q?s64omv5hystOqccEZy6U9TufAxZP/CHJ5DrROYOzhNcMFBqjYGTFlfPUih7+?= =?us-ascii?Q?+duCdJbgHwpBl1ZtOOBW2gmGL5GpNyvta3rgCJyMV14CMOFNtVMn/6AJXb7z?= =?us-ascii?Q?oLs5zxGT0WLiPV9iDor/pyCSXLZhQVLdOirQ66sBkVjjt1FoQRZPw4uSn04q?= =?us-ascii?Q?FBm7eBZAknH0Zbgqpcdss99KFc9xAQTbwFZFOoBTJNwRLkm09oFOv7Qg3dlV?= =?us-ascii?Q?LEGt4AtzLRAya8nP6d5AjCGJi0h/b12nIzSqRWoFzce0l6J/iEsf1ufm4y+4?= =?us-ascii?Q?DEhRzxbHe8N0JT4xNi9FQH1ZcCS6MsgRQNVsMxMEEB2aDF7JlgvC1SvsX0vg?= =?us-ascii?Q?ebqbsleOeff0eft7cwidtoFlGhx6fqgLeWXoqftqS5qwRCDDGgCACEUl0zJz?= =?us-ascii?Q?R59JpQZU81fxKhyza9PE3pP0lk9uualW/UfJElfZmQYholpq6d4q08JxCb8Z?= =?us-ascii?Q?lQMyBJ7yHYyzm5nmfBgFy6hsSxNpWBj6vCf7sWkaALBOMfAqckd5AosQzpkL?= =?us-ascii?Q?X3gvT9hMcZuOivW7FwqXaqM4asK+KnIemfdb4Kd3OU67CxbEF6SDUbOz+itj?= =?us-ascii?Q?QYIxM7jp/pRkAKcqfkDnKjcBYm1gexfrBytw+dZSwizbyDTrnYTc2ebNbSry?= =?us-ascii?Q?aAL7TK+SnH6Vv8fU1fWZ276FEx9swER7cLUPwkz7Ug5ciUwNX71T1mBY5dtZ?= =?us-ascii?Q?7pBLps1DPa3DPJUvt48B062/CctFPICVLO8cvbzTjFoHmVRHUUi+XZX+tX+t?= =?us-ascii?Q?kFqclkGQvyCoPs+rXqYQQ6kp+ODN6aaYHK/UH5CAX5j8t7xth64JqYdwjvdu?= =?us-ascii?Q?qN9rvxJfVyTRJhEolKvW+Y0Hl1hikb2ajyTKb5/4OmDrbegdqkgow3yN3+QP?= =?us-ascii?Q?P67ZnKMvvQUxTebIAblmG6nrFPwWobMlHg+5JgcErOK00D8d/LZQe76S9I0g?= =?us-ascii?Q?a8i+4EH2LSIYHgnmQp+0BMez?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b1380c9-cd1f-447d-1555-08d92511633d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2021 15:24:45.8219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fKll21GiDijfpSG7q2gie4TgdiDykuPtf4YfKprD68kEcyVilbfaxzwJieZVwsKQ4O0xZQf5JuTLN2ORR3pYCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2304 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Li, Daoxiang > Sent: Tuesday, June 1, 2021 3:25 PM > To: devel@edk2.groups.io > Cc: Li, Daoxiang ; Dong, Eric ; Ni, Ray ; Laszlo Ersek > ; Kumar, Rahul1 > Subject: [PATCH v2 1/1] UefiCpuPkg/CpuCommonFeaturesLib: Update processor= location info >=20 > From: Daoxiang Li >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3424 >=20 > Processor location information check needs to updated > When Core 0 is disabled >=20 > Signed-off-by: Daoxiang Li > CC: Eric Dong > CC: Ray Ni > CC: Laszlo Ersek > CC: Rahul Kumar > --- > UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c | 4 ++-- > UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 4 ++-- > UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c b/UefiCpuPkg/L= ibrary/CpuCommonFeaturesLib/C1e.c > index e6e5db75917c..c867802f0bb0 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c > @@ -63,9 +63,9 @@ C1eInitialize ( > { >=20 > // >=20 > // The scope of C1EEnable bit in the MSR_NEHALEM_POWER_CTL is Package,= only program >=20 > - // MSR_FEATURE_CONFIG for thread 0 core 0 in each package. >=20 > + // MSR_FEATURE_CONFIG once for each package. >=20 > // >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo->Proce= ssorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D 0)= ) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 >=20 >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > index bb5d983d1f4b..a3a2861cee5b 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > @@ -152,10 +152,10 @@ McaInitialize ( >=20 >=20 > // >=20 > // The scope of MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS is package for be= low processor type, only program >=20 > - // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS for thread 0 core 0 in each pa= ckage. >=20 > + // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS once for each package. >=20 > // >=20 > if (IS_NEHALEM_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayMode= l)) { >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo->Pro= cessorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D = 0)) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 > } >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c b/UefiCpuPkg/= Library/CpuCommonFeaturesLib/Ppin.c > index 8450c7ea3eaf..3c4c1bc706ba 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c > @@ -130,10 +130,10 @@ PpinInitialize ( > // Support function already check the processor which support PPIN fea= ture, so this function not need >=20 > // to check the processor again. >=20 > // >=20 > - // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only pro= gram MSR_IVY_BRIDGE_PPIN_CTL for >=20 > - // thread 0 core 0 in each package. >=20 > + // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only pro= gram MSR_IVY_BRIDGE_PPIN_CTL >=20 > + // once for each package. >=20 > // >=20 > - if ((CpuInfo->ProcessorInfo.Location.Thread !=3D 0) || (CpuInfo->Proce= ssorInfo.Location.Core !=3D 0)) { >=20 > + if ((CpuInfo->First.Thread =3D=3D 0) || (CpuInfo->First.Core =3D=3D 0)= ) { >=20 > return RETURN_SUCCESS; >=20 > } >=20 >=20 >=20 > -- > 2.28.0.windows.1