From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.5002.1611222455027183539 for ; Thu, 21 Jan 2021 01:47:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yJmEMsfN; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) IronPort-SDR: ik1nUuaxhlsQ7FRDl1+eN5irBCL3HQy+/zAYJN13C7PkcJTWXrB5imXojSo2tkg9M79bdlitSv FZ4uGMTZuPEw== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="179395275" X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="179395275" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 01:47:33 -0800 IronPort-SDR: PygKjLbr+2UUi98N1j6NkJAIKjjSyK771xiLMSW0TtJE04N7SE0Y9ZUw8J7L7zjRP1msjnnIby M4XobGXoPNWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="502101688" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 21 Jan 2021 01:47:33 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 21 Jan 2021 01:47:33 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 21 Jan 2021 01:47:33 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 21 Jan 2021 01:47:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHoNZM7mt4A70Q3EjLJYPRP6vw6zE29BPGu5B4XU8Qgzzg6b4YXWdyXVTqULtmGLSsq8C3B2P/nC2ZnzTkwu+a/aK3BWZBD5DGCiVPVmw2wHcQV1Kmi9Kisnl1FPF1Xqs0xHnr/1PZzWyPWNsqvY9gjuO3/zrigf7aXU30hlEtyVyfes7UKv5kh9PgK8dUcQXQFH3C9peCjLeY3FOfNlC1aQopbHmyDNFDmji9a8zglt2mFrU36dJdeKqfTtjwOATH9Xjo4W8UeOrNmpTPS5R56GEveNt2WGYMV2U4PmJzy0N7OYO5lW+Iffp6hpqsOG35qjFHZ4iDWTmEdpm5f02A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SlMmaxKMRH60jR2nwHgWfFuaNGn2Fep9FYLj7olbh5o=; b=Wa+gRAD+A4NS+XUUlEKS19XvIuFZUF9is838c7EWhas9UHpEymWmM9A6GQRp4iKa67Ac3yB1VqUuNuQCWfikKch1hjZG5r5abM5GQcsW85IjNUiyl9AVP4iWyAfrFKZ8K4S6wDb9WeOrQs/2V+AIre/YPzgG42GPpBWurMYpOJOPIRBpYaihI2jW2sg4cywU2W5WgOGDe3uQkpvJqmgmlxdmGwPu7BRF1zf4UXutPWJSQxXjo4GshCxaqqHZ/k+U+PM79Sp1fGho8I3D7N+Y3TbagtUBP/hnCba/w4Wztd+2FflXo8dPHSChgDN46P3nYcsznAPESEII7Z7yZ3qDGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SlMmaxKMRH60jR2nwHgWfFuaNGn2Fep9FYLj7olbh5o=; b=yJmEMsfNZry79RazLaOz4696I9usMK+bojDOuUqDCjxivmRQwP2i88dnh0SHlwY5hNHsH2vy14xZyoHS5+zv5DPfYGJwcORfdwfgHggdeJvi1TOrmz8DREjvRA7TT7I5JcPjc/cO29jU6w+52MwrD36do+iHwHMIgD3ZLzymbUw= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MW3PR11MB4571.namprd11.prod.outlook.com (2603:10b6:303:59::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Thu, 21 Jan 2021 09:47:32 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3763.014; Thu, 21 Jan 2021 09:47:32 +0000 From: "Ni, Ray" To: "Zeng, Star" CC: "devel@edk2.groups.io" , "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: NumberOfCpus may be uninitialized Thread-Topic: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: NumberOfCpus may be uninitialized Thread-Index: AQHW79kugNd/4gpOA0eNCC1R/oAe1Kox1Hyw Date: Thu, 21 Jan 2021 09:47:32 +0000 Message-ID: References: <20210121093825.1571-1-star.zeng@intel.com> In-Reply-To: <20210121093825.1571-1-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cad6baa-8147-4820-0c0a-08d8bdf192ed x-ms-traffictypediagnostic: MW3PR11MB4571: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pv1yieCPgEI8/h+Xak2DQ1fZOJsYTdmTOqJVTFMiiOe/vxuqbN5gg5fuLD2gXCLilG5Yj3fNwU5G/KyvBdA6owWkt9tWTmvpDFCIepdJ62viqQLCWHXEwv+kbBQRWNHc+BQmIL0CtdC1pNw2ARd+4ZJ9G7+9GGGZ1+ydYkRqbmN95FNCf+Ji33XKfUw15BZ/Kx81OUVJREkdGXs0Txj0awY93HH9C4N6rj2NV0dy5rqgNZRHlcHPsGyGohF5sevv9YMO9kIAjfR+SPqdoGCZrGzuuSrb45rwzGrkwJ1ikLl/RsEANOjq4X0A1tJSRaeWCTL5Mb293jvB86AHZD9SB2yKWfbjAl29Sw6Hb/PpNBBjINVBvwI1seVnmjGYpDiT7uOP+x4qFAyhSO8nUvfOCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(71200400001)(9686003)(6862004)(7696005)(4326008)(66556008)(52536014)(316002)(478600001)(5660300002)(55016002)(33656002)(66476007)(54906003)(6506007)(66446008)(64756008)(6636002)(186003)(66946007)(8676002)(26005)(76116006)(2906002)(86362001)(83380400001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?MRo3cB9CqgUD2+lpj2gaCJhUSR5QEoazT/ky6Nc+NuT3FYMBTK59lBjqLv6X?= =?us-ascii?Q?WtDhBNrRWz2/D1O+KsooEw3DQwlBxtMOhBbOcXIlugzO4xoQlBl4FgmwS9Mh?= =?us-ascii?Q?V15Yh5P2OEneExZIPRv1oYLNHXgR8YFosvD3gsdPsJwA2y6mi/1A2SjnaRH4?= =?us-ascii?Q?S2K17HZFz2t6dND3gQfiCHfNMgFnZ/jFUlW9cHEoM9qs5JWdk5zIE00ci7+m?= =?us-ascii?Q?szDE8bFYkX5H6kDguMApnonwGfn3NKlrsi+24m2ZlWiEbKwmgx0RgXm+pSvm?= =?us-ascii?Q?3bY3u5T5qTYn9mYoxJ7inxJqnxkGmAqciuP8QtKem8hsqVAiD4HBbGEzcpUD?= =?us-ascii?Q?XAGG4Xtr71wlORB4VzlX3K0gHWTtFhpFoMcJ8W/WQ27fny5R5IB1S0ihrLwZ?= =?us-ascii?Q?r64PnvuAo3JnYWRIy2cWCK1e4P9hMujQFWJXUbDomDAcxhsCfgJpzhOrqSTU?= =?us-ascii?Q?IMAnYQTspXF1SS8t32yamvMmCKEwiXp3F/meu0I8XVDDsDqvtPbSW8KKDJEi?= =?us-ascii?Q?6rUogUyNGIDvUIThYUTJyhhvAGIcRuLzuAYD7sqI/nKdpCPlocpWoaZz1Fg1?= =?us-ascii?Q?N8nuass1LiOaGYGM5p6lApnWNpSLPcY7aIW708WNH3yLh67CeKfuJ+W/JII9?= =?us-ascii?Q?mqSHUsUkuD8hKzcv1MgHrNIwgCD4y6YRTz/e67cZ38ihKhVTdYgIvZGZwFS0?= =?us-ascii?Q?kVtv/eJ1CK0plX1NBiclV2kVLS3OdHfqA9yY19QfvLRsokYyGllNLqQqGDSs?= =?us-ascii?Q?EOCtJBH4PnOQyCM561XkCgDBBTijSilrr0HApOC0OSe6HgTvAI7+JIcLlp8J?= =?us-ascii?Q?zs6RWfmcWjOqFeqYaQNv5zUVuQQXulZhm+SYvPKh/Yq+xaP+DuesUX44HK/0?= =?us-ascii?Q?5y999GOmH2FU25ZgZpgRhTd80eGPwWc9MZNvaf+1fmCe7C8g282kTQe0KT0i?= =?us-ascii?Q?pbZiB5Q8wzeJ2x1EWStvyEqZkeyeyVXMvPff370BBOg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cad6baa-8147-4820-0c0a-08d8bdf192ed X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2021 09:47:32.1477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cg0AyNAJCcnYyKsseGx+XhazuxSAZUhjM5apQ85koIb6RPECgdOV36crWpbL/Yr2UeED8OijJydVf87Ibdjdmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4571 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Zeng, Star > Sent: Thursday, January 21, 2021 5:38 PM > Cc: Zeng, Star ; Dong, Eric ; N= i, > Ray ; Laszlo Ersek > Subject: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: NumberOfCpus may be > uninitialized >=20 > NumberOfCpus local variable in GetAcpiCpuData will be uninitialized > when CpuS3DataDxe runs before DxeRegisterCpuFeaturesLib (linked by > CpuFeaturesDxe) because there is no code to initialize it at > (AcpiCpuData !=3D NULL) execution path. >=20 > The issue is exposed after cefad282fb31aff3e1a6dcbd368cbbffc3fce900 > and 38ee7bafa72f58982f99ac6f61eef160f80bad69. > There was negligence in that code review. > One further topic may be "Could EDK2 CI be enhanced to catch this kind > of uninitialized local variable case?". :) >=20 > This patch fixes this regression issue. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Star Zeng > --- > .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > index 7bb92404027f..60daa5cc87f0 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c > @@ -957,6 +957,7 @@ GetAcpiCpuData ( > // > // Allocate buffer for empty RegisterTable and PreSmmInitRegisterTab= le for > all CPUs > // > + NumberOfCpus =3D AcpiCpuData->NumberOfCpus; > TableSize =3D 2 * NumberOfCpus * sizeof (CPU_REGISTER_TABLE); > RegisterTable =3D AllocatePages (EFI_SIZE_TO_PAGES (TableSize)); > ASSERT (RegisterTable !=3D NULL); > -- > 2.27.0.windows.1