From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.8997.1616741373797927151 for ; Thu, 25 Mar 2021 23:49:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=UpNd9z2J; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) IronPort-SDR: y1JyZ8IxqD0RrOORScubZjw7AxfwAv13EAwwqwPoqj/XK/TyKi/PSyvZXTMJmWAbmqIAwABAIZ XD6YEWnsPhgA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="178209043" X-IronPort-AV: E=Sophos;i="5.81,279,1610438400"; d="scan'208";a="178209043" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 23:49:32 -0700 IronPort-SDR: +bqs47ggjpD0yZ/2GrywLp6LTam4C+Ve9I+ahK5fKjHDJSZxJdQG+1j8wYRFOhg6Ll2C9j2Qpx +EVbP1sk/xaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,279,1610438400"; d="scan'208";a="525935500" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 25 Mar 2021 23:49:32 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 23:49:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 25 Mar 2021 23:49:32 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 25 Mar 2021 23:49:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lplpZMoTYJODwj13Q9XMigbzb3KvwU51T/8RgSdOCypw1SyTmUqHJCQDqsYTC+K+5n9LK+6bj9YIMXG+9ZX1qeDpF87kHtkCHph6pzHRux81lvCSfg4is99Q5y/YuGe06kJrxlLV1hQSbkVk8/KDp2PGiARq52HnW6/x2FChhKf4cz9+cCmB/AHDf/vCvP5J34fx6+TjWjr80nko/EVzWOxow9Tp8k6pFbb88FJN5y/SqwrJssvLbN1RK2lgeHVhJiAukJ+JvSiHvN5uLvFl5YHE4a3fzn+qN0IcB5UEBKq5ubhdNO2wQvL2YcTtekuVoec3tud/isdFSdIYNwiYAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l00tcZCpWYEt19C+rdkAJeOjxoky/A4imzOXLWR4ovg=; b=cDPMUu/OvFPdci3BkdWP54PlyJ0NUef0DY4Os3ph4mOWtDpgVbOWBB4eTEdwEdKk8+X2lQL8+jsBdTFlRBq+S1r01MiMRIkn94oxKAw6uBvP6rCATUs3GwYtLgUthO0YhzkPuoJN2aKuWK35YQJWZWE4RYYXPIz65a5BTDAa+lpOifUXDxxIVJK8Mr2H+rarNZWmMEqaekHeaTr35wZtzaoxMNbyJGwbZASr6OhkbvIddAZ60cEuWBCnf9FI99DstNJYF1PWNS4KkTvk3BMaBfvIREXhQkL3ER58uHcqPsplV5MaEFj/JPYPhjzRu3IoR72JsYy/Uxr6sgkiHNHzkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l00tcZCpWYEt19C+rdkAJeOjxoky/A4imzOXLWR4ovg=; b=UpNd9z2JrvI06Mx/ZLiZ/M9Ok/eGCtVXhjEvmEpEXizOgBkFgLvKXkubvWOt1LPVWbdMUttsCPEZsLUXtOJ0oWkWlblbtSrzouo4LXM9s2MzFPHyP/c/Vt6NYUtx3XI5/nIRQouwpi6ol/ihmE4VXoA6W/XY5IgkTq/j/36oZ+I= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2271.namprd11.prod.outlook.com (2603:10b6:301:52::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Fri, 26 Mar 2021 06:49:30 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%7]) with mapi id 15.20.3977.025; Fri, 26 Mar 2021 06:49:30 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcode location in flash Thread-Topic: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcode location in flash Thread-Index: AQHXIgv4anbPXT5RK0+4c3DwaE5BZKqV1Avw Date: Fri, 26 Mar 2021 06:49:29 +0000 Message-ID: References: <166FD19F7613DF94.8397@groups.io> In-Reply-To: <166FD19F7613DF94.8397@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b1b2766d-a15f-4baf-f2c2-08d8f0234e42 x-ms-traffictypediagnostic: MWHPR1101MB2271: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4SFeoMCLD8wVduuNhNwTlKnTURV3Ta7gAg11Kuu4dR394llNinqbM/nvXpAyNDZCxIHZxZsHU4hiTSpy1bNlDW3x1yfRVkIFMXOoT1QIjepD1SAKhI+LuOF0/w9I15pOpMyiTsy2e+k5xFWMqex/6rVZCed4RA8XUgV94iAQvgveBd36BK6kNSJXFK/ZLtf5jqA6ibogTE0a+OyNHsXqZDWZmxA9sRFW/Zf2XSpGBrjY/Bi+gff0Vp/mXUYzaJo24S+k9cgUlEq+QEXTna9GGdZwOrTP6aEK5CZufEDDCVlO5gtsZe4Go38klHq6oseJWyp40KDIqy00Rtb67hC50KY+mbGJ1J4UrRsqp0GioAJzJxJ91YHW/gqmmjrsZnU8KfA3U3FALUoBY2o4y0u+L6btnVFhqhJF5dShZ0cPEtX8/x40PRgAk3pViE+BhE8N/GTHZTWUwpU+G3sv9Ux6kcd1G1j4Wyp4FYcZlKwyX/c4prc5LagJjDWzImldKP8rc/d35qwUCwQOFqOFBHHm/tZL1ot4fY3t8/6DRvKVXWQX8IJT9Uk8/z1OfkIV7PR+f1SJFP0i4q4P6jbccxM5L8+S9avm+Cu+a8RxY5lEoaYo0Y7K6vpwKUW1hwcpuYmpajI3KBhWvF4JiPSrJ4uUUoSlSpv5mebFLnt6303JyS8BtdlRF9CUXO6q//Pf/ilfT9I/bQo+977iSLJxlLOp7+xRwKaibqTZbtx/f15OunwX1miRpggDKMIMSnacfGn4 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(39860400002)(366004)(346002)(376002)(38100700001)(186003)(110136005)(316002)(33656002)(26005)(478600001)(7696005)(83380400001)(86362001)(9686003)(5660300002)(8936002)(53546011)(55016002)(66946007)(66446008)(76116006)(4326008)(107886003)(71200400001)(966005)(6506007)(52536014)(19627235002)(8676002)(66476007)(2906002)(66556008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/CQ0iiv0oQCek4pmga41xKTL0zgAXLdQ6hcbY8iXKV+JL9ORXyU9Pdb807VW?= =?us-ascii?Q?HC5flbE4z7AZ01bN0nQhjlY5nAVUE4/xAlPSWQ/+h0Mrn3oo6fxQYEEmio8n?= =?us-ascii?Q?xOvJ6JGkGRIlrUleKxXJVXA47fE2n0BrbsAUcEwE+yRdchJv4T8H2G3UQLSe?= =?us-ascii?Q?IB8wIMA31r/AuPs7Q+HfwHZsNR34oa+0KQzfttiUVrEvBoW9ht4yC3+rLUwO?= =?us-ascii?Q?l9o5co80JwGLM/2XBxz1ypPzv8Mu8Dl+Ntmx7riQszd+OVoJeFhyGgmd6zp6?= =?us-ascii?Q?id4wTHoix4sK0zamtR7xEGlioFrKsrCi/Eu6BUn9swsIoQi8wYxGVeNiBp6T?= =?us-ascii?Q?fZs6t2n1GAa//rVih/esHPxc0oy9cq/QsiGOGFfyEeuXBP4lZNf6LsewaZ8+?= =?us-ascii?Q?9EgG93SQa0EAcxmJnQOlb6WofQVjbSsK0qXakk99OpEBiZ6XRRZQZ0mL2xM+?= =?us-ascii?Q?mlL2vaCpZ0SAKZ2YGTEaP/4lXkN6Zqstr5YeufpsObC1vxUOD1c2bA65iBBa?= =?us-ascii?Q?2N589rQDQ7UIILp4R1jBsay1+Amp8HesoTei2XQUr+1KIlmNoABXExZd6Phh?= =?us-ascii?Q?txo5dPtS40sO6/MG9eTys5A7Up4PzOsHNl2m52UX7zaczc4KswPOt3Xuk9/d?= =?us-ascii?Q?Gh5d4bsGHFc8TPVi9w8sn197wvKa1EGo1kRrvdq0YthPS1z/lwp5KH4mCyBX?= =?us-ascii?Q?zCB6mUgM69xKX5bGyIEpBxQTvOhy3cUPwlIHwGRb3xL0ikrIzBSdEVSsXvTm?= =?us-ascii?Q?3P8P3x6McLCYLkMlDoIy5iECJtcXemgwPBSajdm0k2t+qQYEE/SFM5s6C4U+?= =?us-ascii?Q?blMV4YmuKHfDAooKA4DTuGAwKVEqEHhc2kwKWwQgAMWDjLSCQs20JmAXmmkm?= =?us-ascii?Q?ANlfuI6t5VVfE+1UWQPTZnKYuO+hI2lBIfHekOd01xKZuesSmKusnqRInarC?= =?us-ascii?Q?yfU/LfZgQbCDwOdIQhV8NxLBJQvDfQnhS2qVrRz0g8v8FCM1Gq7LwCfn5w36?= =?us-ascii?Q?ePOvlI0gotrGTRpGDxEz/Ybqa72uzo/Inwj/T1aGtJ8AaTzgp/X8+7Ijzx3y?= =?us-ascii?Q?CqCYVGO3dK8YdAEzSQkn1qPV3hpZNUGpiK3exLioU76eAhTBybFJ1IRCTIgA?= =?us-ascii?Q?UytWcsfwpePrpy/3EB7QTTh6vheLZmcxc477tFF0XcCwxjVPLX6dKFfx8Al+?= =?us-ascii?Q?jKxf3wryJZXMynU+drpLeEgAPl9ffkQd8FXYlH/9aib2xIKTtq49ilf3bjoI?= =?us-ascii?Q?Ia2QH9s13GuUUjqaOB5ea+Xk0LjJ/jfPQu/jfCSEVurUXL6nqKiPYETw0Qej?= =?us-ascii?Q?qgbY1Pmyx9tlOQVToe7J7QS1?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1b2766d-a15f-4baf-f2c2-08d8f0234e42 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 06:49:29.9730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jVzohty+yp6JmAdLzMktxgEyLCq55TRjMBtKZfL8weB8JWoQTVmPFZGyOOEA5TGU8+jhPGeCDwLR4NyGEc52zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2271 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please ignore the "Change-Id" in the commit message. I will remove that when checking in. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Friday, March 26, 2021 2:48 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcode = location in flash >=20 > 3 PCDs are defined assuming that microcode is put in the end of a FV: > PcdFlashFvMicrocodeBase: The base address of the microcode FV > PcdFlashFvMicrocodeSize: The size of the microcode FV > PcdFlashMicrocodeOffset: The microcode offset relative to the FV > base address >=20 > The 3 new PCDs are to replace the following existing PCDs in > MinPlatformPkg and IntelFsp2WrapperPkg. >=20 > The ones in MinPlatformPkg will be removed in a separate patch. > The ones in IntelFsp2WrapperPkg will be re-positioned as only using > inside IntelFsp2WrapperPkg\Library\SecFspWrapperPlatformSecLibSample. >=20 > Defining PCDs in IntelSiliconPkg is because certain close-source > silicon code depends on these PCDs but the silicon code cannot depend > on MinPlatformPkg. >=20 > MinPlatformPkg contains the below 3 PCDs: > PcdFlashFvMicrocodeBase: Same meaning as > IntelSiliconPkg.PcdFlashFvMicrocodeBase > PcdFlashFvMicrocodeSize: Same meaning as > IntelSiliconPkg.PcdFlashFvMicrocodeSize > PcdFlashFvMicrocodeOffset: The FV offset relative to the firmware > base address. > Note: MinPlatformPkg doesn't contain the PCD that tells the microcode > offset relative to the FV base address. >=20 > IntelFsp2WrapperPkg contains the below 3 PCDs: > PcdCpuMicrocodePatchAddress: Same meaning as > IntelSiliconPkg.PcdFlashFvMicrocodeBase > PcdCpuMicrocodePatchRegionSize: Same meaning as > IntelSiliconPkg.PcdFlashFvMicrocodeSize > PcdFlashMicrocodeOffset: Same meaning as > IntelSiliconPkg.PcdFlashMicrocodeOffset >=20 > Change-Id: I708abfa4a9309cbaedd5c4e4f483ec9f0d5e7625 > Reviewed-by: Ray Ni > Cc: Rangasai V Chaganty > --- > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/= Intel/IntelSiliconPkg/IntelSiliconPkg.dec > index 4a2cbca5..6611c3af 100644 > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -3,7 +3,7 @@ > # >=20 > # This package provides common open source Intel silicon modules. >=20 > # >=20 > -# Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -90,6 +90,13 @@ > # @Prompt Error code for VTd error. >=20 > gIntelSiliconPkgTokenSpaceGuid.PcdErrorCodeVTdError|0x02008000|UINT32|= 0x00000005 >=20 >=20 >=20 > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0|UINT32|0x0000= 0007 >=20 > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0|UINT32|0x0000= 0008 >=20 > + >=20 > + ## This is the microcode offset relative to the FV base address. >=20 > + # Microcode address equals to PcdFlashFvMicrocodeBase + PcdFlashMicro= codeOffset. >=20 > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeOffset|0|UINT32|0x0000= 000A >=20 > + >=20 > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >=20 > ## This is the GUID of the FFS which contains the Graphics Video BIOS = Table (VBT) >=20 > # The VBT content is stored as a RAW section which is consumed by GOP = PEI/UEFI driver. >=20 > -- > 2.27.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#73313): https://edk2.groups.io/g/devel/message/73313 > Mute This Topic: https://groups.io/mt/81622347/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20