From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.5109.1628258403490812553 for ; Fri, 06 Aug 2021 07:00:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=xVngZJgh; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10068"; a="212515692" X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="212515692" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 06:59:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="420178824" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 06 Aug 2021 06:59:59 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 6 Aug 2021 06:59:59 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 6 Aug 2021 06:59:59 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 6 Aug 2021 06:59:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QS6GWi8moDOr2Wj9o4bB1plEn24ldaCWmUzfFWan4fX0KVsih1m5XmyWo7Ifwo5f4LIhKZox2+Om3pgsxadC1dLi89ZdQWfCdWeB47bQ6VqBMSRxdbwEsIqb3Pjt2S/1uDh2eO67UhnkJvPug5UrpHp2BU6t0hytVBjTi616ZTmdw2WdoIqQ/436XjNsdol1OUNFBz9mD9pCASWew12QVj2hRLmSC8k0ojcwXBbsrjw2cNhZuMbDQST1F8BO2Po6zxX6lkbP34ge+YbyVg3+wLLQy5De6QnfnAjHYJIRrGDkZSxOrsurbgPaKrMoXR0iCzUzkQkX3UU9p+8qcftOrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYP4rM48l/j2UdtbIp+NNfQUArBQlnta70/s0GVnnDQ=; b=VuvZs8IQuhkczNOeTrJP77qexL8txtay3kczW16II4s9T+Ic+KdnAYovzDcgeNTozjn9C/CsHPO+fcMgq5lnBpM64Wlx9O6LuZFONpj3pERTaM+e4QFSY+3qyo/z89QMOuh5yCztwEcEIWNlnOpc51oaM4Ale20otgBlDL4AZVvR4RmDAn+18sbjkl3fi9+ODR09hi9JlfKR694B3yXW5olTzoXurRxGPr+eZUFJ5eHPc3RPB1H15G7AzOJpOiPbVN9UoqNPa6OfoEuFg2zFm4U3AiXYhpFma1g7T7S/FjI73k3BanrnSAtun05bi6orAvHJuTAHWoDnUPFF78cT8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYP4rM48l/j2UdtbIp+NNfQUArBQlnta70/s0GVnnDQ=; b=xVngZJghD4tHnm+BinM9GgF+qHG97+8RO5KpEvrN7zkZNqXbvTXET0mZ4RBvq11voGMxcmFFWDmzFJWuB43K2Idp4vpw4NhB0bIR+RyoLguWgMI3M3u6yeaSd69MYG6d8gUzzrcwcfvWp2RjLnsYQQaRUuRSRKEd37I2RB+kZuc= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB0031.namprd11.prod.outlook.com (2603:10b6:301:69::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.26; Fri, 6 Aug 2021 13:59:57 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865%5]) with mapi id 15.20.4394.018; Fri, 6 Aug 2021 13:59:56 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH 1/4] UefiPayloadPkg: Add Fixed PCDs and use Macro to define the default value. Thread-Topic: [PATCH 1/4] UefiPayloadPkg: Add Fixed PCDs and use Macro to define the default value. Thread-Index: AQHXinwLtqe0AVS9XUa36R7izwqKGatmga8A Date: Fri, 6 Aug 2021 13:59:56 +0000 Message-ID: References: <20210806043116.1547-1-zhiguang.liu@intel.com> In-Reply-To: <20210806043116.1547-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.100.41 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 384fd50d-550b-4b38-65d2-08d958e278f7 x-ms-traffictypediagnostic: MWHPR11MB0031: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g9kwZshVXe46/wrt7CWiRsI7M7Ka0rCN4Fc/IbJJaLmcAT95Ps+XyZs62+fAs/LE/wZHjPC7X/jS8RFctfZyiz+XKPArS/IXuh30kqVk6fqCTq//hmKHDjA3b/mlD0Axsb3vIze0TOhZw5J8ecnXKpYzlu6PPasUuma7Ky79mErWg7RnlHbuxDNsRgz9ejztW8P8lSNIlvHPvyfr0G8iSI0r0/dME3g8Hiub6Y2FU5URWItyjIKXPuqJtRWmz8Ja4gFXo4XS2wNTEaYG4OuesJSonkOWisaRMPE4gb5bz/y7KRq7Cs/kNBKE9iX2V9zDsetdMgyGQ6ngq2ZMPKSlCQQKhyGDRIDSyqREyeFnkVBRjcNyZ+yC/Tm7FLZKzi6YMw+BT3AMpeXRt5pmG6sGBxPwELatMlhCW0OkACIaAUVhpOU8Yv4qBWN6MLBS+lhsr7Rl/j1kurExhY7T5IYDUnWODA3Fx09ynlq5wuw2+EXYMgO5TOYBw40PS1r+HaypOrdixYVVQOiPHtOElbBlUloEQ+mdVBFXpgLxgYsbLHnnk0LccOfqFHaHlrweXwqJyJgDYcvf/NI93k2Qy/XpNZfvWkc7eZtBeRv7oaoxuhaNF5Xm2XcchTeTUPqB9UGcV1MsPSX7JFf/EPZs63lkzjEuI+EaSaEGWIHyfBCEznezdw6pK6E7a4huRvqjMmzay9MLp3sCvom3BXWagi+BHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(366004)(376002)(346002)(86362001)(186003)(83380400001)(26005)(7696005)(122000001)(52536014)(8676002)(66476007)(478600001)(38070700005)(38100700002)(5660300002)(64756008)(4326008)(66556008)(66446008)(54906003)(110136005)(6506007)(53546011)(33656002)(71200400001)(107886003)(55016002)(66946007)(9686003)(76116006)(316002)(2906002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0YhhQ//+XBrej+MjA026X1yL0pgGyzD23OETILAXALzax13ErtdQdgNboxm0?= =?us-ascii?Q?JvU1xgYC89/dFrs0iV/On77QliQs+7taY9+xgwemySgcE+0Wz8wjQk+0Zk5F?= =?us-ascii?Q?8VeLD+uJ1r6fO9tHeKQwD9mZUyTxgTk6j5a4oF11rk/L4aEUv6LZc/3P3Skz?= =?us-ascii?Q?+MkaJOx8pJNw6UjuOTypGfQJwGyEYKq1yD7daSXKdNwyzxtckf0fxA1eWrPu?= =?us-ascii?Q?m+8f5tAikq/oTFGvYtM+5qT1FNwaqtck5eOoOBghjl5XKkSLNX5ECgj+EVU4?= =?us-ascii?Q?Cb/u9gzomObgSCFrJMLrTTHCz2/jdptrSCx/sqcjWXNhsg7EJcLt1OHJ1K7V?= =?us-ascii?Q?juVl69qGNQqoPlHSRaLPzp+8bAi+4+zphtknuFT+6bawJZYMGRnKD+hx7HVy?= =?us-ascii?Q?h0UMrSMl6ij2CSLyplVF/SYMUoyudeFqXbw5tNwf1iRmZ8rIjwmvKOQaR5Q6?= =?us-ascii?Q?N61pju34jvh8iMPF+fKrJGayUOXC2Cw2Z/OoC5zzlawaeJMiIrQG1fT342C0?= =?us-ascii?Q?O2NfnEf4xzFp6UpHCfLUXWCcEwOFbc9Ihi9I47V51pGSKI7s8SsAfGiEoiZZ?= =?us-ascii?Q?JQ0HylNAvxLd58dT8ToA+ulnnDh4l+OFXiQRFFLl2RjyFPAaykQbuVUL+/DX?= =?us-ascii?Q?ZKumchr2aZkDJgLASXjhxvm65Wq9ybnP21QLWUc8deTIsc43d6JslrG3gkxI?= =?us-ascii?Q?xexX2TLHYghmNy65Hpq1AwVk5D+TcABOEcZtXrMm7xL5vvCLrTNDVwQ6EOGE?= =?us-ascii?Q?0I4YMnrKWmVowjTtQJTNo2oaqc7SZ7fixgX0hwPGAksUKiUpAJ0jsNIAAKlj?= =?us-ascii?Q?Wfpcy8YRs0k60/BRn1qTi+dzuKnu1ZyIJHGZUWv8BQB1iC8f5GsUBk4qJkcT?= =?us-ascii?Q?jpl3joxGhFmp6/vewJ+TRCLeN5w/LycGg63tXXZEpAOajCDV0qxwCfNvMwvb?= =?us-ascii?Q?/BjxNTHuyTzsb/Lyo2iWZSKfABpuQ8mG1sugzPSRAMJhaBinGSvCmCikir5j?= =?us-ascii?Q?DrqlMLkMiMHwRz9cA0RhpmEhYmHPZ2BA6SfFjH1D1e8A4Ul58sKncLIPIQ8r?= =?us-ascii?Q?TCZcPz2kJSVWy6EwYc7Rx15QKwo+67iGGNVjk4jwC0ZdmIYegKhkq+q2pzcv?= =?us-ascii?Q?Rp+VGXg7OMZ2gLXPIpk297gMxEpsPXwXZ0ovE7k8FYeKGpcCexPulRWyGpHH?= =?us-ascii?Q?mxatml2MGEJkf1IQIvMfrWCxjB50kO0lg09zLIBV5b3+wufkW9EvhoTA9sA/?= =?us-ascii?Q?jpGD3D4uV0L+UyT5mhKx+f/tIlCGasE/8JkpR5OcBA5F4eAjHXoQgKExANey?= =?us-ascii?Q?OQPqcExWNgecpHHAAPNsXzdO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 384fd50d-550b-4b38-65d2-08d958e278f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 13:59:56.3684 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ugBmogl1GaMHvRUr/WXx0KICSkbC0PJfhFsLSkA9pnS2MQ0bx5g+VOku7i5IuMvEmEjPHBEulwyit4XYKebsIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0031 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, Zhiguang > Sent: Friday, August 6, 2021 12:31 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, Mauri= ce ; You, Benjamin > > Subject: [PATCH 1/4] UefiPayloadPkg: Add Fixed PCDs and use Macro to defi= ne the default value. >=20 > Add the three PCDs as fixed at build PCD: > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister > The default value is defined as Macro, so it can be passed in at build > command. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You >=20 > Signed-off-by: Zhiguang Liu > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPaylo= adPkg.dsc > index bcedf1c746..ba54f2057f 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -91,6 +91,13 @@ > DEFINE EMU_VARIABLE_ENABLE =3D TRUE >=20 > DEFINE DISABLE_RESET_SYSTEM =3D FALSE >=20 >=20 >=20 > + # Dfine the maximum size of the capsule image without a reset flag tha= t the platform can support. >=20 > + DEFINE MAX_SIZE_NON_POPULATE_CAPSULE =3D 0xa00000 >=20 > + >=20 > + # Define RTC related register. >=20 > + DEFINE RTC_INDEX_REGISTER =3D 0x70 >=20 > + DEFINE RTC_TARGET_REGISTER =3D 0x71 >=20 > + >=20 > [BuildOptions] >=20 > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACE= S >=20 > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG >=20 > @@ -324,7 +331,9 @@ > !else >=20 > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2F >=20 > !endif >=20 > - >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule|$(MAX_SIZE= _NON_POPULATE_CAPSULE) >=20 > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER= ) >=20 > + gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGIST= ER) >=20 > # >=20 > # The following parameters are set by Library/PlatformHookLib >=20 > # >=20 > -- > 2.32.0.windows.2