* Re: [edk2-devel] [PATCH v3 0/4] Use XADD to avoid lock acquire/release
[not found] <166219FED0821D4E.31350@groups.io>
@ 2021-02-27 11:29 ` Ni, Ray
0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ray @ 2021-02-27 11:29 UTC (permalink / raw)
To: gaoliming@byosoft.com.cn; +Cc: devel@edk2.groups.io, Ni, Ray
Liming,
I pushed the first patch as it's a bug fix.
For the remaining 3 patches, I am ok to push them after the freeze time.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Tuesday, February 9, 2021 10:17 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v3 0/4] Use XADD to avoid lock acquire/release
>
> Patch #1 follows Mike's suggestion to use XADD to avoid lock acquire/release.
> Patch #2 follows Laszlo's suggestion to add global NASM macros for NASM struc usage.
> Patch #3 simply remves all hardcode offset in NASM without changing any logic.
> Patch #4 removes the dead code.
>
> The final code is the same as that of V2.
>
> Ray Ni (4):
> UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release
> MdePkg/Nasm.inc: add macros for C types used in structure definition
> UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset
> UefiCpuPkg/MpInitLib: Remove unused Lock from MP_CPU_EXCHANGE_INFO
>
> MdePkg/Include/Ia32/Nasm.inc | 38 ++++++
> MdePkg/Include/X64/Nasm.inc | 38 ++++++
> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 5 +-
> UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 43 -------
> .../Library/MpInitLib/Ia32/MpFuncs.nasm | 98 +++++++---------
> UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 99 ++++++++++++++++
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 1 -
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 5 +-
> UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc | 45 --------
> UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 108 ++++++++----------
> 11 files changed, 272 insertions(+), 211 deletions(-)
> delete mode 100644 UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc
> create mode 100644 UefiCpuPkg/Library/MpInitLib/MpEqu.inc
> delete mode 100644 UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc
>
> --
> 2.27.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v3 0/4] Use XADD to avoid lock acquire/release
@ 2021-02-09 14:16 Ni, Ray
2021-02-25 19:03 ` [edk2-devel] " Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Ni, Ray @ 2021-02-09 14:16 UTC (permalink / raw)
To: devel
Patch #1 follows Mike's suggestion to use XADD to avoid lock acquire/release.
Patch #2 follows Laszlo's suggestion to add global NASM macros for NASM struc usage.
Patch #3 simply remves all hardcode offset in NASM without changing any logic.
Patch #4 removes the dead code.
The final code is the same as that of V2.
Ray Ni (4):
UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release
MdePkg/Nasm.inc: add macros for C types used in structure definition
UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset
UefiCpuPkg/MpInitLib: Remove unused Lock from MP_CPU_EXCHANGE_INFO
MdePkg/Include/Ia32/Nasm.inc | 38 ++++++
MdePkg/Include/X64/Nasm.inc | 38 ++++++
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 5 +-
UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 43 -------
.../Library/MpInitLib/Ia32/MpFuncs.nasm | 98 +++++++---------
UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 99 ++++++++++++++++
UefiCpuPkg/Library/MpInitLib/MpLib.c | 1 -
UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-
UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 5 +-
UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc | 45 --------
UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 108 ++++++++----------
11 files changed, 272 insertions(+), 211 deletions(-)
delete mode 100644 UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc
create mode 100644 UefiCpuPkg/Library/MpInitLib/MpEqu.inc
delete mode 100644 UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH v3 0/4] Use XADD to avoid lock acquire/release
2021-02-09 14:16 Ni, Ray
@ 2021-02-25 19:03 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2021-02-25 19:03 UTC (permalink / raw)
To: devel, ray.ni
On 02/09/21 15:16, Ni, Ray wrote:
> Patch #1 follows Mike's suggestion to use XADD to avoid lock acquire/release.
> Patch #2 follows Laszlo's suggestion to add global NASM macros for NASM struc usage.
> Patch #3 simply remves all hardcode offset in NASM without changing any logic.
> Patch #4 removes the dead code.
>
> The final code is the same as that of V2.
Given that I was OK with v2:
series
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
> Ray Ni (4):
> UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release
> MdePkg/Nasm.inc: add macros for C types used in structure definition
> UefiCpuPkg/MpInitLib: Use NASM struc to avoid hardcode offset
> UefiCpuPkg/MpInitLib: Remove unused Lock from MP_CPU_EXCHANGE_INFO
>
> MdePkg/Include/Ia32/Nasm.inc | 38 ++++++
> MdePkg/Include/X64/Nasm.inc | 38 ++++++
> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 5 +-
> UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 43 -------
> .../Library/MpInitLib/Ia32/MpFuncs.nasm | 98 +++++++---------
> UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 99 ++++++++++++++++
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 1 -
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +-
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 5 +-
> UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc | 45 --------
> UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 108 ++++++++----------
> 11 files changed, 272 insertions(+), 211 deletions(-)
> delete mode 100644 UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc
> create mode 100644 UefiCpuPkg/Library/MpInitLib/MpEqu.inc
> delete mode 100644 UefiCpuPkg/Library/MpInitLib/X64/MpEqu.inc
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-27 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <166219FED0821D4E.31350@groups.io>
2021-02-27 11:29 ` [edk2-devel] [PATCH v3 0/4] Use XADD to avoid lock acquire/release Ni, Ray
2021-02-09 14:16 Ni, Ray
2021-02-25 19:03 ` [edk2-devel] " Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox