From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.4027.1624943371629555178 for ; Mon, 28 Jun 2021 22:09:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LZBgi1Va; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="229709386" X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="229709386" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 22:09:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="446890781" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 28 Jun 2021 22:09:28 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 28 Jun 2021 22:09:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 28 Jun 2021 22:09:27 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 28 Jun 2021 22:09:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOHx8jCu6Nmz67GWv9O09Lzja+SuGPKTrnfPHn9CIdi2uEk6BXI9Co+aMtqBTN9V93LKU42dYtdczuejhGy2C5ssDAv+dXjFyTMXgyJZ/ZqHSUY0vhhiVxO+SC7ef4tk2sGlzGJktdlChY+w9Ho3vPiDY06x2S52r8nzOjGMwXh1KPK/PAjIJvSGpjI+rYLN/z/qKqlh97uWC7Q8rmoJOQxHRCijpbskh4y/qwynZKhqmbXBSCquxuzEhLlZIZLlZFoJs8yw5VblKBs4Us3Yd3CF5TJ0fOe6kr76/ym5CyWaCJlNjet7NNuNF1rQAb/T00sqIqXrdKOJAUOFcEiSyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tARy7aMgmXGxQuVHwu+RSLEZvEvBugOgs6KJDsuMM1w=; b=USbW/PZK2QiawfPmgYzjoGdPzAxwSqcnA9S/kWiPUaR4PaqJP1DwnWdZlyBKtct07vHPC4xYgSjMAfHy1uRw0vNut9YX61xU91ZMCtLq6AAHfmfooihBPoHMlPs7VgVix0Skeqlr9Rn5WBoT4ffo4TkFS2XVm7/E9vA9SNTyO+OvOboX8vj6zQCHj+LgQaE8FDW9yMEyDEoEHFeeiuqit7c8DmZI5ncP+aeqhwzSL9sWYcmKZ7V3sXsXhokA5E3c3EWa7mEsPc6xD/hK7f6OJrQLH4jWc76/2KHdoHW/g1SKCKVsQ6huI9Do7O96cxl3Y3HZu6AQEdfnzDkHTz1ntw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tARy7aMgmXGxQuVHwu+RSLEZvEvBugOgs6KJDsuMM1w=; b=LZBgi1VaeBQA2CdcpjNooFPD7NDpfQtAU/LcgVuqcj8pAQ3YnEvdZ2CO/hjYCMfgt2HyUWAdLY6DbrEPzdFQx4Z+Kwa2PvGiuMjRRh340Y9h1OBqHduemf3S9VOlICTXHo07KUCSwmp5nzzLEu1KtOSZsiUlpbhSS/HvuSlwkoA= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5091.namprd11.prod.outlook.com (2603:10b6:303:6c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 29 Jun 2021 05:09:26 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::b944:8068:4f2b:a1fc]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::b944:8068:4f2b:a1fc%6]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 05:09:26 +0000 From: "Ni, Ray" To: "mikuback@linux.microsoft.com" CC: "devel@edk2.groups.io" , "Chaganty, Rangasai V" , "Lou, Yun" , "Oram, Isaac W" Subject: Re: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs Thread-Topic: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV PCDs Thread-Index: AQHXbHM49bj9WcsqAUu3Tu3PAH16KKsqcDVQ Date: Tue, 29 Jun 2021 05:09:26 +0000 Message-ID: References: <20210625212120.235-1-mikuback@linux.microsoft.com> <20210625212120.235-6-mikuback@linux.microsoft.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 18403cf4-9cc7-4954-d0af-08d93abc110c x-ms-traffictypediagnostic: CO1PR11MB5091: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SAxDik4XercGlifCyp8qJfWUOVA9bIjg4X3O8jo23EQPtWQly3a9WzHcXLnTtPr5atIBeJs0quR/8wEvQF/W1tIkgnCw+sl6iGEW9l3EzRbm3pR5i+03Q7Dv1d3zZj7883TU6BQAwCuCW4PNplMRK1/gNnYkUSSlGZ3j9qpJPF3p7jFdRyQXd3iEw2GWdEgk5eI5ZgmeO+uzdleAtHfQFuoJ4u7QaAlJdXKdiNakCUO8/E6hM1/HXGuBRlIGgFhbM04Ku2LcckCEbIVo148MxqfBYj+auEFRzFA4Jt3IsuFZtx8vzETMnsewxtStlgGf+j7kG9NCsOAkJly8pHzdqsih5F0PqY8MAYYllgU1GiPDS6dPXcBHpJeBkyXmA3iuxKnO+WqZGfBqUzn2/WI2eRenlFPkImNWljjm3G8BlBZH9LIju0SsfGBhjScgEQj+ct4IOCz5JBY3DHGz4KvezYrMHKLyUpOB/jrwVKTriVkmmu6bVOdeqpRnYkveOZ8OSxnWhox6quaA9ad/QoToPBiLlxz7N8CLbioctRsshAvCXqmlO5mLYR/IoGo7itfJkbiwJoX1YzH3Xa9LRm62cwX/RQbgljiyWeSDLmeuOXLdQPwODqzXi15pOtlLiSvcIufvlovmh4UANZiPHsv24rOpTYHzdXOPQVPzGwFVKc4w0qpRI3fcnUjQc6DrxhBrAxV8eqOVmXHe1c30ENfLLKyT3LSbpB/0aoxRVFhP05K8k2MT1jDRYfWJipMad0LX7ouDcjo415/7mTfN9N4ARiZ4QA4UDzq3CFeyYPZVMoKSZesCRAwCrCevYHz19wxUSJQ+aysNy7UfT7j6c3cP3w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(376002)(396003)(39860400002)(86362001)(33656002)(54906003)(316002)(5660300002)(66476007)(55016002)(9686003)(107886003)(52536014)(66946007)(478600001)(7696005)(6506007)(53546011)(66446008)(64756008)(66556008)(4326008)(2906002)(76116006)(26005)(8936002)(186003)(6916009)(8676002)(83380400001)(71200400001)(122000001)(38100700002)(14943795004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wFHazRnN1LFhAXhEYEuDp0Pw5d5pgZEFjbWvJW4iZpVywZDMuT3u8L5ZwKWH?= =?us-ascii?Q?yjJf5L+I0HNnCqXa4OMSwMJYKjih/mq+WAUXgiCDdmFVcpd/avsH1Q5tDKyD?= =?us-ascii?Q?m6op4eViMdtpDY6+/gmO1tyPmlb6lK1x+LipRyHuxPDmi0GOVNOy+4lL+f7c?= =?us-ascii?Q?IWKE3uRpOjwSiCiLNunl5W3boOiYZ1wpJCJwZq+PESUqPEjjdAfLAgoAYjOM?= =?us-ascii?Q?y4unHGUWdRsuOsyTrnOVwC847rgGnl2N0nME1FIMlayXRXCGKgHfF39CsUd7?= =?us-ascii?Q?6XOkswjybwjJfc4T2Hwv7Bba6/XyxsTJTiTxzv8CPNTsg8CYfBlrLVIvzSgg?= =?us-ascii?Q?HYMyRcPckvBXh2BPAOEw5odVPU1uf3egHd0UQKzEWKivYb6RUIJUcI80fMCk?= =?us-ascii?Q?m5HBcmXa4l0udgDYihUtdlX/fQtMRkCB3s7+nqyzX0pgIZ1FvcI0rIbTOE40?= =?us-ascii?Q?NrGSdJaQEYshH+IwSQqtqVpmCCxT0khq5Es9pV/HjltN/VEbiVw1ZJJY6IFy?= =?us-ascii?Q?u1BIYMKYA7gBHhrHo3Xsr6R/UjnesBKqNJGwL/MsOFzrJNtl/Wwy2wABTDUF?= =?us-ascii?Q?jirO0x2kDSuGpO2sJCKal643WAJi38pePYLyKSEwWZuy/MQRtP2Kqy4rAhDx?= =?us-ascii?Q?XH3naOKUsvysXKwc1ySV09CoaW8mxOyJkKZUWlPPDbMYGXn5e2P8e4+kEV5x?= =?us-ascii?Q?gyRYNi0liFvjSN0Qxrd0Uarz9q3iJqNoOgHjedry7pVO+ES5n0qGsiMR5Ag3?= =?us-ascii?Q?Ey1gl5racRKivJY/iBM+xS3Czg/sWZtgLzRbIgtf5uQptB3BsGlVr72GSBT/?= =?us-ascii?Q?cQj6HExCOh4wKRO3G0b1b/4IIx3CApoi6qv65+RhHl2nPT37y2Q4k34ytjww?= =?us-ascii?Q?kImnRRtv0ZVcf9VQ9aUG4IXAU58OtvdDN0NSy6e6tctDkVakMAtUXjlNDZEK?= =?us-ascii?Q?lfi7uhp6WLDFAPCp3/+nhERBjg+q3j8pATqXZaAnbPZwaEZAjM45O3PWspvb?= =?us-ascii?Q?z61sRxDKATS1sTOQQcA2x2e0EZ17e3cNNUZHXvvlxkxniQBNyNFgJv9Fq23X?= =?us-ascii?Q?ZeDt9hBNJVTJnc3JbQhcOjaDKVp8GgHkSNAvhJlpeext+8zQo2kagwcu/NOt?= =?us-ascii?Q?LWv143IKGgR/rY79E0ENGGUWEF+ofk+eumKiQfic7GNWOvDI0X8F+DqqZWQe?= =?us-ascii?Q?rad5O64avc1DtXkTGtWiBUYkarQdz4qjw3MgM3FKdvCKAGnW2wm7Hh9ESrFA?= =?us-ascii?Q?AueTegUIld4u5uOVQ1YfPvX3ROXXRBfWMmZ0FkJ81ijc1tRxaZ6uHD/4kvBk?= =?us-ascii?Q?ec6IaWrNL5vZdyrIkwxRxCWJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18403cf4-9cc7-4954-d0af-08d93abc110c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 05:09:26.2497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Voa/xIiXgGtw78Yyc2+49zMVED8/7NjfFIlCIXJYT/eWiUi1ogFfLYbluW4yqtQzNK84SKC/t2wx87AZ/jIhaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5091 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Michael, Below PCDs are in MinPlatformPkg. Can you use them instead of adding new on= es in IntelSiliconPkg? ## Indicates the MMIO base address of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE60000|UINT32|0= x30000004 ## Indicates the size of the microcode FV in flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A0000|UINT32|0= x30000005 ## Indicates the offset of the microcode FV relative to the beginning of = flash. gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x00660000|UINT32= |0x30000006 ## Indicates the offset of the actual microcode content relative to the b= eginning of the microcode FV. gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x300000= 07 -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v4 05/41] IntelSiliconPkg: Add microcode FV= PCDs From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a = single silicon declaration file. This allows libraries modules in IntelSili= conPkg to be able to use this PCD. gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dec index 097c4ca4d795..fb8391000347 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -91,6 +91,9 @@ [PcdsFeatureFlag] [PcdsFixedAtBuild] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress|0xFF800000|UINT32|= 0x00000007 gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize|0x00800000|UINT32|0x00000008 + =20 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase|0xFFE60000|UINT + 32|0x00000009 =20 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize|0x000A0000|UINT + 32|0x0000000A =20 + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset|0x00660000|UI + NT32|0x0000000B =20 [PcdsFixedAtBuild, PcdsPatchableInModule] ## Error code for VTd error.

-- 2.28.0.windows.1