From: "Ni, Ray" <ray.ni@intel.com>
To: "Lou, Yun" <yun.lou@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [PATCH v1 1/2] UefiCpuPkg: Refactor initialization of CPU features during S3 resume
Date: Thu, 16 Sep 2021 06:14:35 +0000 [thread overview]
Message-ID: <CO1PR11MB4930BC17EE8FC61C4ED2F1CD8CDC9@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210916020132.3639-1-yun.lou@intel.com>
+ FeatureInitData = &mAcpiCpuData.CpuFeatureInitData;
+ if (FeatureInitData == NULL) {
1. It's impossible for FeatureInitData == NULL.
With this check removed, Reviewed-by: Ray Ni <ray.ni@intel.com>
next prev parent reply other threads:[~2021-09-16 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 2:01 [PATCH v1 1/2] UefiCpuPkg: Refactor initialization of CPU features during S3 resume Jason Lou
2021-09-16 2:01 ` [PATCH v1 2/2] UefiCpuPkg: Prevent from re-initializing " Jason Lou
2021-09-16 6:14 ` Ni, Ray [this message]
2021-09-16 6:24 ` [edk2-devel] [PATCH v1 1/2] UefiCpuPkg: Refactor initialization of " Jason Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930BC17EE8FC61C4ED2F1CD8CDC9@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox