From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.7532.1631772883266292185 for ; Wed, 15 Sep 2021 23:14:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yjNhuFza; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="219309575" X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="219309575" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 23:14:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="516660034" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 15 Sep 2021 23:14:38 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 23:14:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 23:14:38 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 23:14:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dv1n1rui01txhi/WBMwlE4LQpT2kwAgY+2GxFn556UijWpn9/XSE705FJH8o/I4R3HH2Qm26vA9mXt9BktdtwHVBq7TBZfQ0pNoL1mgHmVqgmqtqUSeUpjr+aW7sula8sXpWXHXpdQ1cMXMY+kQDHgt4zxhrA0f851WP55GV75SRP5GZeNGTMlARysk3hUDqmEsPhbYrWByp+okl+03O3YyDO/vY9gzCVx7mmGL4pqpoIti9SGproNmpMkESYJAG8FIkJax6xdzqI5fMB7jPxxlzDADRczZahwWIlPDP12wyDunUzqy9R5naOYLhXfjfgiO52lqBbsj0EJNkdWdD0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0/8K3b8c3vDNYPJ0uZiYBTxprmkevrmovNKinwENCAg=; b=K2bu4brL7MhQC0jhVrA4lLbD7W1wQlYkk6GPu5+Ke9/+8o98jyVDkyJP9OPBgBIXvSvcMeR5nmwmEDep7eyuou+cIZ23E/FTJozDc9hI4aZAus5+MLYHaCrPNqWlLucjHpUG0/WQS4zA842u6nkfFiBcDQ5zZk7RTbEwcty1Uk5TmUiA7NwoE/8YByT5b5apcnztpsAzuVQXyKvaVbojglfAV0KdTW7bBSIi6DqajkR2IKP/BSsKWgq18VBB3bl50qx8G2axVLntYTF90i6rFpow3xfDqoD7Wg1AnINkjGqDqA1jr6ZNVFNdQHnN7nMQdB5Lyab6ySMW/z9UASeuNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0/8K3b8c3vDNYPJ0uZiYBTxprmkevrmovNKinwENCAg=; b=yjNhuFzaiWTs2SWO56rKuVAkQAaLLGQBVH1LunlEyITTU1nPENGQDEscvVj7+nHVlDL5rQJbStxwjS1sSACmRO4S52iQtaYyMD0XgpMJ4erbBP0IOwTdeiuBp8AkCZUXXrhLO6hN5yPMHfRNUCmozRinem7JjrTOvxYLTKSfmEs= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2175.namprd11.prod.outlook.com (2603:10b6:301:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 06:14:35 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::50ce:c9a3:ab37:9fac]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::50ce:c9a3:ab37:9fac%9]) with mapi id 15.20.4500.019; Thu, 16 Sep 2021 06:14:35 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v1 1/2] UefiCpuPkg: Refactor initialization of CPU features during S3 resume Thread-Topic: [PATCH v1 1/2] UefiCpuPkg: Refactor initialization of CPU features during S3 resume Thread-Index: AQHXqp7RZBPDFKHvKkibLHgpKkLyX6umLFIw Date: Thu, 16 Sep 2021 06:14:35 +0000 Message-ID: References: <20210916020132.3639-1-yun.lou@intel.com> In-Reply-To: <20210916020132.3639-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0abcfa6c-107f-401c-691c-08d978d941ce x-ms-traffictypediagnostic: MWHPR1101MB2175: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rimd2H5mUCa0y6rgpVshuaL9HkwTDOMssSxsdLlskMGQhzQNnJXq9psvR1Zs6JGu5XOCe9rxzySjIx5I0859BWQ3wrz1nk718p6j95BgWmIzE7LjQGJRH+c40beN84/1jSYLgapPQpt8sdJWdIGTtvxlVODFaNMGPrO1OgaUNmk/3/IAdy5VPUG6Hu7RZ94NqUFupKFBy9rEPetH2mbxK3UZCATjgdRjgyxv5rgCxF4A4j061WuPiL4zVdR+DyleKRXfqj01iLnhvXu0ffOyeUXMGLmyxc/HKBS0gzexVUr7q8R1khbDbbM8EvW7OjjPr/lUOeRp1jxFr4rz0PZrJlQDE6EvLu5U/b88+ImY+QgusI77JQCuraaWKl0M6WCiSeRBPRr9/0fOyNQ3wUySOVURrVhRAifxDNw/RkC+EpV5QnNAPDD7X7oovYjEKxW5U4x5wb7uA32hZ4GMEO+2iKkibeQEruscaXtGYPf25rbViDAr+BLzQaJ+/QnIaNrhcAOfrI5/yMpYTAgdMK/y6tHuwRrxfriUGJBSUW0ek9PX7PVhrS642qEbwCAXOYrSPoAvwJj6mwVkja0ChvLpqlPjcj65EGdWOgegD2z0UMjCCpf/XIceXNUKetCKEck9CHHaHs6nEIKxjwlTKZ6VTXDeMn4/CEK9rW/O/V33KZ0hWmgBcRqrZrKQIyIep2ycsp3FxPhLs13yirCJlMiqJQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(2906002)(9686003)(186003)(107886003)(55016002)(54906003)(110136005)(33656002)(66946007)(66446008)(66476007)(64756008)(66556008)(38070700005)(76116006)(71200400001)(8936002)(8676002)(122000001)(6506007)(38100700002)(7696005)(558084003)(86362001)(5660300002)(52536014)(498600001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yTlm+2YBi/HkqTqp5TU0AJpfB7SHt09BCqBbAUYzyrPXAW9602GvAjZuBnWF?= =?us-ascii?Q?p+v5tvNgBkgVNvg0IAVMKqLtlq62ZdNyZPPM/+xeSXoEbYVVwwi5tH6wu4Rm?= =?us-ascii?Q?lowxISqXqfRtrI9ZdPGXVfc0zvJlA8grxA9v5Q8qQ2vzu7DEROJ8bfxfEkN4?= =?us-ascii?Q?2L2wM983QVDx+CF6U4QT2ZLLK3eSc7592tL8ixUymKO3D31Rjv0ScDUfHcRv?= =?us-ascii?Q?qs4ZFJfDfWW1TzjC+w74hq0rz/kA4IkcbvnkkboTCRlCGty+Kc1hea37vHC9?= =?us-ascii?Q?gDimsK+8/5DBr/A7F8Msa22MFawey/yo//TAquua55vZx7Vh67lhnYeG8U2L?= =?us-ascii?Q?UJAnGjde7iXhlg7i3DRCJB9Xzwo46RQ3CSAwQWHXETB8h6yq4lsjs+DJoRLT?= =?us-ascii?Q?6FzJwyGmf8VPqkpnlyx/+NQrdODBYlFRJClMi2to4M63CxNq0Rx5LcmfhZvf?= =?us-ascii?Q?4OUJE3wDVKGb2y3/Kr1WxA4Ntl34l6KShWnBwuK/x+t/Ksuv90kP/yX54PD+?= =?us-ascii?Q?2TjO9C+449M9juOe98/s9pGc4RvPmrHyJo30BHiKONch62ewcaZkNeb/JkH6?= =?us-ascii?Q?7O0b1EAgNYy73aNg1PMchm2BYNYLI4T6SmKFqg6QPXHiHU4kxPWwCK7C7mMF?= =?us-ascii?Q?BaiMAkkVhFfuG5H7X1+mXPsFctac1KEhYSBkBq5L2x/+6wclcz+Was9+50qI?= =?us-ascii?Q?qNvJmxcXnJoJyMRItuuVG5iODUO1fdv3gu4dxX0vAY9CyRw0FQYOlObyrjAW?= =?us-ascii?Q?q8SBkh5wqm0pRasKOQHO8KsBUinz62tR/WJg5Yf4lOy6h5HALsqTuRFle2l/?= =?us-ascii?Q?K0zJU3YP7wH74VzFCbuqu9YynmvaIZhdy6bjlHaxSUjntjoAUX1+s9DalqIv?= =?us-ascii?Q?IS7JyK8Ast5PA2aBLyB81gnvGy6kOwYaH9/LWM4qQPbbbcUrFGIRHCvO+Cuv?= =?us-ascii?Q?lV4lJttJMobL6UnaOKzZJMX6xGVLgLuN//awnZcY7nJrB8SCGi1LAsrEukK7?= =?us-ascii?Q?qXWUkuC8SzWQYtSzixuqfed8wwSH/nnZD8zrNK/d0/rL1U6PwXtNC38fvDxE?= =?us-ascii?Q?21Egi7VITftUWjsHxbpL6sdBvn1+dTyCo/SJ/Hdn1SVb9iokpEoMGW5RZ1Xu?= =?us-ascii?Q?Dcpye24MTDFGsSae1Qmt3qghcW7o+I91M8N1qhXkuSHdQh6iRZbZ7thZkzci?= =?us-ascii?Q?xFKttmQXW+R+Ti1wxRKcYmNhpHWkTgzC0gCEWhr5flXvUewGnkxLH8o98+XL?= =?us-ascii?Q?JeMVb+s6Dlp90/xkZ6cPTibdlbC6ha4W75yrLELRmHH1CBX6OLMoNENFZTYC?= =?us-ascii?Q?oO7q3OZHk7MnWISH5ofWc3qR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0abcfa6c-107f-401c-691c-08d978d941ce X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 06:14:35.6271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dOECgI+/AZ0pKAt5WSf1QPfFMT/PU+PtIEpuU8LToaIBLi5tYKFH0UgQck920Cel5e9tGj/nwSTca/TptMWz0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2175 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + FeatureInitData =3D &mAcpiCpuData.CpuFeatureInitData; + if (FeatureInitData =3D=3D NULL) { 1. It's impossible for FeatureInitData =3D=3D NULL. With this check removed, Reviewed-by: Ray Ni