From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.3355.1627007638316052915 for ; Thu, 22 Jul 2021 19:33:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BRX8YQgL; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10053"; a="208679064" X-IronPort-AV: E=Sophos;i="5.84,262,1620716400"; d="scan'208";a="208679064" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2021 19:33:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,262,1620716400"; d="scan'208";a="659347960" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga006.fm.intel.com with ESMTP; 22 Jul 2021 19:33:55 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 22 Jul 2021 19:33:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 22 Jul 2021 19:33:54 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 22 Jul 2021 19:33:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pv/xOg2CmwTCSWPwUIQEMOOymCJUeTCwDmhzRaMbYTnTCjb5esB6AgOmPwFPUij1EnwNr+vca33odRyBsEeP9UqdZNkr1p7cQQDjmzxhhy5r3JtiJ91ORCNL9ILHofZUVR/D1AK3skAhBm3dob8ZWYU6w5znk4oeu1jKGdc9ycI2hBQPlk8Yix5XClsF5+IOQ75d+hittO6w+ns6x4T42VPrHxT98HepTseEYm6eYrUNeDGDdhxseyxySQveCUfWkjw/9wzCwOMH8l+vxWe8S6UhHDhVCBI8j5q5Ii/EQIu6STNzN7k4HSga1jTJ9j75wz8M43QL1HXZVrSSOGt+gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CuwNmN4Njgmm0SqGtskR0xwoJQ8brB9n6MXnWujZ5h0=; b=IHQKIrs+fuzqOOL2RU/5QNS7P1lYspX2xJfRfQU7qLrA1j5k+5OFrhoGkhxHboIZlomft4Y+HggjCSgbe/3tpQ9zA8UtarBmQ5J9tvXRdy5A89Vm3CNTzvqTyDqnOqm+fK9UahpcRA9ZBgopef/WyV6POLdqFiB6hhIzLy/6T5B1AU5Ams7HMliqJuY9VlDvD1RuPrKeZaJ8gR5N0Ng6FwaPYz+HE2wEqy4PkkN6vty+ue65eGYqA/CVNid303Ou/gQvtlUUszD0T9mb1eqG6GMN8zUDQZS0T11Z/H7pD3qmyaFnIZF7kHqwz7SstRFyb9QsCnz1AHGgbHDQl/4e7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CuwNmN4Njgmm0SqGtskR0xwoJQ8brB9n6MXnWujZ5h0=; b=BRX8YQgLlo9vb7Os4B/maJ/XR777YTdWVwSk3osTYT7gNJjG2tlpMBAspCqU0ny6DBWPZdlnMIzgCfqNraDVhGfL/X2RUTEOfYGsiJs+vIdmgB5Qw4rDLF7ySjIePA6RJ+X9f1Uj3QJf0R/HvCD34i5bUbqajohahQmJwGgYmRo= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2301.namprd11.prod.outlook.com (2603:10b6:301:53::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24; Fri, 23 Jul 2021 02:33:49 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::dc21:42bd:8553:2869%2]) with mapi id 15.20.4352.026; Fri, 23 Jul 2021 02:33:49 +0000 From: "Ni, Ray" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Yao, Jiewen" Subject: Re: [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in Main.asm Thread-Topic: [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in Main.asm Thread-Index: AQHXfr3dv+/46eBG1Uig8EZFnZZuuKtP2MsA Date: Fri, 23 Jul 2021 02:33:49 +0000 Message-ID: References: <385d5e4bc26eb601a1ee6eeb982d5cde06ceab2a.1626931332.git.min.m.xu@intel.com> In-Reply-To: <385d5e4bc26eb601a1ee6eeb982d5cde06ceab2a.1626931332.git.min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 93a8dfea-d02c-4174-1052-08d94d824de3 x-ms-traffictypediagnostic: MWHPR1101MB2301: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qmbaTd0QAyqCmMBWknYdWvFyJ/nztUmlJSzUxsAzr0A6gRK0uvlAFS+U33hChgXQz1LMk64FHI7jCiMyD5JqlNF3tnIyIMrF0TdZ9iczXvesBUltrhxE5lV+/R/JazDHm0IhY/WzqeBx8WOOZcV2hrlBZ0ISIXuxIW5RSCMHEhdK4by2zisfSKGnecHDQpB5mLk+28vjVuNNzij7KfQauP5zYDIaose+USw8Z46/u7hxcREesMw2FFZNc/EX3OXJBwOukLWJ1YJwJ3xWl9yl5JUNBU2tT1TacbDTwal3D+2ws3Wwc6Y8xC2iPteZ2IREe2nxzSZKIgRTZysKFG/hV1LD+xJ+nxROxMab+l/ZmXiu+yla1xCApTk/jedceJ41IE2X4VgjGe4ho5MCqPMAzXh6qXcRQpnwHJjK/fWiYnjej1Ue3V8iqRoYizFm1EV6CLiDK4E8rh01EfZZaq76AJl1SnqfRYwHWbYigmHNsigGmLz5Ts3Xc3H6ULpH4S0Q4PS6oNvVrJk17RQVzI7ufWOMY2Uu4uJgzHHP9Ld7N9q/rLBlvXkT6OFP3Fu+WMuRRwL/1Vefo9FiBDBgE4Pz0cfWrMEm0ZKdaxvNmFcMP7Q4OJxlT/47UeTA4Bm5bCKRuXxQSGbM3KmmAY/QIT+aL3zDbOUFDpAc7/4hYlj/bZma2JWQ2gmG114cBGbTGD7YbcNz7tSySuCiHGYIZqzchhV7zenrfqTv5muw7Nq6RLyYfzQ1lJ4S3ISSdZdFGmzxGjMtpDGHey3NPcaEGHvAmgRvCyQ4xrSUpTQhtVKgHL0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39860400002)(396003)(136003)(346002)(19627235002)(66556008)(52536014)(6506007)(316002)(71200400001)(33656002)(54906003)(110136005)(5660300002)(55016002)(9686003)(64756008)(66446008)(66946007)(76116006)(66476007)(7696005)(8676002)(26005)(478600001)(122000001)(38100700002)(4326008)(186003)(8936002)(966005)(107886003)(86362001)(2906002)(53546011)(83380400001)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0S0iLQnC5rdWAX2gwn86IbcCd2k6bpATczpcO7zIixpURXsHRQI5eUpupn1E?= =?us-ascii?Q?I8nzGeUgbBl9vxIXaeFlu8U09R5HUyvn46g5/I7uqkQ8csbDIKFazUqEodWR?= =?us-ascii?Q?KAikxyFTrTftlYTXhDwEKezkqsrdHYUNEludS7HQyUOGIECKmNMBV7r0ROw0?= =?us-ascii?Q?o+XW1TbDgMo1IDDXCrVe1YDVq1kXs6Ym1Eq6FHmHVstcSUk+jAyNZV0e06pC?= =?us-ascii?Q?wgg7k+bomE19iAmQD2OksLIhKoSXKNP2Ye3NJ03wXe6cvb6qRo4rOZ00W1k7?= =?us-ascii?Q?G2llILVFxZYockdR0pBVkwBVMYbBMgJ6DbHT+AmClm2Zeed3zBmmQ4Ndkdy4?= =?us-ascii?Q?8THV75nffUFcMNnUXdLuTyhGCRspfo8YJNZdCgV08lWY9gyKfmeuEEd/1Sl0?= =?us-ascii?Q?8cJwnAdN+q3S/69UdYPfhH3CL6Xx60DyaJw2Xpjfpq4v1sx364e8l5Y67/sZ?= =?us-ascii?Q?Upff97nFptCeI+qifVYnG45HMj/JVYaQi7atXtL57bAf+ZH6+DbN1f36kZdK?= =?us-ascii?Q?Eim88umjRpJcn1shAxqYXAH0X52uyPN3ilNzVjQxxVgQ/FrMJAWTORuLg6HL?= =?us-ascii?Q?ca8oqfmROcqyqd4kgnrS55irguPkn0reEPNyzz6ch+ZCiVoOvsVwEyVZZU8h?= =?us-ascii?Q?MBmgmrpmpzvkI1N6iCitosCVIieG698e7IQ2lEwyqcktOQAPCO8cNYqgjKiu?= =?us-ascii?Q?4xJOs3vDZxo7L56druOwX2jQ87O3Dnnf/ApFTPEzUJBxNHoLZsKUeaqqJ7eS?= =?us-ascii?Q?iflSZLF9k7b4nOPryiOlhMMGNV0chwuiSuqfLirWE27Mo3RvwVCt9yJwXyp/?= =?us-ascii?Q?e/+z0s6et6Tc0wYoHTFe7y7Jt8GBem5fLLUuzS6f4/Z7bHlPYkbaf7HN3ur8?= =?us-ascii?Q?/+56BTr7u1vctG0trajJkqsFhDuI6iC46MNTGtfF8tp248dimiZ5CfsCoG66?= =?us-ascii?Q?V4msAEtNI5ASG/Emp/ayr81oxYM0Dr5R5u9PVlTtyn0qbPeat7XDJlBAVmEc?= =?us-ascii?Q?MAbc7hw+CmgJyhSVxb/zbdxZrMQpHNZtw2ZuGT7vdpQuKS/nA6SxMg7b3cNF?= =?us-ascii?Q?fFXbJnyw4AWfGuJSMHSH5HA/2rfaji9NwY0HBU6/rHz1pRvqzP0YLOfPT8JG?= =?us-ascii?Q?B8KCUFhpL2N4nbavx8D4eBi/jR1HVNV53HEz6E+xADmm1td2+bn4Lp738y9H?= =?us-ascii?Q?qBDYo4EuuzqygFWVy1rarqEJSmhmXxq1jnvnPlYmA890zf8LrlWYGYXnW8j7?= =?us-ascii?Q?p/JZPqXsctiaau3OCcqlRXKk2vmfGUJDBGCXO6OIMclXGihrSkTgqHjKiAaE?= =?us-ascii?Q?hvxFNpK+p1yvbqkW54FpGBSf?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93a8dfea-d02c-4174-1052-08d94d824de3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 02:33:49.7180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HlrSpLDe5TnwGqJqTVt6keo9ivjniXjBSJzEamPInRTcz4tbL20OLNk2xNzX+uTKbOtJTepywkWdAWCqhR3CTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2301 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Xu, Min M > Sent: Thursday, July 22, 2021 1:52 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong, Eric ; Ni,= Ray ; Yao, Jiewen > > Subject: [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in= Main.asm >=20 > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 >=20 > In Tdx all CPUs "reset" to run on 32-bit protected mode with flat > descriptor (paging disabled). Main32 entry point is added in > UefiCpuPkg/ResetVector/Vtf0/Main.asm so that Main.asm can support > the 32-bit protected mode. >=20 > Init32.asm is the 32-bit initialization code. It is a null stub in > UefiCpuPkg. The actual initialization can be implemented in the platform > (OvmfPkg/ResetVector/Ia32/Init32.asm is the example.) >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Jiewen Yao > Signed-off-by: Min Xu > --- > UefiCpuPkg/ResetVector/Vtf0/Ia32/Init32.asm | 13 +++++++++++++ > UefiCpuPkg/ResetVector/Vtf0/Main.asm | 14 ++++++++++++++ > UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb | 2 +- > 3 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 UefiCpuPkg/ResetVector/Vtf0/Ia32/Init32.asm >=20 > diff --git a/UefiCpuPkg/ResetVector/Vtf0/Ia32/Init32.asm b/UefiCpuPkg/Res= etVector/Vtf0/Ia32/Init32.asm > new file mode 100644 > index 000000000000..0cdae4a4a84a > --- /dev/null > +++ b/UefiCpuPkg/ResetVector/Vtf0/Ia32/Init32.asm > @@ -0,0 +1,13 @@ > +;-----------------------------------------------------------------------= ------- > +; @file > +; 32-bit initialization code. > +; Copyright (c) 2021, Intel Corporation. All rights reserved.
> +; SPDX-License-Identifier: BSD-2-Clause-Patent > +; > +;-----------------------------------------------------------------------= ------- > + > +BITS 32 > + > +Init32: > + nop > + OneTimeCallRet Init32 > diff --git a/UefiCpuPkg/ResetVector/Vtf0/Main.asm b/UefiCpuPkg/ResetVecto= r/Vtf0/Main.asm > index 19d08482f831..4920c6937e1b 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/Main.asm > +++ b/UefiCpuPkg/ResetVector/Vtf0/Main.asm > @@ -36,6 +36,20 @@ Main16: >=20 > BITS 32 >=20 > +%ifdef ARCH_X64 > + > + jmp SearchBfv > + > +; > +; Entry point of Main32 > +; > +Main32: > + > + OneTimeCall Init32 > + > +%endif > + > +SearchBfv: > ; > ; Search for the Boot Firmware Volume (BFV) > ; > diff --git a/UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb b/UefiCpuPkg/ResetVec= tor/Vtf0/Vtf0.nasmb > index 493738c79c1c..6493b9863c48 100644 > --- a/UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb > +++ b/UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb > @@ -51,7 +51,7 @@ > %include "Ia32/SearchForSecEntry.asm" >=20 > %ifdef ARCH_X64 > -%include "Ia32/Flat32ToFlat64.asm" > +%include "Ia32/Init32.asm" > %include "Ia32/PageTables64.asm" > %endif >=20 > -- > 2.29.2.windows.2