Re: [edk2-devel] [Patch V3 1/9] MdeModulePkg: Add Universal Payload general defination header file

["Ni, Ray" <ray.ni@intel.com>]

Mike,
Thanks for the recommendation.
Just check https://en.wikipedia.org/wiki/Programmable_logic_device and it seems to me PLD is a very common term in EE world. FPGA is a kind of PLD.

Maurice, Ravi, Guo, comments?

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> Sent: Wednesday, June 9, 2021 12:26 AM
> To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [Patch V3 1/9] MdeModulePkg: Add Universal
> Payload general defination header file
> 
> I see use of the abbreviation PLD in this series.
> 
> PLD is sometimes interpreted as Programmable Logic Device.
> 
> Given this is for Universal Payload, I recommend using UNIVERSAL_PAYLOAD
> or PAYLOAD as appropriate.
> 
> Mike
> 
> > -----Original Message-----
> > From: Liu, Zhiguang <zhiguang.liu@intel.com>
> > Sent: Friday, June 4, 2021 2:42 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Wang, Jian J
> > <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> > Subject: [Patch V3 1/9] MdeModulePkg: Add Universal Payload general
> defination header file
> >
> > V1:
> > Add Universal Payload general defination header file according to
> > Universal Payload’s documentation
> > V2:
> > Add a macro funtion to check the Revision
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> >
> > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > ---
> >  MdeModulePkg/Include/UniversalPayload/UniversalPayload.h | 33
> +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/MdeModulePkg/Include/UniversalPayload/UniversalPayload.h
> > b/MdeModulePkg/Include/UniversalPayload/UniversalPayload.h
> > new file mode 100644
> > index 0000000000..627b9e880e
> > --- /dev/null
> > +++ b/MdeModulePkg/Include/UniversalPayload/UniversalPayload.h
> > @@ -0,0 +1,33 @@
> > +/** @file
> >
> > +  Universal Payload general definations.
> >
> > +
> >
> > +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> >
> > +SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +
> >
> > +**/
> >
> > +
> >
> > +#ifndef __UNIVERSAL_PAYLOAD_H__
> >
> > +#define __UNIVERSAL_PAYLOAD_H__
> >
> > +
> >
> > +#pragma pack(1)
> >
> > +
> >
> > +typedef struct {
> >
> > +  UINT8                Revision;
> >
> > +  UINT8                Reserved;
> >
> > +  UINT16               Length;
> >
> > +} PLD_GENERIC_HEADER;
> >
> > +
> >
> > +#pragma pack()
> >
> > +
> >
> > +/**
> >
> > +  Returns the size of a structure of known type, up through and including a
> specified field.
> >
> > +
> >
> > +  @param   TYPE     The name of the data structure that contains the field
> specified by Field.
> >
> > +  @param   Field    The name of the field in the data structure.
> >
> > +
> >
> > +  @return  size, in bytes.
> >
> > +
> >
> > +**/
> >
> > +#define PLD_SIZEOF_THROUGH_FIELD(TYPE, Field) (OFFSET_OF(TYPE,
> Field) + sizeof (((TYPE *) 0)->Field))
> >
> > +
> >
> > +#endif // __UNIVERSAL_PAYLOAD_H__
> >
> > --
> > 2.30.0.windows.2
> 
> 
> 
> 
>