public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm?
@ 2021-08-16  3:16 Ni, Ray
  2021-08-16  3:22 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Ni, Ray @ 2021-08-16  3:16 UTC (permalink / raw)
  To: Zhang, Qi1; +Cc: Yao, Jiewen, devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Qi,
I happened to find that there are duplicated implementations in VariableSmm driver and TcgMorLockSmm driver.
Do you know why the check needs to be done in two places?

Can we remove the one in VariableSmm driver?

Thanks,
Ray

[-- Attachment #2: Type: text/html, Size: 2095 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm?
  2021-08-16  3:16 Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm? Ni, Ray
@ 2021-08-16  3:22 ` Yao, Jiewen
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2021-08-16  3:22 UTC (permalink / raw)
  To: Ni, Ray, Zhang, Qi1; +Cc: devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

TcgMorLockSmm is only for secure MOR V1.

VariableSmm covers secure MOR V1 and V2.

I think we can remove TcgMorLockSmm.

Thank you
Yao Jiewen

From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, August 16, 2021 11:16 AM
To: Zhang, Qi1 <qi1.zhang@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
Subject: Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm?

Qi,
I happened to find that there are duplicated implementations in VariableSmm driver and TcgMorLockSmm driver.
Do you know why the check needs to be done in two places?

Can we remove the one in VariableSmm driver?

Thanks,
Ray

[-- Attachment #2: Type: text/html, Size: 3187 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-16  3:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-16  3:16 Why SetVariableCheckHandlerMor() is implemented in VariableSmm and TcgMorLockSmm? Ni, Ray
2021-08-16  3:22 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox