From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.5700.1611296979002660703 for ; Thu, 21 Jan 2021 22:29:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jy7ito6c; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: 7GZYE87uYlfUCf+MJDgUgcF48kUkLsQCPKTJpgv+UrjRn2BOS0fooCjaWTrHOFnfeHj+WQvC0u yXlEbaoMqpzg== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="158578046" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208,217";a="158578046" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 22:29:38 -0800 IronPort-SDR: zJkr2z8uYu8aPSNq5g19PPvpmMcCJLtt8nA3M6b1MxvpM+GAgGfeBSaA8qaFIvzB57L64wEgAD woG7uypGBnfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208,217";a="356822853" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 21 Jan 2021 22:29:37 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Jan 2021 22:29:37 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Jan 2021 22:29:36 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 21 Jan 2021 22:29:36 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 21 Jan 2021 22:29:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hm1U1MtcMyUUPFMNzJ/nRgMueAg8A3+DQ2ACVXz9TOEAEuoyxDOxm1qU2vdQFnKk6/T/2bqOhKT9hDye6hDYhNANmxad5vCAIFZeawmFAhjl8CFyJK7pA+co9m4mp+zH+jHqg3+G+d6sOUqWIGses/ESpvHn3E9ExEe8LiDHi7zyxjo5lUsMIwl4uo+weJqM3uLI897Sk+lVDX89/icLx+ig3LjoUIbnrfcB6rzUHvehHa5DSebIT69IKL204TE7KMJQ4yRWKGUJNsk8B1qcPOIaZTc8yQwxUavi2vLKc3Des11EbXelsT8c27r1FTvemrkvg5NvFL2v0TkZGlpn/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Su72qiA5/EilennYZIR5I9gfKRbTLUPusv66Uef+0EM=; b=khHEhlMrSPpCE6ywIu49wLqKjttRzWALZhk9S+7RXctbn6h6tWMdrsBOpJYH+TIhDIviJVVzm5LcCZdhksi7DJrx2690Xp0skxx4bnmzmPGANBtMtB3wGZOCP8NG7IxsPmbPnMpvkwI58Cas8fI7skkC8akzRkNespXcShgobiEUOy405tQ5YXMjdKYfjYuxMpD8J+8tYFqKxmtwKtt1/fV6e5t7JNh88AqCiHzE7t2QeD+t2o7WZaHHcSKb+5YNXnveJlq0m+zVF1qD5x0xA1mQmMK6jYtiPP+RWmSfAAiVZdI+SYZFCGU8oTgUG47/4bX/8fKyRJKd5bLRJdpc3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Su72qiA5/EilennYZIR5I9gfKRbTLUPusv66Uef+0EM=; b=jy7ito6cikmjuanNJa6x/0pOMO9WGq68pv3Co/JoTxK3aN8Dy441N3+QBl5lPbGLv2GSi14qjeDfu5rqoHX1gvrha1mwfhR/26XHJZJtUk9lfplKIZG/8FJFCWMxmhERkxt7jaJNCb7+A1kFqfb84CBq+TFPmgaoxZBTtcustes= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR11MB0030.namprd11.prod.outlook.com (2603:10b6:301:65::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.13; Fri, 22 Jan 2021 06:29:25 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3763.017; Fri, 22 Jan 2021 06:29:25 +0000 From: "Ni, Ray" To: Kun Qin , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Topic: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Index: AQHW6sXUrm3oAYMYgUWTtMgL1+3eOaozFAUggAAH8QCAAB3+EA== Date: Fri, 22 Jan 2021 06:29:25 +0000 Message-ID: References: <20210114223637.2737-1-kun.q@outlook.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: outlook.com; dkim=none (message not signed) header.d=none;outlook.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af09f305-0b15-45bb-52f6-08d8be9f1058 x-ms-traffictypediagnostic: MWHPR11MB0030: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: It57XALkbYs6GD9Vmab1iXHWgTlDsWYoE3/l67zxs82/QJ+fENMtF6Bm1hV145zVCrxhTClUL6V5k9wB1dejHmuPzh9naVf8rQ5Qq9I5FWO1vYZUU/AZuq1eXJJIv2/N+V0WP4JOqnNrbwfG8ZfZHZ+qLH8yr9BQyAwtdSKsWrCHbDi2NRREkOp/rvILSun77ayjJwvD6mwyw+YiJn10mX6veazeczBuDpNqSCptie9CX2E/iO2wdihQHyUY0MwnWdfCP/3hVClUekJwL/z83NZmOHXYhMEXRDQAk9vjzt74wUC5OCtzRW54XWwtvx7cD+Gp5EF6XqaeeQ7sltab1ozA41bGbvP6vDvu72ZxqtYgzAsGhX3YRgpmKFPwe35Gs5OHQnN1hKk6ip5PyEVB5hq2RFA8xOgl/+9fneVrW1G9jfULAfh+j0o8n9IOWnFEJJl+v2IAu9W560zk2ECS+A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(33656002)(53546011)(6506007)(5660300002)(52536014)(107886003)(8936002)(66476007)(66946007)(110136005)(76116006)(66556008)(55016002)(45080400002)(7696005)(478600001)(2906002)(54906003)(9686003)(4326008)(26005)(186003)(8676002)(64756008)(66446008)(71200400001)(166002)(86362001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?9vGP1lTH2z9XgvFznTZnjpxiS4h938j0T3K9g06Gsk+Sz0dic8IYbJ6MMGE7?= =?us-ascii?Q?uLvMW3CpeYu2DTkdYTfwFA1xftu+zTpKKkkNb9Ml59GofABsnJhi9X2pUkrc?= =?us-ascii?Q?egSXfglhkLvadj7BXsjQtLe6bwlmdwB/Aj1TBXeCm0DqRqYfqBQmVkqD/U2n?= =?us-ascii?Q?mfN27Zi/slVhwTTSUlG3PGqK4lB9td4UX4YbRybzn1HSt8h4RW3/oHry/ZvZ?= =?us-ascii?Q?w3ufPeamGW3y6XahUmVqyyICaabU1GB1JNI+enB+myL5r5/yIjEKf6nLqO+N?= =?us-ascii?Q?YeQBzc+BJjmQeRAIzzRNZlJ4FEAs7WR/PF4vmY2amaUG5ktCDpE2JZcHWkX+?= =?us-ascii?Q?4rfiq2EtQsbH9+R9ty+X2h6pCOSnxMMxN8txd++UO0AM6WyL7wijKqTjZzYo?= =?us-ascii?Q?N1n4d110v3s/7YImZtJ4lWkrIu7+T2SAZ0Zmsws09iQK8BSB76gKU7Mlby8s?= =?us-ascii?Q?j7wiYndGCRyI0wh/GUmdrbGq9TfWyVuSg1sNZC3G8XrEKQpt/jipByXghAIW?= =?us-ascii?Q?Tk3n8S4wsOWnTcSl7YtsDAhwptSSk30T0wiaRTJi57FCAk/PTLjn5wSv3bS1?= =?us-ascii?Q?gPoxzw0/2jmIP+r3g1fXr7+NeJi40lDoeT25iCwPmnxOewhOZjAdGjcdU1id?= =?us-ascii?Q?SyzWHBQm+HGqU1nncGPZ1ACSDSfrFdLBxcDAj+HE83jqi1AJ5QqAuAd1yHlO?= =?us-ascii?Q?iYk1DSzg1UawmDjK1z9sh4zN2hMoeYBea/KbzAGiCAt9wXFhPvouY7zI//51?= =?us-ascii?Q?t1jLVAO2LG+NAzDhTBUmeiNNgYg053TNCNcRWoKqdJEoLj8i7FstC6eaYHf5?= =?us-ascii?Q?N8A2v5RHRhtuLLCIjV6FCnn1b5og/jkVXfoNivGMvRk53wDPY8C1uKV+QHH+?= =?us-ascii?Q?WDQ0FdC6+dXNwaWOReOgyGQtTtiw8EC4L3kJ5bXfalov/WA79E1LbukObtSX?= =?us-ascii?Q?5A7S5gZ+VGsQYafxz6TRCA7CCav7BhnswLZUzmuEzacLMsFQ0VupmjXbgwZf?= =?us-ascii?Q?6205?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af09f305-0b15-45bb-52f6-08d8be9f1058 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 06:29:25.5639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z5vz6FF7kgFX0CrvrATsq17R0f1XmOD1clqar0HvwbczJje9UbQIDWHt5+4mOgPW5rmUouB6amGprg4QnbgN6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0030 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CO1PR11MB4930C0B02C1959B4E2C7CEF08CA00CO1PR11MB4930namp_" --_000_CO1PR11MB4930C0B02C1959B4E2C7CEF08CA00CO1PR11MB4930namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Kun, Yes. I recommend renaming the files. This can make future developers easy t= o understand which file stands for which purpose. A separate rename patch looks good to me. Thanks, Ray From: Kun Qin Sent: Friday, January 22, 2021 12:41 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kum= ar, Rahul1 Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support o= f CpuIo driver under StandaloneMm Hi Ray, I was suggested not to rename the file for review easiness and git history = concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuI= o2Smm: Support of CpuIo driver under StandaloneMm (groups.io) Please let me know if you still recommend renaming the files. If so, would = you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"``` to be a = separate patch between gSmst change and adding Standalone MM instance? Thanks in advance. Regards, Kun From: Ni, Ray Sent: Thursday, January 21, 2021 20:17 To: devel@edk2.groups.io; kun.q@outlook.com Cc: Dong, Eric; Laszlo Ersek; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support o= f CpuIo driver under StandaloneMm > > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++--= -- > UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++= ++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +- > UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.inf} | 18 ++= +++------ > UefiCpuPkg/UefiCpuPkg.dsc | 5 +++ How about do the file name change as below? CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S" CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It als= o matches to CpuIo2Smm.inf. CpuIo2StandaloneMm.c/inf # looks good to me. --_000_CO1PR11MB4930C0B02C1959B4E2C7CEF08CA00CO1PR11MB4930namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Kun,

Yes. I recommend renaming the files. This can make f= uture developers easy to understand which file stands for which purpose.

A separate rename patch looks good to me.=

 

Thanks,

Ray

 

From: Kun Qin <kun.q@outlook.com>
Sent: Friday, January 22, 2021 12:41 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@= redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Su= pport of CpuIo driver under StandaloneMm

 

Hi Ray,

 

I was suggested not to rename the file for review ea= siness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/1= 6] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (group= s.io)

 

Please let me know if you still recommend renaming t= he files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h&nbs= p; # remove the "S"``` to be a separate patch between gSmst chang= e and adding Standalone MM instance?

 

Thanks in advance.

 

Regards,

Kun

 

 

>
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c     &n= bsp;            = ;             |=   9 ++----
>  UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c    = ;            &n= bsp;     | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c   &nbs= p;            &= nbsp;    | 32 ++++++++++++++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h     &n= bsp;            = ;             |= 12 ++++++++
>  UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf     =             &nb= sp;           |  3 += -
>  UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.i= nf} | 18 +++++------
>  UefiCpuPkg/UefiCpuPkg.dsc      &nb= sp;            =             &nb= sp;      |  5 +++


How about do the file name change as below?
CpuIo2Smm.c/h --> CpuIo2Mm.c/h  # remove the "S"
CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It = also matches to CpuIo2Smm.inf.
CpuIo2StandaloneMm.c/inf # looks good to me.

 

--_000_CO1PR11MB4930C0B02C1959B4E2C7CEF08CA00CO1PR11MB4930namp_--