From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.6831.1622851626258490145 for ; Fri, 04 Jun 2021 17:07:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=oc8vqUCa; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: /hBnVK4w1IXs8MCQ4HKIlpTYEId7UaB/E4jra1GsMzQX8a5opzOYwXOKfGLat4I9gsiTFxmzfO WaG5GrZciQ6A== X-IronPort-AV: E=McAfee;i="6200,9189,10005"; a="184073853" X-IronPort-AV: E=Sophos;i="5.83,249,1616482800"; d="scan'208";a="184073853" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 17:07:03 -0700 IronPort-SDR: 5dRgqGR47f7gGOGJKMIpeOD6rEo+7vcPlLFwTs6HYAS3McPSp8UgEA7L+FuByOZ0jzMOfaR6Vj UzDho4lQZFlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,249,1616482800"; d="scan'208";a="475632829" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 04 Jun 2021 17:07:03 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 17:07:03 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 4 Jun 2021 17:07:02 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 4 Jun 2021 17:07:02 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 4 Jun 2021 17:07:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C5Nqhs3BIB++KyD3Daa9x3h9vS0Zh22+54a7q9doBqoEoR4uz08hEup66RvO2JJChzKzfjzDqY+4CZkw1KMXZSo33XBDOh7aqW/Dzong2rEkRRDfdEbABYf/jxiEcTjFOK1LRngEfFEQbsHQaaoItWBLYEmnn17DtdGSc5wkIgl44/avt2dxOtH0uC4jieSL6iJlAUXVnHlm+Bw+5crltpJ6Mr2l1gVL00Zssqw9G3P7MCwtjp0slXODvO4TelunO/lTf5B9RTvaQQC68O4dsFk1d1nNr8AvTLRhPVwn9fCSaBT5v6uZ4to2Z+GKugyo+4c8jcn36qRjsT3eJBRYSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcARXg72BhGbtycmvucIZa7EUE8HexsBUzTrywE/k4Y=; b=dwTSq4SMTuYP8LLM2SQOvdXS5KfbWJR5Ys81w8fKmIOXlahxgPPhHmQR9ng6/jxFTnb8UW4vbQI1W7WKIAce8XBvFz8WGgTOEUVN7I6aR+nUYgAQ6Q+n1tuNjsNhE5Gau85tbWxMxaCNFKG80q2paC+nlRjZ+AGTM1Dntky9VIEeq+FRSH5ac4OYUbDrLRAx57EFUIWExPiLHHhhUe2JDou36/aLlCpsF7qbi9olODSWruTDi5Lq9tk6vi/Wr8dVM7ZwMNaY0Oq4a8E7E/gdm56n0Dz7NPMIauEG8Z0eDFvaqIuEKMICiusCdQ6yJBkkQ9E2BAqWrkIPbDlJoImawA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcARXg72BhGbtycmvucIZa7EUE8HexsBUzTrywE/k4Y=; b=oc8vqUCaroW+clHjGgLfFF1nCE2Wm3CoxMGO8tzofMsuwhlYr+/N8jr67DoarA6Qr6PpZuJXKd3oF3x4rFYXgmTsqoUOYG+0HErT1aQcr9Eqi9HVy+GKLn8njJby/OjHP39czua+oI5p7EgTdD2c95WGqVXJm40o+MHpcnpzlZY= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2368.namprd11.prod.outlook.com (2603:10b6:300:7a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.23; Sat, 5 Jun 2021 00:07:01 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::a439:f8ae:4699:718f]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::a439:f8ae:4699:718f%6]) with mapi id 15.20.4195.024; Sat, 5 Jun 2021 00:07:01 +0000 From: "Ni, Ray" To: Leif Lindholm , "devel@edk2.groups.io" CC: Liming Gao , "Feng, Bob C" Subject: Re: [edk2-devel] [PATCH v2 2/6] BaseTools GenFw: Support CLANG8ELF with conversion ELF to PE/COFF image Thread-Topic: [edk2-devel] [PATCH v2 2/6] BaseTools GenFw: Support CLANG8ELF with conversion ELF to PE/COFF image Thread-Index: AQHXWUXptraZMLC3oUS4qrTuCjLZl6sEiinw Date: Sat, 5 Jun 2021 00:07:01 +0000 Message-ID: References: <20210602081145.265-1-ray.ni@intel.com> <20210602081145.265-3-ray.ni@intel.com> <20210604133124.knyesmliadsvvb5v@leviathan> In-Reply-To: <20210604133124.knyesmliadsvvb5v@leviathan> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [124.77.195.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6deb5ea7-459f-460d-32e1-08d927b5d7eb x-ms-traffictypediagnostic: MWHPR1101MB2368: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:198; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zYzckBaopBp2Pn+bHAVXv4f1U4V0gxARQ/7MySB0JH7jnwcl6a2P7rkwc2RDvw4JQgvbWLBOzVD9jEA610Hj4OA8doA+DYaQeerC28QWwbqCr6m0i9z2bpraLcKYlIGk56bDlIGvKgMOK/r5UvUuK6p4wE6eXAbViEco6NY4yY8KW4ZMlGPViNkeD8nSrsmzwU0Q6LSFfvUM9XjFYVJggxs+Dn24ha6H7zQEfm/jhq0Y89x66xx/B1jb2zV8kuOE8l0NM+N3D7cwldPuCutSpbBQURN5ERDcGy6uraETrpoYUa9WmDCp+CHfA3eHdCy+WiVjp0q66fePR5gIRFeM52pSKlkqB3G3+rqU3u7hGrQVVYXuvgbmzVjLKqJ5mEEzi7f+C1gquY1UdhM/+UXcYclKVg/CTftL90rLVfizE0g7wLlOy9+Z8PuBFalFYNddF4z4iWyDRbUYLkFA+BbUhndwqLi+rlEBYE5SmSk/0++aMaQ9VC46SaRaYdvdiB85ib5b8wsucWAIb08pDxx1WfLM1UOQuuLW9+VpwhmHaOl13Y+Po0cMpqoZ6150n0AloSyinyMXSLh7tn4pC6pmcPFszqgpzZw1ewF1e8UYbM3CojbwyaSD3kImj4qVgbk7M4WcwFiJ/0AUcHl1eWnuHRmVpNK08Oay9kkymbjB5Ex3GEIo+CVMBUdINQe69WZNWBg/gl1XJqGYPM8gdNM/M7h55Z0swWiUvFP/dda7YKg5XrIdToNKUag3Yu6OelIAyVEIWs6BdOm0Ik9gSpOWQALmK/fCdfIhrGsmUIM9lKpmsKVTV72VE9/B0+AWIL5b x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(346002)(396003)(136003)(376002)(6506007)(53546011)(76116006)(8936002)(316002)(8676002)(66946007)(107886003)(64756008)(66556008)(66476007)(19627235002)(33656002)(966005)(71200400001)(110136005)(54906003)(86362001)(4326008)(478600001)(83380400001)(7696005)(66446008)(2906002)(55016002)(38100700002)(5660300002)(52536014)(26005)(186003)(9686003)(122000001)(32563001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?w+yUui/gliRx2ZaKnW2ii2wvb3E982Rggtk6PgNLLmEhH5hukw37L0VS9dXC?= =?us-ascii?Q?3Gg7DboaNl454qVyu4fR3wmiE0bTzogWGn5h7FoYLUWj+YyUElMBuso8CKKI?= =?us-ascii?Q?DeXdLzI7bhpCfUC/oysBHm2oZW+wjzThhEjFaZBIBbtoU5p95PLWZQC/VlKK?= =?us-ascii?Q?ws7mbtW5r8+ThRHKuIB43wAoHF4cvxpJzD00u68Uj/MxmB/WfaAz0jP7JscO?= =?us-ascii?Q?C75jGvpu+HuJ5lapVL5F+9/eaUW6GhIq0fdLHb/FE5DqE2DSX7E+BWf1Sh5B?= =?us-ascii?Q?xA5G6u1Xi5kGLiTPf/HuSB2lTph1Kp3dfByyffxyqUBfGsy6P69NIi/oy3DZ?= =?us-ascii?Q?fUGBuntUSI2wEoI8Amb8WPUsaFRsR0ud7U0fOHCS+kJYyWtFa0re7XqWD4Qi?= =?us-ascii?Q?n5fbcEyT+jsyqpSVt1JndZzQGKynCnaiarnjmAbucOJkuddimA3HGghAEgW1?= =?us-ascii?Q?6VRsTsCemPfqVwnmVgkD4X3vYb2nd0c45z+uDo6XhZ18kl+FZRiSDg9I8ncS?= =?us-ascii?Q?x1RKMkhQ4lgMMsBzl/ExYxVWzIZPSFnyQnWW+vSo0pG3lzANyrTvSW7fqIhk?= =?us-ascii?Q?nL2KmbuRbK+xRIQB50hzhwsR5uLAKLGaQqJZedcZSuGE+DPvdf0yyJwnq4ue?= =?us-ascii?Q?KJb7+xH6bZgOgoH4bAJ5l6ckoz4vWN7JKnNoa4+frmxgobVGHR4CX3iDXx5Q?= =?us-ascii?Q?tsxKoWQ1Knfn1caAL59c5z0H6pyb5npOJk0XV6U2UbR4nyH2Okc6wBcP1iZq?= =?us-ascii?Q?Ht02NnR0eYvm/pwmvLOEjZ8f3QeEiv+AVLrdKpGREE4HwxcZu6kFrAEriM8a?= =?us-ascii?Q?rkJ/5n8TtHsH09Q0FXb2/X5WUK+DC4Gat7nm65Ogq5DGVULCwOy4+ACp/2vG?= =?us-ascii?Q?UmCU6h4/mU/AhFp/IBMnpkqL/gl/tIxRqwhXO0skzV4F1fm6pt3LajV/QKVY?= =?us-ascii?Q?Ed8g18Qtn+INepCaSZzwVogrR4J1FS3Xp/cUftHmWgiieyVO4oWRouPinEyT?= =?us-ascii?Q?oUI4uNim+Wo6cfY+BBBHinEEYSGUn21CLmj64+QMinGJkywlEd6V8o9/Ftwp?= =?us-ascii?Q?cscdWByxSVYbu7nAY44xP/fB4ol2g8IISabAhoirfFpUljUaL1+0YQ43eFSK?= =?us-ascii?Q?wfT8Ww/u0zcF/DYl/0ztql6spCI1M7bLGUP4tjmEZqgrmvLMuNofjVmEb793?= =?us-ascii?Q?wjgtkfQ+8wCBX830YVGOLbDzBBQpdANrn7wcpC/nvaY2yswTubuuDhXeS7N+?= =?us-ascii?Q?CDutIjnyGK1OymRvwgOyzZlrqrmlmHbqbhiABM4lxYZ69PAp+qVNnO3A9IIV?= =?us-ascii?Q?2vVQzWbdtT5sj5pRlgEuEwSj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6deb5ea7-459f-460d-32e1-08d927b5d7eb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2021 00:07:01.3361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: URsZabWG+dBaPEJx6kN9QnwhU0BPU1g5AiFTiAFM6aTuiTluF5fdwU+p3WiDp/eo8gkFacibfvevOvX0i2gBWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2368 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Sorry to hear that. It seems a CI gap that doesn't capture such errors. It looks like the logic update to detect .text section doesn't work in you= r case. I am trying to build the OVMF Bhyve because I saw it contains an AcpiTable= s module that has .aslc file. Thanks, Ray > -----Original Message----- > From: Leif Lindholm > Sent: Friday, June 4, 2021 9:31 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Liming Gao ; Feng, Bob C > Subject: Re: [edk2-devel] [PATCH v2 2/6] BaseTools GenFw: Support CLANG8= ELF with conversion ELF to PE/COFF image >=20 > Hi Ray, >=20 > On Wed, Jun 02, 2021 at 16:11:41 +0800, Ni, Ray wrote: > > From: Liming Gao > > > > CLANG8ELF tool chain generated ELF image with the different attributes > > in section. Update GenFw to handle them. > > 1. .text section with writable attribute (support) > > 2. .reloc section has the symbol for *ABS* (skip) > > > > Signed-off-by: Liming Gao > > Reviewed-by: Feng Bob C >=20 > This commit breaks many of the ARM platforms. >=20 > I end up seeing >=20 > GenFw: Elf64Convert.c:719: ScanSections64: Assertion `FALSE' failed. >=20 > when generating certain ACPI tables. >=20 > Note: this applies to both GCC5 and CLANG38 - it is not isolated to > CLANG8ELF. >=20 > Reverting to commit c1aa3bab1259 makes these builds work again. >=20 > / > Leif >=20 > > --- > > BaseTools/Source/C/GenFw/Elf32Convert.c | 12 +++--------- > > BaseTools/Source/C/GenFw/Elf64Convert.c | 5 +++-- > > 2 files changed, 6 insertions(+), 11 deletions(-) > > > > diff --git a/BaseTools/Source/C/GenFw/Elf32Convert.c b/BaseTools/Sourc= e/C/GenFw/Elf32Convert.c > > index 2485b2cb7a..7c8a065678 100644 > > --- a/BaseTools/Source/C/GenFw/Elf32Convert.c > > +++ b/BaseTools/Source/C/GenFw/Elf32Convert.c > > @@ -238,7 +238,7 @@ IsTextShdr ( > > Elf_Shdr *Shdr > > ) > > { > > - return (BOOLEAN) ((Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D= SHF_ALLOC); > > + return (BOOLEAN) ((Shdr->sh_flags & (SHF_EXECINSTR | SHF_ALLOC)) = =3D=3D (SHF_EXECINSTR | SHF_ALLOC)); > > } > > > > STATIC > > @@ -261,7 +261,7 @@ IsDataShdr ( > > if (IsHiiRsrcShdr(Shdr)) { > > return FALSE; > > } > > - return (BOOLEAN) (Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D = (SHF_ALLOC | SHF_WRITE); > > + return (BOOLEAN) (Shdr->sh_flags & (SHF_EXECINSTR | SHF_WRITE | SHF= _ALLOC)) =3D=3D (SHF_ALLOC | SHF_WRITE); > > } > > > > STATIC > > @@ -749,13 +749,7 @@ WriteSections32 ( > > if (SymName =3D=3D NULL) { > > SymName =3D (const UINT8 *)""; > > } > > - > > - Error (NULL, 0, 3000, "Invalid", > > - "%s: Bad definition for symbol '%s'@%#x or unsupport= ed symbol type. " > > - "For example, absolute and undefined symbols are not= supported.", > > - mInImageName, SymName, Sym->st_value); > > - > > - exit(EXIT_FAILURE); > > + continue; > > } > > SymShdr =3D GetShdrByIndex(Sym->st_shndx); > > > > diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Sourc= e/C/GenFw/Elf64Convert.c > > index d097db8632..8fe672e984 100644 > > --- a/BaseTools/Source/C/GenFw/Elf64Convert.c > > +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c > > @@ -246,7 +246,7 @@ IsTextShdr ( > > Elf_Shdr *Shdr > > ) > > { > > - return (BOOLEAN) ((Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D= SHF_ALLOC); > > + return (BOOLEAN) ((Shdr->sh_flags & (SHF_EXECINSTR | SHF_ALLOC)) = =3D=3D (SHF_EXECINSTR | SHF_ALLOC)); > > } > > > > STATIC > > @@ -269,7 +269,7 @@ IsDataShdr ( > > if (IsHiiRsrcShdr(Shdr)) { > > return FALSE; > > } > > - return (BOOLEAN) (Shdr->sh_flags & (SHF_WRITE | SHF_ALLOC)) =3D=3D = (SHF_ALLOC | SHF_WRITE); > > + return (BOOLEAN) (Shdr->sh_flags & (SHF_EXECINSTR | SHF_WRITE | SHF= _ALLOC)) =3D=3D (SHF_ALLOC | SHF_WRITE); > > } > > > > STATIC > > @@ -1060,6 +1060,7 @@ WriteSections64 ( > > > > exit(EXIT_FAILURE); > > } > > + continue; > > } > > SymShdr =3D GetShdrByIndex(Sym->st_shndx); > > > > -- > > 2.31.1.windows.1 > > > > > > > >=20 > > > >