From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>,
"Kesavan Balakrishnan,
ThiyaguX" <thiyagux.kesavan.balakrishnan@intel.com>
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Dump hob information from boot loader
Date: Thu, 1 Jul 2021 06:20:42 +0000 [thread overview]
Message-ID: <CO1PR11MB4930CF68833FB89BBD6D89FF8C009@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210630132626.1061-1-zhiguang.liu@intel.com>
+(*HOB_PRINT_HANDLER) (
+ IN VOID *Hob,
+ IN UINTN Hobsize
1. UINT16?
+
+typedef struct{
+ UINT16 Type;
+ CHAR8 *Name;
+ HOB_PRINT_HANDLER Function;
2. PrintHandler?
+
+typedef
+EFI_STATUS
+(*GUID_HOB_PRINT) (
+ IN UINT8 *HobRaw
3. Size parameter is missing?
+ GUID_HOB_PRINT Function;
4. PrintHandler?
+ CHAR8 *Guidname;
5. GuidName?
+EFI_STATUS
+PrintHex (
+ IN UINT8 *DataStart,
+ IN UINTN DataSize
+ )
+{
+ UINTN Index1;
+ UINTN Index2;
+ UINT8 *StartAddr;
+
+ StartAddr = DataStart;
+ for (Index1 = 0; Index1 * 16 < DataSize; Index1++) {
6. define 16 as a macro?
+ Status = GuidHobPrintHandleTable[Index].Function (Hob.Raw);
7. Should supply the remaining size to the Function().
+ PrintHob (mHobList);
8. Use DEBUG_CODE() and make sure PcdReportStatusCodePropertyMask BIT2 is set in DEBUG build and clear in RELEASE build.
prev parent reply other threads:[~2021-07-01 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 13:26 [PATCH] UefiPayloadPkg: Dump hob information from boot loader Zhiguang Liu
2021-07-01 6:20 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930CF68833FB89BBD6D89FF8C009@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox