From: "Ni, Ray" <ray.ni@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Guo" <guo.dong@intel.com>,
"Ma, Maurice" <maurice.ma@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg
Date: Fri, 20 Aug 2021 06:57:52 +0000 [thread overview]
Message-ID: <CO1PR11MB4930D2B825DCA131C06E32048CC19@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210820062653.714-1-dun.tan@intel.com>
Dun,
you can directly remove below lines that reference ShellBinPkg because that pkg doesn't exist in edk2 repo anymore (it was deleted in year 2019).
> !if $(SHELL_TYPE) == MIN_BIN
> -!if $(ARCH) == IA32
> +!if "$(ARCH)" == IA32
> INF RuleOverride = BINARY USE = IA32 ShellBinPkg/MinUefiShell/MinUefiShell.inf
> !else
> INF RuleOverride = BINARY USE = X64 ShellBinPkg/MinUefiShell/MinUefiShell.inf
> @@ -210,7 +210,7 @@ INF RuleOverride = BINARY USE = X64 ShellBinPkg/MinUefiShell/MinUefiShell.inf
> !endif
>
> !if $(SHELL_TYPE) == UEFI_BIN
> -!if $(ARCH) == IA32
> +!if "$(ARCH)" == IA32
> INF RuleOverride = BINARY USE = IA32 ShellBinPkg/UefiShell/UefiShell.inf
> !else
> INF RuleOverride = BINARY USE = X64 ShellBinPkg/UefiShell/UefiShell.inf
> --
> 2.31.1.windows.1
next prev parent reply other threads:[~2021-08-20 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 6:26 [PATCH] UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg duntan
2021-08-20 6:57 ` Ni, Ray [this message]
2021-08-20 7:03 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930D2B825DCA131C06E32048CC19@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox