From: "Ni, Ray" <ray.ni@intel.com>
To: "Lou, Yun" <yun.lou@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array
Date: Fri, 6 Aug 2021 13:55:17 +0000 [thread overview]
Message-ID: <CO1PR11MB4930D7AE2FAAF49ED7D292638CF39@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210806093818.4924-1-yun.lou@intel.com>
The patch looks good to me. 2 minor comments:
> + } Fields;
1. Can you rename to "Bits" to align to existing naming convention?
>
> + UINT64 Data64;
2. Can you rename to "Uint64"?
next prev parent reply other threads:[~2021-08-06 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 9:38 [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array Jason Lou
2021-08-06 13:55 ` Ni, Ray [this message]
2021-08-06 14:01 ` Ni, Ray
2021-08-06 14:09 ` [edk2-devel] " Jason Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4930D7AE2FAAF49ED7D292638CF39@CO1PR11MB4930.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox