From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.5032.1628258120868291273 for ; Fri, 06 Aug 2021 06:55:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=AGEoxWZo; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10068"; a="214400466" X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="214400466" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 06:55:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="438182962" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 06 Aug 2021 06:55:19 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 6 Aug 2021 06:55:19 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 6 Aug 2021 06:55:19 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 6 Aug 2021 06:55:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KNS6qeK5mm0uAuRPrJO37FS3mqy/gXz5Jxqef++NG5FuQVXBOZ0i0v4roqWquKjRYtQpg9jmFCiKupQISjyCFY8ZNUrJB6mCDxbiWr8JoW+e4URt70cMqqZGr9z5yHl19eslT8DEqNIoUcd9nPoXctCQr+2+MnmU3v2hjgWdU7yPSc4T6qHCBHFzGcnNOZCipc5tRq+DHPzNgDkZ9mdloHuwDVYbeSJGsJO2sP8V9cbMekbGae2rCMS9wu88niqMl5vG7dhXnMsyiDI9XfcdpiRumCacYhswL6Z3rfgKIl2xiG9WXhC9oPZlw51ru4sXD9FLfyhdfhowgvojsifsFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kzczoNjtDYznINdMuxZpjq5VGet3XwgE2R+/gsVAPM=; b=c1vo0H/oXKb7xu7bkmdeAkGYTsoHcWmvz0icSx1FplXKB/axXAGgPJfU6eTTiV7+FnT+Z7i7aFKTwnZ0X1RJbqComT674Hy1HAeAApr0VgvSzjn6t0uzJAZkSi75xdCRin474UWAEpRgaIExuXRXQjq/dwr8oQetVBEFYNroGXnkJWOdhlzc2Hf3SZl7KVrJKnmr3jqGpFShr7Dtz7gMSOqP2NN3zy41C/m1MDE9PGYiXapUn9RVMRwZD/RAx63DQiZdfnhYfy7K46dwhMz+83fEcU5iY1U1WQazsJxulO0WDGzPzqmcGfNKJPXqaCWnhcnYaqTL8iH/coROj85z+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4kzczoNjtDYznINdMuxZpjq5VGet3XwgE2R+/gsVAPM=; b=AGEoxWZo0Wi6KdMs28PoXCiy81fRrHnO4HCK2xLedqdB24cq4PCaiPrlHoW2/1L/Hpofym1cqoVEYOJCu2S7AtSVvGDXTomHfGxQC2mIYhNHXbBBxWQ3VZOR4ktEmtRBg79HH7+jQVntACPqV++ATBaRe+LM3yzMpUZemcAyNoo= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MW3PR11MB4633.namprd11.prod.outlook.com (2603:10b6:303:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.20; Fri, 6 Aug 2021 13:55:17 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865%5]) with mapi id 15.20.4394.018; Fri, 6 Aug 2021 13:55:17 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array Thread-Topic: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array Thread-Index: AQHXiqbRxWgQ1JnEfkKDFk1i7AYtMatmfzCw Date: Fri, 6 Aug 2021 13:55:17 +0000 Message-ID: References: <20210806093818.4924-1-yun.lou@intel.com> In-Reply-To: <20210806093818.4924-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.100.41 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54d6765c-16e9-49ee-6d8e-08d958e1d2dc x-ms-traffictypediagnostic: MW3PR11MB4633: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jbd/rQlnQlK0StJ9Jg9uZ72VaGbz3IRwyhertdR93cGWfehYkuaj/N1156OQbHXlOohD2moJarFBtHwlILv7XUEIdcG4zh3RKZCgK8FXtID7L3ex99pA7K0fcI+nknLI6lgXrvwo3nvrjPQstGmnUf2L6OUNNFE5c/iyAYeDU7G3XAFU1Cq6J7ecMpGvF7k1+9r7Q/O5lONd+xJp65CKtvRT0RNxur3MMKRXTRAZIKkiix1cCfX33gqPPwq5RBuUYZ6dTJY+FvEWL1qoNo7G75TLLcu3t5GpbzFfkf7RdY9P0o1tROrowI8PINNqB4pbJYiaAWFnZyMT1l99M7GGS3+BfNF3dCFMNXF3bXZKAei2Y0B5bKpG0AcAzsKSX3Q5T8iY24wvV1YkXPXrGmOgj/v3pllPovmvQvkiQI250cMKj49Dbi/9PmSF4aqYTxt1URnVzvkzN/sbeSgzlw3tODBsjoIAlgEddbE5ws9hEmTBeKxHy68u3c/NF5U7g6ymklsWjaBv9AasEvfV+ukJGAGGEvpP6CWGNYeOXBSvA5mIRBzB5wDWB3IKSFnzFAG7icgCngmt0yRA8LgsgUnhMmyAKXfAGyyVKNV4rcHzlErQqv1DbC90/uVtb81aSfTuhfhum3WktVJUm0kQgYUf1Q5NArbNqg9iR0mjUA4solR/KVuodFxxwDwZKAJSixvK5IaiIahvSW2KpO08tlWfQw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(558084003)(122000001)(33656002)(86362001)(316002)(107886003)(54906003)(2906002)(38100700002)(26005)(110136005)(186003)(5660300002)(71200400001)(6506007)(55016002)(7696005)(76116006)(38070700005)(66556008)(8676002)(64756008)(52536014)(66446008)(66476007)(9686003)(66946007)(8936002)(4326008)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I3TzixacqwO2VT3E+9j8rT4Y+7AGk4paCF3o+wIlrlbabZajU5TE7CwjRoxK?= =?us-ascii?Q?/a0ZzSd/5/aEqV9YFS4gzZzqFadXG/Wt/E34ap7KGcRHcBQioF2Dw8Gl9aob?= =?us-ascii?Q?eLG5oA12WRDClHfRYphJfFL+8SH6D2z9Pk0pnfzLpzqvrv3wkJwozgubbHP6?= =?us-ascii?Q?YYy0b9MPrRww7zD9cIsHkvvereqpI3pCrDgXkYREHKJFMR6cWzMqgj4f6rWx?= =?us-ascii?Q?vSIaS7ClrLnViIDGvTtAyIYkXy5g6K8ce95pJS84m9yU3PhbBUBe2l0eF6L6?= =?us-ascii?Q?pYzPeeExvXXWwCg9s9sf4JI4GSiSBKilXKKBBcUn807lTLDc+i3YHcPx9eBE?= =?us-ascii?Q?A+Z+DbxwrVMaai5C8RtN5dLAs5fo8FSfPVN2zzPKmss7Iq3n9qmDauHO4U7y?= =?us-ascii?Q?GqfmxvwV/WtRB5sOx4MsBcv1Ntq0tiC4NK0FYZcZDLDuF9q8szkJVSUI74Hu?= =?us-ascii?Q?7ypHqoY1UtQaqQnVIu/oWMwlZh0ssdDGTIDFsB5hde5MgQOsK/AqKeVRS800?= =?us-ascii?Q?XesKYPL6zBX08Du0mV9K5nxlFmrhF8DiUuFBSNeuztd3sn/4svveIk/KEiFr?= =?us-ascii?Q?F9YOGG2ZWi7fvDWOB7B2YHAoYFsjQ4YZ8+R1BD54ru52syKL6HxCO4qjhLQ5?= =?us-ascii?Q?tDAaIitYZs7iaABb7JXNYV5p66QFzrHuVafasaqFXOgs/N84xWkD2SvtoLg5?= =?us-ascii?Q?xJFAIQcp0Xzbjl/IZPk/sriXIQ1nrZmyHfRBn4+tU11/YsSFyxrlxopSGDC0?= =?us-ascii?Q?i5GsyIbghwXn/F5OivJuybxsP9RmFNM1x54+qJdlarC0o2mnTxs33HBTRywO?= =?us-ascii?Q?LB0fepBLW+GWySMCO1FGE1+ONhR/TaF9aaWnD+//37AOfYA3Eu/R9X37KKf7?= =?us-ascii?Q?cXoMzu4ubekouwRxcsJOjvPRsmDp4ZypWTN2LVyBy7R77i0NT4j90ktacfcI?= =?us-ascii?Q?KkPJu9TpqIPwKU/Y8Ps008yo92cXD52KY6zgLyRGzaNGowcvfDHmFuG7kGLX?= =?us-ascii?Q?cdJjL54/4WhJPgPRxELXcyrD4movRL0Tgms80wcFqMJY+04ZViJMj89aw2NL?= =?us-ascii?Q?ialvYhlPBvJzkrIgtbqOxgWT84qXqdtywMfYl48OgiCJkocK0ISCnCOa2u18?= =?us-ascii?Q?uWJLZ0uCoDDbr6PrUMy6TyEL5m26vnpuVBbF/2XXg/2fFe1sRumz8L29BoJq?= =?us-ascii?Q?oL4V7jymlK/hmjow/NlZ5EkYpPJ2Yf7JkGr9ZoQMX/N8AoGvhRoHqeBAM1pP?= =?us-ascii?Q?sTn4SMjB+Ec+iEX+GtYoIEWKZbfiKRQNc2uwaK77dwcwgzMV33j4MXQHGALN?= =?us-ascii?Q?wvew/ao/hhgl0w1yygRVuwGa?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54d6765c-16e9-49ee-6d8e-08d958e1d2dc X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 13:55:17.7555 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jXEB9+5JwJeO6LscXeVjgUj56p0eFFQu1Ip+mYRi4WnM20NnYoOzu+Bx/ZsDqbAivQu1/J0iXEHzN0Y3+wMzKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4633 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch looks good to me. 2 minor comments: > + } Fields; 1. Can you rename to "Bits" to align to existing naming convention? >=20 > + UINT64 Data64; 2. Can you rename to "Uint64"?