public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
	"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [Patch 1/1] UefiCpuPkg/Library/MpInitLib: Fix AP VolatileRegisters race condition
Date: Tue, 26 Jan 2021 02:26:09 +0000	[thread overview]
Message-ID: <CO1PR11MB4930DAFD2EC99F5058882D368CBC9@CO1PR11MB4930.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b92a4cfd-cbcc-8025-87eb-a8434f6e20c0@redhat.com>

> >     CpuMpData = (CPU_MP_DATA *) (Idtr.Base + Idtr.Limit + 1);
> > +    ASSERT (CpuMpData != NULL);

In this case, Idtr.Base, Idtr.Limit both equal to zero and CpuMpData is 1.
ASSERT () cannot trigger assertion here.

  parent reply	other threads:[~2021-01-26  2:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 17:10 [Patch 1/1] UefiCpuPkg/Library/MpInitLib: Fix AP VolatileRegisters race condition Michael D Kinney
2021-01-23  2:02 ` [edk2-devel] " Laszlo Ersek
2021-01-26  6:47   ` Philippe Mathieu-Daudé
2021-01-23  5:10 ` Dong, Eric
2021-01-25  3:14 ` [edk2-devel] " Zeng, Star
2021-01-25  5:15   ` Michael D Kinney
2021-01-25  8:43     ` Zeng, Star
2021-01-25  8:53       ` Ni, Ray
2021-01-25 11:04         ` Zeng, Star
2021-01-25 21:17           ` Laszlo Ersek
2021-01-26  1:18             ` Zeng, Star
2021-01-26  2:26             ` Ni, Ray [this message]
2021-01-26  3:34               ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO1PR11MB4930DAFD2EC99F5058882D368CBC9@CO1PR11MB4930.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox