From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.9376.1616744379349987161 for ; Fri, 26 Mar 2021 00:39:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QFcukV9Y; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) IronPort-SDR: QcD+g604V75cxCnE/fDSsQDJCLTqkqKFM3mMSlV8NI0KZtqWbDNr70/iHFTVrSJaotxgkyPsAg 50cP1rn8M+LA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="211256295" X-IronPort-AV: E=Sophos;i="5.81,279,1610438400"; d="scan'208";a="211256295" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 00:39:38 -0700 IronPort-SDR: 5N49eHSZEA+OAk77rLNFiQ81eeuCp6VyJrx3CVYOrRHdM8ArVARIq9jMduOo0HYpqQrlP7zFmh KdbecFbmEnjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,279,1610438400"; d="scan'208";a="453416107" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 26 Mar 2021 00:39:38 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Mar 2021 00:39:38 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 26 Mar 2021 00:39:38 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Fri, 26 Mar 2021 00:39:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTkD6i+o7GDrRWHY9FAVzLzNl5SUcBi8e8IZcfBlJOHqWj1QNi8V4LHvD+/KygsZw0ZfmFw/2m8dtIxm+CAT5nktxRkDWm/anfieHj0t4JV2LaWOXa3zcKG2xnIlxeAH+p+/WlAx1ZhzEznhzz8LXN7SRQLUBG6bSeTXE0ESRyUvZ4gUxbe14ihWb8AFP/LAZ82WFta8wRrCe1BfODbHUecJ4Fz9I4LzE0VkxSciJ2ZsE8sYEGZpg0Vs8F9gTGNsbU+RCd6+qcXVlfBzWjbUlV6YrOcHa4ufIkUT3plSVGVCTPZEOYQK1an+j0rUrKUVbILhiCZ5zIEdcitU87eOPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2A0mQuH7P7tzdENOGAd6SS6PRoKf0M9YkhlOgz8WM20=; b=b41EYPmw4oZjVN+WqkbBJ3vD9/Btl1FeMLxdOdLixJrxsQgjkOrJgYk7i/vj1FQF4FHFQQQaMUDONehKcyekTvditBcNMgqEHGRxKbYmgBivbl+F771fwORgHb0lsS608JZ6D8hw0CfLUCKkxZkYUHd9PGUF0AHuOAjoBrTyd6jvO6Zd0lCx6vU8lP49zxdLvt4KXilEFKpxszn9697o4ymMV0AY7I8LK0BDt1y5vgjTmoakZ1f2VkDOcCgMEub+OqOmwCJ/7Ksw3rGRiwqCLe+G5dJdg1hF7Gm2UTVq7pLGqTecs253Hjln7wGoVEjhcw+IIR/B4RxfNjmyfV7R2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2A0mQuH7P7tzdENOGAd6SS6PRoKf0M9YkhlOgz8WM20=; b=QFcukV9YCiaGOSo2k8kPocW0wGzVdjXhXu0rHPgrZeE7mWx4dtFMk9j4s79sHZ8O6vR2AQ0zbswfTdxaXdYh75NB/1kPp7eCB/6+jpvtreNYLWGI3MIBSmp2RhFlyVmgaZTCR5IfXK4b/a8QGzu9v63zYUywX9qcrpsxzlh8pZE= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5154.namprd11.prod.outlook.com (2603:10b6:303:95::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24; Fri, 26 Mar 2021 07:39:36 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::8d64:91ed:c259:e95%7]) with mapi id 15.20.3977.025; Fri, 26 Mar 2021 07:39:36 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcode location in flash Thread-Topic: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcode location in flash Thread-Index: AQHXIgv4anbPXT5RK0+4c3DwaE5BZKqV1AvwgAANpNA= Date: Fri, 26 Mar 2021 07:39:36 +0000 Message-ID: References: <166FD19F7613DF94.8397@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82bb5844-f36c-496a-898f-08d8f02a4e68 x-ms-traffictypediagnostic: CO1PR11MB5154: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c58MIyCDTyPxRDjZQ8KAOC1b2womihNSVsMuyJULpVX4GG8FpNEim4ZS8TDjdkVzsoHuLFkyKIQwsKEoug1cvmjT+1uFyhe8s6QfYhmRPLIrJypttuLITBQjoi/rpAVBBYB22PbWaJYxNp4tw1uK53DAVDxsCeIGKe1liIl+OXPFmrC2iib+8KhSRyMWeuK9tvA18c2ObSc1rqKGdLEZmgBlCNJsf/6kxyg7hGnACnTFdfK2yDVRq/g6A/RT5GoHpQ9lFK8CHtTApBZzwehxQOzIX4OxYsu4hZRAO8ercrEOBUYkf7m6BOTiKORhYf1Ppa19DTnrE4NIW0ZMn5vqCUKu0ROgZGcoimjjrNNAylzVRRzJBpnCNJ6CyRGF73VMATrhOI+gcR34VQhYpXEtQZ0b3YpqDBNo/TbK8QHNkiItLwEK/v2rMwhRBzFf3u9lfTM/JTCwRc6/gOdda+CgQTmTPcJZfWu85Klib+sMFtwwXismLP3grVTz9QZHVvtU45sFucP2vME9Fzb4C9GIdTj29Fqjv2CMOd1PPPH0ETgmvMYcFVmfTKq2o7zM6bt17A6vwgal3V2uhUmLfk3hvw5k5INcNXRB6r5vD8/sI3BaSjqp4RotxD98B7Tv0Uj2rBL4ZdEHUHfK55SUAkFdLL2JvWxNVcHw9ISLGfm/i2g2KmhhH+QUJ3EDrXxBCPjSczU/YfIcsWNHrsAbDQZGvlrbmkENC3TEUBuZ18BBQMZhbR7nZxPM0QqYSR5+qmTo x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(366004)(39860400002)(396003)(346002)(8936002)(8676002)(2940100002)(478600001)(86362001)(316002)(38100700001)(186003)(55016002)(5660300002)(26005)(6916009)(4326008)(52536014)(7696005)(76116006)(19627235002)(71200400001)(53546011)(66556008)(2906002)(966005)(9686003)(83380400001)(66446008)(66476007)(64756008)(6506007)(107886003)(33656002)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3wwLWZPj/TZwTmUsj0OQrRuG/r3P793DOtR3Vsx5G3LgmElOfld/1qZz29d9?= =?us-ascii?Q?plEJWnFS/XXNy4qV8b86SNClNbdazfqvY3eAWoM8PXibH4o+KHZNeIiIs6+9?= =?us-ascii?Q?hI4VVkXJC7f8p4RRzCYN6ZFSumnRJ4Kd+T7+buhOy58OdtnWhTDbbFzHBg5b?= =?us-ascii?Q?QCY9tk70nJHNWvUglLDWvIJalv/vqRI46+EE2vGO17L6GZLSkFp5A7E8zUze?= =?us-ascii?Q?sC+rnaUfZD+Hyt8t6hyCXkruEYhOh1wvCVtoo6r8Qr+ELH5rEt7/kXjS1syL?= =?us-ascii?Q?8T9G6FEv0olXfHIsTgL4c8+j47Kx9GFPCppGBjOi7PgtEp6LW2L8m1SCZA1u?= =?us-ascii?Q?r7ISkgp2FNgy1hYeK1y/8sHLj5FGH6RiPLe3zT6Ma8zfusAoN62th59QQT9V?= =?us-ascii?Q?4kj0vs0sS3LGHZi24apsvpUZj3WTu4372Q25XIHA5DmENIGvXerzZvyK7pBr?= =?us-ascii?Q?7xxWLzAWfa7QmajqIeJPvEbTTu274iNrXW7MWMSZXfnYjniRu98nzPrtPxNY?= =?us-ascii?Q?jHzyN8wH3eTLtitNZSNWYE2dYwtiM9PB+5hOcG4O0hRG4T6EAgDwXSsMax+y?= =?us-ascii?Q?zKGa7u3QJDKfAX41s1zGPYdPuyeuhvPCVGKPfshhuPQJ7+n771LDPSAeQoDh?= =?us-ascii?Q?P1kgjG3C35EvkrSvqXrXBUUahdd+6Nk1P6YlA7AoLP8nk9w3qYIjmeZoUcQX?= =?us-ascii?Q?4t+VfTbOTQOiuEZqUjfjjD13Unsyk+j4MZpZtX7Q2W4Id8jdg6NNbKof/aNG?= =?us-ascii?Q?WoVp+gh8g+5cigjfAMkBhiugfgRh9aIGCDbr0i0olgf2sYja8so3a2aD9wm1?= =?us-ascii?Q?7tVxP5LUXjCWh+HxjpHMSaANYtUh9dlEhqRGaCFeVlJjnIpFRYAqO0oeYP/Y?= =?us-ascii?Q?sMZjq90yUXRUAXM0G5ZMGlFisX41vAoyi8fO3K85QCuAsRwvSJD8V/d4mM/J?= =?us-ascii?Q?87HiCplsaqihsnrMy/xI1nT46oDZEKZMuc1WQljx5hdoPWMHcQkm1058ccML?= =?us-ascii?Q?VlP8CQ4rG1V3YHUi6iKkEtnIl/58sO8N8pivG3S+yafR5PWQGFgiNmKPHCgk?= =?us-ascii?Q?7cHzsCVkqcrslWQ5m68XPo5D6mm7YAXYrqN6GBplhd6HEGaHOVw3n5pTMuY2?= =?us-ascii?Q?GFD+rxnC3i3GKw0vVK/PPy7MYh9Zn+whVwk10lp0eJ2FzXE4+BmhTEE3dlh+?= =?us-ascii?Q?aAJurIfwzLkiCSzR+HOwoeAAPdfkkfgRmT19iOiFpJsx6ZU42w6QQornJR+X?= =?us-ascii?Q?Tx5+DwpDQQU67l1h4ZA2WyzoIcuGawTC/8EVcwaLg4hqxLlw4/oQfDcbStM8?= =?us-ascii?Q?64YevR0WGlW2EPY/GCExpZyx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82bb5844-f36c-496a-898f-08d8f02a4e68 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 07:39:36.6467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /4qEdHeGbPfmIVw4czUU4v3h8fw59fRrmHOs4pbf+qlSAwRG2xCymM7uAh4NZJFzfGPw+SR5oOULFJQy3rPHlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5154 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please ignore this patch mail. I sent another series: cover: https://edk2.groups.io/g/devel/message/73346 1/2: https://edk2.groups.io/g/devel/message/73347 2/3: https://edk2.groups.io/g/devel/message/73348 3/3: https://edk2.groups.io/g/devel/message/73349 > -----Original Message----- > From: Ni, Ray > Sent: Friday, March 26, 2021 2:49 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Chaganty, Rangasai V > Subject: RE: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microc= ode location in flash >=20 > Please ignore the "Change-Id" in the commit message. > I will remove that when checking in. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, Ray > > Sent: Friday, March 26, 2021 2:48 PM > > To: devel@edk2.groups.io > > Cc: Chaganty, Rangasai V > > Subject: [edk2-devel] [PATCH] IntelSiliconPkg: Define PCDs for microcod= e location in flash > > > > 3 PCDs are defined assuming that microcode is put in the end of a FV: > > PcdFlashFvMicrocodeBase: The base address of the microcode FV > > PcdFlashFvMicrocodeSize: The size of the microcode FV > > PcdFlashMicrocodeOffset: The microcode offset relative to the FV > > base address > > > > The 3 new PCDs are to replace the following existing PCDs in > > MinPlatformPkg and IntelFsp2WrapperPkg. > > > > The ones in MinPlatformPkg will be removed in a separate patch. > > The ones in IntelFsp2WrapperPkg will be re-positioned as only using > > inside IntelFsp2WrapperPkg\Library\SecFspWrapperPlatformSecLibSample. > > > > Defining PCDs in IntelSiliconPkg is because certain close-source > > silicon code depends on these PCDs but the silicon code cannot depend > > on MinPlatformPkg. > > > > MinPlatformPkg contains the below 3 PCDs: > > PcdFlashFvMicrocodeBase: Same meaning as > > IntelSiliconPkg.PcdFlashFvMicrocodeBase > > PcdFlashFvMicrocodeSize: Same meaning as > > IntelSiliconPkg.PcdFlashFvMicrocodeSize > > PcdFlashFvMicrocodeOffset: The FV offset relative to the firmware > > base address. > > Note: MinPlatformPkg doesn't contain the PCD that tells the microcode > > offset relative to the FV base address. > > > > IntelFsp2WrapperPkg contains the below 3 PCDs: > > PcdCpuMicrocodePatchAddress: Same meaning as > > IntelSiliconPkg.PcdFlashFvMicrocodeBase > > PcdCpuMicrocodePatchRegionSize: Same meaning as > > IntelSiliconPkg.PcdFlashFvMicrocodeSize > > PcdFlashMicrocodeOffset: Same meaning as > > IntelSiliconPkg.PcdFlashMicrocodeOffset > > > > Change-Id: I708abfa4a9309cbaedd5c4e4f483ec9f0d5e7625 > > Reviewed-by: Ray Ni > > Cc: Rangasai V Chaganty > > --- > > Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec b/Silico= n/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > index 4a2cbca5..6611c3af 100644 > > --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec > > @@ -3,7 +3,7 @@ > > # > > > > # This package provides common open source Intel silicon modules. > > > > # > > > > -# Copyright (c) 2016 - 2020, Intel Corporation. All rights reserved. > > > > +# Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved. > > > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > > > # > > > > ## > > > > @@ -90,6 +90,13 @@ > > # @Prompt Error code for VTd error. > > > > gIntelSiliconPkgTokenSpaceGuid.PcdErrorCodeVTdError|0x02008000|UINT3= 2|0x00000005 > > > > > > > > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0|UINT32|0x00= 000007 > > > > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0|UINT32|0x00= 000008 > > > > + > > > > + ## This is the microcode offset relative to the FV base address. > > > > + # Microcode address equals to PcdFlashFvMicrocodeBase + PcdFlashMic= rocodeOffset. > > > > + gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeOffset|0|UINT32|0x00= 00000A > > > > + > > > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > > > ## This is the GUID of the FFS which contains the Graphics Video BIO= S Table (VBT) > > > > # The VBT content is stored as a RAW section which is consumed by GO= P PEI/UEFI driver. > > > > -- > > 2.27.0.windows.1 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#73313): https://edk2.groups.io/g/devel/message/7331= 3 > > Mute This Topic: https://groups.io/mt/81622347/1712937 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > >