Re: [edk2-devel] [Platform Redfish Host Interface PATCH 6/6] EmulatorPkg: Redfish related changes on EmulatorPkg

["Ni, Ray" <ray.ni@intel.com>]

Acked-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner (HPS SW/FW Technologist)
> Sent: Thursday, November 5, 2020 10:39 PM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, Nickle
> (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: [edk2-devel] [Platform Redfish Host Interface PATCH 6/6] EmulatorPkg: Redfish related changes on EmulatorPkg
> 
> - REDFISH_ENABLE definition to control EFI Redfish support
> - Add Redfish platform host interface library to
>   EmulatorPkg build.
> - Set RestExServiceDevicePath PCD value.
> - Add Redfish host interface config EFI application
>   to EmulatorPkg build.
> - Use Redfish DSC/FDF include file.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> ---
>  EmulatorPkg/EmulatorPkg.dsc | 26 +++++++++++++++++++++++++-
>  EmulatorPkg/EmulatorPkg.fdf |  5 +++++
>  2 files changed, 30 insertions(+), 1 deletion(-)
> 
> diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
> index a27cb1beb0..aa5504c137 100644
> --- a/EmulatorPkg/EmulatorPkg.dsc
> +++ b/EmulatorPkg/EmulatorPkg.dsc
> @@ -34,6 +34,11 @@
>    DEFINE NETWORK_ISCSI_ENABLE     = FALSE
>    DEFINE SECURE_BOOT_ENABLE       = FALSE
> 
> +  #
> +  # Redfish definition
> +  #
> +  DEFINE REDFISH_ENABLE = FALSE
> +
>  [SkuIds]
>    0|DEFAULT
> 
> @@ -95,7 +100,9 @@
>    #
>    PlatformBootManagerLib|EmulatorPkg/Library/PlatformBmLib/PlatformBmLib.inf
>    KeyMapLib|EmulatorPkg/Library/KeyMapLibNull/KeyMapLibNull.inf
> -
> +  !if $(REDFISH_ENABLE) == TRUE
> +
> RedfishPlatformHostInterfaceLib|EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.inf
> +  !endif
>    #
>    # Misc
>    #
> @@ -249,6 +256,18 @@
>    #  0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM
>    gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1
> 
> +!if $(REDFISH_ENABLE) == TRUE
> +
> gEfiRedfishPkgTokenSpaceGuid.PcdRedfishRestExServiceDevicePath.DevicePathMatchMode|DEVICE_PATH_MATCH_MAC_NO
> DE
> +  gEfiRedfishPkgTokenSpaceGuid.PcdRedfishRestExServiceDevicePath.DevicePathNum|1
> +  #
> +  # Below is the MAC address of network adapter on EDK2 Emulator platform.
> +  # You can use ifconfig under EFI shell to get the MAC address of network adapter on EDK2 Emulator platform.
> +  #
> +  gEfiRedfishPkgTokenSpaceGuid.PcdRedfishRestExServiceDevicePath.DevicePath|{DEVICE_PATH("MAC(000000000000,0x1)")}
> +  gEfiRedfishPkgTokenSpaceGuid.PcdRedfishRestExServiceAccessModeInBand|False
> +  gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand|False
> +!endif
> +
>  [PcdsDynamicDefault.common.DEFAULT]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase64|0
>    gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase64|0
> @@ -447,6 +466,11 @@
> 
>  !include NetworkPkg/Network.dsc.inc
> 
> +!if $(REDFISH_ENABLE) == TRUE
> +  EmulatorPkg/Application/RedfishPlatformConfig/RedfishPlatformConfig.inf
> +!endif
> +!include RedfishPkg/Redfish.dsc.inc
> +
>  [BuildOptions]
>    #
>    # Disable deprecated APIs.
> diff --git a/EmulatorPkg/EmulatorPkg.fdf b/EmulatorPkg/EmulatorPkg.fdf
> index b256aa9397..5420756eaa 100644
> --- a/EmulatorPkg/EmulatorPkg.fdf
> +++ b/EmulatorPkg/EmulatorPkg.fdf
> @@ -208,6 +208,11 @@ INF  EmulatorPkg/EmuSnpDxe/EmuSnpDxe.inf
>  !endif
>  !include NetworkPkg/Network.fdf.inc
> 
> +#
> +# EFI Redfish drivers
> +#
> +!include RedfishPkg/Redfish.fdf.inc
> +
>  INF FatPkg/EnhancedFatDxe/Fat.inf
> 
>  !if "XCODE5" not in $(TOOL_CHAIN_TAG)
> --
> 2.17.1
> 
> 
> 
> 
>