From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.4942.1607683039897398068 for ; Fri, 11 Dec 2020 02:37:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=v/pNNdFh; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: 7JXliddc2v4vM+i6C4jcGCeI8MfX8EO72GPuiN2ADqhyFLE/zebnQLsnGoZsNpVVJOXs4A98hu FINf4FIP943A== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="153645542" X-IronPort-AV: E=Sophos;i="5.78,411,1599548400"; d="scan'208";a="153645542" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2020 02:37:19 -0800 IronPort-SDR: GXxDcxPJ47lZCYlnNCdYewmw8znxiB78Obk+Kh0TY7D4hzVf7eXZ4y/k/p/9ZEoD26RVfCczuj aoM0tcWiNgTw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,411,1599548400"; d="scan'208";a="409144645" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 11 Dec 2020 02:37:18 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 11 Dec 2020 02:37:18 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 11 Dec 2020 02:37:18 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 11 Dec 2020 02:37:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U8dYM2xlDunUQYt7Mj1nB90dg/6jKXsAbr112DcksNlQ+cD4cDprf7Zoi4u7dQWp+/ghPy2Nv9bL9tQpu/z3JEhI76AggLiZakVWR+O/BOhVwO/FxSPX2t07FHv4VK4yi/xAOKnAzYtboLav1FlZuWPbzVpURlmC9WqIRwVRXheC3hqQtvuwKH5gCVZm0UCUk4jUjML30yFy0JFB81oEqVU5NUlWctr2I3MS6VZSzsQupncVnHdvFdITimW3Degb77Ey725x9DEyuDaX+Tmqqx4MrufXL1DrWHBT8/xYfA8Yg27ZxzSdNdCk6SIeF67zJQU7hwbWHha8DV25Eg9iEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9CiG65qY/MHogSEjbH8SkL2JjSB8W0H2kSJEzX7u/LM=; b=QXulpohpL87ij0Q7l3G17+FlOY5yb7j4YaKhHVfykWaQ1BLB7gHmfKDyknoxPqJ1Rqk1pKdr4O142IMAQoUGRkW7vTH6zgU4el5AFHAmtzI1yx2sRS1hghXsUDu8IEwsFe0mvFKiCaOrcPc5KXyru/XlPtDvNiqFmWCSSLY8/Ft81eTzyEmlK68jVfZQHBIdCsrz5Ni92KCbq+hA82hBgTqo+kIwBE+YErDi/HXF+OXWLVzhukYWbQMRGpp2rpR3VkZQM3E3jLqLNuHMQ2I+6u3OqbmZcpnx8OXWl9k9H7XjrYUZd6zIVmMdasAun28DPYkVCIeq1ZlZku7a9L+jYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9CiG65qY/MHogSEjbH8SkL2JjSB8W0H2kSJEzX7u/LM=; b=v/pNNdFhznx8+1qiN4Hs9K1E8CkMf34/aIZegkZoJWKsHm7bhePUXg4vZhyZTwcs2TYWYBziVQNPqvxBdJASrg5DzNC+qyPJu2xyucMgWuJ/DakjE7by78Q3qUuh5FtxVDqcEf/xDVYhJuXZ86iYceMDGsT+YsTDUy1ka9VrbKY= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB5075.namprd11.prod.outlook.com (2603:10b6:303:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Fri, 11 Dec 2020 10:37:17 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3654.017; Fri, 11 Dec 2020 10:37:17 +0000 From: "Ni, Ray" To: "Zeng, Star" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use AllocatePages() for InitOrder Thread-Topic: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use AllocatePages() for InitOrder Thread-Index: AQHWzh5jaw5j2HbuyU2/KAFB+ufO6KnxtuWA Date: Fri, 11 Dec 2020 10:37:16 +0000 Message-ID: References: <20201209112757.34196-1-star.zeng@intel.com> In-Reply-To: <20201209112757.34196-1-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f638cf1-a1c4-4bb8-8da6-08d89dc0bb14 x-ms-traffictypediagnostic: CO1PR11MB5075: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tDlTccHUp0Cbk6A4cJItJq0C0GeNxxOIOCXCEx0TMsEfZcv6l6QEsOhAgiJKmQAgi1L9Txt6Nnw+ayfMPjdp/CqzCx83zPC0BNakhGxoheGztFZvzJLb+rICBhJ38xXFsBPRLSz6C+GmKO1I29LypmP4CyWXtFVoR7fsGcT7C0T09DMRRz/B1w120lm3qXxic/V5RsbizoK2CSflWNMScbdUh3iHxAuGmBbVsJkn0CXccMzhmSgt065aKTsLa5i8NxYQ7FIaX+8sFCTdFQOi6A22beNfyvDBejcqi25/xvPQNNg1lpG5pCQH7OXRloW+bkhydgUMYU3+PJ6FPsWeyA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(136003)(55016002)(5660300002)(83380400001)(76116006)(86362001)(508600001)(66446008)(66556008)(9686003)(4326008)(52536014)(66476007)(64756008)(66946007)(26005)(8676002)(110136005)(53546011)(71200400001)(6506007)(8936002)(7696005)(19627235002)(186003)(2906002)(33656002)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?scojVujh95Yu+imWEVkZG/4pPgLpi1vd4uEf81cG+SkJLo8cHx70Bxcya2NN?= =?us-ascii?Q?qmL23ipputcfSjwr8uxQmln2Y6hOV/xJ5jT/AV0KdgqKYncMziAPPmbPMc98?= =?us-ascii?Q?Wff6RgkHFv7c3mZGgMwU8NTuGAOJ7b2nlrATt45E9cz5A5woGvQmFw+qujY2?= =?us-ascii?Q?+8MZ+wxGyQLSSPwXC+u+Qpa7NrxACW8jNU9C70scFXSWXMYo8SXkCST1tmc/?= =?us-ascii?Q?PzHPR12Ef5hDYw6Mt+qDB0WGmXIi030OvoFBCJxLucvlfzxtxwpCwA5JF9Fb?= =?us-ascii?Q?O88aJdSedtzjbouD24NjQ/+k+jQJ4+iO5rEw/rzd4Wgx5QsiCZZ/Oyc3Sz0F?= =?us-ascii?Q?trihy32N6KWurHZV6d6ga1sFtAu9ZIUYs6dZBPQTgI8CU1O+zeWJlLne+UcX?= =?us-ascii?Q?bTUxAQtNxEhCGbmA2DtNjHZhbClW2IkZ6xAOXlxqfNRen76dMJwk+93dv5M4?= =?us-ascii?Q?BPUuf/E9d9LDia494RGlSWKa7P03YaTf+m07x2DT9XVCO7wFs1BGR94Me1JF?= =?us-ascii?Q?/r2+7T+BQzbDaNYWSjMWz3OWdNj6SmWpC+FpMrdQbSHLPcve75Plw11dfLNw?= =?us-ascii?Q?bGZ573TvXUNe6x6tRkUViNC4o3+d4IxqvwvZIM6PYAEtorNQg8gzQFx3yXF/?= =?us-ascii?Q?l4qXse+7k0SE5EtCVzFcVIhh5eJyH2nioDpWE9riUiH7h7wGnQmurgtdfXjJ?= =?us-ascii?Q?v7nHGXLppJqbBv7kv6R+A1hK+IO/1V2WULdUpttBXLveWuP6tYpPJwqsERGa?= =?us-ascii?Q?ykuTs3x/DHWaekgHPrkTc8T+vs1wfNbMigEO5LVzTMR3yCzO8ZE2Fse9iR0y?= =?us-ascii?Q?tCVDnDeYom8FCBf+qRRbKdbgJpDILB0Uj/UWPAtEGL9u2zIJVZ9xJcw7bnJc?= =?us-ascii?Q?/KwMePET5wkMcE1K5XzPACB5uk6f7mfNJVtGbkcbJu4uNwid0VC0NiJdQsy7?= =?us-ascii?Q?PDvLDSQwb9NVhUtMgxPRQQgE09J0LYsbdDM0SmWcfld3MP6Jhqf1Dd7RrDme?= =?us-ascii?Q?3Br9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f638cf1-a1c4-4bb8-8da6-08d89dc0bb14 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2020 10:37:16.9668 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AwA+S05XIdlPD5i8b0WNKWbrPEaEQ2nKPTMIxLyULtK5u281dN+lGyzEAaGcmPS1BhPqW2MPXf+rCHKSLCKY1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5075 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, December 9, 2020 7:28 PM > To: devel@edk2.groups.io > Cc: Zeng, Star ; Ni, Ray ; Dong, E= ric ; Laszlo Ersek > > Subject: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use AllocatePages() f= or InitOrder >=20 > The required buffer size for InitOrder will be 96K when NumberOfCpus=3D10= 24. > sizeof (CPU_FEATURES_INIT_ORDER) =3D 96 > NumberOfCpus =3D 1024 =3D 1K > sizeof (CPU_FEATURES_INIT_ORDER) * NumberOfCpus =3D 96K >=20 > AllocateZeroPool() will call to PeiServicesAllocatePool() which will use > EFI_HOB_MEMORY_POOL to management memory pool. > EFI_HOB_MEMORY_POOL.Header.HobLength is UINT16 type, so there is no way > for AllocateZeroPool() to allocate > 64K memory. >=20 > So AllocateZeroPool() could not be used anymore for the case above or > even bigger required buffer size. >=20 > This patch updates the code to use AllocatePages() instead of > AllocateZeroPool() to allocate buffer for InitOrder. >=20 > Signed-off-by: Star Zeng > Cc: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > --- > .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitial= ize.c > b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > index d4a576385f0f..ba052732a86c 100644 > --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c > @@ -126,8 +126,9 @@ CpuInitDataInitialize ( >=20 > GetNumberOfProcessor (&NumberOfCpus, &NumberOfEnabledProcessors); >=20 > - CpuFeaturesData->InitOrder =3D AllocateZeroPool (sizeof (CPU_FEATURES_= INIT_ORDER) * NumberOfCpus); > + CpuFeaturesData->InitOrder =3D AllocatePages (EFI_SIZE_TO_PAGES (sizeo= f (CPU_FEATURES_INIT_ORDER) * > NumberOfCpus)); > ASSERT (CpuFeaturesData->InitOrder !=3D NULL); > + ZeroMem (CpuFeaturesData->InitOrder, sizeof (CPU_FEATURES_INIT_ORDER) = * NumberOfCpus); >=20 > // > // Collect CPU Features information > -- > 2.21.0.windows.1