From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.4690.1611289039801097481 for ; Thu, 21 Jan 2021 20:17:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=kJoYRoyV; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) IronPort-SDR: P0+1TElKrzIcNzELQZDUC6yNMtH8KS8uj5QIslNjKA4h0/vhtw2E4aHluwS0xATYCKwKzffN0e MKyMxpXLlGTw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="179538075" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="179538075" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 20:17:16 -0800 IronPort-SDR: q4IwmTWFHsxezBZVMQP9u4sizIMKw81rvGNQzSsX3BuN4O6ibmq3ef0v3QW7CdthIiXR1WxMG3 Y4pihfUHDXRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="400394579" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 21 Jan 2021 20:17:16 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Jan 2021 20:17:15 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 21 Jan 2021 20:17:15 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 21 Jan 2021 20:17:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RlNKyxhCUmrbxswP5ZKU9Exl7oF0BrWl/hskTlWhTsNGUmvJeUpclU3WH3bpvPci4hbj9itugbHuTf+O/USsEdQy6v+lJ6lUxY6QUQvb5WQoB4D1BVLPSlRZ3qjtv/TktsHIXwj50urp3aTrq6j9rIbT0+UejKAAuWJnH18Ft6gdllIwpD1EOpjcAwU+k1agr8QRIfJRNsuVth2CeoECwlP2bqIzw8dtXHA8MlJwBxl9wE1HW+8cQr+elIFGQ7x15J7kGKhcWvKnUQWbY+l9ZXU2Ao4dnG90e5lO8EC6te83llfB6d6BdWGrdw9lyfKaY7PtodFUgbt4P/NpolPxZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yzqbl3EGsmYCkLBvIu7yfibLhhYznJj/OqaIsCxlA9s=; b=OZaYd9y60GeYwoWaAZmEisXotZo59POtOZxReWwEu815xsw0Frkzq9jiHyBNzDmajqh6KEriuwql5d2VcNNguw/HqdB8UluU9HNh3rtAHe3qpGbDyCPeb41dsd1pNY2OVUEPdBXoLWgFwa2UclwVwl8T67RMdzEKW3sRdSg4WmM9WzdrWJT5jNPQ4mAmkdbWSNomKMsc+8daqlH7CCfG/gVcMokxVkf9ay/5l5wm8ca9Pss2R0p5h1qid8JkL65cnywd8flMzUP29SWyHsUOsDvuPyQAymX9nHM1V+DEhck6BCUBId/4riEWXh/LOcH9g/lQj4DPBTFCoUBeTv7zfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yzqbl3EGsmYCkLBvIu7yfibLhhYznJj/OqaIsCxlA9s=; b=kJoYRoyVYVDjXIqJsm6Rp6b5Pb/BmDRwV3mB1bTw7GfU/x4LYYcKegZU+AvphRUxIFhswlSyXEuvYCuD3UusaS96B7qFpcV4IAsvfZZCsPVcpOu2hgMsb7kqS+JAU2b2e5qK8WnDUUrz+LtIMQmVRrxuG4/9Nq3hknHXMwh0cEg= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by MWHPR1101MB2078.namprd11.prod.outlook.com (2603:10b6:301:4e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12; Fri, 22 Jan 2021 04:17:13 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::d18:1234:c1d6:5936%7]) with mapi id 15.20.3763.014; Fri, 22 Jan 2021 04:17:13 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kun.q@outlook.com" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Topic: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm Thread-Index: AQHW6sXUrm3oAYMYgUWTtMgL1+3eOaozFAUg Date: Fri, 22 Jan 2021 04:17:13 +0000 Message-ID: References: <20210114223637.2737-1-kun.q@outlook.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb762104-80e9-437f-1eab-08d8be8c98ae x-ms-traffictypediagnostic: MWHPR1101MB2078: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J0KEBnkViUFWn4xKR+NUga2f3JctBjzB4fgLZTo537M/gWtSk7h0TVqdoVGP49mCBtnEB9A2X7ZRT4eAt56mf6dbKV3BqdPflKUTWdgLEJhdl+AnxkNECHO/ed5/4ncM3XWQs3fV/cu+TJYp/zUfHCRCuxcoGMOyMQH7Jq178+LaJdUk5SQKo5xccgsGdCJiydjUSF5j5w8jaRRKN0LnTEO8tKu1qmk5k+qrg8/ARFDIkY++zgVLd4UKqH3fZIwrVmC3cNWuncC1suyCCP314hxjlZLMu9yjN6vrQ6PU2jhU/59OrbcK0XEOl+Erj1qi8qeTUSxik9Qh7YJx933ALQfuXEaLnMfi946d1WE5Q6pEuWKhtiv5DoHmGQPf0KZfw6gVKgzBycwZzLJwRRrhBuMljk++hbfzafZY3xQFo0cbk1yXtQcfrZzRQzBVpuXJUH/l7Dvblb71TMWAh8TJ8vAJiaQ85bxGLHge+0nhX3nvOnWMhh77RDENosih7b6+3Wdc4eVZW0C6DxPhEzocfA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(316002)(6506007)(107886003)(4744005)(64756008)(52536014)(186003)(26005)(66556008)(110136005)(55016002)(54906003)(4326008)(66946007)(5660300002)(66476007)(76116006)(66446008)(7696005)(8936002)(9686003)(33656002)(8676002)(71200400001)(2906002)(19627235002)(478600001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?2+7NzoBDu9w/zmnt3vsOzZ56jfgWiyG9zAl+9IHrcsVMsEqUDRMZsKOjRtID?= =?us-ascii?Q?8PMl1NM992VJuKTmBfot9V3wc7AbY2xKQL4S7PnFfHkCz3zp+YYWOj0x4SmK?= =?us-ascii?Q?W+jZTXNvs+uc3G2is66KI1nqqkLraYpFScHUJid3iczd68lebSlRUcic2QOz?= =?us-ascii?Q?6eJXMAgQk1dY2q9mOrqU2LUsFmMhkHjmJ2Gx6MvI8jUn/tRpUGLb9kUdkMHM?= =?us-ascii?Q?B4esw0/MJ2HrWW3MSa5DSdS82VfnupOUpT2mQ9SrFzTm4/cNzLzXtn5z17rH?= =?us-ascii?Q?fkEN4cy5j6/YnHALSrAokLrbujv/BFt5ZTVejHd9LJeH7P+okl/HjSUgiZ9E?= =?us-ascii?Q?i/nosszF+Zap7U1YRCsFkc+/1IYXeozEzqE4CW7SjeaSDYhJFT1+Fxq/drct?= =?us-ascii?Q?0rLwjamlA0hZOUPPKVeQ2PFJ+7t68vVR3l183+m5WDwQAsoMspa3hsmwZr3u?= =?us-ascii?Q?8+bvKXjjzILn1BK4EIB1huTa4Ns+ZqZS3MwiqbhgVI+mLrS5WC31BUGTCmYh?= =?us-ascii?Q?kKgFNaLNRVGbMae6r1qQPsduFj7liqYh0x8zn2OFwiLHUzXAX9bUucHeK5F+?= =?us-ascii?Q?L+tnDY2BcBcz7J4opeD8WLTJXDO1Lci6Ep4Q3dPhjlpO7H4O3ghZLza2Gy4G?= =?us-ascii?Q?nfYFu2akl7FIcVHN27RrryEB1D9EMN5gT983fV6pkqwfG6wZlnd1W2tbh4s9?= =?us-ascii?Q?pvLqTQSQn18m9kGisL6wuVVBfMIAuONc/qnTSzAZ3MqRqott/FLXho/a48LR?= =?us-ascii?Q?00M9sOGiceUqmizNvBTs9huK5UUL7Y7XPR3fAXtdTKKWONQcnOAvrGcipyGn?= =?us-ascii?Q?6ZxAcSdqmvmvEssBvb31DQB8demO5Eu0FH+926IEOuPDafRf3YtjUYzhRyNT?= =?us-ascii?Q?Ee/meu4Ck/P4EdYO7pOBoZWKZIe4eGmi8o4bZCf8PJ+Zk4y+/tOWvuANgw+r?= =?us-ascii?Q?Khv3WaLXbkjKx1jUf0z9iDVhZ4w+0l7j8FTmSMUOzBipQ7zVy2KF9A/rqWpz?= =?us-ascii?Q?SE55?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb762104-80e9-437f-1eab-08d8be8c98ae X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2021 04:17:13.8514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iVanRbB2bjWseSiBZscqjTUj3mYDugqkF/USF1++KHbxVZMlFlUW+S5ipjbkf2sDoc5x3VfjkUxjb2Ykz7tboA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2078 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable >=20 > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++--= -- > UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++= ++++++++++++++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++= ++++ > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +- > UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf =3D> CpuIo2StandaloneMm.inf} | 18 ++= +++------ > UefiCpuPkg/UefiCpuPkg.dsc | 5 +++= =20 How about do the file name change as below? CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S" CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It als= o matches to CpuIo2Smm.inf. CpuIo2StandaloneMm.c/inf # looks good to me.