Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Dump hob info from gEdkiiBootManagerMenuFileGuid

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan
> Sent: Tuesday, August 31, 2021 1:38 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin
> <benjamin.you@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Tan, Dun <dun.tan@intel.com>
> Subject: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Dump hob info from gEdkiiBootManagerMenuFileGuid
> 
> V1: Dump this hob infomation from gEdkiiBootManagerMenuFileGuid
> V2: Delete the duplicated assertions
> 
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  UefiPayloadPkg/UefiPayloadEntry/PrintHob.c                | 25 ++++++++++++++++++++++++-
>  UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf |  1 +
>  2 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/PrintHob.c b/UefiPayloadPkg/UefiPayloadEntry/PrintHob.c
> index f93aeec472..b5ea9a17a2 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/PrintHob.c
> +++ b/UefiPayloadPkg/UefiPayloadEntry/PrintHob.c
> @@ -10,6 +10,7 @@
>  #include <UniversalPayload/ExtraData.h>
>  #include <Guid/MemoryTypeInformation.h>
>  #include <Guid/AcpiBoardInfoGuid.h>
> +#include <Guid/BootManagerMenu.h>
> 
>  #define ROW_LIMITER 16
> 
> @@ -410,6 +411,27 @@ PrintMemoryTypeInfoGuidHob (
>    return EFI_SUCCESS;
>  }
> 
> +/**
> +  Print the information in EdkiiBootManagerMenuFileGuid.
> +  @param[in] HobRaw          A pointer to the start of gEdkiiBootManagerMenuFileGuid HOB.
> +  @retval EFI_SUCCESS        If it completed successfully.
> +**/
> +EFI_STATUS
> +PrintBootManagerMenuGuidHob (
> +  IN  UINT8          *HobRaw,
> +  IN  UINT16         HobLength
> +  )
> +{
> +  UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU *BootManagerMenuFile;
> +
> +  BootManagerMenuFile = (UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU *) GET_GUID_HOB_DATA (HobRaw);
> +  ASSERT (HobLength >= sizeof (*BootManagerMenuFile));
> +  DEBUG ((DEBUG_INFO, "   Revision  = 0x%x\n", BootManagerMenuFile->Header.Revision));
> +  DEBUG ((DEBUG_INFO, "   Length    = 0x%x\n", BootManagerMenuFile->Header.Length));
> +  DEBUG ((DEBUG_INFO, "   FileName  = %g\n",   &BootManagerMenuFile->FileName));
> +  return EFI_SUCCESS;
> +}
> +
>  //
>  // Mappint table for dump Guid Hob information.
>  // This table can be easily extented.
> @@ -422,7 +444,8 @@ GUID_HOB_PRINT_HANDLE GuidHobPrintHandleTable[] = {
>    {&gUefiAcpiBoardInfoGuid,                 PrintAcpiBoardInfoGuidHob,     "gUefiAcpiBoardInfoGuid(Acpi Guid)"},
>    {&gUniversalPayloadPciRootBridgeInfoGuid, PrintPciRootBridgeInfoGuidHob, "gUniversalPayloadPciRootBridgeInfoGuid(Pci
> Guid)"},
>    {&gEfiMemoryTypeInformationGuid,          PrintMemoryTypeInfoGuidHob,    "gEfiMemoryTypeInformationGuid(Memory Type
> Information Guid)"},
> -  {&gUniversalPayloadExtraDataGuid,         PrintExtraDataGuidHob,         "gUniversalPayloadExtraDataGuid(PayLoad Extra Data
> Guid)"}
> +  {&gUniversalPayloadExtraDataGuid,         PrintExtraDataGuidHob,         "gUniversalPayloadExtraDataGuid(PayLoad Extra Data
> Guid)"},
> +  {&gEdkiiBootManagerMenuFileGuid,          PrintBootManagerMenuGuidHob,   "gEdkiiBootManagerMenuFileGuid(Boot
> Manager Menu File Guid)"}
>  };
> 
>  /**
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> index 416a620598..3ee449219d 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf
> @@ -70,6 +70,7 @@
>    gUniversalPayloadAcpiTableGuid
>    gUniversalPayloadPciRootBridgeInfoGuid
>    gUniversalPayloadSmbios3TableGuid
> +  gEdkiiBootManagerMenuFileGuid
> 
>  [FeaturePcd.IA32]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode      ## CONSUMES
> --
> 2.31.1.windows.1
> 
> 
> 
> 
>