From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.5122.1628258505668303586 for ; Fri, 06 Aug 2021 07:01:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TIxdUXgX; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10068"; a="193966748" X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="193966748" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 07:01:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="569757740" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 06 Aug 2021 07:01:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 6 Aug 2021 07:01:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 6 Aug 2021 07:01:04 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 6 Aug 2021 07:01:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 6 Aug 2021 07:01:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nwv6bjDSvIXRgsqqsLxqS/eNlN2SAl7v9PK5kagn7Og5S8rZNmuP+xYL29fx3HnohiTAPDXhUOtgCN28tUEVclkEBW35S5OTFbkczz8abKGfDLAAfSyY7hgXftNNBNjXTYYvclU+vFYFfR6FJZ8N5XC9OgOPHwDAX5nvF4n0jGj/UPIEXas3ojx6FmBwQsQF0b8YXRk+1+nElwoxQoRNPn4Lv39m5zw+KNbhDYdkwPnMlCymjS6/LWpSX62JjA6ntaf4vCN26CDWmlSC7HcZogHbLbBCzGDtL3k10mtM3Jf1+ZHdcK1ujn8prJRkb4CGAyKpVr0etPPAUhHwmGnzpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tFE4F1hghY00AhERpvUkGxZjNxmEuAngOrx6yAJBvvM=; b=jquKxBtIPbyHfIWo4MIl4uxgXuTO+jb8JyZCUwdF3dTtprb7Lo68cCIZEpYay33f1C5bijfhQGqLVnhDqvNXMQd3p7DJxlrjg22cwkdvbB7q7iY+1zXQtOxbf2sTKEJhqwLgv0bxUvq9yIf4y2aguYMmxcAkTjkFldZrs5AGor0W39tMHuEJZhsBwoN4kzoJEPej9GQY9Unh1v1wWD/B3CDwDZheKP07pgDbFIe9DFreAmKaHuOa2D0+Ul/HR6ghSGdZrTkhE41ueihKJRyfhKgNX/a5PLX+GW3+q3g4xFI0fwaR/lFXxiqEAy741OEH39A54RxPn824TVbByyB49A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tFE4F1hghY00AhERpvUkGxZjNxmEuAngOrx6yAJBvvM=; b=TIxdUXgXGlisHehznoYVWGufFtWzvb4K0aIcKFdH4jQP6jfxK6pCZRNiRegsulgIf/CU3KZIpMqROxjbkXchkt54McnNr4CmYW1z3BnJZmd0MVRpyJ4UlWnOZP+rBjiw5zjiFalRiZ1orzTIg5ARIX9+EaTO2hvWnmlECpHBSkA= Received: from CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) by CO1PR11MB4834.namprd11.prod.outlook.com (2603:10b6:303:90::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Fri, 6 Aug 2021 14:01:03 +0000 Received: from CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865]) by CO1PR11MB4930.namprd11.prod.outlook.com ([fe80::c98d:a1f9:48a8:8865%5]) with mapi id 15.20.4394.018; Fri, 6 Aug 2021 14:01:03 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array Thread-Topic: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array Thread-Index: AQHXiqbRxWgQ1JnEfkKDFk1i7AYtMatmfzCwgAACVkA= Date: Fri, 6 Aug 2021 14:01:03 +0000 Message-ID: References: <20210806093818.4924-1-yun.lou@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c19501cb-3459-4c29-ee02-08d958e2a0d1 x-ms-traffictypediagnostic: CO1PR11MB4834: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9y6Qzb9Wh0hND92A2kOrsuejLoB8SDY99Xmn11ddxOkrlfFqsGq5J5JbBRWpEfX+nPpXwSN2znKo66Sj4mKqQkfEtKZ3xMAsi0lFs42SgV0FXwyem3T3ASDBPD7O1cRIG+Uzr71mSbeb424DqkSqEoouZ9akzJGFDdeJHHv3fsEYchfSbMZOCAUt0+/4x+QvxEQifol3x8dK/FWulUYcqKjZzFGelWQdpd626OFxPQisYntbSwJDF7C78XV2vz1OAyrCqGA4yoW6u70vlhWfy2eNAR8BB2XMJlFwr0ULk9gZXnAF/UpunUx+dLdYjxLLMH31B8MN3CcFVbLC0B7AOyQis8VGzEHEDa8LT+TxkfQhghNB3yybegEXEcwQACaUB4R79n6Ln2HkoioD6yqV6x3ULo/bnHutruXhhEPEPUjQu2gl646T+kdD+ivgEpyX+5wUXlgnGjeLc361itRYG461QrelgCM84RmxJzLhtWYk7q2fI/oUnbelhVm3k2xK4BSE1fMaYnDyCDUc8WC4Q9ljF0ZRrSxybKTbwhU+vsk7LUzhtqp4ZpV/7/fVKn3AT4K/FRBNYJ7bX9HR0cd1G53GvHJhI1UCDZJNSop0qZ2WScg7SVOxQXPhEbZOpnl3clclDxNkELOeu3uNylkp/8azpGci+W8EMAJKVDg4sLxUYfb4paRxe1xlaEud37rEzIdSQtabaTUmt3APfRDeTQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4930.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(107886003)(38100700002)(83380400001)(122000001)(316002)(86362001)(38070700005)(2940100002)(2906002)(76116006)(6506007)(53546011)(26005)(66446008)(64756008)(66556008)(66476007)(71200400001)(110136005)(54906003)(33656002)(478600001)(186003)(9686003)(5660300002)(8936002)(4326008)(8676002)(4744005)(7696005)(66946007)(52536014)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3bxRlDOW4I2LLD4TB2/kOKsGVpicc1cgwL5Nz+0HOYai+iv0yDolJ4402tVo?= =?us-ascii?Q?ne5J1Az8wbbFicBaWOILF/ck8oIC0c2HZd3ee6+e5E69YOxWUKoWhpEst6n1?= =?us-ascii?Q?MrYJybpFePrcbrl64W09zg4jLuTzasqQtWVIu5wij3+KyHkwWdFzQfRfI/bw?= =?us-ascii?Q?sZ8gKb8PZY5bTN5CG2ZS12qBcQyPeFFbtCCjdjAZZsSbPHq31s7XrWnprj7g?= =?us-ascii?Q?KUKs1nv0ekPMWBNqp85ZOhvlJWnLt5YGjGS49rCxjKKKzMUh5th9aIWnHf91?= =?us-ascii?Q?CPG05K9OSq9W2EsoO0hBl+P+ny7zcAP1y1QAJj7mU1ZKzK40hc7DMQsDoHd7?= =?us-ascii?Q?PJQdFCwU+ne2n8qmGcRplNkh5p/pfFVY4/0DPJNy4Ehv4iA/gF8uIE/hjDrD?= =?us-ascii?Q?6pKb9OeI/d2nJyPLYcf40XCKLLy5taEQcHE9ehVThx+5mQ8d2HMTYgPY1CO8?= =?us-ascii?Q?19x334qtTInlNyiOw2sasKTGcVSKBAZd1wuhecGSK+MbIt3mpkwEvLW7kqxJ?= =?us-ascii?Q?ZQn/EuvlWRH1i+4XCxOjh5iJ6sVKirWlFxZgO3Y9DatDeIByT42P2jgRPpAK?= =?us-ascii?Q?Cdx0NEjRrHsRYiaa6aveTKSU0wC3ktvcQDVRwTXZtzqTCM9dk/nLoM+t+bXt?= =?us-ascii?Q?CFuaiQsxtvp+bQ3a6q1hGgP7jNeJIjyPCfK8t6r4xwfTYPp9bVcoKkL+2A64?= =?us-ascii?Q?+/bONN8K36xmWRS+DLbs9F7TtXUrqWShCdAapSvoqgg5TQpjU5iIClQVjOgF?= =?us-ascii?Q?ohtV2FJzt2J50sIWVI0bUr8kQYAORqi4+zBGUUxmPY6V56NUQFpKCbEpDsix?= =?us-ascii?Q?EcvTlGjNmd2rws4Gjw32B6kEt27M5gof1qpuArn1CNxGw68fluTAWnpGS8NU?= =?us-ascii?Q?tig6zCDTo9YQIPTqKA3PRsxcaj8WOyZs8cpgpNOrheE84l5ZIbyC+cw1GBfK?= =?us-ascii?Q?/dv4mxH9Ubay2/qV2fdY6wh2nPyim5Sagec+rSChZrNf/EN8klr/AUqe5wxx?= =?us-ascii?Q?ItbTIab+TWcSQ0PllP6WQYIt+kw7rq4E6wYuhs9KgiWQesN2z+4SnydOhnin?= =?us-ascii?Q?ZOVjffGUX7rYgIZX/CK31DPC/l91rHedQbZSxC3/ZtjocVq0Um6bxLGiVerr?= =?us-ascii?Q?FEa94agB44iQOLrWNYCqc5srrDKx8bSrbITgRoWHLnUTe9ctlUU7hFaiwenb?= =?us-ascii?Q?XZo7WH4kr1CSWV+SVYRZF7RREJbCRQmuTzrllTEExTSg6V2iTMHyrq0Ga/eA?= =?us-ascii?Q?RqdaaD03cXwX2cz72JfDncnZGMFa4jmos2+he39si+qR67O1DTCvyYCp4lZE?= =?us-ascii?Q?puUDsw1eyfS5p6CVshr1Y1Jc?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4930.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c19501cb-3459-4c29-ee02-08d958e2a0d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2021 14:01:03.2725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1lQCr9ddfsIES35jqOy3fREXg1LDycVDk5qIOIBdbcJj7oQ0W/rkqKULSwWP6kVJTiOb9YdHklByiw3D0gg8ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4834 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable With the renaming, Reviewed-by: Ray Ni > -----Original Message----- > From: Ni, Ray > Sent: Friday, August 6, 2021 9:55 PM > To: Lou, Yun ; devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; K= umar, Rahul1 > Subject: RE: [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo arr= ay >=20 > The patch looks good to me. 2 minor comments: > > + } Fields; > 1. Can you rename to "Bits" to align to existing naming convention? >=20 > > > > + UINT64 Data64; >=20 > 2. Can you rename to "Uint64"? >=20