From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.11640.1645195524910982712 for ; Fri, 18 Feb 2022 06:45:26 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DIteicUU; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: maurice.ma@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645195525; x=1676731525; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wBlncITNpO6VbhGgY6PIVlkBpH3vQAzXM4LyK9H9pd4=; b=DIteicUU9KSC4XXhT7tN5WW93EVoL2bghCnOxo6XA3gRgeU3T2vUtcZp 4ger6HC2ZFvGlRbb+YpwFrvdHB9bEDvlr5NG1mZdO6BkL3FpcaG+53HvS Fv7Ccsj8vwiv/gn5M57X2a5Rmfh10XD6UrvP6zcjS69Pf/dqNheZw4qfr gmprvbwLnBKEz1J6Jqtvec40uLROvqIFJTfYii991jQvbldq72ua38Dcn ZXvXsCM7jc5L4BsW8GBllXcaUWm7GQCTbehbuCVuSiHCTop/vPnlMp53P t03THiCIs534OGwX59EeumMlBU6eWv7+731eWuSz6P/M2OhtSh8HTu9d0 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="275733304" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="275733304" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 06:45:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="489493966" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 18 Feb 2022 06:45:23 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 06:45:23 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 06:45:22 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 06:45:22 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 06:45:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L1xLf5lvXwfywqMv+Ufqc4W1Kq8DqZ+TqlN1qaPHQx4pfd2Qjk3c0YMNM8pYMOZMWo4cbHY3Lvbt1eXaGCy+grgpI1ASHOG9rHe1y70MNudvhbQL8NUVdlA3RreOfHON1G1IPwqpX3cdJYSalgr2bkY1xKCMX+Y9e0WZ3CBqe4lOmmZAAkZuyW+OeedyNFjjnNmhVekrlCTWYDdADX1mtGSjldBYYzuzE3A4eFeCLH4N1IPML8oHXXT1A8X+lzvJvux1sctyn+39c794LMiphMbo1B2oOHnA48suqdFWI4b89NPgYosg9hsGkTpmuCB+p7mvxJEexz+l3/gWFGQEog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/jzaE94/fBCNFehPsn57ZJj7/xpmBA54yPtjC7tb008=; b=fRvhb/td9+NHW+8v73O8nfByRVctipRnn+f3Nq1MoOEMOVKgPxT7P3lPMTog4Q9u0lvQQJu3aT8P1L9St5R+nwnANa3vwyLaMttLqySfioMRzJTUlbWgk1NJTqSdsU1HGG7HmWGKY0mhWetuMcPxiDQ9Equukcd+6qbMNdfePHp09cmt45r2O7RhaHkb+dbOlXlvshWph7of3/uD31xCt+hLxDcCwYgLlyWmbBmDrGL7N+nVSHkeAvpKqD1ft0NcnWK/jbH4K3U5oJNafJppUnFbiTeb6POusOtAqfwCBJ9TauQMv/USywLZhsdzUOkDH2riUusASGZzyysKu3lVew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by SJ0PR11MB5613.namprd11.prod.outlook.com (2603:10b6:a03:3ab::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 14:45:21 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::c9d4:be7:7abc:48c0]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::c9d4:be7:7abc:48c0%4]) with mapi id 15.20.4995.014; Fri, 18 Feb 2022 14:45:20 +0000 From: "Ma, Maurice" To: "Rhodes, Sean" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" , "Ni, Ray" , "You, Benjamin" Subject: Re: [PATCH 2/2] UefiPayloadPkg: Hookup SD Card timeout Thread-Topic: [PATCH 2/2] UefiPayloadPkg: Hookup SD Card timeout Thread-Index: AQHYJJiEqSyNiVWE80+ejW+Ryymqq6yZYGgw Date: Fri, 18 Feb 2022 14:45:20 +0000 Message-ID: References: <58e761ec0ca27ea0cc2007387309b94105d9ef57.1645169028.git.sean@starlabs.systems> In-Reply-To: <58e761ec0ca27ea0cc2007387309b94105d9ef57.1645169028.git.sean@starlabs.systems> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0be55af-7a88-4707-f75d-08d9f2ed49d3 x-ms-traffictypediagnostic: SJ0PR11MB5613:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jkCWPyGLYom6O5MBwy6Pf/3wK876wB2MBj+XLZa+Jgau7E4dCjV+b8BmsNlHGxR4qxtNHomWHAX3ZRecoW0nljVldeu0vA8upDfZC188qs+FWDNa9ghO6Sdc4m4NCpoL2tOodgPSEbDR9LFj9f2xE+pGRR8Fhk4rmH5X3ce5agQv+g8lywnx+WxRd5Jv8w9cyVTZI07VHDucBIk439PkWeGzb1GQqsDoCzu044z/karqR9cIzDQMhwWRyvX+XeDAxRENkDJr0sKGq2DjknZQcMg8jaAzfQd6gz6Lsep7auIR/2JXjGPWtb3P06Ci0OUzGpvPMPvin8S9S9AM/cHM6C2GllOq/Q6cvf/bU0gmOaPVne9l8wuJPs7t0dODmAWKX94WHrtxmTeoRDYBrN36FHPmsAZCO7/XspmncZqYklCODtOZhep19IwNLit5XspiSLU05TSR13dI4x2kd/RIdsZVJvGsD57GgQsfHYimwo0TdzZLu1YGSWf58MUrucyT7McJSTbdkyIm5hpItaVPS80bhcHnyfdI3fraNnzbIAO7AuodvG1LhT+b/Fiqa255+8Pj2+qgpWnGikDgDsGQa8Pw7VDszYfmCVg1TNuokFxxlztZstUpP9cY80nVyozXDW3onm7i1kuRvuIR/pVY+HJf8Dxqrfeg8HKG20Dm6vFaM2/3L9PDAlCDTjI379RGlW3aWSotvwnNpBJi6NpwjHA0y/dz+aAJ/4NMmHdSQc+H7NXZidkvtqivMUYpIcQ/9y4BdcbmNiN5iMuynQO+DQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66556008)(5660300002)(66446008)(66476007)(122000001)(64756008)(4326008)(76116006)(66946007)(316002)(2906002)(55016003)(86362001)(8676002)(110136005)(33656002)(38070700005)(38100700002)(52536014)(82960400001)(8936002)(71200400001)(7696005)(9686003)(107886003)(6506007)(508600001)(53546011)(26005)(186003)(83380400001)(54906003)(52103002)(158003001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ERRr0rP07PsFk/4xfKhZk96V5Tfisgy8BBKgLByKEaW523h4yyyMKUXphORk?= =?us-ascii?Q?3ng/QsEqFc+Xm3plluEIpQ83s3VTZXXUHLRaNBXIknYMB4NWdEnTrd8TDuAW?= =?us-ascii?Q?gIIKXuw+DOQ2o39M4fMXTLZAAQBHAo4QtRj0sruZTq1b7mvpodwI99tRuj03?= =?us-ascii?Q?uzPFcpMPmKhBPyn7QIFYLbPOBRGt7/xErLNu9hcrdGJnm0wdWv7GJMn92X1J?= =?us-ascii?Q?I7c5sdQfJKYxrh2uXqUOTCH360VUoIVlQU9sRwKcthSzFupgILgiWiJYeLZt?= =?us-ascii?Q?bcxooLa78/t5RlArXw4eRbl0RfRkW43vSKhbwtXa73bmO1I2n/XhqSiR6w+h?= =?us-ascii?Q?SdfXlSL5Jl6rvCD6zAgWsvQOGP2pJMZ5AsZsdmBDt+TzvI9XB0+cIM/0KYnW?= =?us-ascii?Q?KoDpYtkevc1Px+hJ42YDzVFPpm1aWB4b3k/ddXmmzWzL3HB7OdVNr/DLZZpC?= =?us-ascii?Q?fNk7n4WydEtsjmRNIXOqfQjlHj37m8Qn3hbxzCa4TUy/1TjUVVjxXPFwxEP2?= =?us-ascii?Q?PlHXi2Ge/rXUgIzhNiZbcOiX70KRk16zC2w6RvbMN3XPa9y2l2wLAGtqa99P?= =?us-ascii?Q?PvaQWk+cN4vycmJdpPfyzV6dYQDD8shtRf2ZJ1vTkiqq9XR4ZxFag/VDG/qR?= =?us-ascii?Q?fNjV7X6QFEx0kwVA7VWC8hfx6yilCUokOFJmg2HLi0q/HTjp2Skfj4XONUHw?= =?us-ascii?Q?5c1DAM8+TNOzprtFIwg+iFhZEUwqUOREWadHCUQDYqobCu7PQsoOs4pxrjQT?= =?us-ascii?Q?Tw7dgPciiv2XutvinnAvIHOs4Nk55Q2CMLBz4hO+BFjlreCkj61y+Iba4xa1?= =?us-ascii?Q?gDYx1fqgJ54gOzSKzubGvCHvownsYbTYEpeLjnW9vTMluLHkhAjhIcgMmgqw?= =?us-ascii?Q?Ff3M6d4gCQ4QlgbdgiGeVqcXwb/7tQ0w2O/Fvz7Hi8R9Px9aniJ+6TjrVHvA?= =?us-ascii?Q?fTGzfa3wTUMtmvFZI8VtmZfgjvO3PtvFqsmqeOhTMaYGUcI4G373AwmqO1Td?= =?us-ascii?Q?S68rOEqVfw7mZy2Cnk0AZl3gJnIOUTpxcDLCh5wZwBIU8dgEB0KXGvv5geBI?= =?us-ascii?Q?trCBSki6s4wkBs8+zjIHcAxhflNy3k1lUSclbMWqVrQNvLGfZWzhVrFxi1yO?= =?us-ascii?Q?XuJ62BqCUmp9azWu/JifMVv0kfkbzMsQg03eRYaRqirQvaGT+noUNt+Y8ihB?= =?us-ascii?Q?iOl4T/h6JNoDL2/69WExfv9TGft+6gwQe/AJsw08jw/uyZ7xOPuDugVK6Xr6?= =?us-ascii?Q?1zpKFvM+/ZL0Z8JSnsDU+7TU9R6fZeA5xO7Labpv+uiY4pXAZbSFrReMQgyN?= =?us-ascii?Q?xkKMZXf54l/rkBkJvNV1h06s5RDD6QVzOp6dT8IDWdNPQKaPLcBuCJzuGDhF?= =?us-ascii?Q?VCpokWRWD48/ZGlJH3umRRG2ASVyvysAitO1gA6/1b2kh2g6Fjq0gxsiKswM?= =?us-ascii?Q?UBt7g1ZeD/pgfnFaLnIaCPIV6dVgvpryg035zuQXOr//B37bbnMfsL+UJ1Ya?= =?us-ascii?Q?yLbJ9TKh0Hnrg6DEn5IZytHOHpqDnRlclsjjPEATfoK0Swlb9zf46gISAIP9?= =?us-ascii?Q?bUcyK4kyVRIKPktznc5jt54zjMaXQOQKrKtMLJQn9EFbWQHre2HVnRQCQuNl?= =?us-ascii?Q?0bq0UHaw0NLp+42RVYAL3c4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0be55af-7a88-4707-f75d-08d9f2ed49d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 14:45:20.8028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7ZnxhhbgDCXI167DfLfGLRnOY0WKKd9NQjQok5/PMsVpqiJz59T6s88FdCoPhJpZrey+toLnxJfebevzHcM6eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5613 Return-Path: maurice.ma@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch depends on other changes in MdeModulePkg to add a new SdMmcGener= icTimeoutValue PCD. =20 The changes for UefiPayloadPkg look fine to me. One minor comment is about the macro name. Is this new introduced timeout = PCD applicable to both SD and MMC device? If so, "SD_CARD_TIMEOUT" might not be accurate to cover the MMC device. Ma= ybe use "SD_MMC_TIMEOUT" ? Thanks, Maurice > -----Original Message----- > From: Sean Rhodes > Sent: Thursday, February 17, 2022 23:24 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Rhodes, Sean ; > Ni, Ray ; Ma, Maurice ; You, > Benjamin > Subject: [PATCH 2/2] UefiPayloadPkg: Hookup SD Card timeout >=20 > Hook SD_CARD_TIMEOUT build option to SdMmcGenericTimeoutValue PCD. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You > Signed-off-by: Sean Rhodes > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 1ce96a51c1..d75fe26426 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -33,6 +33,7 @@ > DEFINE UNIVERSAL_PAYLOAD =3D FALSE >=20 > DEFINE SECURITY_STUB_ENABLE =3D TRUE >=20 > DEFINE SMM_SUPPORT =3D FALSE >=20 > + DEFINE SD_CARD_TIMEOUT =3D 1000000 >=20 > # >=20 > # SBL: UEFI payload for Slim Bootloader >=20 > # COREBOOT: UEFI payload for coreboot >=20 > @@ -398,6 +399,7 @@ > !if $(PERFORMANCE_MEASUREMENT_ENABLE) >=20 > gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask | 0x1 >=20 > !endif >=20 > + > gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|$(SD_CAR > D_TIMEOUT) >=20 >=20 >=20 > [PcdsPatchableInModule.X64] >=20 >=20 > gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER) >=20 > -- > 2.32.0