From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.6986.1646278039644834578 for ; Wed, 02 Mar 2022 19:27:20 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Ocghttcl; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jian.j.wang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646278039; x=1677814039; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=+nivg/sitkYWgJY93b2VJrMsqUOW368GDopOw+yps1I=; b=Ocghttcl8o0qANWfopJMfig95ibHvclM0/oUroLFXdL6c8p/nQmFDuv0 EcjLZiheOz0ukvffv3PbA5FQE1xcBSFrrcU4QjN7CL1fW4o/BhEZT7HCg 6IKRuBat5Cn1/iG7+XpkEF6NARLnXiZ1Hf3OQeHwKv7q55g/TjFTltL5V PT1cF3AlKQz2pUQHD/r4c0H98oS+NJ3I6TpmZttFujDBYnjUGn79/SgJi p6x4HlF2qBUnMGCMa7ydwKBV2yJoldbY50PkFOiarhAsxIbeigHcN7wVX QHWKJudfy02QSqsXtkKVEQbBYhrreaBuy3gpvo5Id8VxYJ54vIRDXsfoG Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="251143559" X-IronPort-AV: E=Sophos;i="5.90,150,1643702400"; d="scan'208";a="251143559" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 19:27:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,150,1643702400"; d="scan'208";a="535645705" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 02 Mar 2022 19:27:18 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 19:27:18 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 2 Mar 2022 19:27:18 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 2 Mar 2022 19:27:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4xKoSRYpHsIOcfCmi4ZD4P1MD4bvY9j5hAhRpdGaGbLnMwdC9e3/K8XQOAjE0azJ7tVDjkWwiqHkhE5NcnzKZ8FjNcSaswMmnVcXuBGfCM2FC4pB+ylG0JpIJ8E4HWdXfn2l2C+XVirlkSFsb4ix1ZzERX+UN/Boeuk0bQt72SoHcrtCw1ZeXeuwanAVzE+DTkMSTda0IeDQol4ze0Rxbr1G3jb5shbb9S2OGwa0gzybREo5TnQa3BAFerFWfPKAbsAp+qo/ot+dJlcpz210D6CGfqbcC0Zj2JTwueDygznc7vpiiAdzPO/cU5dlFTqWvjsMGGoEtCwhVj4zTRZQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BLGYQjH87wpOlrYmk+Ad0ia3OdlATZjZ/rYeMKhf+AU=; b=MgRMxVcZoL6oVrUEWlmJ0tCY8p772rVb8atFbzhuAvTJ+1CO/BRWHuJCE7PxOJ9H5rWeEoOUBt1YOqg7id5ngy+Lh8MJ0S+J9t6MuUT/4t9upY0y1pHTJmwwOWjG1qDeq7ujUUe4LNpQ6Xil5pUtUqYq5LCvt2dncLX+JiHuzkFbVrAbqPmd2nE58y7jAtixI6w9hZwzL8pVXUZbA5bRlkuGDpjUNL2h+GAaXffdmtOiEMcjKY1V6uKdjXrbW64p6PCHV0E34kxL5Rt5VhDKUBr+2nEmtO+qIVJcMaKR/xwTCaAceJrjZ7Kl8tjhvrGS2HdV3d8gYx55XVCi6g12CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by DM6PR11MB3769.namprd11.prod.outlook.com (2603:10b6:5:142::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Thu, 3 Mar 2022 03:27:15 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::c9d4:be7:7abc:48c0]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::c9d4:be7:7abc:48c0%4]) with mapi id 15.20.5038.014; Thu, 3 Mar 2022 03:27:15 +0000 From: "Wang, Jian J" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Wu, Hao A" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky , Gerd Hoffmann Subject: Re: [PATCH V7 26/37] MdeModulePkg: Add PcdTdxSharedBitMask Thread-Topic: [PATCH V7 26/37] MdeModulePkg: Add PcdTdxSharedBitMask Thread-Index: AQHYLHP7ZAMY3wXjZEy5xu5QodEZ6KytAtQQ Date: Thu, 3 Mar 2022 03:27:15 +0000 Message-ID: References: <19e78590c90f510b13230ba9eac7b58f87f35044.1646031165.git.min.m.xu@intel.com> In-Reply-To: <19e78590c90f510b13230ba9eac7b58f87f35044.1646031165.git.min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bde67d97-59f0-45bd-de19-08d9fcc5b6ad x-ms-traffictypediagnostic: DM6PR11MB3769:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tJeOzH/qq7w+er3hSsnNvxJKJeLb3OwfDRj1XJEdxN9woORX0siYzl5y6W4VRahgfWvQXm4Z4+h1j8U5HDz+MQtk5XBJ9t5GZ4EEEKmvnFqJMiFuQcsgl2ezcxw7lumERyFGpdMH2dcqjIiKSyvgOKyWG0Glq3acye7mXfj56HLQLtSNvHPmcRW7rxlpzgKSsY6qiLmJaUwNBWTBEwVZKEgjNh/ZwZffXmVRCKGkhIQR+NCfkfuqwMFCwAlDfjIcmxnxvcxrndpQuTFi7D1ys2yPNZhzqQUNKbSgk6tSenD+Ov0lUIUfQvqGth+3vyG+XLqOq+E3EelURVlYKijH/Wr0On3ZQxgJ7zCOjmrWLr+A5gPF/qGphgE5fhbRmK5N6WQdt+97KxsPG5EAGE/hS0lgeJS7Bu27AjmhYNOkxICAmHoxgXxAsC7eVLKfC3ot37oXllzpysWTkoICbUv0FJJwJ+Ermm2GEAVxm+/14Z0iQPctSyBpo6hydKjtBPWDN8n3xxl9CkHUyqznlLp+2ZCZM2qxlivzbxGV1kMCungf9h8YdgJUK0qsox23VWMKk2QiO7hektVcJ62xl/PprhgU4ayWZI2d6krvhlYW/uROc7DJdtiPQlYKjXDh7Y/KpeKyg2+Ifh7w8q2PXnF+9e5iR3mOb9EU2R5q8LjVSCNJk34USf6FjM1+AIFWCmLY86ywjD93+oWqdAlvw4mNCh93iwi04iCbKNXZX9Y55yhqBUp5/ux8GBt84GvyJ+ckz82lLxE/RkarQ7J8uAueXEHDSaovnScddaCCWjXonzSVTuJ7NgadyTV/YsXcrTVTeLQKGlZUXJxPvS6hTmevz9YZe5hjEpBADA5AX7iMJmo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(5660300002)(82960400001)(4326008)(38070700005)(38100700002)(8676002)(2906002)(66556008)(66946007)(66476007)(33656002)(76116006)(86362001)(64756008)(186003)(66446008)(26005)(54906003)(110136005)(7696005)(6506007)(71200400001)(53546011)(9686003)(52536014)(316002)(55016003)(83380400001)(8936002)(508600001)(966005)(122000001)(156123004)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zXob6ThzGjqB/HVCnyYMwnh7VE91poM1Czey2oegG1d3jaUOOc2htUF4HIQ4?= =?us-ascii?Q?93bM5C+6ZudrVAPkilT4XVBnYhnm0Watpfe5U7hwb4w4VZox+VRoBUlZMYls?= =?us-ascii?Q?E40ooxue6kx33wFt45JeVJahFCATBJna4c9C7Enyio0nG2d/Vxlord47CM8y?= =?us-ascii?Q?pceKRfY3odx2cocQi0woHJxW2umCZV7DbWF9v3sGDaXEd8vL4+mGuSExPLb7?= =?us-ascii?Q?reuFx1jD+b12PyncEcsf1+VwFiFq9RlSiuyKj/1//0spOqDKD0hvnkWm9+C2?= =?us-ascii?Q?G9xqvv8LXZtNovQdEGblvedWNGpl0CcPj72+Da86eIgCMxJsGFG3SSUqbEKi?= =?us-ascii?Q?6HN/o75btm9JANs3UMFeI4/brcUW3n2aGqikMZAlEpD0jGtJHrw/It35gmM5?= =?us-ascii?Q?Pb922RE85AfQqkZBW5HArgunfvSZrhYFuVkbGdCWF1slc7hyJS+M9aQIeTAy?= =?us-ascii?Q?NV7RKvYnooZ3Lqf6sgtxB0Cq77C6ZVkpirABUToLs9ICpYoC/PL7fVWlnfTI?= =?us-ascii?Q?zzS1TkvHBjiaMOobWoEPbfGt0KDphbarNKzRCdvq9+NvRdp9/kWoFbmGyyhN?= =?us-ascii?Q?Ey8cOuxz/OA8fgKfqcSIDV1M+mFC8g4zm4wRN0Bi7hnDR5zu4C+O1kRv13vg?= =?us-ascii?Q?vUcen7hU7wRi6kqr4rVkEuwFnbxSAFBVirJ7KmkimNlrOG23uUAA8pZtME0S?= =?us-ascii?Q?7FJ4WmNG2ZlpJzHtFD9LIlNTGs/2BzJSTCb1HK3QlRxrZC/+V9cGpNNXapOl?= =?us-ascii?Q?6JTyL5JF3mPNZUq2iiyn2HnUP+fCXJ6FWgmg74R7mXDjH/D60/BbNl+7p98M?= =?us-ascii?Q?Om4zjjyrRBpPnpv2f6lLnMOXkNSKXZIGYp5XL6MuU+qzdEbG+ookTJt+dRg9?= =?us-ascii?Q?TokEoZHjPX5/BUgJtqBpoSMhholhPk1akI/967JlLX6QzcVRQeN+Xro6XN1Q?= =?us-ascii?Q?E9fI7mPb/j9wa+pTdqztPEIDFr641YWUX8e+//HtGd9PquMXeRkAregD4S4e?= =?us-ascii?Q?W+/bmduVfJfqwJZEhvdSGaNnxUupMuNc7TKo2Ag98z6oLaps9FROsCnngGuT?= =?us-ascii?Q?kncSdDhSo2gkNFzQ+AxHUowfSKWUe3PTudytMayFcK4YQ3Rh+j8M5r9d7PFR?= =?us-ascii?Q?az8fh/glZcV6lXKkEd7erbFvlyza7shI6nAjCPdxkbw02vBQ+uu2y6fcbVCG?= =?us-ascii?Q?tSvEO1zKKtf4x9I/CRYoTN2qn0WNq7QsFHN7D8HhfJdK8M7tOl9G2gw9lX3C?= =?us-ascii?Q?w7MGpfXLS4YxuvDZcOJeQh2EmVNAZftLQJS/I52XIkkShhZDuUcM0HttYlIp?= =?us-ascii?Q?VTAjmZ5Nw4EYbCltJZmkKntGP2ipcxjmfjnW5IArJhEByygXnSLsKi53+gC7?= =?us-ascii?Q?phI5nQkVBPFhbNgsgS9YmyGIVTD/44Dx+4YIbN6KqT9X5Dp4M7I+WMC6ekaH?= =?us-ascii?Q?sp7l+6Cro/JrkZg3uvyDMUc1BhHIHBdlcWOhp34pWr8CWw+fsfv0N5GnUUF1?= =?us-ascii?Q?2PB5Zf9GZL3SkDgOznCFmEFhQwyPEK8ZPrz8Txz3eZnFzD3f56LBnn0tnDlY?= =?us-ascii?Q?EZcWUFEI6nZlD1eYHYSoY+CIe8gyxETb/fzGZlTgyEVViXsdFNhXqUk0rYld?= =?us-ascii?Q?M7zlA4clfEMY+iD8iOd6VaE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bde67d97-59f0-45bd-de19-08d9fcc5b6ad X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2022 03:27:15.1187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u3nA6dZbyPKm/ZUaro9Xvq4y79KbV6sNnBNK0wxDjMuuHz3LbCgbNdqPxZ+BOP25okRyPCG/vUf3c0xfBHRoSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3769 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Min, Similar to patch 25, I don't see the needs to make this PCD dynamic only. Do you have any strong reasons? If not sure, maybe it'd be better to put it under following section. [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] Regards, Jian > -----Original Message----- > From: Xu, Min M > Sent: Monday, February 28, 2022 3:21 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Wang, Jian J ; > Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann > Subject: [PATCH V7 26/37] MdeModulePkg: Add PcdTdxSharedBitMask >=20 > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 >=20 > Guest Physical Address (GPA) space in Td guest is divided into private > and shared sub-spaces, determined by the SHARED bit of GPA. This PCD > holds the shared bit mask. Its default value is 0 and it will be set > in PlatformPei driver if it is of Td guest. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Gerd Hoffmann > Acked-by: Gerd Hoffmann > Signed-off-by: Min Xu > --- > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 453f2a74b11d..e90a7f38708c 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -2143,6 +2143,10 @@ > # @Prompt The flag which indicates if IA32_EFER is allowed to be chang= ed. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdIa32EferChangeAllowed|TRUE|BOOLEA > N|0x00030009 >=20 > + ## This PCD holds the shared bit mask for page table entries when Tdx = is > enabled. > + # @Prompt The shared bit mask when Intel Tdx is enabled. > + > gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x000 > 3000a > + > [PcdsDynamicEx] > ## This dynamic PCD enables the default variable setting. > # Its value is the default store ID value. The default value is zero = as Standard > default. > -- > 2.29.2.windows.2