From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.13395.1661135066504823791 for ; Sun, 21 Aug 2022 19:24:26 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jdvLywT2; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jian.j.wang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661135066; x=1692671066; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AzoSkYf87n7bJjeeuMmi1VtN+yE7MS2k0Omdh0Wu064=; b=jdvLywT2z+zEIu46AQqI70V6ovLbffxSB2xASZhL1csM1sGr/qcjVSZS Od5r9sU61An7rix7d6+EIruQGOApDOBv0gjK3IFx4hZEis793f0hXq4bI Pm/KpGYnZOaWOrpWlLpr6/cmrSSR/JGvCqxQlAI11iMetZDckJ6ClH0MC izdso7FiExye6Mb5voVRPPUL92ZXcc9DUhAeT93a6BnxChxGIpw/moYDI OFwcbrfTYkJ4V55ibvImZWrQUuLNknTPfhbg6ZFgVk1RhWxKpIKm8687P rcgrgiH2qXf+nJlBJI/sZgIPde26UJs6G+tAFKRbldZ2dAJe5pI2hSnbX w==; X-IronPort-AV: E=McAfee;i="6500,9779,10446"; a="293302111" X-IronPort-AV: E=Sophos;i="5.93,254,1654585200"; d="scan'208";a="293302111" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2022 19:24:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,254,1654585200"; d="scan'208";a="637984893" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 21 Aug 2022 19:24:25 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 21 Aug 2022 19:24:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 21 Aug 2022 19:24:25 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 21 Aug 2022 19:24:25 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Sun, 21 Aug 2022 19:24:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RCC9H+imG0r9/ohCASHEVm/aee4f8xA7YHsjJElYlxXmG4YAcZXPdoM1qHmfO3s0LLCEqcY3Sf0PtzB85CXYG+cGMiOBW2l9eJB2zQAa2Ps0n+cAvchWFWkeVo5W4tPKGkm9uKqdIImCaMNWNs0AFVlIBAr0DGTkw1gRitPlgc+ReqCmzHJyaqDEjElFw8KwjrI0+IEvScKk3FvEHHiUBLYinbI6vRURXPTofIcEdlpLTXEZowtaDJ2mlUqXa9fLNKtlgJmZG/ALABXcOYQnRuoiwzsXC4zb21ZPj23y1J3CU0O2IWPmgPRr9K4NhirMtVRzGGAxXLTTdGUmO7AyDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DG1cX/GDus12y68asbrflMgMCna8MQzqnFlmMtvrWOc=; b=nwv9Jcl+2EjKU5z35w1kl+yn8CIB0i4ZHx54SlHo/fFZgqoi7XCl3fiqjRR2nAgY6N2Z2I1OOP3IFMLHrHXOvicYMeAUdo3aa1yQFm84Z8kW2TUvLHSmdkGgpwPDBfgd82N44AHBT5AcKaIK2A4/lmuTDsKQWucMYmGYDlQp48sfWxBwfOLD5OTJ4YJgsMidZ6SNvvI/kOqm4v9RBiEBhqroAZKdud2cNjyYXq4XYFGatBtJW/KDiVZ1PplppeEWwbablXG3chdwGR4RF3NuyjaI2q2/E0ik2N4bqarO6HOHrDS/ehQjCd4nCX/wnT/CSspS8Q2oprEhPCP18bqUuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by DM6PR11MB3337.namprd11.prod.outlook.com (2603:10b6:5:a::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Mon, 22 Aug 2022 02:24:23 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::ece8:740d:999a:e17d]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::ece8:740d:999a:e17d%5]) with mapi id 15.20.5546.022; Mon, 22 Aug 2022 02:24:23 +0000 From: "Wang, Jian J" To: "Vang, Judah" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Mistry, Nishant C" Subject: Re: [PATCH v4 11/28] SecurityPkg: Add new KeyService types and defines Thread-Topic: [PATCH v4 11/28] SecurityPkg: Add new KeyService types and defines Thread-Index: AQHYrU8vEP7p2/WSnUuuCOO0HIcZ/q26Qeeg Date: Mon, 22 Aug 2022 02:24:23 +0000 Message-ID: References: <20220811065337.2068-1-judah.vang@intel.com> <20220811065337.2068-12-judah.vang@intel.com> In-Reply-To: <20220811065337.2068-12-judah.vang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 680f3a0a-2379-4980-4cc0-08da83e56d88 x-ms-traffictypediagnostic: DM6PR11MB3337:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6s5kS8DelwS7JzdEt0atktr+3oxotuSUpU3sM+UzFbWsktuLTXuw9Emy3ui1WVN5qpEvgJlyHjN6QQfTZv1Hm6/ZhewV6OpM0Am/A6llgKl3MbD2a/378H49FQbeOZEX+r0C2hLQtp7sB6Me1y6DbkfcChXFJ4b/pUrMpoZkVAAsIIRtGMU21A/prWoie/cEzFs8RdSJX3eD82NSk3dDHHDLs9OunsxSMZobKJI7M+VMfJ3/e/qYtKbhytcPFE3o3fjojEK6BUDuNSbSjs41086R4Cx/B4G6RV8v/sHzyc8egz8Sk91rpjayCbPB99f0ZLjVKdRqBptiTB6x53lDv9LqScT7sD9LtAXc5sBUr5eq6R0EWrbNYrHtQ3ItbrTQp30GmJVemoDZ/sopjXiH8gFuQgFkcsVFvHTHZFByfzK2J2W7aPgZse4RIszV02HafoRXIkOrfx0PHtbMWYVJgKKwUKmkCKpg5Q35z+8bvxv7jGWg8Fm2FF2HRopJuykW1fvGXwTOLRIPChAKlP7ykFKIiZ20KuHomud5Ic2FLFQyTnM7qzEJWoX+cwu8W2+oHMh7PFrjyCmwTVG2egr4OVGOUVPz8jcT/ach7CiDEEO5gLSZ6JgnbwLAvwMvVIVmSg0xhHna48A4+ncLDTdxEDB1N3RLo44Cf2Dmc/56j3ilw6GpU4zEWPdSNTFY5cxg7BsUGTLGIdIAZJVhqWWLYBaF1qoHQZNpqS03qV1HuLfQV5+g5Nlv0E4Gs/Dr5Jzis33aG5xUA+uVgLEBCPv8ltOAxz+wPH3oxfBSrBmsaJw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(136003)(376002)(346002)(366004)(9686003)(316002)(53546011)(7696005)(6506007)(82960400001)(55016003)(86362001)(110136005)(41300700001)(71200400001)(54906003)(478600001)(966005)(38100700002)(122000001)(186003)(38070700005)(107886003)(83380400001)(8936002)(15650500001)(2906002)(5660300002)(4326008)(52536014)(33656002)(76116006)(64756008)(66556008)(66476007)(66946007)(66446008)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pW9whPT3rQaI2D8f1ehHEVXD3szFUkF7eiLITL9EU+k8c+nieb7DIGiu3V+6?= =?us-ascii?Q?zcMnsnJyHGqFIHbo/RqQdhrJsmTMgMAStqpab3npjchqhjVxiJjHkbFrJcr3?= =?us-ascii?Q?r8sZb4IokjDOiGIecRFQGNKsyCxjvHwkKFXLZtJuXeeC+TvzlQ/XfaQZc/dU?= =?us-ascii?Q?TMJErsfYDxJWZGKdvEBfgk2L0lTfmBMWynD7Zxd+NSWrA7kr3OwYNPVi3h8u?= =?us-ascii?Q?3lUZ4nFkLrZ9PqxeY3R2D8Ew4NdlMtLSwfg7XsyHuLRHtlzVG9br8GPZK2Et?= =?us-ascii?Q?1X1T2yACuVWrlVuFkBd7RahsEOn+RIDmW2Xof3Z8R/DxgNzL+t6R+6EnDPA2?= =?us-ascii?Q?h/ptQSxzwjqdnbZrf+23NXt63bq8KwjglAm3iwS6ACToWTODEpEJbxUvTgGI?= =?us-ascii?Q?WAbs1eFdtzypKHdE3bU3bhCOBqMEKsE5uyqh6M95rBPX2sYZN9zWSy6ZxYGf?= =?us-ascii?Q?YwmZFf1IuvjTaGcSezagS8Q4TLZLZBJ44gByXEzp9W2I/u8k9As+0tWnjhJC?= =?us-ascii?Q?PQCdEq+FWzzpJpMUJA/FiSa2FHa5F26QLZXng6urvrGQ99OdBPfkst7YoPKk?= =?us-ascii?Q?ync96vaSgmdiYWl1ozZtB0GhQkIeSmu/eCUy7yg0SesVfdWpDby7bTPYCbjF?= =?us-ascii?Q?AN0BqSXr8weVAFr9GHxJkWhDwSWRYwS3hsOO2nIDMOY9XIcUOKuFrlGt5twh?= =?us-ascii?Q?yt6v0Q8ED2dPY+Tgdbd+pTogL5HfSrue0BTgOCmVCuTmVjFHe/YFOkYAtLSx?= =?us-ascii?Q?NGNoG2/bkgHDvAItCGcIAEV7xkqIhIsypuK3vPXWGb83sG2G4j0gMgyMD1BR?= =?us-ascii?Q?fime1/xqMgyXMS7HgSkGW8kbC27g2wuiUeGmcoCAxSMt3NOD4AvhYov0E4L3?= =?us-ascii?Q?ikJmzpM5cbXbYOKw24Sz2FzwM3LKdeIm3OM5UtP/D+WuYVleY0UGi1qBLi1g?= =?us-ascii?Q?OwFVfcQrT6V+xW1PLBm4H9w4roicaEz6WqdVekVUTP4LCLNtSUiPvqfUf8sq?= =?us-ascii?Q?jLJh8VFZCNr4Zpt5kydYCXyoXLrI+lDfXGZsWS4Islmuo5NL0Le4lSrhUwlp?= =?us-ascii?Q?sbnfzWqrIwoJ+GIEwY0vilyfX11DLlxQ7kxcCgco5LiwOdND/7IkDfFZdC60?= =?us-ascii?Q?GFZauH2ksq7pzhbIq8pu63y0KYUzit6kc+nKdi99r7IzaxyqFFC5ogcQR/cp?= =?us-ascii?Q?AIX4Tr2fGkUNobLDqvk2/pOtbIokQqqNZCon8TKolp8trJFlvahV/vJsdBhz?= =?us-ascii?Q?Hp2iF03JGFmC98GCODOfLWDAod+tcFx7vrgiJi+JAgX36x6pSsRl0a0/PRey?= =?us-ascii?Q?xHoPxuHP2cwC/PSZGrwnzv1Exuq0uwZNwlXyvYAKNNUFzDdFZZH4KPIDC23F?= =?us-ascii?Q?wKB3hml/9P6K/62kQRfILviSKLLys59EgFlXuiqlDFT+X67oIlX8nr+IiDlq?= =?us-ascii?Q?odEhjkFqi9/+6imUlsfXqketj7RrwN7zRgNTVqMjfuSS/1aCirLdhX6h2S8c?= =?us-ascii?Q?7VN8nQM/SGnP4kWUGYD+oeYXnuoF4MP+IVYYhpxszayaRCIEliHKnzmOavgj?= =?us-ascii?Q?dNJlIgfQnQXPLf1SuHHR4dP1AlO6/nrbT0WNDaVZHzGKUgE67XaeOajmfCVy?= =?us-ascii?Q?MxGhmzlQo54TMLJAcP/qXHZ7K8IeVs5w1l0zNA8avDtW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 680f3a0a-2379-4980-4cc0-08da83e56d88 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Aug 2022 02:24:23.4432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2/4tGhW6f1ZaJK4l+NEnTys21f5RAQWC1AHcOZsNwWnP9ZDRcdI98Tjmjy1dVPQh3caSQbixLjUBgUMRUpJv9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3337 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Vang, Judah > Sent: Thursday, August 11, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [PATCH v4 11/28] SecurityPkg: Add new KeyService types and defin= es >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2594 >=20 > V4: revert copyright date change. >=20 > V1: Add new KeyService types and defines. >=20 > Cc: Jian J Wang > Cc: Jiewen Yao > Cc: Nishant C Mistry > Signed-off-by: Jian J Wang > Signed-off-by: Nishant C Mistry > Signed-off-by: Judah Vang > --- > SecurityPkg/Include/Ppi/KeyServicePpi.h | 57 ++++++++++++++++++++ > 1 file changed, 57 insertions(+) >=20 > diff --git a/SecurityPkg/Include/Ppi/KeyServicePpi.h > b/SecurityPkg/Include/Ppi/KeyServicePpi.h > new file mode 100644 > index 000000000000..8cfec04f96e5 > --- /dev/null > +++ b/SecurityPkg/Include/Ppi/KeyServicePpi.h > @@ -0,0 +1,57 @@ > +/** @file > + Provides Key Services. > + > +Copyright (c) 2008 - 2022, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +@par Specification Reference: > +**/ > + > +#ifndef PEI_KEY_SERVICE_PPI_H_ > +#define PEI_KEY_SERVICE_PPI_H_ > +/// > +/// KEY SERVICE PPI GUID > +/// > +extern EFI_GUID gKeyServicePpiGuid; > + > +/** > + Generate a new key from root key. > + > + @param[in] Salt Pointer to the salt(non-secret) = value. > + @param[in] SaltSize Salt size in bytes. > + @param[out] NewKey Pointer to buffer to receive new= key. > + @param[in] NewKeySize Size of new key bytes to generat= e. > + > + @retval EFI_SUCCESS The function completed successfu= lly > + @retval OTHER The function completed with fail= ure. > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *KEY_SERVICE_GEN_KEY)( > + IN UINT8 *Salt, > + IN UINTN SaltSize, > + OUT UINT8 *NewKey, > + IN UINTN NewKeySize > + ); > + > +#define KEY_SERVICE_PPI_REVISION 1 > +#define ROOT_KEY_LEN 64 > +#define SALT_SIZE_MIN_LEN 64 > +#define KEY_SERVICE_KEY_NAME L"KEY_SERVICE_KEY" > + > +typedef struct { > + UINT8 RootKey[ROOT_KEY_LEN]; > + UINT8 PreviousRootKey[ROOT_KEY_LEN]; > +} KEY_SERVICE_DATA; > + > +typedef struct _KEY_SERVICE_PPI KEY_SERVICE_PPI; > + > +/// > +/// KEY SERVICE PPI > +/// The interface functions are for Key Service in PEI Phase > +/// > +struct _KEY_SERVICE_PPI { > + KEY_SERVICE_GEN_KEY GenerateKey; /// Generate Key > +}; > + > +#endif > -- > 2.35.1.windows.2