Re: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter.

Re: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter.

[Yao, Jiewen]

 Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Hi Scottie
Please remember to add Wang, Jian J as reviewer too.

Thank you
Yao Jiewen

> -----Original Message-----
> From: Kuo, Scottie <scottie.kuo@intel.com>
> Sent: Monday, May 24, 2021 2:41 PM
> To: devel@edk2.groups.io
> Cc: Kuo, Scottie <scottie.kuo@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> Kumar, Rahul1 <rahul1.kumar@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Chu, Maggie <maggie.chu@intel.com>
> Subject: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes
> parameter.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3408
> 
> The value of SupportedAttributes in OpalGetSupportedAttributesInfo ()
> is left undetermined, if the caller doesn't initialize it.
> Initialize it in the function entry.
> 
> Signed-off-by: Scottie Kuo <scottie.kuo@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Maggie Chu <maggie.chu@intel.com>
> ---
>  SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> index b58597e61f..c840590e8e 100644
> --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Public API for Opal Core library.
> 
> -Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2016 - 2021, Intel Corporation. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -1647,6 +1647,7 @@ OpalGetSupportedAttributesInfo(
>    NULL_CHECK(OpalBaseComId);
> 
>    ZeroMem(Buffer, BUFFER_SIZE);
> +  ZeroMem(SupportedAttributes, sizeof(OPAL_DISK_SUPPORT_ATTRIBUTE));
>    ASSERT(sizeof(Buffer) >= sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS));
> 
>    //
> --
> 2.26.2.windows.1

Re: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter.

[Wang, Jian J]

Acked-by: Jian J Wang <jian.j.wang@intel.com>

> -----Original Message-----
> From: Kuo, Scottie <scottie.kuo@intel.com>
> Sent: Tuesday, June 01, 2021 5:26 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io; Wang, Jian J
> <jian.j.wang@intel.com>
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul1
> <rahul1.kumar@intel.com>; Chu, Maggie <maggie.chu@intel.com>
> Subject: RE: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize
> SupportedAttributes parameter.
> 
> Hi, @Wang, Jian J
> Please help to review the patch. Thanks😊
> 
> Best regards,
> Scottie
> 
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Thursday, May 27, 2021 6:32 PM
> To: Kuo, Scottie <scottie.kuo@intel.com>; devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Kumar, Rahul1
> <rahul1.kumar@intel.com>; Chu, Maggie <maggie.chu@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>
> Subject: RE: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize
> SupportedAttributes parameter.
> 
>  Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> Hi Scottie
> Please remember to add Wang, Jian J as reviewer too.
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: Kuo, Scottie <scottie.kuo@intel.com>
> > Sent: Monday, May 24, 2021 2:41 PM
> > To: devel@edk2.groups.io
> > Cc: Kuo, Scottie <scottie.kuo@intel.com>; Zhang, Qi1
> > <qi1.zhang@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>; Yao,
> > Jiewen <jiewen.yao@intel.com>; Chu, Maggie <maggie.chu@intel.com>
> > Subject: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize
> > SupportedAttributes parameter.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3408
> >
> > The value of SupportedAttributes in OpalGetSupportedAttributesInfo ()
> > is left undetermined, if the caller doesn't initialize it.
> > Initialize it in the function entry.
> >
> > Signed-off-by: Scottie Kuo <scottie.kuo@intel.com>
> > Cc: Qi Zhang <qi1.zhang@intel.com>
> > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Maggie Chu <maggie.chu@intel.com>
> > ---
> >  SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > index b58597e61f..c840590e8e 100644
> > --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
> > @@ -1,7 +1,7 @@
> >  /** @file
> >    Public API for Opal Core library.
> >
> > -Copyright (c) 2016 - 2018, Intel Corporation. All rights
> > reserved.<BR>
> > +Copyright (c) 2016 - 2021, Intel Corporation. All rights
> > +reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -1647,6 +1647,7 @@ OpalGetSupportedAttributesInfo(
> >    NULL_CHECK(OpalBaseComId);
> >
> >    ZeroMem(Buffer, BUFFER_SIZE);
> > +  ZeroMem(SupportedAttributes, sizeof(OPAL_DISK_SUPPORT_ATTRIBUTE));
> >    ASSERT(sizeof(Buffer) >= sizeof(TCG_SUPPORTED_SECURITY_PROTOCOLS));
> >
> >    //
> > --
> > 2.26.2.windows.1