From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.16602.1653228949920060603 for ; Sun, 22 May 2022 07:15:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MkHnAfjs; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jian.j.wang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653228949; x=1684764949; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BypNPHRcuDtxe4h++fYzIPM5U/5A8cY2G3MSSQeb6lE=; b=MkHnAfjsDQbe5r6Ap6e9/iL7NTphntdyZSRkAl83n+dxWEU6apsZOYvf 9wEnthEkIcOTWjuLJHsNM79WVZ4tZH1MV+4rnVHh15+qf4GnLPrOnI0RP DVUpI9r9G5+yqMzf6RqtImj/xF2f+FTHQMMnQBFPaIHGnX18GeYfEZ9zg T03QcJTIqmBB71zNjJmEoKDT2lTP/A7y+u17qEZ5cQwWmOSdxLpxDubmE 6ZG24tcfmrmdC7ic601mAGcAD7+gi+upId/tbxxJf8XxPQ9qNrUHIO9Wg h0OF+3S+jzHbdcOh6V5gGHUEp8ndcAHdwv2hbqfHDGmAaPNU3QjkYHCGF A==; X-IronPort-AV: E=McAfee;i="6400,9594,10355"; a="271822883" X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="271822883" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2022 07:15:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="900153274" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 22 May 2022 07:15:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 22 May 2022 07:15:49 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 22 May 2022 07:15:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 22 May 2022 07:15:49 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 22 May 2022 07:15:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4HRSSkuF7nY3tzhZY+2zSSQkMPAnOfYmJcHOn3C0bbhxowweFKhxzB81L6zwAlhPyx9l9vGojoFVGedrCEFc1mjV9fjM6jN2e/3JJTBxC3o2xM6FJ/YbN3JgkAjKW7ZtJRlefNSuFB/9XR4CRRFPlOjULED6A9kG153esZ8eu5k4q0EKIugFaLlfaCLoq53c0hOJGfZwXE/itQ46I1nQ3SeQDXcge0j7gEHYD0fId68ue7kVYi6/YV1evoDIxzaRMfnP33zX+8A0W7+NwOUlJlhqtFJofZOL6DBSYlDOZmePP2ygyNCYFnCFLT2LRNcLzGG7b83pl2llAV+aEcYnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sothS2994DZcMOCZPebVkRAGU2TO6RD/f4Sx3FTaMnc=; b=InXRyNH5/3GAKXaFxfnrZYNT5Rnvbvh/SFQFtzJO68BF23L2UAJgPof+EPkmL1tAthXvTQA4VcR3EWBKVLrofLsoXEyQKw9RyvFuIxhsBtnR0VnoxigIdl/Je62mg3SAgHzKzeH4qPPn8tvAPnAHSFtTnDRTugOesCLBL984EHri6uujuWZA3rW3skIhu9Mg8FRwZlXF4VgaCgc/DHz/DHEr2sd3bao62yJs/qFJIIG9XDXLps5oXp+iUD0DlTu/Hc01ZVxWBhtyjcp/sfn99n6wQhKCcwk3tFQocePZ5EZSO6P4tKS7FqRCKMrK64qkLneaF947UQkmhcXS5CNB7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by BN6PR11MB2050.namprd11.prod.outlook.com (2603:10b6:404:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.19; Sun, 22 May 2022 14:15:46 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::a420:db2c:31db:7906]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::a420:db2c:31db:7906%9]) with mapi id 15.20.5273.022; Sun, 22 May 2022 14:15:46 +0000 From: "Wang, Jian J" To: "Vang, Judah" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Mistry, Nishant C" Subject: Re: [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API Thread-Topic: [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API Thread-Index: AQHYW/O9HWILjOhRvEumrlFzePfUrK0rFDTw Date: Sun, 22 May 2022 14:15:46 +0000 Message-ID: References: <20220429180430.3292-1-judah.vang@intel.com> <20220429180430.3292-14-judah.vang@intel.com> In-Reply-To: <20220429180430.3292-14-judah.vang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: abe509a1-c74d-4745-1e5a-08da3bfd9080 x-ms-traffictypediagnostic: BN6PR11MB2050:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YAfhtNRbIOY/b+3/YuJT5h7S5rhvUv9UzVf29MV3F0JjuouJ0ot4KNjIvWVa09eAtrOMjOWUw0+FpeFB1YeHHQLrUeWAZl4H9AKR5+FoZBVYfpsjh2XGhKMwu9vvBQJ4a0ePJsGg18hlb2VK8Y8Ofed+WHkVhYsmphWym7Ybhz5CHm/qkshgTIaxhIf7ZireG4fzOfnz3gOkL614aNakwJL1OIReXQniCHrvd+J/CfPBPUqC5Szk1j7yfk7CwlOFsbjQwkuAtZhFYu2PsfYpwh6xNlmGVH0va9tbHa7gHI1U/1A80Lf+7qnIqYy1g0zQxqq4OH0U5WCuAXQLiNvwg60sEIAQx2RYRozljXkGfWMQKS5FE3fzEpy23F6lLtRSdActc2eDGd5YBw5sMMplXpg8Esy92ZpezqOweikUK/PW15FPQRH4rRjncVYAuO45okLCnq3fKow7Gyiryc8/1fZLjLshraUGuuYB/CO7c4h0YPuFx6SMk3/zqaorwX0RcY8htphShz8KJXZvGryTSiJ2v6z0bGcRtd1o7emzsQBZosK2O8az3RYwsoAYCtexrC5dI7BFzkOTItMJa2Fv3Nd7ai2oYwkGpqyu3JfuDdFDd6goU5UHBZELbgAm0nLpMxk/mE5gk1aBHru64DU3JLehWhxM02awfq2M6OgxUL+xwpv6he83mugFnnkjZ+j/Mt5Tum+jnnvXs/xyDLsidm1rmgktxDjBNWStxMqwMfBQAwaQWVVluuslEOjTbj7se2raK+ljlNxcQXZQP81949ZbfKAD5B9OFCb3DDdRDbg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(6506007)(508600001)(8936002)(86362001)(52536014)(966005)(26005)(107886003)(38070700005)(9686003)(122000001)(186003)(82960400001)(54906003)(53546011)(33656002)(110136005)(2906002)(66556008)(66476007)(15650500001)(7696005)(76116006)(64756008)(83380400001)(5660300002)(38100700002)(66446008)(316002)(66946007)(55016003)(4326008)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0pAyNTFuGcbylPK1Qgudg6fnEsTGOmo88MXu6cMv+NqoiJtGJ3lSbiyZZJ/I?= =?us-ascii?Q?Bvyyqr5dQGAI9Mk0d3StiaC2moNqSGzLU/wiYcVckGBvqrJ6VXxF//P52J8b?= =?us-ascii?Q?ogEu+WbDNIkcif5Vv0qmZw3k0+9R7+0Qpt3huwZbzkZnsF1oGd7hrNG2WtD+?= =?us-ascii?Q?OltydojYU1H/anc7+jfF+l/GM6M/oXy64in3qWQom4Jxo2FeGZE0D2EfRa3D?= =?us-ascii?Q?gIpwvwQqQuIgX+8CNEQ2RvRpn6tJdAMf5ZUHEAGbUpGPf14spfxUFcXSv0mT?= =?us-ascii?Q?aeVCChzd7W1h0zmybvACUwwZJb1Cm5Upvtvr7YDvLBOq9ArUFo/y9442IoiU?= =?us-ascii?Q?wqZxopeva2xOp+nAN0rH/wtpQSbj3e416P5WeXdCosIR0TTA4qMbwQxSegby?= =?us-ascii?Q?RAoSoAFeUEgapwv1oOCm5UMtkFsmJ1h0dDK3HEInIkMYvkQWFHwlgpqnUd+Z?= =?us-ascii?Q?JMya6gCQqVDy5FvYp6D8U7HfKtJ3PtlRA/0IMagXQ7OtuP3eRtoQPTSpP2ac?= =?us-ascii?Q?GtJ4cHzibFhKZY0eb4jIiuq4PPMmPVq5VsNNz+rLM+lAJv2V8jw6B7vgc9ZR?= =?us-ascii?Q?L3t6RDqAAwfWqwU7ZEyFF3Okkw+ojT8Uyx2GoyVBxa45Rr55IvEzi52E0VRT?= =?us-ascii?Q?nHWsS+yvE33yzCZQlmG0pjTmDoNyXdmJDcamNPOdzL0G1wBFoYofXpzfL+KF?= =?us-ascii?Q?sxbpewB3JRREtoqVOW7zB49qTO0/cZPvm5OPjz5NKCxZ8mrwQy0UT20lCA/u?= =?us-ascii?Q?OCORh+scs6v3/s46C4sDNo39TN/pNi0r3zTxH+86P7sO6p3FevAC8qP98O3D?= =?us-ascii?Q?VrdkdMP2qJSrEAlhjPEfz15UPGuEh0EwbRIvlLylCT48uWKOmIb3V6XBQ6iX?= =?us-ascii?Q?JlN1qe8LhYoMaXHf+4mjPX5RhNp0NcIWci+b1naUQWyfA7DP1eN6TNaWbzJt?= =?us-ascii?Q?5MdEpGbEZuaQI41VZzySv+zHN+lQbrVjuBX3bkO9DYUaVZkRPWYJjq0ILvRv?= =?us-ascii?Q?P6XdtSLLsA+rKgShd5EmiaswigaR5b9ijfFDsqcNt6jO9WznXmxgsbQfBqfc?= =?us-ascii?Q?oup5+K7MK8oK68zBzV0NTSYTsqN+qlLmvNMAXddQHNOqPJOS/mit4RO9ZDvO?= =?us-ascii?Q?3nTNgr+qbWFY5cw+bNNs1kgKc/jmceIDqbGNbyucTLWIGo71BE4nXn34QypI?= =?us-ascii?Q?A8ZEPH9rFUP4cHQv5V2aFimwjfOG6eixglTNigqqhRXv9OzpDIC+szb7ZTk0?= =?us-ascii?Q?+JsSRASnp2dfrAMHeqLx0qzYGj3xK0iXzngGhqGNG8R11cwYYKessP5NqC8t?= =?us-ascii?Q?w2mmH08SpUGq8URDrYBHuGaSZc6heSGfGkVPSUzys4I5DG2kg3Rgep7XEXxz?= =?us-ascii?Q?hn7PUOqJBhaQbqX5rViN2oWeirIPuxxGIkdscQnawepbCp+On9ilItLTDofW?= =?us-ascii?Q?OO2jn3Jfavaucfn2Pselehqs2CX1waRuE3EJGojPeeH3P/cjuFM6oL8U5ALA?= =?us-ascii?Q?mBwhjEyCjG+Pv8Y87jRrfUoISFCGpxkgF6t+hQMe3BSNuZMuqPXCMP+Sfswg?= =?us-ascii?Q?j7o9xmpqViz+tb8QV3G6BpthszhitZCRj4NvKKVF3xiThYVpxqC68xainjNm?= =?us-ascii?Q?tlVyIpTq4qVQKOu90SgayX5lNejJwOCXuHTcNTsFScjkDiAOTJ6UkQ6WuwBA?= =?us-ascii?Q?fQI4Yunp6vWGrwe1cCVBFql04F0ezfW6kKG8I6ziAK9mZysSodsuIi/A5gPQ?= =?us-ascii?Q?ROt58iEGIQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abe509a1-c74d-4745-1e5a-08da3bfd9080 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2022 14:15:46.3113 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gvMvB5sqT+AJjVdAiCCOzJJOvgCDGp/CDjJlOH0DdxQki3tdqp7LtixMx+UGeYhb7tQqpJq72ck4mXKR/fnNcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB2050 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Judah, My comments below > -----Original Message----- > From: Vang, Judah > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Yao, Jiewen ; > Mistry, Nishant C > Subject: [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2594 >=20 > Fix GetVariableKey API to match changes in header files. >=20 > Cc: Jian J Wang > Cc: Jiewen Yao > Cc: Nishant C Mistry > Signed-off-by: Jian J Wang > Signed-off-by: Nishant C Mistry > Signed-off-by: Judah Vang > --- > SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > index a08def767b5f..cfbad54ba106 100644 > --- a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > +++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > @@ -1,7 +1,7 @@ > /** @file > Null version of VariableKeyLib for build purpose. Don't use it in real= product. >=20 > -Copyright (c) 2020, Intel Corporation. All rights reserved.
> +Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > EFI_STATUS > EFIAPI > GetVariableKey ( > - OUT VOID **VariableKey, > - IN OUT UINTN *VariableKeySize > + OUT VOID *VariableKey, > + IN UINTN VariableKeySize [JianJW]=20 'OUT' is removed here but the parameter description in function comments still declared as [in,out]. Please update the function comments in patch 12= =20 as well. Regards, Jian > ) > { > ASSERT (FALSE); > -- > 2.35.1.windows.2