From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.8639.1667320024746818871 for ; Tue, 01 Nov 2022 09:27:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=cIRqGtAD; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jian.j.wang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667320024; x=1698856024; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1VJHqdOEnt2K2HDGOgWwiQEtWsL1nSDK2SXN/Mg5eKI=; b=cIRqGtAD7irXssEEfxWD1vRM3sC+rQMj1+XHdNpLRIbdbbKr61TMMC0O Nx2vgXzHQ6FCHGM+trKy2C/WTP4vdUmQCH+3QzZbj33lwflUHpXk5aYiS SzVSB12BBB4hleTGIA6Gq4SUMediwC/gx1LTMY0pUqdrlWj/TPzHfB08o PtdxwNPjng3bha5Ri4SjKwJ06CtqHoZMunMkpP1VrofbmPUTVnUm5PpzT v9E3PsOFNbeZGZN2yPmFYWu2FkwKM3jUbgqudUI3svhmqaSNQZ3hcN7bd /0ExYG0J4ldVAxXo8okf9bYRjcc9oglP4UuCUwKjd4SRlZM95VTiUyQQo Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="288894059" X-IronPort-AV: E=Sophos;i="5.95,231,1661842800"; d="scan'208";a="288894059" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 09:27:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="665203820" X-IronPort-AV: E=Sophos;i="5.95,231,1661842800"; d="scan'208";a="665203820" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 01 Nov 2022 09:27:03 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 09:27:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 09:27:02 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 09:27:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrEDHN5Z+CiO1euGEkz2A/hhRkKuIGfnmpzvUFsyDDnzrmEyyHy1vxy80L826Kvbgaoy7ZRnV0ZBueL2et4/oNu7hrrHK48cywowFFuPW71twcKyCDoWaNrdeEe0NeiHbqGJ4HAVs1hw2ec/M0fOsixrVjqChy5EueexLJ8Fln3hHseQD/hOOwjFDeysVeJa/3kkJgip4010R2dABR/GSLSan75q0hlcY3POO8K/BBU807sJXuC9d1bpGN10BdGJm07v3/AOdaiHK87txRr7nF9ImfbqHN5bPcdma+PKXdFVLa4D5AD/2DhDcFshI6CHj03ZHa1EUxh/WjciZMtAWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eGn8DterJZGsDhowzz6kr9GZeMPO/jfNLTlqdykTOPo=; b=e94baIr3Wht3wc3sq3J6VmflMJ3w9JnrdluBCwww0d19yYBQ21xfiYvtGdg1Dc7Cc1LgiGPlXypWwmkKzzH47P2k9+/qb6SRwHyIwLq96R1MrJeunFG5GY5ScVeuNXVSLyQgo4V1VUJkeFo0jDyqcMXcDh/vHawtJQ1Q3QYy1NfLKKDsXxqo1rnskxIqQGAOjAxguPZFzdJI2GzxhhFesCSmjBZocfVNRuA/PmrToGvGl9ql478RImHKAKReg7n7Fw0BcHHgnDBBn6WucdaMrMHdCOLCXnAi9tk83uuEbzxrLG28YSHUe90LYxM2mvlSp3gFuPOUp/Nm1BB0scVgRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by DM8PR11MB5701.namprd11.prod.outlook.com (2603:10b6:8:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Tue, 1 Nov 2022 16:27:01 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::5119:bd1c:6c57:40f6]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::5119:bd1c:6c57:40f6%7]) with mapi id 15.20.5769.021; Tue, 1 Nov 2022 16:27:00 +0000 From: "Wang, Jian J" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based unit tests Thread-Topic: [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based unit tests Thread-Index: AQHY6v+eFmTgEGrgR0CmV0ng9Wvn0q4qR1YA Date: Tue, 1 Nov 2022 16:27:00 +0000 Message-ID: References: <20221028190034.1642-1-michael.d.kinney@intel.com> In-Reply-To: <20221028190034.1642-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB4945:EE_|DM8PR11MB5701:EE_ x-ms-office365-filtering-correlation-id: 9a2d4b62-47b2-46be-695d-08dabc25e760 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3z72nIpm1JVfA4+pRO1B+/Ux7wGs9b8+Wq2Sp0UbNvOSpjZcFEBMFbQgBOZdJSQq/kz0bP/t4vFDfffFVwZV2uQFajNu3p12F87nINDjSz/VJWV+CDHjMmGrDZhSTp9yh9mRdb72gzAOELAeG9SIKOQ535Mwsn3KS/KcrtqGKGvbJbWikT8MyRxgaZIlxlIrMt4xWLtA8By9JKJJD8zhYOBTOmbsk5tGLZJYhNlcUu/k2y455+hLJzepKEmx+CxwpEFUmMGvwZzsp25Xcrqaw4wZfAy9vno7FnqvLITKQFZ739aHczg5PCQlSLWb8qXO7KrRDxnZGNGlqak/FVjJSBrEl3a7e1e5jCl3i2zfwFMNPkFodhpW59YUc694xoWc0OnTCxFsg3X0Nx+i+Z52hfOHte2GcPO0ridCDfVmIyzkjQG2rC/Cu3lQuMhc5xNR5eKeCKgE4sfyRfgIdqlmLJFV07xAzj7P41VHGQiAtHIlSWc3IFJ/mJsZbxYnHfwhROI6kYmuRaGyyvBu4fVuUln2nDrFSHbaS0ZKjrASpbcZzbAokRX/tqA+E1Z8JFNlU7sVHMuMT3WfYr6gWDzFKDRr3BGidy6+ywl38NIKpu7HOGwulfjWVM+2vnBwvPsC4u4Ubvlk56ErQTQpJiS5BoyGC1yqgdpTlpUQKYi1PVwh75CCzaZa1PcSJr/qyDa2PjdI7WcHiwQroPQxA5geBB/yI8psCMUdXVPHga+BF4EiyL+FMaMAWVGhu16PCItDZmK4kZZ65+n7eaejQcyJokGTZZ8iS5aAcsGdqClt4yI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(366004)(346002)(396003)(376002)(451199015)(478600001)(71200400001)(966005)(83380400001)(2906002)(53546011)(4326008)(316002)(8676002)(86362001)(19627235002)(38100700002)(122000001)(7696005)(186003)(6506007)(82960400001)(45080400002)(8936002)(5660300002)(52536014)(26005)(110136005)(41300700001)(9686003)(54906003)(66446008)(55016003)(64756008)(33656002)(38070700005)(107886003)(66556008)(66476007)(76116006)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HHGhAanpqp5stnwiu8d8LEBkUpfUHWpzFUDBbLeZwiNvkUEQrhSAO07xubxu?= =?us-ascii?Q?bQIEtNuQmF9a8PnOZXoPCxk6Wq8pRWWMJV9xuqnp2EFhUBo5/RQfhs14hT19?= =?us-ascii?Q?sXm6iVjftTy0OhxTyaA8JXzycvETIgm9WIKC0H+G8nL/uR6eXcMuqOgZEF19?= =?us-ascii?Q?Q/H176JrRUP1reD7Yff6MgFpV4/PY1DlcgOD9DzFxdK+HXUuRPyc5mLsooPO?= =?us-ascii?Q?0dHJCbGgtHkbBgMajvdaabPmu+5CfPnqa7z470/zI7HYZMovHgGnL2t4ncou?= =?us-ascii?Q?skhOycLAv7Oe3DuT2lQu7SfVB9GBQUuTXcwJaVK4svT8Y7cmRaBq+EqD/GR+?= =?us-ascii?Q?4J9VfZnH+nt+NZEDgNlRRuDmhaiXf86lJiignlzfRKFkvtFm8VmxXNwWvDaB?= =?us-ascii?Q?KLDvF/v2NMUiRdNUK+oMVeJqUR91mgO2njfN1C+IR4xZgxk1hqX3zopBOcug?= =?us-ascii?Q?jgFOPAvJAU4wJXUVoY3SCF1lN3MT4x/JHOBY5Fsk2Fk9Dx4RNqbeHxR4mgve?= =?us-ascii?Q?P5QQU70LCTau7gl2mC2I5/t5wnuSUspUjIzLl1ywqV3ktn6fZJkF4pSaSM6L?= =?us-ascii?Q?u/FEAksDe3vIyTqR50gYJhifPyWHkGJ0eSQee2qahqwzUItWzswoLqVORrS/?= =?us-ascii?Q?15DHVVccTLfEgVeC2ueVZ61dSewm/1unqcCZ8sq+lcifPWxrhegeYF2Ng+78?= =?us-ascii?Q?YGwGvgFVZMuPqJosGe/DqmopfKXRxEdMh+7VAi4+q0LZN7foIfs3V4sfLt+5?= =?us-ascii?Q?NsejACScwFeCJ14MMXGdmMk+X2dhNQGxuV1rNlB13HGuBKPYrxkqWawh6CdR?= =?us-ascii?Q?dqhNU/cQPKv5Bb7bAILTG1Me1O8Nzb0MJkt4dFEIHX3aLRtnuVxuSDs4jupT?= =?us-ascii?Q?tu1m5VukSK1qnNL0NwMlPotHtlbPoSFYxP17opb/epPeBzIIseF44NB6CwOi?= =?us-ascii?Q?XabrPYdkO4jiqm8paZS8JRrlKtSkd1y2ACbBYhcCvbEYfIRfYldGSqdFIQKH?= =?us-ascii?Q?7iVtAYok/dkpfmsBmWi0ncQSPzSHpDOhpqtgGNAWxcMJFgoaWwLHWWl0+Dpj?= =?us-ascii?Q?ZRvGeXOVnquhaISk2SDpqJBLaMoTyv3TlMvcEVLNWAJiN9NPUsiKNdp+Nes6?= =?us-ascii?Q?R9jz4aAbi1HaeEzAPHUvpNNx1GBYsrr82cCuIr8d/libbb5vP2QRbKD7V7Aw?= =?us-ascii?Q?LWyQVq24070iNxBRRL+nqeIJ6wYTo0G+T/E9j2CdGnSvoOvTqwytPSwhvsli?= =?us-ascii?Q?eUUFDp4z0FfdZcq+1n06Bf204J6QRY/EKEjUM72m5KBeVhCq8RIOH49F3srZ?= =?us-ascii?Q?q2ctgG+qHtZMvN38FP7qNZdwkoDufHRPBuPklGS7qN67hcPhTyr5XSVqaBwN?= =?us-ascii?Q?Xk0iOnivR8x4wJ3b6Vk5dE979fy+3qvtNOrVA5Qtp5cHaI1/t/UQwOc0JTI6?= =?us-ascii?Q?rzoC6H3LE3HetM0uLLa+DmGx+2fdhB744QK4nYvgltADAazjLKp1FxAEVmiZ?= =?us-ascii?Q?tYvs+KpwTd0NNUufwPRSQzJVhcyoVzIxNlLV7DUk5E+wWNqKmR80WkvQZS9Y?= =?us-ascii?Q?qyPxl006ADCeIK9DhdWmp2GqdTnh1q7Jqb/Xr1dU?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2d4b62-47b2-46be-695d-08dabc25e760 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 16:27:00.7701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qXGlBb0twWzC/TKeyhqbYJ7/B7ifiaUPmTEYVobKi7uH2Zj+z0kDd88u1RqKV9Ht+iVXPal1VTTee8TPm1dJWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5701 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, October 29, 2022 3:01 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, Xiaoyu1 ; Jiang, Guomin > Subject: [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based uni= t tests >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4130 >=20 > Remove TestBaseCryptLibHostAccel.inf and instead use FILE_GUID > override in DSC file to run the same unit test INF against > OpensslLibFull.inf and OpensslLibFullAccel.inf >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Michael D Kinney > --- > CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 10 +++- > .../TestBaseCryptLibHostAccel.inf | 56 ------------------- > 2 files changed, 7 insertions(+), 59 deletions(-) > delete mode 100644 > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel.in= f >=20 > diff --git a/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > b/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > index 369a1cb69939..3ed3e9b75d84 100644 > --- a/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > +++ b/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > @@ -20,7 +20,6 @@ [Defines] > !include UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc >=20 > [LibraryClasses] > - OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.i= nf >=20 > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTableLib > .inf >=20 > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizat= i > onLib.inf > @@ -33,8 +32,13 @@ [Components] > # > # Build HOST_APPLICATION that tests the SampleUnitTest > # > - CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHost.inf > - CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel= .inf > { > + CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHost.inf = { > + > + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > + } > + CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHost.inf = { > + > + FILE_GUID =3D 3604CCB8-138C-488F-8045-18704F73E734 > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > } > diff --git > a/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel.= inf > b/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel.= inf > deleted file mode 100644 > index 9d0fcfd3577c..000000000000 > --- > a/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel.= inf > +++ /dev/null > @@ -1,56 +0,0 @@ > -## @file > -# Host-based UnitTest for BaseCryptLib > -# > -# Copyright (c) Microsoft Corporation.
> -# Copyright (c) 2022, Intel Corporation. All rights reserved.
> -# SPDX-License-Identifier: BSD-2-Clause-Patent > -## > - > -[Defines] > - INF_VERSION =3D 0x00010005 > - BASE_NAME =3D BaseCryptLibUnitTestHostAccel > - FILE_GUID =3D B1AED64E-B53A-4D69-B0BA-60EEDAC47A6B > - MODULE_TYPE =3D HOST_APPLICATION > - VERSION_STRING =3D 1.0 > - > -# > -# The following information is for reference only and not required by th= e build > tools. > -# > -# VALID_ARCHITECTURES =3D IA32 X64 > -# > - > -[Sources] > - UnitTestMain.c > - BaseCryptLibUnitTests.c > - TestBaseCryptLib.h > - HashTests.c > - HmacTests.c > - BlockCipherTests.c > - RsaTests.c > - RsaPkcs7Tests.c > - Pkcs5Pbkdf2Tests.c > - AuthenticodeTests.c > - TSTests.c > - DhTests.c > - RandTests.c > - Pkcs7EkuTests.c > - OaepEncryptTests.c > - RsaPssTests.c > - ParallelhashTests.c > - HkdfTests.c > - AeadAesGcmTests.c > - BnTests.c > - EcTests.c > - X509Tests.c > - > -[Packages] > - MdePkg/MdePkg.dec > - CryptoPkg/CryptoPkg.dec > - > -[LibraryClasses] > - BaseLib > - DebugLib > - BaseCryptLib > - UnitTestLib > - MmServicesTableLib > - SynchronizationLib > -- > 2.37.1.windows.1