From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.8912.1642175610711710159 for ; Fri, 14 Jan 2022 07:53:31 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KFi+4SZW; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: maurice.ma@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642175610; x=1673711610; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2TssKmMsHbRYPMOq4ILSx5Ai4d8tfvBWJnLVbPQHkog=; b=KFi+4SZWS5fzJiy9ZUHkjQSOyF6n1YZ2oPE0ZPZdi605AfmWNMmO1xJI 3Zr5Rln9G58oDBuIwCK9FWde9m3FNdS8b3WEWNVOouB6uswPjE7wVTjor TED5a9KrZrPfD73KeoB4/6cbfH0FB/RHh0rEE2SxETzx2hkUCL2V+dMcw aJs76BnKvnWrxoj4OVyUF4F9WZsAUFyi3K2//um36y04yMAmqUWLRDtmR 6hphVA0VrbsieJN+8q7YZWYO8cH9KfQUmE1aLZkwCoENn26lPB24PUVzQ +0qanJFXUYZNDCIsM04qcwyxvGvEouD857/J5jfhWmaFiO6PtNG9hNKdT A==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="244064309" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="244064309" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 07:53:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="577312528" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 14 Jan 2022 07:53:27 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 07:53:27 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 14 Jan 2022 07:53:27 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 14 Jan 2022 07:53:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgYl7TSC07sWA8rGREXlUjCxI7I0v4VmZTBDQS6wTMURKBlsMAGjvp20qf+v2qrm//xCWTy25W5pKJ27M7SWpYCvCvIJvZP2NFdbkP+o+fl6lWKQTsc1Ilg/AETTaaE2S5nbTFJjz1o7Yz4On2XI3gedU1MPluFh5BPiwQkwJ3hoZDTuB4FOl6IDL+sCinga2c9msuczakHBA4B14BLA5J7Tt7yY9amfcyHhl90UB1BCrPLxv3gYWdVh3zLxEXfIUQzoThVUfuDhiOMKt1wRhZLk4Bxzkli9gJV/4N8kKs1G4TYDS7cc7/s00wU+HoAwbFLbu/EX2yPTzLFSo24OHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mvMx6ETLfhmM4gu8hTFY0aPYG0chluEEXMWf+LCUc4Q=; b=VEp0sfjHHp5Z+ongGPCL+7D9O2u8QujulI2K6rH7THtKYVnAEvE0wzNzH6JZe733iwcfwcx7afWEkrR55RUCHXBX2sbO1pBJysm9v/jmwjDgtTYONWawuIitBnG9K3QtfVXX6NuvDoQa93K1lNTz4BExvOyYrXV0yNXKQm7/NUuFx548NgWr+BSRlmRsG68OZyIk8ClgqNT/i6NKDP825WSGAxqjD1Lt5ddBrbQNdLO9Obh+3708XIS5XQanj5kenOmTVzjGGky4/uDuvIcPuAhNB2nQ1O5HlyM0+MoUUQjOuWzUmfnyDqwXV0SfjdlshFOYmeuq8FYnKINKrW19gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by PH0PR11MB4981.namprd11.prod.outlook.com (2603:10b6:510:39::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Fri, 14 Jan 2022 15:53:25 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::ad21:6d4d:159d:14be]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::ad21:6d4d:159d:14be%5]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 15:53:25 +0000 From: "Ma, Maurice" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ni, Ray" , "You, Benjamin" Subject: Re: [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by default. Thread-Topic: [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by default. Thread-Index: AQHYCQ4yBXpOK2BcbUmO3x8axkHHkKxiq03w Date: Fri, 14 Jan 2022 15:53:25 +0000 Message-ID: References: <20220114061518.503-1-zhiguang.liu@intel.com> In-Reply-To: <20220114061518.503-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57ac9d99-bba2-423e-7632-08d9d775fff7 x-ms-traffictypediagnostic: PH0PR11MB4981:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LVUk8KGq1AKKSZXVa8JH0rBTSUTw0W1pmFmG+GkXHNmPTVjB7+Dg95hk3QoHyJ9RhHl8VtH0KUsCNhFAoB8JZvn+3o34iJRjq53WqBbQZT0+SsUeFb49BcB3M62fIAa7A/y1Osp2DrdRyKcK9WgxeDkPIGEw605D9heNJoR8S2oloZmLWv3E4tXT7WGE3654Xrk7AbCeBwJbchnQB3NO9PFAgl5zPNLunnGRbota/tUPW0B4numU+Gdt3nl92F7JjrhG3xEa/i/Ek1r0C2njOzMEf385lQaBsPiRVzVgtEvtxCp39UD97C55KNfvpJij1S9rr04uZ4gKiiZtbUetEK5KInxPqpO0O80lHadY3BS4C9TFqrwKn5eH/3Q+DbYt3igydUmaFZkVqXPoKgk6xpWgwi115oce6ImVFnxEhJDf4ceJclPSl+Dcon2Z5n15QHYF7xDbpUSTctVuFMVGZPPrCphsRF/XLBP5zBm9FgUp5Rq00lkU+AzLzrS28CnQlkNOdNyeEJWFUoMUr/h47wdjbE0MtWZ6Lmb0S2/3s7KLD39ZIrEf/8V2Q0RJLXXgIUHV4gmUUGOu4e+1hJWovPP0bZNuf99lw4D0tSFU2zzgyt/aACTx9s9lZ80DlMlA8b/eezxCls6wxCTalJmV8rYeLZWDIEs34KybmEJvmUrPUi7/C8bp+BOZk/9Zm8GkPxNtAzAp48rLHGDeIFusQg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(122000001)(38100700002)(508600001)(66476007)(52536014)(66446008)(64756008)(66556008)(83380400001)(4326008)(38070700005)(2906002)(53546011)(76116006)(66946007)(9686003)(71200400001)(8676002)(6506007)(5660300002)(82960400001)(110136005)(54906003)(7696005)(8936002)(33656002)(316002)(26005)(107886003)(55016003)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L/EzkqZN8w2YEnA1hsfpTzq9xhpKbBuM0miCK8ig1GgWJYJKraTqAjRnvvys?= =?us-ascii?Q?VTcwvFvszEEj3HbPKPg+vonLMQAGZ7fZDPgq9PlMmDbZvIeLlni0oFQCO/Em?= =?us-ascii?Q?ttvBg7Okn6eruKgxevzStZcI8HwaQdwrD5lriMilLO4UY8APKs6pOSeC70g7?= =?us-ascii?Q?+A0NM5rMXkPg9UAudusgnyB+09WWcc3rPGY3l6HWhzzBAKiweH9VxCU9E9fo?= =?us-ascii?Q?ugLgfcr/7dUcaNSagyzHhXFF4H8JDJX+jcdF9GiLY18UcJdNS1B7yXej75lM?= =?us-ascii?Q?qdJAWEHuA8tqXcr8fVZeNKnccpecAshiNKQAWr+vCNuQLFReFSXpQ3QDI08T?= =?us-ascii?Q?7oE9RZNiDQfWtQ+cUzEcFgpFwWY0CRE+pfzjV15FpREK1ydbNIialTAzmf8C?= =?us-ascii?Q?m1z7xF3u8fZl5rGla0lTNtEnnvAx4FudS+ARoVmXG/xHHwW87i6CBb9c+q7e?= =?us-ascii?Q?8wH9v5bqawwLzETPphcG4ecliZ6ZUo+UWXJKbWSkWA/CVWM19Kl3w+trKqwm?= =?us-ascii?Q?9b+dNlAvAhHh7N+RmHK7biBoJw666IK9hxt1RJLM0rwOA9YANaHajNN8gyop?= =?us-ascii?Q?2oeZjTS2RYMWNYmVjneqEgkXxbu+hNUYCFiP34FMGoPGphtDMAL4rEJm3N2W?= =?us-ascii?Q?52UnNhpJaJk5bECfLCzWU3qpOGL0t1X7+ms0HdD2ORsZ9hIn3Dtz3tl5Os01?= =?us-ascii?Q?hn/MVORBsSH9P3KhRQGeIqJwZoh0Kj7201hw2kjdahetrhxlxmgdTCaxwBph?= =?us-ascii?Q?SjhNhPeVyDK1LesSHgvlEDGgVCLjLr/LuR9knrPx7qAi3byqp4qRsGbpRBW1?= =?us-ascii?Q?A1z2bCE9ytu00PJmnN6HiuPWIug+NqI+fxoCHMxV7P9x6mWLZM+B+wutmcbb?= =?us-ascii?Q?s6pxvLTU6Qr9/0ig27J42cZWt5AZGgyX+XXp5UBeEzQNS8xLNGJLXHIWl1xY?= =?us-ascii?Q?QRJjLNG88JdeSJ+cKPz5W80TyrAIAhB90SPqn77FvXHIed88zhpNbNL4KKCA?= =?us-ascii?Q?MkjMtYvG+k2zumZgn0ga9VDDaIHuWcaY9jGJdM6FbgGt66dRfLlXhr4X80RF?= =?us-ascii?Q?zD7ktXURBs5IhR8EUSQlL1oAkz8yolxCj7HFfSMLM18cUgbxdVUNwgK/SK1T?= =?us-ascii?Q?PQTEj/X2+fg0h6Vyc/P05Xz8qpx3+a1Ekqd+NP0kTO7ajhCa183BN4OyolRa?= =?us-ascii?Q?zG3IVQfQYYXuykGrUkjLmr+mHG3bgZWW5dRRcbbYlQjt1UbrhYyC/Z9NdBfu?= =?us-ascii?Q?a9V+J3ibijttfm06rthSepvb6Ma2XO4/eQ0c5RxVI/c4nGVl7ViznvPsDo7N?= =?us-ascii?Q?KaKBmxFVWvE1H968tB5qlM91ddWlPpDLh4jRkX2VIPFd22W9RGcT/4jXIyDK?= =?us-ascii?Q?/xcoisuKu3LRD0BcV0vrk19ONmsFEZ2xyOeEewLQACtZ2ghcVLoPOHYPCZH2?= =?us-ascii?Q?zMI6CHhcnLVFoRX7P5X7RfpEEOsOZm3TGff1RccLLJDD0pvaKKMMSiRiiIVn?= =?us-ascii?Q?obGcIT+/dMIAYLfBvXeBDAsQLvWqLCJuQ4TEWWYOkB1yzV7U+yk7wgMgbQHp?= =?us-ascii?Q?m8LHp+LGmDFiGE+3v+CjYjM9WUPb9HhQOQ5SZJjxCvL1i2zmXNjL9HNOQ9mw?= =?us-ascii?Q?Tg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57ac9d99-bba2-423e-7632-08d9d775fff7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2022 15:53:25.4095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K/GDOWQl/dzHYK4epQv+qNcTcrRXTrfGvG8F2fJoF2+Yas7yepct3dhObPDEbezSlpAmK8t4fJ2JTrD4hPimSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4981 Return-Path: maurice.ma@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Maurice Ma > -----Original Message----- > From: Liu, Zhiguang > Sent: Thursday, January 13, 2022 22:15 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by default. >=20 > For recent X86 CPU, 0x15 CPUID instruction will return Time Stamp Counter= . > This is recommended way to get the time, and also how BaseCpuTimerLib > works However, some CPU doesn't support this feature, so disable it by > default. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Maurice Ma > Cc: Benjamin You > Signed-off-by: Zhiguang Liu > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index 3d08edfe31..65c1bd610e 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -111,6 +111,11 @@ > DEFINE SERIAL_DRIVER_ENABLE =3D TRUE DEFINE > PERFORMANCE_MEASUREMENT_ENABLE =3D FALSE + # For recent X86 CPU, > 0x15 CPUID instruction will return Time Stamp Counter.+ # This is > recommended way to get the time, and also how BaseCpuTimerLib works.+ > # However, some CPU doesn't support this feature, so disable it by defaul= t.+ > DEFINE CPU_TIMER_LIB_ENABLE =3D FALSE+ [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG@@ -217,7 +222,7 > @@ > # # Platform #-!if $(UNIVERSAL_PAYLOAD) =3D=3D TRUE+!if > $(CPU_TIMER_LIB_ENABLE) =3D=3D TRUE > TimerLib|UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf !else > TimerLib|UefiPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf-- > 2.32.0.windows.2