From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.938.1625173030719931131 for ; Thu, 01 Jul 2021 13:57:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Ju63jDCU; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: maurice.ma@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10032"; a="188306713" X-IronPort-AV: E=Sophos;i="5.83,315,1616482800"; d="scan'208";a="188306713" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 13:57:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,315,1616482800"; d="scan'208";a="490041031" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga001.jf.intel.com with ESMTP; 01 Jul 2021 13:57:06 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 1 Jul 2021 13:57:05 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 1 Jul 2021 13:57:05 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 1 Jul 2021 13:57:05 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 1 Jul 2021 13:57:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRryTRKP1+6npo8T13NPOC81yxUMeNZDBLLomxLgIs7mPhiiaUVXOke/nAUYKVPm22knDyaaV1ZNVLPyXi+AnRGphDqXyOB8Mntabi3Pi426w7HS3/8s5MpO5ftz12Z9Ab5ZMbJhyIN7g06eKFz9GPDvoW+v2rsVVwgV5Iifb/ikbRKzgFha+llnYBMtMrwG8KMWkQ30BQ4aL+UFG6xPQHGbs31m8GjrSnYzFp04NG33sCrd9FA6Q2LtkeNHaQuQYXHdnXPko/GM6FS1ZqAIYKN4nK6BV39H5XKzdHZU+NKus/fGL+9VNnS8VlRp15ioXMtsdZlCygWG20qTdNuntw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x7o1whTSJ88OdGbnvFIFv3e7r84Vk20WeQuUbzumuo8=; b=T7WO3RrHoay4U677zCrORyauQbHOc9ALjmnMTP+pgIzne85eAM5p9nQDEC6X7BTuBUbTxS0OYEZQUNXy4bYQ8SBGDE8YLzVI3eb+J3Iv4SDeOlAXJ1xal385fHphP2/ULL0/9sYxxHFo60r+Zc6cDCYHV10QlH581reEfc6ztzPYu8eLSWWT7FZXhY4b7TRkOK/yseYHrVhgRYhy2HW8ZqX/ybbCGC20CuvUzNM5YuUR8zZNwcwF5dlaP2KCFxMxuZnyUp5Lq9vU9fpYHgU4+h6pj+EYqSRea5enyQlRKTg5oG/SRF1elyojGYBRdnJjgOlk5I5FPmTVssT6Ex9eUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x7o1whTSJ88OdGbnvFIFv3e7r84Vk20WeQuUbzumuo8=; b=Ju63jDCUn+BCdlw9JVogRwNUm8Ie4oiDlvRUXw6iXEj4Ay/hzuDxNPhtHms0Lp5iEOPs/XhlyYr5D59Fu23+2kKKSkxnFqMSswEyoDM6VnoPttXRDKDSmtQaFYhAgfoL1fhm0lfRoWhijNTXWVam8vJvXoDXmWl8Ej6pVy4fsK8= Received: from CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) by CO1PR11MB4995.namprd11.prod.outlook.com (2603:10b6:303:9f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.24; Thu, 1 Jul 2021 20:57:04 +0000 Received: from CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::480f:a616:cf27:9bc9]) by CO1PR11MB4945.namprd11.prod.outlook.com ([fe80::480f:a616:cf27:9bc9%4]) with mapi id 15.20.4287.023; Thu, 1 Jul 2021 20:57:04 +0000 From: "Ma, Maurice" To: "Dong, Guo" , "devel@edk2.groups.io" CC: "You, Benjamin" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the build failure Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the build failure Thread-Index: AQHXbgJhXfG1DKNSIkuMRFQbIvLcRKsumx7g Date: Thu, 1 Jul 2021 20:57:04 +0000 Message-ID: References: <20210630225036.34272-1-guo.dong@intel.com> In-Reply-To: <20210630225036.34272-1-guo.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [104.153.200.60] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f59ca0e4-06c5-4b91-5921-08d93cd2c7cb x-ms-traffictypediagnostic: CO1PR11MB4995: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ivqP6Z6bgaz1RF9NE+GuNZIPOFWnLH5XJzQHl9zgrIt12Ck/IuDZuOAHJciR2mBBq559JWEqDGnakVx1C7Su5I9t1vHJQCy9wUr23XtgwRbro4po/yek2Nbny9BDfRGWW+VO93ZelEcRia9wxFJFSDOQDwedjJUMETe9WFcNV9bPlYMd5DNoivqQ1xviGU3rDGSx9tGTT4f+x0VmUGLKox1EKMP3PpLhqzFYfhPdkIhmVgRPgtMYZMPkN9N3KzW3y+ilUBpxTqD7xlCV7ptabKQqu/1hHAWG2eL7yPW/vk7heNCKW1Fh+NYHlIl5hUShx/evru84UmtrCZTZRhbu/jDlccnnx3x5N3jW7+vPRTpTR/XOwz/wOpiG61bJ2SX1vCuv/oYE3RCalgbu8sOde+jPuZn5R2WDL0HGCnxAmKxqcI95nneBtdcDZrsxyJ+wrE0hlJ30D/aGA2oS62D7M2S9sJXuaNyUCnw+pJNbcSVUgdGSHaP3/crdPedAQukOu43S9QVyNOqNxzyQnRMIPeYGuuZsgidL9MTK4iv0wZAXsJcfpMXNFJj0RKzwfQEFuinvtG3fGLkcFZuTKDmkcS62enVaU7gubhX3QhrDFcarfBZF76giy37t2OrNF0j1zqH2dlYlsNy8qroPzzxcEQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4945.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(346002)(396003)(136003)(39860400002)(38100700002)(316002)(110136005)(122000001)(478600001)(83380400001)(8676002)(71200400001)(8936002)(86362001)(52536014)(76116006)(66556008)(66476007)(186003)(33656002)(7696005)(66946007)(2906002)(107886003)(53546011)(26005)(66446008)(5660300002)(55016002)(6506007)(64756008)(4326008)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U5qS2pVSxKjn9erkh3fWmfYCxg7rg3Lml7q8Jp0+X+Yba8/9Wm3e0BRRXPFw?= =?us-ascii?Q?AgdC42MtXvxCjXqaVPKyGHGBxyckXtBSMQU2+oPsd9PUpnHeXelK8hjfiWW7?= =?us-ascii?Q?zcJqzVRfi05T/+arux8woY6GqtRfcWugVYLuOxjMGM/IWg7zi7SZMuYt3F8H?= =?us-ascii?Q?Bf/8+9KYPG+oX1RjffD6Iudy3OjQb4kFWe8rjwn6/+Ik5+bTB9mem7zV49Df?= =?us-ascii?Q?s9BetaRxZlPT/A4fOYzHG9/C60gkfwB52IUzZDhI83qX7UDuo25Qdw3TdH9M?= =?us-ascii?Q?+C1Uxvo1EJokXqUhajWm6voM3co+q62QRlrVSvvMWTWMGAIsrRhq2LH5EeB9?= =?us-ascii?Q?Qk9w6VN/QdYQ8TYGhMlfR2O1/zNud3wM+nvSDJyWoIC3ONORSl3cymk1uEMx?= =?us-ascii?Q?4A0HYLmiMHWXkghwco9sjKigLft8yQBKvhyRHT1AZMdoaK/LggGQl8jdMOGY?= =?us-ascii?Q?DcUuzpfolAq3cedXFZmAQnGxqmOGBdp9uCRYoDEA3KitrxJYto+rUx8DxBZb?= =?us-ascii?Q?fcRmi0uHjbT/szIMcRUHFpGHHTFW87KOBGjhO8W+0RpcAqg9SGldKapXXVcz?= =?us-ascii?Q?RA7sUQyR5LzSjMXgYgFjba93q0l7lduvlaaIq2zhxQyljCufoiyqO+Qa2aV4?= =?us-ascii?Q?fk8j0sTZJb/+/fCugvhrQwKPYnjiZT3LewuVDIj951x8UH4/Nj31rKeSidaf?= =?us-ascii?Q?WSlQZ+KKQh1eLjB4DpCL+ZIo/gaVn9HMams9dIjyaZWVHzi7OWSqu8S+SoBK?= =?us-ascii?Q?vvTuIlAOswzaY7Mh+2iO27hyhWHFZR7ZUd4+6AEv61DRMH8j86DJc6JTkl5Z?= =?us-ascii?Q?1Wio5xBuyOffjjn5XjBwENWgw9jfxrHBYuN6AMmb166ewsx+LSWqC3XqLPuW?= =?us-ascii?Q?/QZ/bgG4B5P64LRBHYb+WOpnzTSWwXeUEewy58GejmKlEWTvvDNUG4M8LCGm?= =?us-ascii?Q?he/mNMjwG1q+Bxvpz5w5/NL9xq5o4xGKpYnfLQGgbjF5ejOJP9x9ojEAYMiY?= =?us-ascii?Q?j4uwAJOHwNpdB8GYgitRZi5cNvgI/g5B8IoO3DlLT2sLbiSBNUp68QuINR/Z?= =?us-ascii?Q?ehziIaGOt3NZNHIJY+VtQqevVy1lll7aAXjzY7NdMLU36AoiJRA8gmkQRIqS?= =?us-ascii?Q?gJpWVd5GA0swDDM3cdkOeka85qnxm55sDU3YMsWFNDoiMxGC0/Dw2MKWX2SK?= =?us-ascii?Q?vuUYLvc07fiIu2ZUOloEzoXAkpDCXWwZdeAep0cvPxOYK+KrMPZReZBPHo4R?= =?us-ascii?Q?o9NFASWB0z60/Q5/cNw54Br5ci4vXOj7V71uicfCqMVlcHFiNA/ZmxBrHwC3?= =?us-ascii?Q?1WHNwtKO1pUpuw0GyFDCWLbx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4945.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f59ca0e4-06c5-4b91-5921-08d93cd2c7cb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2021 20:57:04.1431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sFxirh5OM1W6BO8p+r2mzDFjuqClzzSPiNXl5ErmHEzbiUpf9RpUdy7ckf83kCu4Ja0+j3pprTLxAE4nvwQxUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4995 Return-Path: maurice.ma@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Maurice Ma -Maurice > -----Original Message----- > From: Dong, Guo > Sent: Wednesday, June 30, 2021 15:51 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Fix the build failure >=20 > For non-universal payload, HandoffHobTable is used without initialization= . > This patch fixed this failure. >=20 > Signed-off-by: Guo Dong > --- > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 3 +-- > UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 4 +--- > 2 files changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > index ed956c447c..ae16f25c7c 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c > @@ -559,7 +559,6 @@ PayloadEntry ( > { > EFI_STATUS Status; > PHYSICAL_ADDRESS DxeCoreEntryPoint; > - EFI_HOB_HANDOFF_INFO_TABLE *HandoffHobTable; > UINTN MemBase; > UINTN HobMemBase; > UINTN HobMemTop; > @@ -603,7 +602,7 @@ PayloadEntry ( > IoWrite8 (LEGACY_8259_MASK_REGISTER_MASTER, 0xFF); > IoWrite8 (LEGACY_8259_MASK_REGISTER_SLAVE, 0xFF); >=20 > - Hob.HandoffInformationTable =3D HandoffHobTable; > + Hob.HandoffInformationTable =3D (EFI_HOB_HANDOFF_INFO_TABLE *) > GetFirstHob(EFI_HOB_TYPE_HANDOFF); > HandOffToDxeCore (DxeCoreEntryPoint, Hob); >=20 > // Should not get here > diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c > b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c > index a67653eb11..7a00a56ab9 100644 > --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c > +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c > @@ -364,7 +364,6 @@ _ModuleEntryPoint ( > { > EFI_STATUS Status; > PHYSICAL_ADDRESS DxeCoreEntryPoint; > - EFI_HOB_HANDOFF_INFO_TABLE *HandoffHobTable; > EFI_PEI_HOB_POINTERS Hob; > EFI_FIRMWARE_VOLUME_HEADER *DxeFv; >=20 > @@ -393,8 +392,7 @@ _ModuleEntryPoint ( > IoWrite8 (LEGACY_8259_MASK_REGISTER_MASTER, 0xFF); > IoWrite8 (LEGACY_8259_MASK_REGISTER_SLAVE, 0xFF); >=20 > - HandoffHobTable =3D (EFI_HOB_HANDOFF_INFO_TABLE *) > GetFirstHob(EFI_HOB_TYPE_HANDOFF); > - Hob.HandoffInformationTable =3D HandoffHobTable; > + Hob.HandoffInformationTable =3D (EFI_HOB_HANDOFF_INFO_TABLE *) > GetFirstHob(EFI_HOB_TYPE_HANDOFF); > HandOffToDxeCore (DxeCoreEntryPoint, Hob); >=20 > // Should not get here > -- > 2.16.2.windows.1