From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12CF57803CE for ; Fri, 28 Jul 2023 05:24:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jz5PikDQryOCitiPMSmXcQgk2arIQ+q7EJoV2xsdlaY=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeadersSta mped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690521842; v=1; b=cL57csS8L3Aj+yxwKEs3JwVnpFIGs5UUDbMI0sPc4NwY9Yk0E6s86gW1a4YMTBMBYBe0VYOs j9qav98WUz8mrR2HKZymO3nnLd255LuvYW04MwTtqRnWiefBpb1iZFq0GIg91Bpg2NACutjJl+D v9esjdZQ2HllK8/1d5QfxDBw= X-Received: by 127.0.0.2 with SMTP id mRzQYY7687511xdfJmK0UakE; Thu, 27 Jul 2023 22:24:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.26563.1690521842036445738 for ; Thu, 27 Jul 2023 22:24:02 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="368526431" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="368526431" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 22:24:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="870722912" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 27 Jul 2023 22:24:03 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 27 Jul 2023 22:24:01 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 27 Jul 2023 22:24:00 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 27 Jul 2023 22:24:00 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 27 Jul 2023 22:24:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5qzJz4s4H5taXlE9ou7xnHX7jm2KNWWsA1b3i5B3oEcMMokO8DMJprQnZoa2KV7lr0t2Vcgi9IgOwg26bRCY9o1zkFTLOPieMWG9bSchpe7r0fnB7xjbmPt9uGrgv4wgWe2MilyATa7AiYzJui+QR16S537wk6RgML9CCaqhPTkVDyJeqaxmHLfmIjyiJzgXXuhLgF4QDLdyeZANflv26WdVupmq7rGwMuicEbc3Kc9UR4gd2PJVJdDHs2NFz7dO2VSzuJ/j/X0SskAsxuMjAkrotv0iym1g7711AwmBsmO+YAzb4dVNlpVxfAIsQ3cKTTomoTW03rb1DZFX+u0Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hjwFawZUjSz3erCgIFASQpwtV3qfpJh/RAOGvcvDb58=; b=J4A5XEe2Hbj65Rw5yypYhFU02uey7tKE87ZBTolOLyUeFt/lQrfRYUDO4XBNps2QE1LgoNmlMqAFARUpCLZXwxTS4X7Siy+xvE5QLNIm5rTUsPHQoxhEzpiin0gHg+sGoXlCzO28aR/QwQ9VBbqZSEYHNZ1gL7Oj3YHOeI6Z9JI4iPxl7Fuc/L/RHLSJeWSIZOliPut8vWE6LZ3XDybKnxxVqwJ7pWxoGvMbrE2KDZ1zZRLIGgj118IXc0dIGQ03LF1x5iQSmcLK9uTb7gZw2NUQtydZNFtTWyt8dtXLQ+IDkqXkjB1ZEsrq1nAcwpYC26APrwnunba5UPm+N34Yaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB5026.namprd11.prod.outlook.com (2603:10b6:303:9c::13) by PH0PR11MB5806.namprd11.prod.outlook.com (2603:10b6:510:14b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Fri, 28 Jul 2023 05:23:58 +0000 X-Received: from CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::ed23:8558:1980:cb8a]) by CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::ed23:8558:1980:cb8a%3]) with mapi id 15.20.6631.026; Fri, 28 Jul 2023 05:23:58 +0000 From: "Yuanhao Xie" To: "Zeng, Star" CC: "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , Gerd Hoffmann , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Topic: [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Index: AQHZwRL2jP+w119yqUGHXqQoCoBWkq/OpM3g Date: Fri, 28 Jul 2023 05:23:57 +0000 Message-ID: References: <20230728051805.6250-1-yuanhao.xie@intel.com> <20230728051805.6250-3-yuanhao.xie@intel.com> In-Reply-To: <20230728051805.6250-3-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5026:EE_|PH0PR11MB5806:EE_ x-ms-office365-filtering-correlation-id: 3428132a-c428-4b45-de38-08db8f2ad806 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7bhRTTROD1L35+vC5x3YVd3evIzeQ37/4sOactURMRkYYvzMopH+oJsU3Scz2ElKkvzuwrFZv19UCgMbOPTMG9HIP6ErKDnBh6XhTMFToUXc6SFTqD6PZFhaTcbpqHY0uT3L6/XybdLeAiQb9gXDokiUKiR5PmJgDMTZyTvTfkCpsqS2Sf5URGUf7+nkbx7Y5dm7DGmeaXgjfD43fAJIKoFQ3Ljw67xNzjYKU38gXVc7mHyxd1GFw7tMO1rwZU68mlN6bJMJ8n/8F9UcWUUxpsq7KWXyJEOK7zjCCnvbKlwkjAiGny/8Ptfv7/QPgZkTOAntvI/jTgce6TCI08n7E3FWK+xnF+VTL7Vukean2cT6KS5FYh+8lN1yeJF+PD95Hzaj6JLrhq6kKjy+JIKuGhvt5D79n9/2cjlwyV2ft7ndtlTov5valOf8irP7DMJ9zi+Pvu5pbKC9JRoNn4C06d6Xr2Y/ANWVG6cNgh/saKMPLhHmdRnfY3wRlwyld2W5tB0RM1aXuoP+W0HQzUtMFxUnq2b96ExQ2m+Rya2XveTu+Ln1aLH50b7evt1sKC0bIolFHYLO/waP9dGQe18z2A/P1mPvnTE6Hw0oLPILwrxNma7Zbclxle0FmcmwKdOqTiMRAw1IsKdP1As9gwDeiQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y+Fv7cJLOgQ5eXfDjhkNE/XLtUxuIfqRqneSfNbRg5UE02qTCUoHy53nik3A?= =?us-ascii?Q?1ScQH4EgvncKWz7fBtcpCNtrzWr2WtFZhmsgovKedJ1os7zK8pF4NxPFgeSw?= =?us-ascii?Q?Nm3J98pw4NLZxYuEo7OGtWDP0/SYZQYIjHXr4XIVpFwNe3yvifOKrfxRgxch?= =?us-ascii?Q?bpZYNUcNBEUAPC9BEja9AQcFRQaOhhdvSi9g+G1VwSagDKLZoeOEc/H3aXY+?= =?us-ascii?Q?HfPNU1+IPyGBmCHis8z7vJWmeJcJ48HnjX/nRTIrND/d6v+WnRo4nPX5ZlVI?= =?us-ascii?Q?niiLgRNWBqjEhfCHh8GIVMV1yyF9XJdsL/FUACW10/T/DtYJ20hYIUndUQFQ?= =?us-ascii?Q?G+VbQ0m7h/dJeRJDA01Ev+aLxp0vm2OamOr9UIIQSIkOYrnnAkpXlreznvH+?= =?us-ascii?Q?ImhYDkpYFlNhVkPzGHX2yTGAJegS/XRpB8HNJHIdPww24+eOmM0GG03Zvt1c?= =?us-ascii?Q?83UNQFzSrAs3MfOhqrsi0PM7e1abUMUuTD/SzfEhowMqw5j/iV1P42x6f8q4?= =?us-ascii?Q?Tz6TnGdaV5ZkEPiY/bOueD84xyNOvcEN5cTIo9p5+O350Pf29Be6ezDZksYI?= =?us-ascii?Q?/QLxpG1mLn6yRuRyVqjAQFnaI6TzP+kTMpZTHMUnoSdYCZ6qyHgcSPYuaxLY?= =?us-ascii?Q?knt4ENWigLC4cEvtoO+4FbsWe6uy5KOrM/mhuzWtr8HQ8gLXaVxFFBr5qGqQ?= =?us-ascii?Q?m2d970Nndp1n2UHcx7w7fh1f6vwxCYrsR4ypi+0GZ0GDbo8NFCS+Nfv2e0c2?= =?us-ascii?Q?ReLYfXcLM9eHA8etFqhtoW5khH7g+tBXjyO/GXMhweuGCiblF7yqCmMfMzoP?= =?us-ascii?Q?OF6sRp+TkGiiUxnfKkTH8qwiresJhHIbEu4ZfQEjTmBphtdUULdC8tM2nnbS?= =?us-ascii?Q?teag3AnWngcFOYQMzlnZdHCjIgs8zGYYI7i3srYZP3MlqkU8Zbu7f8IVaaY4?= =?us-ascii?Q?1goId5FxHxhkM0JvwiVuxMZ0wYqxlThTWAx4QUMfz49seYqJ03dsozLRhS8C?= =?us-ascii?Q?IFA/vIjLlAfg4zF2l0dvADOsQIeYi0LEdvnqc/RKZ16OA6+accJeAps6OTZK?= =?us-ascii?Q?kX/3aKN5MrH+AiL6I2cdA+BtrkQOHB4q7UKyn13HnA6LyqiZHZVzjHZpZEx9?= =?us-ascii?Q?wp/O7pJ/KcROMeg/utcazewdi3c7igUm88lalhc9zJkn+7E/pWamHikAmLJR?= =?us-ascii?Q?kjd4hoRVk6LBubchCOFAsY0WnBjXPATtCBy8DYmgrOQCzIsgmAmbBXbSEJ9Y?= =?us-ascii?Q?197V0nj0jsk+RMrOpK03r+6AWY2em0HwY/bNfKD4Rnm/5iNwVujvQr0/hzr2?= =?us-ascii?Q?BaU3w2G5lPH5/dmmSg/UKYUIPOhuJSS8aof2InO7O1ARhvdhqZgQJ13v99AX?= =?us-ascii?Q?R+nIFYIhsc1IQxdoqKrmJEZPW2Af0pRoYEKrZ4hB7YQdISpOj7ug0w+5ZUhB?= =?us-ascii?Q?JhUPG4sUHgAyUOTIgMeD5wD6qgW7kbBf/n0X08TMgnGjI4QY3HaiX/ahvAYq?= =?us-ascii?Q?XUwWRvg0HQve9klESHthw9HbHIDhN58pKVr3ZDTylTlvW6ApClZrM8ilQ+M5?= =?us-ascii?Q?1ON7g7Q8KOAPwIK/1HzH1FDbMsSyw2IesS4BAr0g?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3428132a-c428-4b45-de38-08db8f2ad806 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 05:23:57.8265 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ArMCY/h5eNSpIRkasqr9vEv9OJh2szqacCz4dyTYEfTCNka7n/k72P0Jy+K5i11QV36UsD9UEzHuWYu+6d0taA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5806 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2iDgUH4ZDjVdJKWlrC7rhZWMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cL57csS8; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Star, Could you please review this patch, I have made updates to the comments for= : Do we really want to mention OVMF specifically in UefiCpuPkg.dec PCD defin= ition ? Those comments may be better to be in OVMF dsc PCD override. =20 Thanks for the feedback Yuanhao -----Original Message----- From: Xie, Yuanhao =20 Sent: Friday, July 28, 2023 1:18 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Kumar, Ra= hul R ; Gerd Hoffmann ; Xie, Yu= anhao Subject: [Patch V4 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment = and necessary to wake up APs by INIT-SIPI-SIPI. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Yuanhao Xie Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + UefiCpuPkg/Library/M= pInitLib/PeiMpInitLib.inf | 1 + UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++ 3 files changed, 13 insertions(+) diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/DxeMpInitLib.inf index 7d45d3ad4d..55e46d4a1f 100644 --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf @@ -81,6 +81,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApStatusCheckIntervalInMicroSeconds ## = CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures ## = CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase ## = SOMETIMES_CONSUMES + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi ## = CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard ## = CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase ## = CONSUMES gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr ## = CONSUMES diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/PeiMpInitLib.inf index 83e9028d0f..bc3d716aa9 100644 --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf @@ -66,6 +66,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## SOME= TIMES_CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase ## SOME= TIMES_CONSUMES gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures ## CONS= UMES + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi ## CON= SUMES gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase ## CONS= UMES gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr ## CONS= UMES =20 diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index e7= 726a605c..fcfbd618dc 100644 --- a/UefiCpuPkg/UefiCpuPkg.dec +++ b/UefiCpuPkg/UefiCpuPkg.dec @@ -214,6 +214,17 @@ # @Prompt Configure the SEV-ES work area base gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize|0x0|UINT32|0x30002006 =20 + ## Determining Whether APs Awakened from SIPI or INIT-SIPI-SIPI. + # Following a power-up or RESET of an MP system, The APs complete a =20 + # minimal self-configuration, then wait for a startup signal (a SIPI =20 + # message) from the BSP processor. + # + # TRUE - Broadcast SIPI. + # FALSE - Broadcast INIT-SIPI-SIPI. + # + # @Prompt BSP Broadcast Method. + =20 + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|TRUE|BOOLEAN|0x3 + 0002007 + [PcdsFixedAtBuild, PcdsPatchableInModule] ## This value is the CPU Local APIC base address, which aligns the addre= ss on a 4-KByte boundary. # @Prompt Configure base address of CPU Local APIC -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107319): https://edk2.groups.io/g/devel/message/107319 Mute This Topic: https://groups.io/mt/100405492/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-