From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.24641.1687743974276673633 for ; Sun, 25 Jun 2023 18:46:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=I7z9BCJ4; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: yuanhao.xie@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687743974; x=1719279974; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=p+fFC4bgAj5uBi1XgoqsgfVb3f1BQYvkfrOboISwY0k=; b=I7z9BCJ4kIXjkF6O/gKOXY1rqNF9qfHBnJU4AOWM3udka280997niVc/ OarKMNyyyQB4vwbotd10vCmSqsx+46hXB+VTQZaJU8wzuTOUjV7D6FO2C R1pWAMjl1nMmnd9dwsTP/nv07lB8mIh6yQUGlUs+f4n4VYK8s3ZwkB64L j2B1cg67vDAZk/+nPqmquGvze1QWaZAPtYHT+qIm5axKfcOfxkl6lbAaa 6RbmIP2qeXOcDqqJs4+yn8OM8Ry8w4r9lDGgtBqhqs7CcwzZA95KtwNlW XWnyqMdrgu4Wx1C9TPycwyMhwvxjgtc2SAvZtX7E8qRB4fFu0Bj2p6TKo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="391357047" X-IronPort-AV: E=Sophos;i="6.01,158,1684825200"; d="scan'208";a="391357047" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2023 18:45:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="719159416" X-IronPort-AV: E=Sophos;i="6.01,158,1684825200"; d="scan'208";a="719159416" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 25 Jun 2023 18:45:53 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 25 Jun 2023 18:45:53 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 25 Jun 2023 18:45:53 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 25 Jun 2023 18:45:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=igTwu1Noh6Y3zkT76ipJc/leuNnKX3tcuNzoceWCgmsbIazHK58/BeBCJAjVqBHyKM65ro9aQN0eL6GwAiIjHBUKUHpBuY/J4JgJ2VezcJ4V8PXft6lcRh1VP7OSshXQL90vNx5D0hqB/YcXPS31ZpmA0tmw38WEw6rlzaDnSq7b0mfIf08plXAi9eoqHyaTwqB8bG83rOZoVXe12HFbge6rFfYyZOr/orVoiXo+wdoiu+Tv4znxLgvb5aiYpmdnCpLh4EiAcpQPDjgVsD7BiZ5TPfHNSbgWa8oMwKmTZ1SpWWDn1hHa7K0WZV7gOpLxDBGu7tZPHBEOX+kXHGX4IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jvj1Wi22eg2S5xx2b0EbzBfFE8AEKRChO7Iho5+dSxM=; b=XTJyb3QYk7R3WcM9Sq1mxfijMw+IplfJ0tGyFq+XuFR7jTbFu3DoLqHyghm3MG4QtHCocNaMJ9RlgdcOTfVNFKmNs4eALHw/XTxUdh6unhiP9Oki6vqZGfHAaXi/Zaz+at6saxp/tKziGaIkGYEHC5E22XHXeowFpUC4YBYyzl2vj90V4ZX0c0ug/Kg4XVndJCc5P3QZRjzsWT69tcXn1RVpwI9PTsJPGjTLjTnnf4muBOl+M0peBfuTBD4Pnwm9XG1d1DLKvcPEDhoiguJySDJAmMe1AcTSNpDZTdTc6pBdbLBGppwJCmOrBYGidjSvWIDLF0LD0K4yemlbTBlLhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5026.namprd11.prod.outlook.com (2603:10b6:303:9c::13) by IA1PR11MB6098.namprd11.prod.outlook.com (2603:10b6:208:3d6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Mon, 26 Jun 2023 01:45:50 +0000 Received: from CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::95dc:1690:6fc8:790c]) by CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::95dc:1690:6fc8:790c%7]) with mapi id 15.20.6521.023; Mon, 26 Jun 2023 01:45:50 +0000 From: "Yuanhao Xie" To: "kraxel@redhat.com" CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. Thread-Topic: [edk2-devel] [PATCH 3/5] UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. Thread-Index: AQHZnTMbFT4c95qp9UCOERSGxeuPaa+Tx58AgAfnWuA= Date: Mon, 26 Jun 2023 01:45:50 +0000 Message-ID: References: <20230612133720.15501-1-yuanhao.xie@intel.com> <20230612133720.15501-4-yuanhao.xie@intel.com> <6wlb63465sjdrac2ilgfalnshfgfn6wi7zlak72tdyzwekl7p3@fp56m5kjjjry> In-Reply-To: <6wlb63465sjdrac2ilgfalnshfgfn6wi7zlak72tdyzwekl7p3@fp56m5kjjjry> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5026:EE_|IA1PR11MB6098:EE_ x-ms-office365-filtering-correlation-id: bf096b09-347f-4e39-334c-08db75e7122f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dM9gBbWSb6WS/Y7bfVZvDDKcOEyOiapksbnb+hLnck+jqfON8W0kW60rYGF26C9CCUv4wHFhNQ/WkzUI9yw8NdtKF8IWQeWqkVBMbzqOw0Cwm4Sj4JJFMje8RfvxqtfK3EMkkLGiK4rk+r0VYuiTr9EArHRdQ69anRrusxzegNRLm8EtIZhh1pz5vkrhpJ7JRoFOE/twTIODwYDlToRuc1cAkF9eMC8/7RIb7SHTJjZzP73RSyZGBUOQA0yb1l3pJqFPHGQOCzN+X+MWkxP7383GSTA2PuqWym6iMYQLnNWINA2tvbRm90i3nfD0+wD9L7EKJS6wFjeyT+rtRhyRg1TWIcKlCy6MjkWuXL67m2YvBXghiZAkDH6kdlqaKhbfqa2cvmPp2JKJDNhGYvLpWkuHQyGfyBzfV92pQlTTBfpaHm0akh1HZH93ddzSFvYjXQ3p6z7T/5gIuxiW0hhqcwUXUBl9I7PtbI+mAkFcZBb6x7n+b8wLyBOrSmAUgYwSuV1ugbJrcb3eKGma6MtuB/7xGaMn0fBWmYYUPC2s622zU7zXhI/+nEfyPWLxmpEMp/3ho8RQE492jEgPuqtoV9f1kaRXMZn0+KWiX661zmBzd4QsnOkuh1j5jVFYBWgFluTGLMhHZtEDD3p8DWjqNA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(82960400001)(122000001)(38100700002)(38070700005)(83380400001)(33656002)(86362001)(478600001)(966005)(7696005)(71200400001)(41300700001)(55016003)(66476007)(66556008)(66946007)(316002)(8676002)(76116006)(8936002)(66446008)(64756008)(53546011)(26005)(6916009)(4326008)(6506007)(186003)(9686003)(2906002)(66899021)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vXPCaA/zAPPR4JHiI6L3a7cezqKlCgpoZaFm2unaBDS0KlJ2HaTogO0VP7Uu?= =?us-ascii?Q?Qz2ZDjzfOg66TrXo705GtE1UI3wtsL/o5Qq6ArTixfoytUKhmfXl6zp8/f3Z?= =?us-ascii?Q?ALZPzTt/79FPqDRWqBp7ltl1KZQ94eRrPwW4jfdp/iNlR2Doo1E8s6BRXv5f?= =?us-ascii?Q?RN1Y8FGUWqTxG0z9DEXQvBTeQSFV/XGzHsthpWgKdnFKGSvWaHM3mLg0pflO?= =?us-ascii?Q?HvBIIME+J1J9NiRG6QADvqDBhfOISM5kgR7ZIDqDBQLar79a3nuFbMi65FsV?= =?us-ascii?Q?GUb5v9tvgSgk1urQGmkjnHoKd+W/6PDr0teF+afPIQt6Vw+gH1Khb/APBSG6?= =?us-ascii?Q?QFNBMsYuSYSunI3ztqjfys88H8gH8Po3KnL85yJCPUwxGJi2cN0rb6lMqG4C?= =?us-ascii?Q?HUEVT22ydqkb6qD/CTmyitW8JRU7SI5u3atqbEOj7JA7M/J7anXJTUCTyhez?= =?us-ascii?Q?DD0/Y8j1O+/aZRVvGYNH8X0Ilfhu1p5EamwgSet9f2GMqTg/Sop0fRlVxirI?= =?us-ascii?Q?jpkj7nGyhnFkXxc04vtqy1Iq3SsT4dBNreBeAs0oJrdEwXb40OxuPrrD1T+M?= =?us-ascii?Q?sxykw5IdBe9X+XrmnhqK9/2YAE5cQSxjJo+xUlWyjAb5MFM9XzUGTMhdVdvu?= =?us-ascii?Q?ZFUd0zI12/55Yafvu5XQxYBemdW77daOAWHy1MWA3gg49f7h7ysEp8DmGthv?= =?us-ascii?Q?rEGVVrExqgbw3MfiKfVaamFh25UMk8XyD7f89xouMtkz5QZooPBSwIITgCM9?= =?us-ascii?Q?94I1YADASyo3YMR/XKckmYZ6fx7g069QpiwltGThazFATUSfqy1Pei5g2+vj?= =?us-ascii?Q?K3SKysUniKeK3W/3JZ7loPYyzX1wC+w+Ykdu1RGBo/Nxqo4p+GEG1FcIL+7g?= =?us-ascii?Q?zZBn+6N/aZr9rXHxf4XKmncDnCR4SpuQ++W/Nt/+w5ZndwSPgl4lp6GfSEAX?= =?us-ascii?Q?XMpvoUn3OXvMdzI0e+GLIKgwlqyt+EiJm6+H52XuCnazHux3OXoXAoou8Yyq?= =?us-ascii?Q?zx2L6/e3rChsbQaE8cn/+ZBLlI8P8e6i0CjORO6DJ5RZQuTxF6L9mJKjNEdx?= =?us-ascii?Q?ulTZZEnmCuq5rWIbGrFZ3JycSPXl/pe2hEcTDpf0q18dXLZhuX9wW2udyHxa?= =?us-ascii?Q?14lh7TPdyV7DpZg9TaKeRjif25pQa0yk3LWa62g/YOpWxW29y6NDX3pmUpkX?= =?us-ascii?Q?v0PZJJu3dWWkNoMOkNDaxu2aLDgKtrU6S02hf+EUqk2/qezY4H7rl8Mgo39u?= =?us-ascii?Q?04mEA46G9ndoaUyrU4tlTfz1rnKPn9qhTVgICCxuTvDpvNvwtzx1OgYpUuS3?= =?us-ascii?Q?QEcfyBlcLdE9N+G9E+xYG5jIG03iWN5IclXxYT7QNKhBViYzR/LmoY0sP+L6?= =?us-ascii?Q?9mHBK2qQNpOeboAj92XesMLl9CYXwLefycn21ZeIKl8AoxkWFo0NrrmhT32G?= =?us-ascii?Q?cB/uJGhdtuuI5vqKkl1SJbGnd538jbb0a/cKz7davbE5RWJW65YYqkc4pWUM?= =?us-ascii?Q?Ld8s/9mvflOWv4xtzDCdkL4xnuKoa3MqjoC0XBp9MdhCukqXwtoOlL5NNBB/?= =?us-ascii?Q?xdqj/s3SDzPQlFmdkuYH63y81qxxvdstSjumw1JJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf096b09-347f-4e39-334c-08db75e7122f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 01:45:50.5778 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7XY0f2yU+qlcj5h3oo9sQ80bEW6o0FwTB0WgfcWl3NEVQ+AshbT7d8Xuy1A672elYuGfcRnZkHkzsuSAvgtbFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6098 Return-Path: yuanhao.xie@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gerd, Thanks for the feedback. I have updated in V2. Please have a check. Yuanhao -----Original Message----- From: devel@edk2.groups.io On Behalf Of Gerd Hoffman= n Sent: Tuesday, June 20, 2023 10:11 PM To: devel@edk2.groups.io; Xie, Yuanhao Cc: Dong, Eric ; Ni, Ray ; Kumar, Ra= hul R Subject: Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg: Refactor the logic for pl= acing APs in Mwait/Runloop. On Mon, Jun 12, 2023 at 09:37:18PM +0800, Yuanhao Xie wrote: > Refactor the logic for placing APs in > Mwait/Runloop into a separate function. > + // If AP start-up signal is written, AP is waken up > + // otherwise place AP in loop again > + // > + if ((*ApStartupSignalBuffer =3D=3D WAKEUP_AP_SIGNAL) || (*ApStartupS= ignalBuffer =3D=3D MP_HAND_OFF_SIGNAL)) { > + break; > + } > - // If AP start-up signal is written, AP is waken up > - // otherwise place AP in loop again > - // > - if (*ApStartupSignalBuffer =3D=3D WAKEUP_AP_SIGNAL) { > - break; > - } Nope. This isn't refactoring. Please split the patch into two, one doing = the refactoring without functional change, and one adding the code for MP_H= AND_OFF_SIGNAL. take care, Gerd