Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: After reset, wake up APs by SIPI.

["Yuanhao Xie" <yuanhao.xie@intel.com>]

Hi Gerd,

Could you please provide me more information, like where does it hang, ad what build and boot options you use

I used this image https://www.kraxel.org/repos/images/fedora-30-efi-systemd-i686.qcow2.xz, and extracted the kernel from second partition (VFAT) of "/a29755367bf242efb072cfdd1a70134f/5.3.12-200.fc30.i686/linux" .

Build and boot with:
build \
    -a IA32 \
    -b NOOPT \
    -p OvmfPkg/OvmfPkgIa32.dsc \
    -t GCC5 \
    -D SECURE_BOOT_ENABLE \
    -D SMM_REQUIRE \
    -D NETWORK_TLS_ENABLE \
    -D NETWORK_IP6_ENABLE \
    -D NETWORK_HTTP_BOOT_ENABLE \
    -D TPM2_ENABLE \
    --pcd=gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel=0x8040004F

qemu-system-i386 \
    -cpu coreduo,-nx \
    -machine q35,smm=on,accel=kvm \
    -m 5120 \
    -smp 2 \
    -global driver=cfi.pflash01,property=secure,value=on \
    -drive if=pflash,format=raw,unit=0,file=OVMF_CODE.fd,readonly=on \
    -drive if=pflash,format=raw,unit=1,file=OVMF_VARS.fd,snapshot=on \
    -debugcon file:debug3.log \
    -global isa-debugcon.iobase=0x402 \
    -chardev stdio,signal=off,mux=on,id=char0 \
    -mon chardev=char0,mode=readline \
    -serial chardev:char0 \
    -kernel linux \
    -append "ignore_loglevel console=ttyS0"


The end of log are as following:

	PixelBlueGreenRedReserved8BitPerColor
	ConvertPages: range 400000 - 141CFFF covers multiple entries
	SmmInstallProtocolInterface: 296EB418-C4C8-4E05-AB59-39E8AF56F00A 0
	CpuDxe: 5-Level Paging = 0
	MpInitChangeApLoopCallback() done!
	SetUefiImageMemoryAttributes - 0x000000007ED47000 - 0x000000000000A000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ED3E000 - 0x0000000000009000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ED33000 - 0x000000000000B000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ED2A000 - 0x0000000000009000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ED1F000 - 0x000000000000B000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ED11000 - 0x000000000000E000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ED04000 - 0x000000000000D000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ECF8000 - 0x000000000000C000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ECF1000 - 0x0000000000007000 (0x0000000000000008)
	SetUefiImageMemoryAttributes - 0x000000007ECE9000 - 0x0000000000008000 (0x0000000000000008)
	ValidateSetVariable - Variable (4424AC57-BE4B-47DD-9E97-ED50F09F92A9:DUMMY) returning Success.

Thanks
Yuanhao
-----Original Message-----
From: Gerd Hoffmann <kraxel@redhat.com> 
Sent: Monday, March 27, 2023 7:03 PM
To: devel@edk2.groups.io; Xie, Yuanhao <yuanhao.xie@intel.com>
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg: After reset, wake up APs by SIPI.

On Mon, Mar 27, 2023 at 11:17:11AM +0800, Yuanhao Xie wrote:
> Following a power-up or RESET, since all APs are already in the 
> “wait-for-SIPI state,” the BSP can broadcast just a single SIPI IPI to 
> the APs to wake them up and initialize them.
> 
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sean Rhodes <sean@starlabs.systems>
> Cc: James Lu <james.lu@intel.com>
> Cc: Gua Guo <gua.guo@intel.com>
> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>

This patch breaks OVMF (just boot the firmware in qemu image with '-smp 2').

take care,
  Gerd