From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.11654.1687942366173118610 for ; Wed, 28 Jun 2023 01:52:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZN7XpzEh; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: yuanhao.xie@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687942366; x=1719478366; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0u7m0jVxBW1yynJWxGTT03jxMiu1F2KwkRTSAw2IHCY=; b=ZN7XpzEh/RpllxUGZkjpsDNyjf7EZIxvTqYg9HNkVWTS2ho2KZdCDSbG vx5H26x5dWQwxGIu4j3VBHSvcebzUttISZlasQg9+vpLhpxJbnDQeVouD XeyHZanYhFxAj1ufOiRbClqdIDcyTgAvE9d0c+WQEF86tE704/e0xm0A4 xSQ7Xyw0H+R7P6ZkQzQcfSEG8vIymz5Zkkknd0LJQuVcGGRnLIyunD3nJ 9bcIkwIRhXvUfZrvoa4oh5gFO4/lbDldpJEnQyIsY7lIuFY/jxh2+a4N9 1B6eOLsWnfua9fLDzDmlhNEDThbmx+wvn9KtQD+cQdCNme0Jm1gUPFd4P Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="341374554" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="341374554" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 01:52:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="890965758" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="890965758" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 28 Jun 2023 01:52:31 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 01:52:31 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 28 Jun 2023 01:52:31 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 28 Jun 2023 01:52:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2jRAvi+d1lgLqd//xQK8RELUDP3HNrt7Gkf9gZnGx/+xrD3ZkvT11odNnJCjhV8NIll4sccsHSY4HGhlwuTKNk+S9J10Yxs8e2aLxguqk8a2oPepqwMLCEfb8qciyEwpbGKONJFeDUIl2jdFfMwegsX5KtFDImgxXO0qXxnrxE4Nvy3cmR09JRURa3eCHwXLneUC1E9q25welDVhGcSRzcwNgueVFQJrIHGykAzvStAXit2Z3bbrzJ2KKvGMe/aQwUjcmxpdEHk+M2pLAoeQ/QCidMgVP7l6ETBloZ9tzR2imIEiaeK5B7YwZGaocXd8uxrXecd2JdQAbYG0m2hxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Kd+SFhCBm8CzKxuOtkm1JklwgMz/NxeVilqrw57VxY=; b=PLx/NSkg9/cx/S2cWKCuduimg1gKsYcz6qca4m69LkTdGHx93i8/IdhR/43+eQJ/Is3VmDdyq6G8SXxdmVJ/lBdyZy04x4npQyajScwkc4WHcxIO6rpRATYyEhZcVFABVwl+Ao8ekv3ayeiH+SX8bwG3pfr0NHOD/K5CYRG+esXvDB313OqdLeNJzJtaCi0+q0J4Mp1TufLbSU4ngib7/vUuJQhkQqBucGrRgWbggXib9lGRVEBjJIcy3O0Ftsb+KrK3M/trEMKQzav8qby1u6fhJykMC2cW1zb0EkvVuH5gyrzUWPGTNvTy3fASaeKCWHr0ovq60OIjItF1t1JCmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5026.namprd11.prod.outlook.com (2603:10b6:303:9c::13) by CY5PR11MB6258.namprd11.prod.outlook.com (2603:10b6:930:25::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Wed, 28 Jun 2023 08:52:28 +0000 Received: from CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::95dc:1690:6fc8:790c]) by CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::95dc:1690:6fc8:790c%7]) with mapi id 15.20.6521.023; Wed, 28 Jun 2023 08:52:28 +0000 From: "Yuanhao Xie" To: "Ni, Ray" CC: Gerd Hoffmann , "Dong, Eric" , "Kumar, Rahul R" , Tom Lendacky , "devel@edk2.groups.io" Subject: Re: [Patch V3 5/5] UefiCpuPkg: Eliminate the second INIT-SIPI-SIPI sequence. Thread-Topic: [Patch V3 5/5] UefiCpuPkg: Eliminate the second INIT-SIPI-SIPI sequence. Thread-Index: AQHZp/Mdcg1M96xQq0+5/XGWmwAhh6+eJwEAgAHD7CA= Date: Wed, 28 Jun 2023 08:52:28 +0000 Message-ID: References: <20230626055705.57145-1-yuanhao.xie@intel.com> <20230626055705.57145-6-yuanhao.xie@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5026:EE_|CY5PR11MB6258:EE_ x-ms-office365-filtering-correlation-id: a745429e-42b6-4e8a-cabc-08db77b50085 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jEcifxqfisC1I20WxNqsFB1wHSKTgqJxppIQxWJZmn89i3u+NRwHYZ+eGCzFltUnmis8whs/TI80ZPXpJb+zFu3V6i0nvy1Zh2RY0ZnEMHEIiFHK0ktwuGNPGu/tTtFUZXPFD02/VP5VngNgmFW8xf6vUGm+aOAgi9hAkCXhyNdF615RReu8LuqlhA1bAryRANPmmKVXRD1PsYIcy1RaZbCq9Y1Gpe3nHJ4brg/08kNbivJkaxHHBEHr7EqXN8I9PNZCfB5I63deWoP3r9SUsu6Gr6nUYZlvx1PbSLDbCDMXFIyBuYSzPCiLS4LzLmKh5ZCCkVp5ZdYm63vnU8y4Cq1UXn5su5y5w4ISGJP8swn7VYf8PZ3QP77IlMshynH+t2tvHtNlZ0v+tP1qI7Jn43+YFKOaRURyfaOw0gziEi5d/5kw0QCA1alBUD3tOKyoxpVqDU08/zaW7P4XMQi2DhLuJLCPCm1YOCW6GPjhcXq3zGx/q21mZYCKhq9knw7Xvm8xAGlubaXQow2dVPJv7b8DTsIgCx/OR5ldpcGFyzJHvHvveZZbQdwGbUFR3Y/feY/EIgWelSzBUiQUal52utDcVaxasDAFu/gtHZibnPaw+0HTG7vJXTtmma9lb4MR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39860400002)(396003)(346002)(376002)(451199021)(66446008)(38070700005)(19627235002)(26005)(66556008)(66476007)(33656002)(122000001)(5660300002)(52536014)(6862004)(86362001)(8936002)(41300700001)(4326008)(316002)(8676002)(6636002)(82960400001)(66946007)(55016003)(64756008)(76116006)(38100700002)(6506007)(9686003)(186003)(2906002)(71200400001)(83380400001)(54906003)(7696005)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UIV3VjkUXOXozSLsBGW+ZlvZ0KdUOIkS48Ry1u2cYiEn42+SexkdiOAasfSL?= =?us-ascii?Q?OCsDcnMfleyY1vb5cxpIXGswI38oP3hbUzhjGCV8r30J9Lj0NJEt39TwnifE?= =?us-ascii?Q?GbIV76UXZG2VEWIGPHsnr0u3iumi9tiCZ4ErqjD55A5kvsARRXC2QBeLLx5c?= =?us-ascii?Q?ErCwFm4frlZ1KT/NPT2mDGvHV8GYg8DDDqo+r7sfpwedAfF6e2Hjxf3sKsNZ?= =?us-ascii?Q?PTPGP07peHnQzMt8g3aSjR3b78Hyl23c84z0FKdFanImMwz5OaXpAIzlAvPH?= =?us-ascii?Q?e8Gee1xpClPXgs0+mFL9iGRl2AgK1aTWdeNeZvcRlfBTM0GhGQ2X6+2rD+YL?= =?us-ascii?Q?Zeg/pAgVwNNsnZsUN8cPeDUPmLfx5+Yi+OKdeOVq1LwFbGUI1626LSXqHYVn?= =?us-ascii?Q?uwyPKgr2BOrBo97R6shzYem/wieclkxQxF46STNZeEjV3lXqnAJ/Ziagu/wV?= =?us-ascii?Q?gStV/OTISGsdlvIpAYIsSm1qee+BZqdiNZa7IR/StAYZuZ36mgIT/0UsaPmX?= =?us-ascii?Q?+5JrCb0INmfX7Hr7tzPBRfSA/kfq9zdjNuJTfemIBlJjk3QXPD1IFdWcQ0Hc?= =?us-ascii?Q?EXI5EntyGJARyg13qSExIUX9XXGX40uOyQiNu1qkxSXaxMHCizclhPDrwK9N?= =?us-ascii?Q?yrg/9BsWB9uT5caonjDX7HckqvjCqM2tk1UsSFb5D+QRfxnijXHkOoPihEb4?= =?us-ascii?Q?Y3dkVqXR7EFHAmsghVPGcglJSezVpE9C0lXw3sg0gy2mEGYU2qPF+PJK382K?= =?us-ascii?Q?OOX6Eny0PpR5RFxzBnJYwyMKutyGsWgLgpgELIQpubDYQXvg+0yBfVc9C5SE?= =?us-ascii?Q?LBETjT/rHXRLIa/bPR6hVibQkJPfPmVZMkU02VEGrh9WivLP6HdcIMEu31b1?= =?us-ascii?Q?0/+v3ODtHeG2AGe+xCo9kpaTP3fnSjh8QXegWMoj0nmsQgKnKl2B9Cg73Wi4?= =?us-ascii?Q?O1SDKBSl+TZrnQU23YNUQa+yqdMidu1+nwkIrqoPkmf7wLh83guqwcSxSicn?= =?us-ascii?Q?0ayjXNy8DYXgN5mZUOBuPwmN133+X6p4Neacy4nNZ3BRHa0ew+gaa1DJ3r8S?= =?us-ascii?Q?CfQ0MIh4ytF4raupygHZupPsRWZht9Tocdc8orYOkidoxvMRROdc68Jkw/Jc?= =?us-ascii?Q?seOgmXkaXfPgZ2uxlYNMuTNOVl0XJ233VFzg2AN4L4cPT5zzuGzjYZNslmGj?= =?us-ascii?Q?VZcGCq7HtGY9L90y/7A0cgfD45r6n5TIATO9bKqZ05d99CeOAYDMt746vRYp?= =?us-ascii?Q?k0XbbYhc9GESSAdXGplOvfcn/wIYM9hztYqUukvR8X/CLfd1yyzmUC5yevgf?= =?us-ascii?Q?T4EbDWmOYbZI5tLLpulRY62jh7Ab/QCHbL1PEQ3bvTaxKVerSi/sBTDSdqxD?= =?us-ascii?Q?mD+UlNXgEwelAtU3p2TaBuCsjPewu4e+Bf9kQpex/Iw5TERq2URY6yGTuAnz?= =?us-ascii?Q?/9D5bO2PBZhOcvfKiycrRSq99DwaIdzykQESQ8BnAD+t2odCjYjD88jSt/zl?= =?us-ascii?Q?h8742uAFcVDI31kn/uEHIWxRy7nAw7hF9OD/eXIPDwCRdP2/pJAmjk9FHfpz?= =?us-ascii?Q?mnQMj6VUMSwwMg1tBzI0/qMcNwpEUgBC4k+5MF27?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a745429e-42b6-4e8a-cabc-08db77b50085 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 08:52:28.4249 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KIX3awfB+7Cz+Fo59f4uIlkDrQwvoLPTDhHF6XiHaUcrGWuEEoE1l9kwX7Qzw1FH41++We7bX6eu3B/SE7HJsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6258 Return-Path: yuanhao.xie@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, Please check V4 patch series. Thanks for the feedbacks. Yuanhao > + OriginalValue =3D InterlockedCompareExchange32 ( > + (UINT32 *)ApStartupSignalBuffer, > + MP_HAND_OFF_SIGNAL, > + 0 > + ); > + if (OriginalValue =3D=3D MP_HAND_OFF_SIGNAL) { > + SetApState (&CpuMpData->CpuData[ProcessorNumber], CpuStateReady)= ; > + } 1. I don't think InterlockedCompareExchange32() is needed. But it's consist= ent with the following code. Ok to me. A: I keep this in V4 patch series. > + > InterlockedCompareExchange32 ( > (UINT32 *)ApStartupSignalBuffer, > WAKEUP_AP_SIGNAL, > @@ -887,6 +897,32 @@ ApWakeupFunction ( > } > } >=20 > +DxeApEntryPoint ( > + CPU_MP_DATA *CpuMpData > + ) > +{ > + UINTN ProcessorNumber; > + > + GetProcessorNumber (CpuMpData, &ProcessorNumber); =20 > + InterlockedIncrement ((UINT32 *)&CpuMpData->FinishedCount); =20 > + RestoreVolatileRegisters (&CpuMpData->CpuData[0].VolatileRegisters,=20 > + FALSE); PlaceAPInMwaitLoopOrRunLoop ( > + CpuMpData->ApLoopMode, > + CpuMpData->CpuData[ProcessorNumber].StartupApSignal, > + CpuMpData->ApTargetCState > + ); 2. CpuMpData->ApLoopMode is set to PcdGet8 (PcdCpuApLoopMode) in DXE phase. It's possible that when building the Dxe instance of the library, PcdC= puApLoopMode is ApInHltLoop. Then above code should not expect the CpuMpData->ApLoopMode is either = MwaitLoop or RunLoop. But, if the CPU runs here, PcdCpuApLoopMode in PEI phase should not be= APInHltLoop. So the question becomes: Shall MpInitLib support different PcdCpuApLoo= pMode values? I prefer no for keeping the configuration simple. Then, can you please add an assertion before calling SwitchApContext()= ? (see comments below) A: I added assertion in V4 patch series. > + if (MpHandOff->WaitLoopExecutionMode =3D=3D sizeof (VOID *)) { 3. can you add "ASSERT (CpuMpData->ApLoopMode !=3D APInHltLoop)" here? > + // > + // In scenarios where both the PEI and DXE phases run in the same > + // execution mode (32bit or 64bit), the BSP triggers > + // a start-up signal during the DXE phase to wake up the APs. This= causes any > + // APs that are currently in a loop on the memory prepared during = the PEI > + // phase to awaken and run the SwitchContextPerAp procedure.=20 > + This > procedure > + // enables the APs to switch to a different memory section and con= tinue their > + // looping process there. > + // > + CpuMpData->FinishedCount =3D 0; > + CpuMpData->InitFlag =3D ApInitDone; > + SaveCpuMpData (CpuMpData); > + SwitchApContext (MpHandOff); > + ASSERT (CpuMpData->FinishedCount =3D=3D (CpuMpData->CpuCount - 1))= ;