From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.8006.1672903175242001934 for ; Wed, 04 Jan 2023 23:19:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ZUxkQMp9; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: yuanhao.xie@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672903175; x=1704439175; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PA0/llOOHq4t5IyM2VpMDXIdO1baZr6GVCTl3+I8WCI=; b=ZUxkQMp9b6/WyKwh+DorQd1nuiGmhtzKcI+8vxZfxsAv6nBlb0aqp1cN pwrmAV6sOMm8p+HcDPlmpOKQ/qYJ64p/nsbPgS6CZvyewCwBBPl2lQ8GT OJd7X93bn3g3hogQOpxGbI6VhegYTNRZrQqyt2OuIxONNJpvrlt+6getU mCcdpb/244aJn3aV9IUOqitoKHGgNSZ3jmEEXvDX/xh7XQhWCoF9c3Qsu RTo2IKYjBD48zojkestNONgyDZxkui4LLyHm19aLu447O1h8rQcC/N/HE 45QrvHzYH4Z9ugr0k8vi4WSEb43dD5OVmwxFAiV/rUqWylJsI2jJLK/bN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="408387922" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="408387922" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 23:19:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="655459590" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="655459590" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 04 Jan 2023 23:19:34 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 23:19:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 23:19:33 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 4 Jan 2023 23:19:33 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 4 Jan 2023 23:19:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fSHKJ26V+izv08CDEiN5eEfciHfDQrvRwCE80lFqd1qd06KYRf6O4A29T7wlIMO31IxOxOsKbDAgz1YaYhvg/T+tqeYnB1YY5C8zdqM60aXAxGQpigF9l/Z3pEhMc+x4pqwzD4fx0qgOU+d7xDsgYrax7RiQTRSggUFs944u54OAl2LHpmCTkX/S4aGAtXzR41iyeLPF51xe2SO00/ZiQaDzoeMScnmHNui0zm3ShATuTWL5/ST8Z/VWWUV13uqwNj7RTHNd6c43OJUyUgrF3i/EGm8JxFNfAEC8QLFuSqP5y7EEf8uEV4c+UjqqJ1feb7GpLKMHehh+llRDWhAmJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aXS1RkWBEu23WpSi5OuXi4O4fx/bEXaRrJkeP4Gw5wA=; b=h+fwNB7XUEDXc8oCB6n0Om/Xa3iC8a57qqgqksrhdeq1TvfXWbgkQ4h9PkmtcI2577bSyRN1G4M01Uf8ZTE8EP6FYjFv7pPfV/C2C6uM2qLW/aDwptu6oLbzR0zzCnopl/Zwmhg4g+Dz8gOkhIwAMd9j6QYwNZw0lA/oUwUI8cIubyhty1NYeKZIDHs8GW4fHZeQQmyarcH4CYTK9Qgu7XyhM6YOBspOeumyf1HWu1s986pZNlkMsSOnmPWxOB37DJ9e7PFb0E67sAjJH6PV5Azv+/1Cr0ozt+vRKRFmV/uPrdxk0UEd19XW/b6OXto8Bo7uz8oIN+W4hLXL9uXQRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5026.namprd11.prod.outlook.com (2603:10b6:303:9c::13) by IA1PR11MB6490.namprd11.prod.outlook.com (2603:10b6:208:3a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:19:31 +0000 Received: from CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::9752:5dd6:f56d:fddd]) by CO1PR11MB5026.namprd11.prod.outlook.com ([fe80::9752:5dd6:f56d:fddd%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:19:31 +0000 From: "Yuanhao Xie" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , Gerd Hoffmann , "Ard Biesheuvel" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB Thread-Index: AQHZIM3y7zRguZhih0CPAG/4hrEpf66PW2FQgAAHuqA= Date: Thu, 5 Jan 2023 07:19:31 +0000 Message-ID: References: <20230105062108.1796-1-yuanhao.xie@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5026:EE_|IA1PR11MB6490:EE_ x-ms-office365-filtering-correlation-id: e9eee8a2-76cc-47f8-5d77-08daeeed3094 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Um5+usawdMrkow2Ijd435JvWYmbt+yEa8p2lerCr56o7W3tHjxuUehL5jpKgRg1ggzNT8q7d3d9h2aplt/9gPeaesAgNBYIEUwWsGZaKggI6UJxYEfiK50u+bpBC9pkOksP4aFbrxRB8qN61QSpJ8TcjtNDO4Cgc1Svl4BqdMY89VhwUdWH6odPeCyCqbKPoOkOhPrtEJ88AJogLKBdbldcDfp1J3PSSmwSvKPZqS98jVA2cnWmJJlp1FAaM0CraFBCNEI6JskNgxmLGkUPjZhRq80aCwjO5Mr4lqRzInDTWXMgjWPhITAgvwMULohZL4hcECmaJgVNvPQLGujxzlWPOOluxutGvakb195LEz5jTUWGit4or/jAR+tj8DV49tbwy3ojc0NtDUMYkNG8huhvBhL7bEkrJ710mV+I7kNbhdnzMkI66fga3b/CjpKyhNhbDExO4Zq7bbOBkbGnZHsm/O8iMtwF3GNgQVcJSy+YkWQ22Ss7H8NgptPfhWfGDYSlN+l/Z8f4wmpfkMv4y/CqiGwL84bar4NPqzGwJ2w7DvM8XE5o9Yei4DWiGz9MjliFobkZoONRA6vciwxUhiaVpDX10eSr10aVL/T16gMsC6+mhy91tnhbDoflPmJTk8cI+ZsJvCy/CtQBxzUDP8PNyC2lVQkbszGHCiA4P/yWYfMsyCqLmxSYk+N/Cgj/fiNytVm2kbHKKQDhFovPdiQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5026.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199015)(5660300002)(4326008)(41300700001)(316002)(66556008)(66946007)(76116006)(66446008)(8676002)(64756008)(66476007)(8936002)(110136005)(54906003)(2906002)(52536014)(6506007)(7696005)(71200400001)(478600001)(9686003)(186003)(26005)(53546011)(86362001)(55016003)(83380400001)(82960400001)(38100700002)(38070700005)(122000001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1jzBWFbjYaePujzbob19fSJt9opMQpnPUp7qN4qMJgfXgLI2XiC9Ul6JbFPA?= =?us-ascii?Q?7D1XRkW3OkMq+J5v0XgqUmivRCvXWHkBVphxdJ5AG+ijMsmqFUCfoQwpGitq?= =?us-ascii?Q?OKcKU7AF+Jhwl8Pi6kCQ5y+C13KBmuPbt7qhqHi4vsHi2YMFt7bzS7g6wCaS?= =?us-ascii?Q?5FKcdg6HUUIwDRF0yoNUKYxDI458e7TjpGwtRvjcRA7D+nL71R6jsj7dyck/?= =?us-ascii?Q?fByD32PQmhnSZEsG6/rFhzO9zC497m7lu/zW243X/PFNFZ8pWc1YFXccMOk9?= =?us-ascii?Q?QXAbiZUsojDOhwYyPn2p3u+YVP9QsHN9W+s60Re1iwP0PavWNXi/4kkmNxX/?= =?us-ascii?Q?dtd7h49z//YzcWUyXnze2DdV+WmEpumJI9rMRpGEY9uJgL0x8nf9hrk4P+3R?= =?us-ascii?Q?xIxrw5q1MM+orc7U+oeBijA4VIIGgBbycKuHa4Za/P8AZZybz1sL00aHgb3i?= =?us-ascii?Q?CxJfnfD5iyKXTMH53ozYMsKbElZzfq9nPWkqafh8nL2vQ2GKa0myTgQbBWqy?= =?us-ascii?Q?dpw5X9CGWMS5ufbLTH1QRhJApnqv9wtxjAwn0UlIs7By2qzb1a7MhGWjGYJT?= =?us-ascii?Q?5DGYsLghOMdSHyCO8oB9q5P4L3XY5j7IRNP2UwuOHlznKselSpjCF10YwOxn?= =?us-ascii?Q?ZThiIBOJn/vQl4Rn2Lza4t4RmyreqOI2VS+L2ylzDwH3rjaNh2gOSZL/F9l1?= =?us-ascii?Q?qbNewpAdSdAxdKohB26VwcCRV3oAHhew3yEqbpiFoXca0w5I6WJobipV766w?= =?us-ascii?Q?MaxlG0/nde9f+1ouXTPnxMFfylQ5lyHMuTwyUr0t3obATvGS0NbBpxtVJTgD?= =?us-ascii?Q?aEOcHue+QFhvhFOKeosy/NGk+W4S6EGqJXBr8CxVLydfmtaoAEkbkQq+sDHo?= =?us-ascii?Q?XVpwdThQaOrSLAKYznvvkdGbsutVtmMF0aRPrNXFFCK969enUV6+MWB2KCve?= =?us-ascii?Q?XGq6vGmKbqC9z68zKh3LYHOqtuo/TaQEhfUvZc12EFMFjvnmYlXWjvJ1L/Wz?= =?us-ascii?Q?D55bSKqXtQhbgQwYjqPECrvf77THEr5N5hDdmVyEv6j/KPx39QxpKV29S+Ql?= =?us-ascii?Q?vTamNb5w0nqUzeBRcRWOxKGcc2lR8bHhm2gGJq6A5Teq2ObiaUvDpzMx6Beu?= =?us-ascii?Q?pKmIruTth6rj4ioKjAkarzXFEnlbT5KYxEBIBKhqVSRw6q58u9DvfPz/dPmf?= =?us-ascii?Q?z1NrwZo3XM80N8LaG5O5c5R+pvo3mO3SoQ9pJ2wz/5rwlOveDJuE49RwzwS0?= =?us-ascii?Q?LWGHoOBP2xihjK8JnXZ3sMHPeX7ElKVaVflhJZL/TnYnVeNgm8Bjo72SxI7R?= =?us-ascii?Q?re4jx+stw8p3qpNJipLdsWK6IFkhcX+zxD/rrva2JJggj/hWXIJP/i7VpZG5?= =?us-ascii?Q?ICtfwEbnEXhJ9H0f7Y49Kl4a56TSJlHgYHeuN6BvZCw6JQQ5aZh1a7+Yz725?= =?us-ascii?Q?mb1n0FDi6S41+mE+DMgDj7ASVYcghsDSrFd6fZUwihpCHuyvlAiOCIIiP98n?= =?us-ascii?Q?DBfPyx/nAhG7bBSPID/8NTc7aHkA5w7GWHiHNbYw4iwePsLU1UzGG6ZDc4gZ?= =?us-ascii?Q?OhV16vjhR3DfAY5IuXYiDIkvpy6y4ci7x3tGK1EL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5026.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9eee8a2-76cc-47f8-5d77-08daeeed3094 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 07:19:31.5880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HHw4BuElNqvYTBEj3R4ueDG3roXYxYq/5PyNS3Zv42SlYYn9178x8E3uhAlfuixNV69/UBy8qA7g6xSJ2v+l5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6490 Return-Path: yuanhao.xie@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable -The above commit message is not quite clear. -How about "Fix 32bit version AsmRelocateApLoopStart to retrieve the parame= ters from correct stack offset"? -I also recommend that you split to 2 patches because the code change here = fixes two bugs. Ok, I will split it as 2 patches with updated commit messages. - Have you confirmed that the 32bit Linux boot hangs without the changes an= d succeeds with the changes? Yes, I confirmed. It hangs at: "CpuDxe: Level 5 paging =3D 0" without code changes. With the= code changes, the "debug.log" continues to read "MpInitChangeApLoopCallbac= k() done!". Linux debug messages are also displayed on the terminal. Thanks, Yuanhao -----Original Message----- From: Ni, Ray =20 Sent: Thursday, January 5, 2023 2:29 PM To: devel@edk2.groups.io; Xie, Yuanhao Cc: Laszlo Ersek ; Gerd Hoffmann ; Ar= d Biesheuvel Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart a= nd ensure allocated memory <4GB > Fixed AsmRelocateApLoopStart stack offset in Ia32. The above commit message is not quite clear. How about "Fix 32bit version AsmRelocateApLoopStart to retrieve the paramet= ers from correct stack offset"? I also recommend that you split to 2 patches because the code change here f= ixes two bugs. Have you confirmed that the 32bit Linux boot hangs without the changes and = succeeds with the changes? Thanks, Ray