From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.8477.1636009389973936589 for ; Thu, 04 Nov 2021 00:03:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=snsYsrOX; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: min.m.xu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="295104248" X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="295104248" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 00:03:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="450350239" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 04 Nov 2021 00:03:09 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 00:03:08 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 00:03:08 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 00:03:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKm8fUBvV2j1h8PHu72S12kurb7BnoHLQDdrH5LGjPa9UFfCMnTUDVMKksHj4p+sInIQOONhAAkiIIPO2Xb384yj7Iv3YEPb2NR06oIp5vsHmzScS7UDL2kf0HaE4kwdRg5JgYP7ZxrIg24SYt6BEEiQ6p7K5cbcFAIjgrVsQwBMDm+EIA/IHMDApjnGODWmhncu3qkWjtQ5Jc7b2hbBblUf41Y5Esso6XbKHaTEhErhbK6OTIwFRVN3qguQYrTjXE7yuCdsy4y7r2+ZfEVKtJ8L3ceIv6PLRlV6WS/b/wsGMYLdDveTnzTwo5X0efFgrt6aLLDPzWlxXWYqStbVIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vMnyeO8gPAMyumtAX6Gd4NA2shv2THqiOF0+gQKip+4=; b=ZB7JNx8H9/8GzMe6FM4niGTuJ0Ig4z2oVKQRS9dSce8x/eP2iuhzxSqTqTkrTZC1FaSAx1MAovDitDOLZ5DPU1zAolbs5R+AX5xxNwMzJwkpSpR7n7p7LgOebhqWn1y9Jn4ISSatWOS/FPn1g6KpmbITAksJxqPuvwnKEfdxTzUSUjRANhuuCikqyH6deOldt3eid4E832cOg/DkUMU9NgKVDFDwOVJuVxv4ANROLiHg+mdlIENm1uQwiLqKeuDlqvnp1m2Y/UrTthekkHceCfrzVlYKPpilVEaNYBhDw4h8RWT/X1wuYewXPI7q1xJg2obakXXQ9EEa+9p3Ctgktg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vMnyeO8gPAMyumtAX6Gd4NA2shv2THqiOF0+gQKip+4=; b=snsYsrOXtPfnSZGt/BPv59HxLiYJ5nz2CQopBA5MivPQxJU7uud5IsFBXz+ooHTBYT3kqGhwfv+OOkrn0vI3pgA1uct6f2buNcLFXT/kCBT7PQmN4dkgLBmMxv35Fdwfm/rt/zNP3Ptmdq8R+WpjFVXccdtwG0z/nGd3RGQpyRk= Received: from CO1PR11MB5058.namprd11.prod.outlook.com (2603:10b6:303:99::17) by MWHPR1101MB2352.namprd11.prod.outlook.com (2603:10b6:300:7e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 07:03:06 +0000 Received: from CO1PR11MB5058.namprd11.prod.outlook.com ([fe80::49d5:fe9f:6dd9:8f95]) by CO1PR11MB5058.namprd11.prod.outlook.com ([fe80::49d5:fe9f:6dd9:8f95%9]) with mapi id 15.20.4649.020; Thu, 4 Nov 2021 07:03:06 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Wang, Jian J" , "Wu, Hao A" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V3 22/29] MdeModulePkg: Set shared bit in Mmio region for Tdx guest Thread-Topic: [edk2-devel] [PATCH V3 22/29] MdeModulePkg: Set shared bit in Mmio region for Tdx guest Thread-Index: AQHXzyL/e6MWVtO2mk6VHoW8xEkqe6vxYdeAgAEv88A= Date: Thu, 4 Nov 2021 07:03:06 +0000 Message-ID: References: <20211103065725.wdwzz5ki2rlyqcp3@sirius.home.kraxel.org> In-Reply-To: <20211103065725.wdwzz5ki2rlyqcp3@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e69dc322-fcfd-4e1f-2908-08d99f612741 x-ms-traffictypediagnostic: MWHPR1101MB2352: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F0e6WWmKPiOFBOQ8nBKuOphLsmiCTKvZKd0szkl/A1ft0V98bScul76gNif6+TjNHs0Q+RTxRTLkbKeMVW6eADbts+t9OuYHEBd1rmraQcrBHugYoJGRMXOO0LBdxL0iAFpNAyNUK1aCBAdp89UCaC8nOO1uSYeZNVdZsS7daMcejicK0pdWwjri67jTWCPwsh8NqHvUsFyPP5a4H6Ogfy+9Cyzfk1oiygnGp+Wdq9JLVKpRYmQ2WwitZsdSI4/ANefvUwi+uBLQGk76M9cQDUkO+kgDMR+IeuJ17LPlrhE3Z+7RAg13kCXYonbkMmgR/5Mc7NFOcMfWZ3s4SglEj0+o4CbvAYuKCMgobkatysRU6natc0BRoC/v/ri9YWDnRWQardKLRO5CMkKKANXifWcKRx+dIXqOyNTkoWAeZm6oeZDe42Ec8P1mFH/51E8Nev5x+jYIbkYMYr/W1qXDeU/Un1z2FWugJ5abtcYPQd+9KnnhtEvaqXk6+Iys9zD1opvzTjafvusjpvIoVgGPy9H737TpzbNPCaSs28bubh1FGSQx1IeE7fZ6tTa89Li1GUMVxqwd3P5EXcwhHACt9fi5x79RtGua6Dxtn/XdimkCb/iaFzfDtS7UGdC0C+exzUqdWVZGQxoGJBd7Bhmnc+I6WM+PwG+Cz2RRZ8oA8uZQjWAs/KAhk0gj8fbJ4kHBrvH9p2tfHURBgBGEkOztXQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5058.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(52536014)(55016002)(508600001)(4744005)(82960400001)(86362001)(5660300002)(122000001)(38100700002)(4326008)(6506007)(9686003)(7696005)(83380400001)(66476007)(66556008)(66446008)(66946007)(316002)(2906002)(54906003)(110136005)(38070700005)(76116006)(33656002)(8936002)(8676002)(71200400001)(186003)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zl/dPlqj4c2dRKAiTXlsatERnghzabIMVrwUWsDFHzENF6K22TXPnv/+nx5Y?= =?us-ascii?Q?rgWKCEbAJhkOuKwe3BPd/C7PLanSdtro9+HzJNfQSlHXzhdkTvBGILu9pNic?= =?us-ascii?Q?fwrs9ZV5fNGqOj8qaezHhXAGKIB0UqXSlTf4iperaH3mxKz+eKynyrhd3mrm?= =?us-ascii?Q?OGWShV2JRQpbaxe8u5TRhtQ1nzFqB2RcBBM+06WflxZR2bjoOSOPJcxV9tWT?= =?us-ascii?Q?q8Sr14BGVFIPqVNzvd24ep30mum/e2K4f2eb6JjiJI33H7mBgKokxZB08vnL?= =?us-ascii?Q?u9josHla7NLlJqGeFVa3HCDTC/Y28S84fc1zbzkuv8AoDy+/z+hzTgCXF3ri?= =?us-ascii?Q?aPZTabuUeVWSIfiIToa9kphG/uwtV2A9nWdTJUnlphwc5D8oKTZkPUgNIBur?= =?us-ascii?Q?53EZThD1E0VA1bwXfU4ZU23Ns2FQ1N43GLP+tQp0VWdBJ8I29TIzW6DbLid1?= =?us-ascii?Q?GtNKjLH8JFlaPAqadgSKyFQqx0WBF3lpGSvFZKtgMoLx04YFiXEJok6zNR4O?= =?us-ascii?Q?6xzRSJGvrs6382n25EFL7TbYVmLrbwjoEzEnEWOpjVDAC26EcNyQIQzuP+YD?= =?us-ascii?Q?SZtruD9H2caerItgF3kKy8SgrwluDiyhYJUudflfIUVK1ojoJu2+Dla9Hq/R?= =?us-ascii?Q?I+ODNvwwljqgZolaNqWVQpklmNmv05HYTc2pqBijy4KaNMF0e9j1dGg/CxmR?= =?us-ascii?Q?PjEWp+EapFbZN7kkkpec14uRfKL5dtplRLowuLNEWxOHem1VgPogXhXEpM2t?= =?us-ascii?Q?rSTGidizdApojbeOGjopAdZCIUKsSGPqwUq5OvLiol4DpNTkldoZKXcp6TKw?= =?us-ascii?Q?pWIURVnVUfC1gm09Y8WgKJoj2CYDreHCzFTHFPGKnjY6UkymkjVXJUrSNf9x?= =?us-ascii?Q?0sPWQlNzifhn4pdItuFNMwjTOq18FxMFbHfRs4Gk9xSQ/I2OVq4JPG/5u47y?= =?us-ascii?Q?Hq7GRVHVviGPj16abcQbyEgo0OIGK4GsZU1cf8lk7+QvTjvFwgaEO28++eAZ?= =?us-ascii?Q?tKaqWqqVbFe7PN+ufBTQwUwZqat28Anq4o94ZvxwUmTMYkzoBqAGZye1j4IZ?= =?us-ascii?Q?AdcnWifqdqlHw1InINixlQUz7flTh6iiGk7nOx26q2mD5G3i1rTR9Vanp5dG?= =?us-ascii?Q?K0uPHoT+UpiQ9Q1a4Cv0hO9wlrqvHnP7YcFp5gR254SWuSnH2Q+bRwAAYbfa?= =?us-ascii?Q?spAqbkBrO0GrsnafqUfpq+NFMfy3HKNMDScIM5GsTn8pwIQf7fgGzCWqc+0O?= =?us-ascii?Q?yaS3vSvfZXOFxUm71b2jZsBTmeo0XawqookgktebDiFW3DnHMeZKuBLVbRTx?= =?us-ascii?Q?TYvMi6U0gUMce/xhdiANQF5gJgtz6Z+TVPpJdMxPbuBQA2YLEOUK+BNPzUtW?= =?us-ascii?Q?wzo567vVSXYFz9F1l+FM91DzVeqYJ1VUcB1aYoZ6r9LSUXjUEr+4TIK6B8SG?= =?us-ascii?Q?edvrRyuY3H6xREtEe9fBY/7QenkhXtNTiQW4gy3FbfgrsR8xz0NItaBsi+B1?= =?us-ascii?Q?nkYSuqsy6WPbQelaMF+Jaz9Wk8sk6AGJmDIoaGV0XrkgXszyC5Qg42Q88UpR?= =?us-ascii?Q?9R3MQS/e0tbsYu3O1IOH+Tlq8jBjasPDKc4ZghgsNDNEBn+D/bRNs+JHus/1?= =?us-ascii?Q?AA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5058.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e69dc322-fcfd-4e1f-2908-08d99f612741 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 07:03:06.8463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YHV3WnMg5stMUigtDdsAlBUDlgyHMaUOFu/GNaU2r+Je1B/knCufCQu00mB3GN0MQ5SOUHTChBmmXj4vNoJ91w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2352 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On November 3, 2021 2:57 PM, Gerd Hoffmann wrote: > > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/DxeIplTdVmcall.nasm > > @@ -0,0 +1,146 @@ > > +;---------------------------------------------------------------------= --------- > > +;* > > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<= BR> > > +;* SPDX-License-Identifier: BSD-2-Clause-Patent > > +;* > > +;* > > +;---------------------------------------------------------------------= --------- > > + > > +DEFAULT REL > > +SECTION .text > > + > > +%define TDVMCALL_EXPOSE_REGS_MASK 0xffec > > +%define TDVMCALL 0x0 > > +%define EXIT_REASON_CPUID 0xa > > + > > +%macro tdcall 0 > > + db 0x66,0x0f,0x01,0xcc > > +%endmacro >=20 > Again, shouldn't this just call TdxLib instead of having its own copy? >=20 Sure. It will be updated in the next version. Thanks Min