From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.510.1662075279916489356 for ; Thu, 01 Sep 2022 16:34:40 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KsMeQSdw; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.20, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662075279; x=1693611279; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NWDUfbAOGopdRYxMgofzNmHvT9ecPm6dhF6zRR8hzm4=; b=KsMeQSdwwW5RKC8TbdMFYC0e0RDOxZLHVYcTpsLTBR2TF3nyRUWHcSNz l6oVkXxYNjmpEqgdOZzqp8B2gxcdFaF0Xzv6TP5Xq+SaRp+peeMUc7MbD jc+65JRJ7a+RAUcz9gy0+hmbQwzkz2Uigjxnh1itIDik80ncsqh+7UBS2 pSrXcJ5P+ZShfUV3G792uf6rJeA/Li4vygZxSiasB4TKHFZUhGq2FlyEJ /R+nB3+baDw0Y8+YHsg6JqeAG9Vk2agkt9mnQbiTZMzDsyB80I7/B8v4b IJJ+V1rf2e3YfaH07NNwIosUdMDX4TxgyfK8z1kIxTEKnFDdFxn+xIcL5 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10457"; a="282837291" X-IronPort-AV: E=Sophos;i="5.93,281,1654585200"; d="scan'208";a="282837291" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 16:34:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,281,1654585200"; d="scan'208";a="674093914" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 01 Sep 2022 16:34:39 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 1 Sep 2022 16:33:32 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 1 Sep 2022 16:33:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 1 Sep 2022 16:33:32 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 1 Sep 2022 16:33:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nh7n9/PFdcVY8pt2txwWjQuRTAFbr9T5CdBNswbtxCL4bVi9gtlq0NJqgE+PLXt08cB1UpOvU5N0TEeXvLa6S/H1dFyBs+OmPe/30+Du4lmN7ZMtzokhQJOfxaTrFPgqUls/SlwmpUPwVxkzkNzPue+SS2OKCCmM5tPCC6hUcUlTdt77pPJFXyA9rRu3RVmAubg1LIAd5VGV9Ks2mEpVhPB+aqEzaAsj5BzexoXz4/wct9UaPjNfs4koSfyDQqB2/vZwbyFzkay+vYh86aiVU2vXokpL4m2VhUn8nbQnnxecWdeSiq+c+2intgolB3PDQUALvVnNlROJj5RPeiWbvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ry4/5PhFG+ocmYX89K8/Wv8m4VLIGecL9InyLiTYyr8=; b=Z7PTqDya3xxTEhhlv4/LQQo4iTLTeV0rHDyxld3rA6SedJxp5Wl/qw584SrpyQ7HqEpNCLvX4/ypUDDUCqb6pmwSDOZLQ65ncr5JsXzPOSj/rkLy0ZtLjTv5TOlTT4PyOcLVYjXQ/oUlGe9wXRFgjeYJwesHc1DTzWZ4yVcX6bgLnbICE2RWe3IEwrCAM4BcrLXB9j/hFAlmx6/uhRuAYJQW/HUkgqQIZrz3fgAngYL08ug5ERWRz1Lp9fXraEtv77vYIhn4Yk1FfbRMiwV9wmw6yKtozxo21oQw/OIexKaXE+ZbsXT+kHV4Ynke8eZxvzsMbg3SooXhW3etIV4Ncg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5058.namprd11.prod.outlook.com (2603:10b6:303:99::17) by BYAPR11MB3127.namprd11.prod.outlook.com (2603:10b6:a03:91::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Thu, 1 Sep 2022 23:33:30 +0000 Received: from CO1PR11MB5058.namprd11.prod.outlook.com ([fe80::b03c:2a36:f6b4:970d]) by CO1PR11MB5058.namprd11.prod.outlook.com ([fe80::b03c:2a36:f6b4:970d%3]) with mapi id 15.20.5588.012; Thu, 1 Sep 2022 23:33:30 +0000 From: "Min Xu" To: "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page. Thread-Topic: [edk2-devel] [PATCH V2 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page. Thread-Index: AQHYud1ou0Y5UyBbeE+4mLu+KmjHFK3Kwv2AgAB98uA= Date: Thu, 1 Sep 2022 23:33:29 +0000 Message-ID: References: <20220901155613.bor7ddpz63ps36gr@sirius.home.kraxel.org> In-Reply-To: <20220901155613.bor7ddpz63ps36gr@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d5ddc8c-efa5-4619-abc5-08da8c726083 x-ms-traffictypediagnostic: BYAPR11MB3127:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mo5hbSCT5QGDFNjuK0w9q9hJXaQLtyE+2wZt0yHFSU6EBAvz4bWtGPy24X51zEsUBAnbEOX5YbGkHBoM4w79DU1eWyT9tIl4YVFXfD95w7tJ/08+rPLGtjWw+MLMnFqDqYINvugjld+CWQOgfhQnjlBE0gjSQ4gFi8dR+Rtez/HO/kDfrI0rDzu0cbmRmks66GWpT67BL8vzkYVwdV9kaY24ZVAllv2+Tn1CzcaY65cEpULmctnzuWCDmaEMyURMxkthoOUZ2wMjHzibcVlmcJvHNuaW5lSRPbnw/g5AHYmNhJQ/OIUSZqN1XoQUoiW8c3wciIfxqNN01D/JMncGmImx2oVUbgnI4ykQLEWSobjWZxm4NXjrUPyHbwIkVujRkgoUnvhnw+f4x3FpzNgDBDk0vkH4kUA/CXkd2P1pBxt3pemm+Z9IxNac2/VZuczx74gaVm2qpej8/qNVeE07fGa0hqA0BJ5z3Zlb4ylqf7JbUDkaadvZQYxNNvpaJWNbPTZSUWK4q15Sv0+VikU9OTeutRAJ9Yl5NkEGjZ6mqOmoi3bSFa53x9b+MJbt/MuyFGnV6Zy3nmnIYBc1TcZQUmmU5N6avpWpwYyxf+svJzN+kJj80ubfyZL71yfCrHTQLXTCMfRYoYApeXj3Wxf2RFOIKGPa98+FTH8l47PTMTjykQ9Ldxv70b7afGnpBwMvb6YGKsnB4r4xDIoDLEFZwy9QNWk5OaantxOdWZ6bGVkrTnffaDFGDN7NvOTBx5dwmOvYp1DVgFAbt4+QNnzpBA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5058.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(396003)(136003)(39860400002)(26005)(82960400001)(33656002)(9686003)(110136005)(122000001)(54906003)(38100700002)(71200400001)(316002)(38070700005)(8936002)(52536014)(7696005)(6506007)(8676002)(76116006)(41300700001)(2906002)(66476007)(66446008)(64756008)(478600001)(83380400001)(86362001)(186003)(66556008)(4326008)(5660300002)(66946007)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9aLNdxlc4/W0HRKWQzvxK7whSGq2LyDCMmVM1DfRvy0zI9W0bHQE7Uv1wlkE?= =?us-ascii?Q?M5k9WgdRvz35M52zy6Lg+vnWyXj3nKMrqN4ZE8qs4rkXPrpclSNUZVvwTslU?= =?us-ascii?Q?kQ7Urn3OZ9zD42l54+w84SxVO63OM/BBHufthgI/WLjQT+wGq8mqktLlaKUK?= =?us-ascii?Q?lNC6ig4Z4Vpn5VDZHuFG3ud2QlEL9UwDG95ecXLBjryVUmMZ86JBoCHe+XGJ?= =?us-ascii?Q?LYXebjTHPvUGe+jxVPSLuF8n62F7S0szvQNwRLI9w82Q+xP5Gdu21EqEWsc0?= =?us-ascii?Q?YIs4lYv6jZzv/23wTRxW2V97VLWSOK0Ncrw55bPwCOtX71K78SLaISFVK5aK?= =?us-ascii?Q?IpM6BcC09VXUIOU8tTf6UxnT25BMNEHabiDA5+Mg0oatlBzG6UMbABov6X3V?= =?us-ascii?Q?nzOuoVvnlXx9o7JaGndbJK19bGO66nOjATLUGPvWPCFEW6Fxs1WttucSR5fQ?= =?us-ascii?Q?kpQh3x0z5lxmmrmWqLO5wnsEJrAJWeB5fzZqEYe2Jz+3XJ2vjbnBbZO6N2pa?= =?us-ascii?Q?8cULiO/6EfNFuqou9ngrHsz5vxi5w/W5XbBcR5L/AqbspdCeF8JZAxHiUYi5?= =?us-ascii?Q?186IW27HOVu/i+6lP/kr/VpSLjnDsjJqUsU5cGtGKLEAkIESkkrkWj5+SEG8?= =?us-ascii?Q?klJb1Cuoxrz01NLJmVVOcPY4TqicIFgZ3EIFooJ98QoaTU8foL7NGCPUms03?= =?us-ascii?Q?sLS2PYED0EdF+Qwh2LioSTDsJl/7BlTDFOzzVwWZd0gFvl1qtSIoR+V/uolB?= =?us-ascii?Q?pCb8uWieuBUbXiLCqd+M9GLFjzik0QNuvtjPOWju547kHulFxmbCsnNWTrXK?= =?us-ascii?Q?qDJ8V57/jBimRNjibXhvE+O6zipyza0Chg7ZLE8oUy2XZJOL4JFcVYKBbqVC?= =?us-ascii?Q?Aywh3Mw3WAxOV0JjBgjeglP4htxBBjEBDQGkn6JuRBredStAg1d3JUettiVr?= =?us-ascii?Q?W+/+39awK9w94uLM+CzCWu8oAjvGrubsM57UtQcwE1jl9XYs6hah8+RTlS4C?= =?us-ascii?Q?vvNCvo66Akq74st4ezZSSQPlGRR+HChhePm52SdejsThfum0375noVg3TkNw?= =?us-ascii?Q?C3TB2uJpDY4NO/IRTuNZRRwDZBFsWckd3AVvnRC2xNKFrUQDUcTmh5xFhFXB?= =?us-ascii?Q?Cj00Lmrd+LO2TS1C1Tb9GlJ50k2cM79UgxxldEUj+axTDMVjrlv7yPOFpuBF?= =?us-ascii?Q?qBp1OOhSUZJuX5w2gaG+DkGFL16R//ig5kJu3uCzkzzyv7ypvSmOwpCvwbzU?= =?us-ascii?Q?ACJQMyTkXCJBEyA8i3dlSWW6i9ElavyR7GASZc9m6G9ASNc8baXrrGa763q/?= =?us-ascii?Q?Hx6lvZ1ehsYXylDnLriY4FI3EJyfgGlC/698whah0mESqNikDl14mGWmXris?= =?us-ascii?Q?RgVKyGdqq5d4H5Uan/PxHNXEZTf9j5ZWK1f9nsxCyX9E5WfMbyJ+tKdhLla3?= =?us-ascii?Q?vK0wzx0AQqp7wDec0DTPKIMNN07QQ9NB9wt8ImXY92FAs57kOtBis21SxGLH?= =?us-ascii?Q?kCIvF5PTNipyl2Xsu0JTSqY+xS41mms3F8H0F2ciyS8W3FRBBNFVKyV2f0td?= =?us-ascii?Q?IfHCsqS87Bm3lViXeKoBn715w27iygw0gqSi2JaZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5058.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5ddc8c-efa5-4619-abc5-08da8c726083 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 23:33:29.9124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2bcE19hzTHvsaDuwJtWqhz6+HZ7su5/1WBOZ+KD7CXi4rvPcIycMTo06cnX9ARBBOd3U5+wfghQij5odM3WbzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3127 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On September 1, 2022 11:56 PM, Gerd Hoffmann wrote: >=20 > > Lazy accept page can be controlled in build time like below: > > -D LAZY_ACCEPT_PARTIAL_MEM=3D512 > > > > The unit is MB. If it is 0 then it means Lazy-accept is turned off. > > > > Lazy-accept is turned off by default in OvmfPkgX64. > > Lazy-accept is turned on with 512MB by default in IntelTdxX64. >=20 > > + > > + > gUefiOvmfPkgTokenSpaceGuid.PcdLazyAcceptPartialMemorySize|$(LAZY_AC > C > > + EPT_PARTIAL_MEM) >=20 > Hmm, cover letter says 0 means accept all memory below 4G >=20 > Care to clarify? Is the commit message outdated? >=20 > Also I think the discussion of the last revision ended with the agreement= that > accepting all memory below 4G is a good idea because it simplifies the > workflow (no need to split low memory into accepted and unaccepted ranges > for example). >=20 > So why we are again talking about accepting 512 MB ? >=20 I may mis-understand the discussion of the last revision. So the agreement in first stage is that: 1. Accept all memory below 4G. 2. The PcdLazyAcceptPartialMemorySize is not needed in current stage. 3. The patch of "Pool and page functions accept memory when OOM occurs" is = not needed. Because OOM will not occur in the situation of accepting all me= mory below 4G. If that is correct, I will update the patches based on above agreements. Thanks Min