From: "Min Xu" <min.m.xu@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion
Date: Mon, 9 Jan 2023 00:49:52 +0000 [thread overview]
Message-ID: <CO1PR11MB5058FEFA4B4945DF8F89784EC5FE9@CO1PR11MB5058.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ed95fc53-9b1d-d1ae-1e03-ac4151c6ba9e@redhat.com>
Laszlo & Gerd
Yes, I will provide a new patch-set with 6 patches. Thanks for your comments.
Min
> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, January 5, 2023 11:11 PM
> To: Gerd Hoffmann <kraxel@redhat.com>; devel@edk2.groups.io; Xu, Min
> M <min.m.xu@intel.com>
> Cc: Aktas, Erdem <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Boeuf, Sebastien
> <sebastien.boeuf@intel.com>
> Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add
> back log and fix code cohesion
>
> On 1/5/23 14:15, Gerd Hoffmann wrote:
> > On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote:
> >> From: Min M Xu <min.m.xu@intel.com>
> >>
> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237
> >>
> >> Commit 9fdc70af6ba8 breaks log analysis and code cohesion in
> >> AcpiPlatformDxe. See the detailed information in BZ#4237.
> >>
> >> There are below changes in this patch:
> >> 1) Add back debug log
> >> 2) Add error checking and handling if InstallProtocolInterface failed.
> >> 3) Delete the QemuAcpiTableNotify.h because it is superfluous.
> >> 4) Delete the global variable "mQemuAcpiHandle" instead of a local
> >> variable.
> >> 5) Install the QEMU_ACPI_TABLE_NOTIFY_PROTOCOL with a NULL
> associated
> >> interface.
> >
> > Five changes in a single patch. Can this be splitted up please?
>
> Right, I've requested 6 patches :)
> Laszlo
prev parent reply other threads:[~2023-01-09 0:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:13 [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion Min Xu
2023-01-05 9:09 ` [edk2-devel] " Laszlo Ersek
2023-01-09 8:34 ` Min Xu
2023-01-05 13:15 ` Gerd Hoffmann
2023-01-05 15:10 ` Laszlo Ersek
2023-01-09 0:49 ` Min Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB5058FEFA4B4945DF8F89784EC5FE9@CO1PR11MB5058.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox