From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 929FC7803CC for ; Fri, 5 Jan 2024 02:38:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6OKJY/QsZIiF5Ymt0eO+cP+lfvNECwmSiKe7XGwlRcw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704422285; v=1; b=b4+yHUW6cmy278l7/2APPUkuRo59sWE45hA0qj03fG4fmJXDvlSEZ8yQVBTFJNi+PsIqqZhP g0KgDvC90QtfYQ0PkRLtssQKsBP6HGfKuztcKy4JdP+Ld5gfongLTJLTHdkH63wopve1jyjP/H3 buMwgNvnv1Cj65HCDS6azMwY= X-Received: by 127.0.0.2 with SMTP id 2NnSYY7687511xaORXRvO8iS; Thu, 04 Jan 2024 18:38:05 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web10.15498.1704422284263944965 for ; Thu, 04 Jan 2024 18:38:04 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="18929538" X-IronPort-AV: E=Sophos;i="6.04,332,1695711600"; d="scan'208";a="18929538" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2024 18:38:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="730349448" X-IronPort-AV: E=Sophos;i="6.04,332,1695711600"; d="scan'208";a="730349448" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Jan 2024 18:38:03 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Jan 2024 18:38:03 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Jan 2024 18:38:02 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Jan 2024 18:38:02 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Jan 2024 18:37:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nr00Y3h1E4GcbXjT4StXbtKv6i41DYFHf0DOCspr3EfKMID72+zmeCyrnXyRuBrOFe1Pvqi7qh+FVGH62AqdVfDe6dVVgee4NqeVm0UYjETNtl4XFtuCJj+XwkmiJEDt/X6WGylrawiS5zeVm7uFB2S1Y/PVlCs5ew3DsAeCXouk0zJF8ZdHzaiCYNgVshF6/HoQgKXzpskkbiIxUBnusJD+/NmWPUEKACJNKKuK1UbS7WS/ozMgUTcMyx0ojO++yH2+KeUjgohNlcNyPKByzScJrJAvotKVGDGkN22wYSMjTNnx/bX0dp2c19cigUQOTZFy5JgZob0oLuVAP8BXsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=txsC6OOj6oa0sj9Yrqq1W91nxsjJ4X/wI6WBxV9ab8s=; b=KCKF7cO8lYVBBsyfLRnTNYaVrLZBKJiTKYTp7FFl2zZK9gGs77lhYR0I6syy8qj0MKoDgl3bSu3EQeS58Sn/RWhJj2qxlx3J0BIjOO4GToV00sI8h/DLFd5iFbe4P0k1ZDKGkWkDyNnTIKesP++pDoB9U3N5hTJMvAVfjDN2WMGuSDBTF0pNNH1N4kCE6UGLuqkLhE2C9eDq6ptsK0HlFEemA7/BkEZ11dSLLwy0FRKUVIoozNHKMn0vlD/LzP+GjpaAcwFJVkT/QyEWal+5s/VFr124vujLtXhKcvpfFwjmA54u69PzRukcz82QxtILJbvILml/TEksCZppousctQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from CO1PR11MB5185.namprd11.prod.outlook.com (2603:10b6:303:6e::11) by CH3PR11MB8547.namprd11.prod.outlook.com (2603:10b6:610:1bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13; Fri, 5 Jan 2024 02:37:51 +0000 X-Received: from CO1PR11MB5185.namprd11.prod.outlook.com ([fe80::36c3:605b:5ed8:ffd]) by CO1PR11MB5185.namprd11.prod.outlook.com ([fe80::36c3:605b:5ed8:ffd%7]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 02:37:50 +0000 From: "Zhi Jin" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize PatchSmmSaveStateMap and FlushTlbForAll Thread-Topic: [edk2-devel] [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize PatchSmmSaveStateMap and FlushTlbForAll Thread-Index: AQHaP3uEpkmWeLO4P02LnNM1FyxhCrDKe/zwgAAENwA= Date: Fri, 5 Jan 2024 02:37:50 +0000 Message-ID: References: <17A7512BA8BD522D.25044@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5185:EE_|CH3PR11MB8547:EE_ x-ms-office365-filtering-correlation-id: a81e4ab6-5969-4b99-44df-08dc0d974fb7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nzc9KkOdfk+VMsvwCBexFF79enGf2mpQzdNGmrYbKrEwp1hF5dXhf1cDknCqPdOkOGYTgGKOqPMzMt44cYd1cM5i6HsxNADuGX+QZ2clanRBhPYL6zRvAKjVQvFE600d4IWqyDQIs6rlwVMuhjtfD4pmtwNv7rgUwuodJsl0msfmAq9wpIs4bc/yVheOlwFYJrYKknhuc94UbKFSVKY3BbYWTafu4cmbv8wDAiZySRR6F5EspxA0VqVWepJI4RLOU7y6Y/MmoHxVxe8KfjYiKH5tzs82/vZLPFpgH70aQLp2sShmRlOlCBIfFdDl8nyqszUfKgU6fBvfim6bt6HtbfPQb8RWsox8JiOc/gmRYGXJjYJeMO4y3Ar9SBNOBNEpofE4ay02I0lXD8KnDJPgI9y/5SXTF6LgRa6Uhzdf4pCqTtwnuCtsS1pCAAS4Z1eBfnPxLnnOakiYpM+JIwE25GNxdgRKUJk6/Uc9FwWVsCrhrkUDUn9r7kbtnn9wUxEUDBApcrY+nAPVqI/3pOXzjNNie4b+Cp9a8qRHzZZV5Tl8xxhoKyxiGvqUBF5qsVfleLUSNPUcfH23Q0L6xHlNo29s4GI0vgOmdDLUyxcaAn+zw0XJiPWQaQnoo0Szy5cgjEu9Z3Ksu1ju9rbdzydgBslkfXJZYce+yP1B2pYuGJk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WaxETOiRQSl9aUbPYxMgu+fS03NrxN7+f8aNfmUqGDeuL9e2oBMvjVV1xmnJ?= =?us-ascii?Q?0Cy78rBJbYnCPn0FEYd7ZukZ3S41taHp40DpyB9swL8yC/XEcIZ8MOulxzmi?= =?us-ascii?Q?rsBC5IMEaHLlWRBtSoih1K/S1hfOQZ1ayuCaIELaqDdQMjh6lKnhQVRihLx2?= =?us-ascii?Q?GaXEBCLhBuj0+yB3ncqoa3FhPHgu0KS9FgIsKFQuloa2YlkRKEw0LxWCtc++?= =?us-ascii?Q?YHL09mVjDsht97FAgF4kK1qEZWzYxhkc+7/3lT50U8EmMS74S+hpNm5iF+9s?= =?us-ascii?Q?F92PdgeQm6SxKXrGCns9i8ByYYZATjQ/NP2MvoAQENp3A66XmEkLzTxgj7eI?= =?us-ascii?Q?Ie2C0vxZ/Zjq/9DsPkT3tI7zETCTKAMcYhGSJtCMxgBj/1knRmBqkBvcueJL?= =?us-ascii?Q?zOM4XP3dl2gjKn44awdEMvdtkP6YJnX2PD0gLUbVJrgAlBs5YJkbRosPNiur?= =?us-ascii?Q?AtXA8rm/HgevBmVnhiHrDO5Ra5hBFPvOWFA31FdkRHdg4kudMNE5g/12w+3X?= =?us-ascii?Q?W8VOhP2cwPBvExFdcuVaDmW1FezX4ZK5ipPl4f8UZOb/f7+m+Ugf4P+6VNoB?= =?us-ascii?Q?OAxMUrMx5ZF9zoPSgO2GqCmTU823upkIjZIMKABoIDaJQ7d0OvRt8uWxPi6h?= =?us-ascii?Q?6xMqS2iqgn0Fj0H8Qfn4PIv8+fEq/ysIEcwHwYTpLEwIWQUfjgRlknQ+DeEa?= =?us-ascii?Q?I0KkRI0gIleErbhRxnOPYdzsJ7osSUv7M+i0Kfv1xinegVK3nxROrQFq3IFH?= =?us-ascii?Q?HJpwqFe5EhcT3Za0MY2gIq4gKOtwa7R6kraVRWwT29HhE4nImM0CmWGYVJX+?= =?us-ascii?Q?Qn4XwDUN1UA6ClGNakgw+BjkYS0WbunkxiWmPYdplbA4H8rYvnxENwvNS+5r?= =?us-ascii?Q?3uhm4eC551i+mHIaEeqXhT5hosiTK9Z1n+4tFaO3i8lBXz5OtbJrdrZsaY44?= =?us-ascii?Q?4vrMLUtEocXtJCfho4jb7Ry8PDpjOpIf4jdYZ8h4t4adVXQvrZ9/sRiHdJvT?= =?us-ascii?Q?XpU5PyFDf2AtyPI1GpZ1XitxFMVpwZG4WOSvdHbmbc4SDusefrZ7TGAuYAtZ?= =?us-ascii?Q?rqvRZYien7wSesiQBUMqDMueVjrkZmVcdD36jK7BDwJWCrtLq/rUcewS1+Jz?= =?us-ascii?Q?p5SuTCmpMnxYoqwFh/Sp0O/gPY9oDeJ22uMTzxsY4b1lIl3jXKvPpdvq5gUd?= =?us-ascii?Q?asSwdxGJCGvUhPHZ0lps05QEti1vL1Awf2/3TW4m1UjdZfZXGsfEIIC6Dn3P?= =?us-ascii?Q?D1u0hJf+giJnK5oDsv/lmUEIqFMqXGlvJ16754RKJhoBz8m/ulRw4p7RIAky?= =?us-ascii?Q?0D7/aSoDvJLLuJsKd5ZLt18mg97CeyeGwyLj8SkRCUyG5e18F4ypSW/zAUn3?= =?us-ascii?Q?4fEosGozWMLJYnKgwj5JPqga3/MHjlyxopXzTVbm04cg8moyRVK8sWEAz3LZ?= =?us-ascii?Q?0jHPZZ6oramCS8Eqvomob7m8h441EVOPqXd7JnugQAHcRSAMATRZCUq46QPZ?= =?us-ascii?Q?d8w7YrserZeKdSC8B4U9iI5m7xZTxnMrO6L+sLESUuJnxv/AdocmhdIuNUMV?= =?us-ascii?Q?CDFkcnla2t6mjqf488A=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5185.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a81e4ab6-5969-4b99-44df-08dc0d974fb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 02:37:50.8045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: do55syC3gQfNkehfK9hwZXg8MD8GhdKOndcj6QZUphcUs1bumAAFJ9Y5mvIrMsr97VRhSmfztudryPgJSbUmGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8547 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhi.jin@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9eRl5kxUqwdoW5X0ePW4SUBmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=b4+yHUW6; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for the comments, Ray. It is a mistake to remove the FlushTlb() in this patch. I will send out the= patch v2. BRs Zhi Jin -----Original Message----- From: Ni, Ray =20 Sent: Friday, January 05, 2024 10:21 AM To: devel@edk2.groups.io; Jin, Zhi Cc: Laszlo Ersek ; Kumar, Rahul R ; Gerd Hoffmann ; Wu, Jiaxin Subject: RE: [edk2-devel] [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize P= atchSmmSaveStateMap and FlushTlbForAll Zhi, With your patch, 1. SMM entry(code) and SmmSaveState region (data) are changed to correct pa= ging attributes. 2. FlushTlb() is removed after the changing. 3. FlushTlb() is updated to flush in parallel. My concern is about #2. Can you explain a bit why FlushTlb() can be removed= after changing paging attributes in #1? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Jin, Zhi > Sent: Friday, January 5, 2024 10:04 AM > To: devel@edk2.groups.io > Cc: Jin, Zhi ; Ni, Ray ; Laszlo Erse= k > ; Kumar, Rahul R ; Gerd > Hoffmann ; Wu, Jiaxin > Subject: [edk2-devel] [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Optimize > PatchSmmSaveStateMap and FlushTlbForAll >=20 > PatchSmmSaveStateMap patches the SMM entry (code) and SmmSaveState > region (data) for each core, which can be improved to flush TLB once > after all the memory entries have been patched. > FlushTlbForAll flushes TLB for each core in serial, which can be > improved to flush TLB in parrallel. >=20 > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Jiaxin Wu > Signed-off-by: Zhi Jin > --- > .../PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 95 > ++++++++++++------- > 1 file changed, 63 insertions(+), 32 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > index 15f998e501..d4066436f5 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > @@ -547,17 +547,14 @@ FlushTlbForAll ( > VOID > ) > { > - UINTN Index; > - > FlushTlbOnCurrentProcessor (NULL); > - > - for (Index =3D 0; Index < gSmst->NumberOfCpus; Index++) { > - if (Index !=3D gSmst->CurrentlyExecutingCpu) { > - // Force to start up AP in blocking mode, > - SmmBlockingStartupThisAp (FlushTlbOnCurrentProcessor, Index, NULL)= ; > - // Do not check return status, because AP might not be present in = some > corner cases. > - } > - } > + InternalSmmStartupAllAPs ( > + (EFI_AP_PROCEDURE2)FlushTlbOnCurrentProcessor, > + 0, > + NULL, > + NULL, > + NULL > + ); > } >=20 > /** > @@ -799,71 +796,105 @@ PatchSmmSaveStateMap ( > UINTN TileCodeSize; > UINTN TileDataSize; > UINTN TileSize; > + UINTN PageTableBase; >=20 > - TileCodeSize =3D GetSmiHandlerSize (); > - TileCodeSize =3D ALIGN_VALUE (TileCodeSize, SIZE_4KB); > - TileDataSize =3D (SMRAM_SAVE_STATE_MAP_OFFSET - SMM_PSD_OFFSET) + > sizeof (SMRAM_SAVE_STATE_MAP); > - TileDataSize =3D ALIGN_VALUE (TileDataSize, SIZE_4KB); > - TileSize =3D TileDataSize + TileCodeSize - 1; > - TileSize =3D 2 * GetPowerOfTwo32 ((UINT32)TileSize); > + TileCodeSize =3D GetSmiHandlerSize (); > + TileCodeSize =3D ALIGN_VALUE (TileCodeSize, SIZE_4KB); > + TileDataSize =3D (SMRAM_SAVE_STATE_MAP_OFFSET - SMM_PSD_OFFSET) + > sizeof (SMRAM_SAVE_STATE_MAP); > + TileDataSize =3D ALIGN_VALUE (TileDataSize, SIZE_4KB); > + TileSize =3D TileDataSize + TileCodeSize - 1; > + TileSize =3D 2 * GetPowerOfTwo32 ((UINT32)TileSize); > + PageTableBase =3D AsmReadCr3 () & PAGING_4K_ADDRESS_MASK_64; >=20 > DEBUG ((DEBUG_INFO, "PatchSmmSaveStateMap:\n")); > for (Index =3D 0; Index < mMaxNumberOfCpus - 1; Index++) { > // > // Code > // > - SmmSetMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[Index] + SMM_HANDLER_OFFSET, > TileCodeSize, > - EFI_MEMORY_RO > + EFI_MEMORY_RO, > + TRUE, > + NULL > ); > - SmmClearMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[Index] + SMM_HANDLER_OFFSET, > TileCodeSize, > - EFI_MEMORY_XP > + EFI_MEMORY_XP, > + FALSE, > + NULL > ); >=20 > // > // Data > // > - SmmClearMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[Index] + SMM_HANDLER_OFFSET + > TileCodeSize, > TileSize - TileCodeSize, > - EFI_MEMORY_RO > + EFI_MEMORY_RO, > + FALSE, > + NULL > ); > - SmmSetMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[Index] + SMM_HANDLER_OFFSET + > TileCodeSize, > TileSize - TileCodeSize, > - EFI_MEMORY_XP > + EFI_MEMORY_XP, > + TRUE, > + NULL > ); > } >=20 > // > // Code > // > - SmmSetMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[mMaxNumberOfCpus - 1] + > SMM_HANDLER_OFFSET, > TileCodeSize, > - EFI_MEMORY_RO > + EFI_MEMORY_RO, > + TRUE, > + NULL > ); > - SmmClearMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[mMaxNumberOfCpus - 1] + > SMM_HANDLER_OFFSET, > TileCodeSize, > - EFI_MEMORY_XP > + EFI_MEMORY_XP, > + FALSE, > + NULL > ); >=20 > // > // Data > // > - SmmClearMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[mMaxNumberOfCpus - 1] + > SMM_HANDLER_OFFSET + TileCodeSize, > SIZE_32KB - TileCodeSize, > - EFI_MEMORY_RO > + EFI_MEMORY_RO, > + FALSE, > + NULL > ); > - SmmSetMemoryAttributes ( > + ConvertMemoryPageAttributes ( > + PageTableBase, > + mPagingMode, > mCpuHotPlugData.SmBase[mMaxNumberOfCpus - 1] + > SMM_HANDLER_OFFSET + TileCodeSize, > SIZE_32KB - TileCodeSize, > - EFI_MEMORY_XP > + EFI_MEMORY_XP, > + TRUE, > + NULL > ); > } >=20 > -- > 2.39.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113207): https://edk2.groups.io/g/devel/message/113207 Mute This Topic: https://groups.io/mt/103535844/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-