From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.201826.1672304406742072217 for ; Thu, 29 Dec 2022 01:00:06 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PFSN23I2; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: min.m.xu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672304406; x=1703840406; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ai5OkNp/bWewz8cuYlEwoH27PEfW+1znpymLm/ayEK8=; b=PFSN23I2jisJsDrNvty+qmOeTQ3Z4xON4L9ns4iOw6NIxQ1Uld4d65II UdTj6tXfoNNb5dOja5Mb5bm888wD35s0DJcNVR0sf9UJ2IpEfzEJzNaTe rjBIQFhk52eO8JO/hFa+No9l2J7RBicwFdPnDl02Dd2eOSik86N+PFFte wb4jlUXniN5J5Eu3e0zX3MEB3k1KTSH0j8+L48g3pBzJIVh4w8fSwdDg+ OrfL8PV5m3bOL4U7bItLCh4m48Rt6zmK3LqVsR4mn1lTkPSiFWsjlP++/ RElzsukg67+zBaDXyKcSlJyuIIfGg4uQ2bIK6JA7mi5LQqL/H21JY0WD1 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="301375848" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="301375848" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2022 01:00:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10574"; a="898914460" X-IronPort-AV: E=Sophos;i="5.96,283,1665471600"; d="scan'208";a="898914460" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 29 Dec 2022 01:00:06 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 29 Dec 2022 01:00:05 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 29 Dec 2022 01:00:05 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 29 Dec 2022 01:00:05 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 29 Dec 2022 01:00:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oOfBWLBPXUVG+AFd9sCG28ZTZOxBU8EOMDWtwmz33ugrJPX4VEcGCD7Iq8DaRrgqR8MUrJjkSxMRAfE43ZVPCIn7Y4sqkzNSm4LGmpngJoYkqAJKVGNxW4YangYOmsNTlpg2iKh2WTATi8jHLoQ0FGfjdFRz2/a65s6DM2b4qRuMICatOpQYX/BwOC+WGy4FI/H4XmBbQ5/GcQUUd60ljen3599mo+OwtzGbZlbZZHBl2QpiwywBbPwSFjDAeCErQE1g18fB1WydrXjCicflXm/NQAE3LlW+f7bXYbdaZGQi2B1X+DGve8MMLjmtFgYxfw1WOa2V72XzayGNKjUGMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zvFruvN/nr83Sv8yeYe0TC5REglVOpv0Qyf1829pzO4=; b=IsPstBEZVNj6Jh7kZMaVcq4t8hj12zf+ZqoMOrA+pmz0m+wRYfF3YvSyBjWHvJfn2/tThScWAD7o+QluifqZRhsHUZLga6DiGv/geiiuSXvl5sDnkI5klX7hrhNP+lmDZUIS/EgIZe9wiJdHJPgmJsAyi/PTgaQePSiTMuh1MgOLki9XtdXEzEMB6yvf6QmbM79OuNtk8lvDUM2HMSBRIblUN60XUXxR6N+n4kMl0oUSx7erADyGNZVZUdChAuL+udgwJnov23iWAHSWpcpY3BpkXoVIhTfxkHb/wtHmNOAH4gYTKHSYcaHkYWMsk4tzZxP/4bZSiEojjExCGsdZ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1SPR01MB0003.namprd11.prod.outlook.com (2603:10b6:303:95::24) by CH0PR11MB5443.namprd11.prod.outlook.com (2603:10b6:610:d2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 09:00:01 +0000 Received: from CO1SPR01MB0003.namprd11.prod.outlook.com ([fe80::9ff7:e521:722f:aea2]) by CO1SPR01MB0003.namprd11.prod.outlook.com ([fe80::9ff7:e521:722f:aea2%7]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 09:00:01 +0000 From: "Min Xu" To: "devel@edk2.groups.io" CC: "Aktas, Erdem" , James Bottomley , "Yao, Jiewen" , Gerd Hoffmann , Tom Lendacky , Ryan Afranji Subject: Re: [PATCH V1 0/2] Refactor TDX MmioExit Thread-Topic: [PATCH V1 0/2] Refactor TDX MmioExit Thread-Index: AQHZG2O3+V+NlVqH7U+ld+Jn2KNMPq6EkO1w Date: Thu, 29 Dec 2022 09:00:01 +0000 Message-ID: References: <20221229085548.476-1-min.m.xu@intel.com> In-Reply-To: <20221229085548.476-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1SPR01MB0003:EE_|CH0PR11MB5443:EE_ x-ms-office365-filtering-correlation-id: 6b0c73bb-8068-4b37-c680-08dae97b11b9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ++D7Kbk4H20pEbvawnaDZtDV2amKNghf7F9WF3DHEPAiqrKtsA76cTGLzIDZf4bHlYxPgGU32pZu0PAP0+Ec6ydu02arFipI0lClJHk0TptLXc4pYdHrGcYrNkp71WzhR2cZSjSfaLbROqrWqy/Ytaw2GSrozeAsJLAwAQiSwgV5ShoCL/gohK8Dhv9+lx1Akc3y/rwXeLK5MM5ReKFDdnoGKYATtvRp3T2rMiGcDexNb71BXV4/OeJFhgT6M2UtRAaQkplNYi0UFGnTg/tlmUehpNmxAHZOlxrZ3LUmD4pxzeOAhrO3vfGWdKwTxg/VkX+ARvOmUQ7iSrQQu31oOjLstsTd8Vp771kweyq6kidpwt3Y+dTBGncdXQPZGQ+fcGDLC/VTuW+vc/fcvtiwMf0zxsDTDjYn3zlSDLYddFpQgMErypYaAOFrrrT+AuxjdRswDFK0fs76f7roVq+/E7BfJ4hod+Hh/POVlDEArso8lNqz5LDCmOJN036JD30LqA52it3QtdMGRZmV/TB487xd96oGI6YvujrWLJclkx5KBEc03Krl1OrtwKDWl/hbzTdneg16o0gdEt3+qxTAV/RgEYwRf9PQbdTcZi4PCu7j22I9BHZBGKfnNYfZggajpdo9AsqFiruNAat/zVPHq5D555+QE3RbSke77pMwQZSeO7PC0eDYKHz2xNy9CWP+tQwzLwau10Cy+2DsLlwvPdRrGI3rtuBKXIv09ktW6J910XUPlpKbgxHSxZjtJrofVOI1wE/h6CwYZ9UZLksZTQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1SPR01MB0003.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199015)(66946007)(5660300002)(64756008)(76116006)(66446008)(66556008)(4326008)(66476007)(8676002)(41300700001)(8936002)(52536014)(9686003)(26005)(186003)(6916009)(2906002)(54906003)(478600001)(71200400001)(33656002)(966005)(316002)(86362001)(53546011)(55016003)(7696005)(38070700005)(6506007)(38100700002)(122000001)(82960400001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ISfqO5tX6TNAbq1uORdm8HRjOW9IAwx+fWEocPZ+P/9/vdV1kgHZMMIoLZYX?= =?us-ascii?Q?4oaTaWN2YkOA3D8Uevg6XHCK5SMWzqAkKi9LrqK1wYuwYnO09UVMi+0T6HHT?= =?us-ascii?Q?m2ZZkRZGmuSm4rMOTwF2UDkcXSDsrS29qp6iSvg/CCsfVnUryRAab+BPCiR7?= =?us-ascii?Q?/kVTLXpFYq4tWaPZ/8tqT85dKN7pDy5kJuZDLvSZnv77Ey8A7dcYC7A66KWs?= =?us-ascii?Q?fGKD+wzoMp8lKGdDbvMssrfz/e8/hRX5ZkGVBjVfG9khX6U+XSv7vjGB9/WO?= =?us-ascii?Q?dTbT47deM453o3iuIAOn6/5ypYkXhOBETY6iKdZ1Xn4F5AftBVvTENfleZiw?= =?us-ascii?Q?YjHFDWYYrP9Phb9B3O4mXreV0vxbGRX4Yvg+3qU5RMpz6h+kQF+87aDPJykc?= =?us-ascii?Q?fq/xHd+Jxlgmuqew2WVzQUELRXQBXcZJ8RLmDJhgGwym39IaR+qlHsGM16Uv?= =?us-ascii?Q?8qM+Rjbq9UT1wWsRVaoKO5rSQeeXG5Gzo8Rm8ldzxdUGowqrmkckCSb6/N+1?= =?us-ascii?Q?8BMuPt3cXc8nAdqajeCmGNvUDYtDChjzt41/xKYl9s+HjwCZIcJeRaaxTyER?= =?us-ascii?Q?/9c1FRpjw/LFIP42kPCf1Fj/IgDurRZs6WkavhyLIAVM06+m298WvVERSAWh?= =?us-ascii?Q?Ced3rlozyl/U16xfiOzc3yUaOMtTohop4gJIG90KyyAxOOtmlyPvC/Ux6/T+?= =?us-ascii?Q?+f+j271w5yO6iqpS631KmL4wwhfWBM1ISxW1fTAYamaJLxJpJuUKj2SBgNeI?= =?us-ascii?Q?oltZpFWIuac7zhNUHSuw7JEIS5lXPbzzAZcmaDNK0mr5cWm4aYMjoGIo65o3?= =?us-ascii?Q?uMQprrPOANB2wVI0WAIpnJ54JXtW5vwKr60ro3VJ5XRMFeRLwUrmGmBnwgkm?= =?us-ascii?Q?iPjo3g1kCOvfeA6i0k8J4Bx0TAq7WMNYfy23KgQlp+TTkhVPiYHSSmrRJgCb?= =?us-ascii?Q?AeLT5bd8I+EIQxb5/yEkK4gm2ptU+OJpR08V3PZOCNO/nS9Pkij9P/nokUzq?= =?us-ascii?Q?x+rA260PmS5hfSlBSESNWlMhNNwF6cFPqtXidvapNByRZcraomcO6JSeYtSU?= =?us-ascii?Q?Qqh4+irEL1jfRaDjoEgG29UWQRMTrD91KDXuPTMIseBIgGqXA7aTo6aqgaCs?= =?us-ascii?Q?0nVLLUTarANoSwsjvV/+7Nz/b9EYgy7ZRPQf9hrRES33QYLpVJfmeLSWT0uk?= =?us-ascii?Q?FxJQTaeQ48NPCk1uHcTvC4J+7tS9FBw8+36WvhkdYXT7HsxjK3d5jQYpZpSC?= =?us-ascii?Q?RMFmOB+gVsyXzzX3mIHPev7jxvg6hBUjtQ8I124vW5b3GufjIBwe+f11s1F2?= =?us-ascii?Q?HFNy6QP+cKovKCegoX1xyPyDnSSA2bCBYUuxbPktOT0ayGIznPPZ4Qu11GLy?= =?us-ascii?Q?JSROQ5E0r3pT4CZTTIhJTcTq9WvnMg17Io++lJY7Rn7qazv2G/o7O853l8l+?= =?us-ascii?Q?VDV5qHN6loTskSfxp5516DPxXX0MSdSfvAtWbGGr0Y8wyVDluhJRkXQizyTk?= =?us-ascii?Q?vHcyapRL1W4R+9xIMLjfJdAwodMyrqHsSykp+FffpHJiZmaTWXh4E6kTkz2i?= =?us-ascii?Q?j5sWGm/S41QMkj0npGvl54IiyfgwrU7/tMuMyHMp?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1SPR01MB0003.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b0c73bb-8068-4b37-c680-08dae97b11b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 09:00:01.3670 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8A8HlTzpSQiXxIrGCGBlxyhn4foplYHBvJiNfxUY5iWwqQpp9+LfwbMBRd0avNcO2R5x32SgOeFpBN1GaqNTjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5443 Return-Path: min.m.xu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Code: https://github.com/mxu9/edk2/tree/TdxMmioExit.v1 > -----Original Message----- > From: Xu, Min M > Sent: Thursday, December 29, 2022 4:56 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Gerd Hoffmann ; > Tom Lendacky ; Ryan Afranji > > Subject: [PATCH V1 0/2] Refactor TDX MmioExit >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4169 >=20 > The previous TDX MmioExit doesn't handle the Mmio instructions correctly = in > some scenarios. This patch-set refactors the implementation to fix the is= sues. >=20 > Before the refactoring, common X86 instruction codes in CcExitVcHandler.c > are moved to separate files (CcInstruction.h / CcInstruction.c) so that t= hese > codes can be re-used in TDX. >=20 > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Tom Lendacky > Cc: Ryan Afranji > Reported-by: Ryan Afranji > Signed-off-by: Min Xu >=20 > Min M Xu (2): > OvmfPkg/CcExitLib: Move common X86 instruction code to separate file > OvmfPkg/CcExitLib: Refactor TDX MmioExit >=20 > OvmfPkg/Library/CcExitLib/CcExitLib.inf | 1 + > OvmfPkg/Library/CcExitLib/CcExitVcHandler.c | 697 +++----------------- > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 498 +++++++++----- > OvmfPkg/Library/CcExitLib/CcInstruction.c | 454 +++++++++++++ > OvmfPkg/Library/CcExitLib/CcInstruction.h | 197 ++++++ > OvmfPkg/Library/CcExitLib/SecCcExitLib.inf | 1 + > 6 files changed, 1082 insertions(+), 766 deletions(-) create mode 10064= 4 > OvmfPkg/Library/CcExitLib/CcInstruction.c > create mode 100644 OvmfPkg/Library/CcExitLib/CcInstruction.h >=20 > -- > 2.29.2.windows.2