From: "Lin, Derek (HPS UEFI Dev)" <derek.lin2@hpe.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "yonghong.zhu@intel.com" <yonghong.zhu@intel.com>,
"Lin, Derek (HPS UEFI Dev)" <derek.lin2@hpe.com>
Subject: [PATCH] BaseTools: Fix python error with --genfds-multi-thread.
Date: Wed, 9 May 2018 09:03:24 +0000 [thread overview]
Message-ID: <CS1PR8401MB0678B43DB9F96DB3F6A6E7C0C2990@CS1PR8401MB0678.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20180509085932.1032-1-derek.lin2@hpe.com>
When self.Alignment is None, it ran into python error since there is no
strip() in None.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Derek Lin <derek.lin2@hpe.com>
---
BaseTools/Source/Python/GenFds/GuidSection.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/GenFds/GuidSection.py b/BaseTools/Source/Python/GenFds/GuidSection.py
index 1105689e0d..6cadff0bd2 100644
--- a/BaseTools/Source/Python/GenFds/GuidSection.py
+++ b/BaseTools/Source/Python/GenFds/GuidSection.py
@@ -2,7 +2,7 @@
# process GUIDed section generation
#
# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> -#
+# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.<BR>
# This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -273,7 +273,7 @@ class GuidSection(GuidSectionClassObject) :
self.Alignment = None
self.IncludeFvSection = False
self.ProcessRequired = "TRUE"
- if IsMakefile and self.Alignment.strip() == '0':
+ if IsMakefile and self.Alignment is not None and self.Alignment.strip() == '0':
self.Alignment = '1'
return OutputFileList, self.Alignment
--
2.15.1.windows.2
next parent reply other threads:[~2018-05-09 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180509085932.1032-1-derek.lin2@hpe.com>
2018-05-09 9:03 ` Lin, Derek (HPS UEFI Dev) [this message]
2018-05-11 0:15 ` [PATCH] BaseTools: Fix python error with --genfds-multi-thread Zhu, Yonghong
[not found] <20180509073901.15208-1-derek.lin2@hpe.com>
2018-05-09 7:49 ` Lin, Derek (HPS UEFI Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB0678B43DB9F96DB3F6A6E7C0C2990@CS1PR8401MB0678.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox